@jwilger/pi-development-system 0.46.0 → 0.46.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.46.0",
+  "version": "0.46.1",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/core/model-advice.ts

@@ -47,7 +47,7 @@ const direct = (matrix: ModelMatrix, tier: Tier): string[] =>
  * frontier but lives in strong). Undefined when it is in none of them.
  */
 export function tierOf(matrix: ModelMatrix, model: string): Tier | undefined {
-  return [...TIERS].reverse().find((tier) => matches(direct(matrix, tier), model));
+  return TIERS.findLast((tier) => matches(direct(matrix, tier), model));
 }
 
 /** The best tier that lists the model at all: what a slot resolving to it is asking for. */

package/src/core/review-flow.ts

@@ -144,8 +144,11 @@ export function adoptSeverity(
   };
 }
 
-const where = (f: Finding): string =>
-  f.path === undefined ? "" : ` \`${f.path}${f.line === undefined ? "" : `:${f.line}`}\``;
+const where = (f: Finding): string => {
+  if (f.path === undefined) return "";
+  const line = f.line === undefined ? "" : `:${f.line}`;
+  return ` \`${f.path}${line}\``;
+};
 
 /**
  * Nits are never stored. Each is reported back so the coordinator fixes it now or drops it

package/src/core/review-packet.ts

@@ -10,11 +10,7 @@ export type ReviewPacket = {
   readonly verdict: "no-blocking" | "blocking";
 };
 
-const SEP = "[—–-]";
-const HEADER = new RegExp(
-  `^##\\s+Review\\s+${SEP}\\s+(.+?)\\s+${SEP}\\s+round\\s+(\\S+)\\s+${SEP}\\s+lenses:\\s*(.*)$`,
-  "m",
-);
+const HEADER = /^##\s+Review\s+[—–-]\s+(.+?)\s+[—–-]\s+round\s+(\S+)\s+[—–-]\s+lenses:\s*(.*)$/m;
 // Reviewers add text after the location (`fn`, a second location); the first backticked one is the finding's.
 const FINDING = /^-\s*\[([^\]]+)\]\s+(\S+)\s+(?:`([^`]+)`[^—–]*?\s+)?[—–-]\s+(.+)$/;
 // An indented line under a finding is its detail (trigger, fix), unless it is itself a finding.
@@ -24,8 +20,11 @@ const isDetail = (line: string): boolean =>
 // `until` ends a section; by default any heading does. Findings ends only at a known section so a stray
 // heading inside it (### Nits) makes its lines errors instead of silently cutting the findings off.
 const section = (text: string, name: string, until = /^###?\s/m): string | undefined => {
-  const match = new RegExp(`^###\\s+${name}\\s*$`, "im").exec(text);
-  if (match === null) return undefined;
+  const wanted = name.toLowerCase();
+  const match = [...text.matchAll(/^###\s+(.+?)\s*$/gim)].find(
+    (m) => m[1]?.toLowerCase() === wanted,
+  );
+  if (match === undefined) return undefined;
   const rest = text.slice(match.index + match[0].length);
   const next = until.exec(rest);
   return next === null ? rest : rest.slice(0, next.index);
@@ -94,8 +93,7 @@ export function parseReviewPacket(text: string): ReviewPacket | ParseError {
   }
   const lines = findingsText
     .split("\n")
-    .filter((l) => !isDetail(l))
-    .map((l) => l.trim())
+    .flatMap((l) => (isDetail(l) ? [] : [l.trim()]))
     .filter((l) => l !== "" && !/^(?:-\s*)?[([]?(?:none|no findings?)[)\]]?\.?$/i.test(l));
   for (const [i, line] of lines.entries()) {
     const finding = parseFinding(line, lenses, i + 1);

package/src/gates/commit-guard.ts

@@ -174,7 +174,7 @@ const stagedThenEdited = (
   // re-staged from the work tree, which was reviewed. Message text is one argument and never equals a path.
   const named = upto
     .filter((i) => (i.sub === "commit" || i.sub === "add") && !isDryRun(i) && inThisDir(i, cwd))
-    .flatMap((i) => i.args.filter((a) => !a.startsWith("-")).map(cleanPath));
+    .flatMap((i) => i.args.flatMap((a) => (a.startsWith("-") ? [] : [cleanPath(a)])));
   const covered = (name: string) => named.some((n) => name === n || name.startsWith(`${n}/`));
   return names.staged.filter(
     (name) => names.unstaged.includes(name) && !covered(name) && !DECISION_LOG.test(name),