@jwilger/pi-development-system 0.45.1 → 0.46.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.45.1",
+  "version": "0.46.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"
@@ -52,7 +52,6 @@
     "@types/shell-quote": "^1.7.5",
     "@typesafe-ai/sdk": "^0.6.0",
     "knip": "^6.40.0",
-    "markdownlint-cli2": "^0.23.3",
     "typescript": "^7.0.2"
   },
   "scripts": {

package/src/core/redact.ts

@@ -1,7 +1,7 @@
 /** Removes credentials from text before it is written to committed logs or session entries (R11). */
 export function redactSecrets(text: string): string {
   return text
-    .replace(/(\w+:\/\/)[^\s/@]+@/g, "$1[redacted]@")
+    .replace(/(?<!\w)(\w+:\/\/)[^\s/@]+@/g, "$1[redacted]@")
     .replace(/\b(?:ghp|gho|ghu|ghs|github_pat)_[A-Za-z0-9_]{16,}/g, "[redacted]")
     .replace(/\b(\w*(?:TOKEN|KEY|SECRET|PASSWORD)\w*)=("[^"]*"|'[^']*'|\S+)/gi, "$1=[redacted]")
     .replace(/\b(Authorization:\s*)\w+\s+[^\s'"]+/gi, "$1[redacted]")

package/src/core/test-runner.ts

@@ -2,7 +2,7 @@ import { basename, isAssignment, segments, splitLines, WRAPPERS } from "./git-in
 import { redactSecrets } from "./redact.ts";
 
 const PACKAGE_MANAGERS = new Set(["npm", "pnpm", "yarn", "bun"]);
-const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava", "tap"]);
+const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava"]);
 const EXEC_PREFIX = new Set(["npx", "bunx", "pnpx"]);
 const SUMMARY_LINES = 3;
 const SUMMARY_MAX = 300;
@@ -59,6 +59,7 @@ export type ResultLike = {
 };
 
 /** A pipe or sequence makes the shell report the last command's status, not the runner's. */
+const NO_TEST_SCRIPT = /Missing script: "?test/;
 const MASKS_STATUS = /[|;\n]/;
 const FAILURE_MARKERS =
   /^(?:# |ℹ )fail [1-9]|test result: FAILED|\b[1-9]\d* (?:failed|failing)\b|^FAILED\b|^FAIL\b|\bnot ok\b/m;
@@ -68,6 +69,8 @@ const isRecord = (v: unknown): v is Record<string, unknown> =>
 
 /** Exit code of a bash tool result: structured `exit_code`, else pi's status line, else error/not. */
 export function exitCodeOf(result: ResultLike): number {
+  // `npm test` in a package without a test script exits 1 but ran no tests, so it is not a RED.
+  if (NO_TEST_SCRIPT.test(result.text)) return 0;
   const reported = reportedExit(result);
   if (reported !== 0) return reported;
   // `npm test | tail` exits 0 whatever the tests did, even in the structured status; trust the output.

package/src/state/config.ts

@@ -31,7 +31,6 @@ export type DevsysConfig = {
   readonly profiles: { readonly override: readonly string[] };
   readonly models: ModelMatrix;
   readonly routing: Readonly<Record<string, Route>>;
-  readonly jev: { readonly timeoutMs: number; readonly confidenceFloor: number };
   readonly verifier: { readonly maxPerSession: number };
   readonly cadence: { readonly pushMinutes: number };
   readonly eventModel: { readonly provider: string };
@@ -170,12 +169,20 @@ function route(raw: unknown, key: string): Result<Route, ConfigError> {
     : ok({ slot, thinkingLevel });
 }
 
+const ROUTING_KEY = /^(?:trivial|routine|complex|expert|\*)\/(?:low|medium|high|\*)$/;
+
 function routing(root: Table): Result<Readonly<Record<string, Route>>, ConfigError> {
   const raw = root.routing;
   if (raw === undefined) return ok(DEFAULT_ROUTING);
   if (!isTable(raw)) return fail("routing must be a table", "routing");
   const result: Record<string, Route> = {};
   for (const [pattern, value] of Object.entries(raw)) {
+    if (!ROUTING_KEY.test(pattern)) {
+      return fail(
+        `routing.${pattern}: key must be <difficulty>/<risk>, each a level or *`,
+        `routing.${pattern}`,
+      );
+    }
     const parsed = route(value, `routing.${pattern}`);
     if (!parsed.ok) return parsed;
     result[pattern] = parsed.value;
@@ -201,7 +208,6 @@ const TOP_LEVEL = [
   "profiles",
   "models",
   "routing",
-  "jev",
   "verifier",
   "cadence",
   "event_model",
@@ -237,27 +243,20 @@ function deliveryAndReview(
 
 function limits(
   root: Table,
-): Result<Pick<DevsysConfig, "jev" | "verifier" | "cadence" | "eventModel">, ConfigError> {
-  const j = section(root, "jev", ["timeout_ms", "confidence_floor"]);
+): Result<Pick<DevsysConfig, "verifier" | "cadence" | "eventModel">, ConfigError> {
   const v = section(root, "verifier", ["max_per_session"]);
   const c = section(root, "cadence", ["push_minutes"]);
   const e = section(root, "event_model", ["provider"]);
-  if (!j.ok) return j;
   if (!v.ok) return v;
   if (!c.ok) return c;
   if (!e.ok) return e;
-  const timeout = number(j.value, "jev", "timeout_ms", 4000, POSITIVE);
-  const floor = number(j.value, "jev", "confidence_floor", 0.6, { min: 0, max: 1, integer: false });
   const max = number(v.value, "verifier", "max_per_session", 6, POSITIVE);
   const push = number(c.value, "cadence", "push_minutes", 60, POSITIVE);
   const provider = text(e.value, "event_model", "provider", "builtin");
-  if (!timeout.ok) return timeout;
-  if (!floor.ok) return floor;
   if (!max.ok) return max;
   if (!push.ok) return push;
   if (!provider.ok) return provider;
   return ok({
-    jev: { timeoutMs: timeout.value, confidenceFloor: floor.value },
     verifier: { maxPerSession: max.value },
     cadence: { pushMinutes: push.value },
     eventModel: { provider: provider.value },