@jwilger/pi-development-system 0.44.1 → 0.45.1

package/agents/implementer.md

@@ -37,7 +37,7 @@ You are an implementer. You receive exactly one task record and nothing else: do
 
 End with evidence the coordinator can check, one block per command you ran:
 
-```
+```text
 Run: <exact command>
 Expected: <what the task said>
 Actual: <what you saw, quoted>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.44.1",
+  "version": "0.45.1",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"
@@ -51,6 +51,8 @@
     "@types/node": "^26.6.4",
     "@types/shell-quote": "^1.7.5",
     "@typesafe-ai/sdk": "^0.6.0",
+    "knip": "^6.40.0",
+    "markdownlint-cli2": "^0.23.3",
     "typescript": "^7.0.2"
   },
   "scripts": {
@@ -61,6 +63,8 @@
     "lint": "biome check .",
     "lint:fix": "biome check --write .",
     "check:build-gate": "node scripts/build-gate.ts",
-    "check:version": "node scripts/check-version.ts"
+    "check:version": "node scripts/check-version.ts",
+    "lint:knip": "knip",
+    "lint:md": "markdownlint-cli2"
   }
 }

package/principles/NON-NEGOTIABLES.md

@@ -5,31 +5,41 @@ Departing from any item below requires an explicit decision from the author
 departure is warranted: stop, say which item and why, and ask.
 
 ## 1. Never rewrite pushed history or force-push
+
 Amend/rebase/reset of pushed refs, `--force*`, deleting shared branches. Because it destroys other people's basis for trust.
 
 ## 2. Never weaken verification to make a gate pass
+
 Deleting, skipping or loosening tests; suppressing a lint; editing expected values to match output; `--no-verify`. Because a green gate must mean the same thing afterwards. (Changing a test because the *requirement* changed is a recorded departure, not this.)
 
 ## 3. Never claim something was verified, run, or green that was not
+
 Because the record of evidence is the product. Evidence comes before claims.
 
 ## 4. Never push on a red trunk
+
 Except a change whose purpose is fixing that failure. Because unrelated work on red hides the signal.
 
 ## 5. Never work around an unresolved gate
+
 Stop, record, ask. Because a gate you can route around is not a gate.
 
 ## 6. Never violate repo-local delivery policy
+
 Delivery mode, protected branches, required reviews. Because the repo, not this tool, owns policy.
 
 ## 7. Never let secrets leave the machine without sanitisation
+
 In commits, logs, eval cases, or subagent prompts. Because exfiltration is irreversible.
 
 ## 8. Never commit without a rationale-bearing Conventional Commit, or add AI attribution trailers
+
 No `Co-Authored-By`, no `Generated-by`. Because the message is the durable why; attribution noise is not.
 
 ## 9. Never make an architecture-shaping decision without an ADR
+
 New dependency class, boundary change, persistence model, public contract. Because "Revisit when" is how decisions stay honest.
 
 ## 10. Never ship model-visible instructions without an evidence check
+
 Skills, prompts, Jev questions need a fixture or eval. Because effectiveness is eval-driven, not vibes.

package/src/context/status.ts

@@ -13,7 +13,7 @@ const ciLabel = (state: DevsysState): string | undefined => {
   return `ci ${ci.status}${sha}`;
 };
 
-export const activeReview = (state: DevsysState): string | undefined => {
+const activeReview = (state: DevsysState): string | undefined => {
   // Without an active slice (before /devsys-start exists) show the most recent review instead of nothing.
   const review =
     state.activeSlice === undefined ? state.reviews?.at(-1) : reviewOf(state, state.activeSlice);

package/src/context/system-prompt.ts

@@ -1,7 +1,7 @@
 import type { BeforeAgentStartEvent } from "@earendil-works/pi-coding-agent";
 import type { DevsysState } from "../core/types.ts";
 
-export const PROMPT_SECTION_NAME = "development-system";
+const PROMPT_SECTION_NAME = "development-system";
 
 /** Pure: renders the system-prompt section from current state. */
 export function buildPromptSection(state: DevsysState, nonNegotiables: string): string {

package/src/context/turn-verifier.ts

@@ -7,9 +7,9 @@ import type { Jev } from "../jev/client.ts";
 import { judgeTurn, type ToolEvidence } from "../jev/questions/turn.ts";
 import type { SessionState } from "../state/session-state.ts";
 
-export const VERIFIER_THRESHOLD = 0.75;
+const VERIFIER_THRESHOLD = 0.75;
 export const DEFAULT_VERIFIER_MAX = 6;
-export const VERIFIER_ENTRY_TYPE = "devsys-verifier";
+const VERIFIER_ENTRY_TYPE = "devsys-verifier";
 const VERIFIED_PHASES: ReadonlySet<Phase> = new Set(["implementing", "reviewing", "delivering"]);
 const MAX_EVIDENCE = 60;
 
@@ -23,7 +23,7 @@ export type TurnVerifierDeps = {
 type Parts = { text: string; callsTools: boolean };
 
 /** Text and tool-call presence of an assistant message; undefined for any other role. */
-export function assistantParts(message: AgentMessage): Parts | undefined {
+function assistantParts(message: AgentMessage): Parts | undefined {
   if (message.role !== "assistant") return undefined;
   const text = message.content.flatMap((c) => (c.type === "text" ? [c.text] : [])).join("\n");
   return { text, callsTools: message.content.some((c) => c.type === "toolCall") };

package/src/core/departure.ts

@@ -79,7 +79,8 @@ function renderScope(scope: DepartureScope): string {
 export function renderDepartureMarkdown(d: Departure): string {
   const revisit = d.revisitWhen !== undefined ? ` · **Revisit when:** ${d.revisitWhen}` : "";
   return [
-    `### ${d.recordedAt} · ${d.gate} · ${d.tier} · ${d.approver}`,
+    `## ${d.recordedAt} · ${d.gate} · ${d.tier} · ${d.approver}`,
+    "",
     `- **Default:** ${d.default}`,
     `- **Chosen:** ${d.chosen}`,
     `- **Why:** ${d.why}`,

package/src/core/gates.ts

@@ -3,7 +3,7 @@ import type { Tier } from "./types.ts";
 export type GateInfo = { readonly tier: Tier; readonly default: string };
 
 /** Registered gate ids (plan Appendix A); grows per increment. Qualified ids use their base entry. */
-export const GATES: Readonly<Record<string, GateInfo>> = {
+const GATES: Readonly<Record<string, GateInfo>> = {
   "git.history-rewrite": { tier: "hard", default: "never rewrite published history" },
   "git.force-push": { tier: "hard", default: "never force-push" },
   "git.branch-delete-remote": { tier: "hard", default: "never delete remote branches" },

package/src/core/git-invocations.ts

@@ -15,7 +15,7 @@ import {
 } from "./git-intent.ts";
 import { stripHeredocs } from "./heredoc.ts";
 
-export type GitInvocation = {
+type GitInvocation = {
   readonly sub: string;
   readonly args: readonly string[];
   /** Directory the command runs in, relative to the starting one (from `cd` and `git -C`), when it moved. */

package/src/core/model-advice.ts

@@ -9,7 +9,7 @@ import {
 import type { Phase } from "./types.ts";
 
 /** Highest first. */
-export const TIERS = ["frontier", "strong", "fast"] as const;
+const TIERS = ["frontier", "strong", "fast"] as const;
 export type Tier = (typeof TIERS)[number];
 
 const PHASE_SLOT: Partial<Record<Phase, Slot>> = {

package/src/core/profile.ts

@@ -4,14 +4,14 @@ import { isParseError, type ParseError, type Profile, parseError } from "./types
 
 export type { Profile };
 
-export const PROFILES: readonly Profile[] = ["rust", "typescript"];
+const PROFILES: readonly Profile[] = ["rust", "typescript"];
 
 const MARKERS: ReadonlyArray<{ profile: Profile; files: readonly string[] }> = [
   { profile: "rust", files: ["Cargo.toml"] },
   { profile: "typescript", files: ["package.json", "tsconfig.json"] },
 ];
 
-export const isProfile = (value: string): value is Profile => PROFILES.some((p) => p === value);
+const isProfile = (value: string): value is Profile => PROFILES.some((p) => p === value);
 
 /** Boundary parse for configured profile names. */
 export function parseProfiles(names: readonly string[]): Profile[] | ParseError {

package/src/core/review-flow.ts

@@ -110,7 +110,7 @@ export function combinePackets(packets: readonly ReviewPacket[]): {
 }
 
 /** Jev confidence needed before its severity replaces the reviewer's. */
-export const SEVERITY_ADOPT_CONFIDENCE = 0.8;
+const SEVERITY_ADOPT_CONFIDENCE = 0.8;
 
 const counts = (severity: Severity): boolean =>
   severity === "blocking" || severity === "should-fix";

package/src/core/review.ts

@@ -90,7 +90,7 @@ export const LENSES = [
   "performance",
 ] as const;
 export type Lens = (typeof LENSES)[number];
-export const LENS_THRESHOLD = 0.5;
+const LENS_THRESHOLD = 0.5;
 
 /** Lenses that apply when Jev is offline: the ones every change deserves. */
 export const DEFAULT_LENSES: ReadonlyArray<Lens> = ["types", "tests"];

package/src/core/types.ts

@@ -22,12 +22,6 @@ export function parseGateId(input: string): GateId | ParseError {
     : parseError(`invalid gate id "${input}": expected dotted kebab-case like "git.force-push"`);
 }
 
-export type GateDecision =
-  | { readonly kind: "allow" }
-  | { readonly kind: "block"; readonly reason: string }
-  | { readonly kind: "require-departure"; readonly gate: GateId; readonly reason: string }
-  | { readonly kind: "require-user"; readonly gate: GateId; readonly reason: string };
-
 export type Phase = "intake" | "planning" | "implementing" | "reviewing" | "delivering" | "idle";
 
 export type Sizing = "fix" | "change" | "capability" | "product";

package/src/gates/approvals.ts

@@ -6,7 +6,7 @@ import { type GateId, isParseError } from "../core/types.ts";
 import { appendDecision } from "../state/decision-log.ts";
 import { DEPARTURE_ENTRY_TYPE } from "./record-departure-tool.ts";
 
-export const APPROVAL_ENTRY_TYPE = "devsys-approval";
+const APPROVAL_ENTRY_TYPE = "devsys-approval";
 
 type Approval = { id: string; gate: string; command: string; used: boolean };
 

package/src/jev/questions/shell-intent.ts

@@ -4,7 +4,7 @@ import { redactSecrets } from "../../core/redact.ts";
 import { err, ok, type Result } from "../../core/result.ts";
 import type { Jev, JevError } from "../client.ts";
 
-export const SHELL_INTENT_THRESHOLD = 0.6;
+const SHELL_INTENT_THRESHOLD = 0.6;
 
 export const SHELL_INTENT_QUESTION: ClassifierChoiceQuestion = {
   type: "choice",

package/src/state/config.ts

@@ -11,8 +11,8 @@ export const CONFIG_FILE = ".development-system.toml";
 const DELIVERY_MODES = ["trunk", "pull-request", "local-only"] as const;
 const TRACKER_KINDS = ["repo-files", "github", "jira", "linear"] as const;
 
-export type DeliveryMode = (typeof DELIVERY_MODES)[number];
-export type TrackerKind = (typeof TRACKER_KINDS)[number];
+type DeliveryMode = (typeof DELIVERY_MODES)[number];
+type TrackerKind = (typeof TRACKER_KINDS)[number];
 
 export type ConfigError = {
   readonly kind: "config-error";

package/src/state/models-command.ts

@@ -19,7 +19,7 @@ import {
 } from "../core/models.ts";
 import { CONFIG_FILE, loadConfig } from "./config.ts";
 
-export const CONFIG_ENTRY_TYPE = "devsys-config";
+const CONFIG_ENTRY_TYPE = "devsys-config";
 
 export type CatalogModel = Available & {
   readonly cost?: { readonly input: number; readonly output: number };
@@ -32,7 +32,7 @@ export interface ModelCatalog {
   hasConfiguredAuth(model: CatalogModel): boolean;
 }
 
-export type SlotRow = {
+type SlotRow = {
   readonly slot: Slot;
   readonly resolution: Resolution | undefined;
 };
@@ -45,7 +45,7 @@ export function availableModels(catalog: ModelCatalog): CatalogModel[] {
   return [...catalog.getAvailable(), ...classifiers];
 }
 
-export function resolveRows(matrix: ModelMatrix, available: readonly Available[]): SlotRow[] {
+function resolveRows(matrix: ModelMatrix, available: readonly Available[]): SlotRow[] {
   return SLOTS.map((slot) => {
     const r = resolveSlot(matrix, slot, available);
     return { slot, resolution: r.ok ? r.value : undefined };
@@ -62,10 +62,7 @@ function priceOf(model: string, available: readonly CatalogModel[]): string {
 }
 
 /** One line per slot: `slot → provider/id (via candidate) · $in/$out per M`, or `UNRESOLVED`. */
-export function renderModelsTable(
-  rows: readonly SlotRow[],
-  available: readonly CatalogModel[],
-): string {
+function renderModelsTable(rows: readonly SlotRow[], available: readonly CatalogModel[]): string {
   const width = Math.max(...SLOTS.map((s) => s.length));
   return rows
     .map(({ slot, resolution }) =>

package/src/state/session-state.ts

@@ -19,7 +19,7 @@ import {
   type TestRun,
 } from "../core/types.ts";
 
-export const STATE_ENTRY_TYPE = "devsys-state";
+const STATE_ENTRY_TYPE = "devsys-state";
 
 const PHASES: ReadonlyArray<Phase> = [
   "intake",

package/src/subagents/orch/mailbox.ts

@@ -2,11 +2,11 @@
 import { randomUUID } from "node:crypto";
 import type { SessionEntry, SessionManager } from "@earendil-works/pi-coding-agent";
 
-export const LEGACY_QUEUE_TYPE = "pi-subagent:queue:v1";
+const LEGACY_QUEUE_TYPE = "pi-subagent:queue:v1";
 const ACCEPTED_TYPE = "pi-subagent:mailbox:accepted:v2";
 const CONSUMED_TYPE = "pi-subagent:mailbox:consumed:v2";
 const MIGRATION_TYPE = "pi-subagent:mailbox:migration:v2";
-export const MAILBOX_FIELD = "piSubagentMailbox";
+const MAILBOX_FIELD = "piSubagentMailbox";
 export const BOOTSTRAP_MESSAGE = "Subagent session initialized; awaiting parent input.";
 
 export type AcceptedKind = "steer" | "followUp" | "update";

package/src/subagents/prefs/agent-import.ts

@@ -12,7 +12,7 @@ import { dialogText } from "../ui/dialog.ts";
 export const IMPORT_REQUEST_PREFIX =
   "Import ONLY the agents I selected in the pi-subagent-manager migration picker.";
 
-export const IMPORT_CHILD_TOOLS = [
+const IMPORT_CHILD_TOOLS = [
   "read",
   "bash",
   "powershell",
@@ -61,7 +61,7 @@ function stateDirectory(agentDir: string, create: boolean): string | undefined {
   return directory;
 }
 
-export function importWasOffered(agentDir: string): boolean {
+function importWasOffered(agentDir: string): boolean {
   const directory = stateDirectory(agentDir, false);
   if (!directory) return false;
   const stat = statIfPresent(join(directory, OFFER_MARKER));
@@ -89,7 +89,7 @@ export function markImportOffered(agentDir: string): void {
   }
 }
 
-export function buildImportPrompt(options: {
+function buildImportPrompt(options: {
   candidates: readonly ImportCandidate[];
   agentDir: string;
   cwd: string;

package/src/subagents/prefs/settings.ts

@@ -14,16 +14,16 @@ import {
 } from "node:fs";
 import { dirname, join, resolve } from "node:path";
 
-export const SUBAGENT_MODES = ["off", "opportunistic", "orchestration"] as const;
+const SUBAGENT_MODES = ["off", "opportunistic", "orchestration"] as const;
 export type SubagentMode = (typeof SUBAGENT_MODES)[number];
 
-export const WIDGET_MODES = ["full", "minimal"] as const;
+const WIDGET_MODES = ["full", "minimal"] as const;
 export type WidgetMode = (typeof WIDGET_MODES)[number];
 
-export const TOOL_FILTERING_MODES = ["allowed", "all-except-blocked", "all"] as const;
+const TOOL_FILTERING_MODES = ["allowed", "all-except-blocked", "all"] as const;
 export type ToolFilteringMode = (typeof TOOL_FILTERING_MODES)[number];
 
-export const MODEL_SELECTION_MODES = [
+const MODEL_SELECTION_MODES = [
   "pick-first-available",
   "pick-first-scoped",
   "use-current",

package/src/subagents/types.ts

@@ -44,7 +44,7 @@ export interface AgentType {
   /** File path of the base definition under the customization, if any. */
   baseFilePath?: string;
 }
-export type ThreadState = "starting" | "running" | "paused" | "completed" | "failed" | "stopped";
+type ThreadState = "starting" | "running" | "paused" | "completed" | "failed" | "stopped";
 export interface ThreadView {
   path: string;
   parent: string | null;
@@ -71,7 +71,7 @@ export interface ThreadView {
   /** devsys: per-spawn model/thinkingLevel pin requested through agent_spawn, when any. */
   pinned?: { model?: string; thinkingLevel?: ThinkingLevel };
 }
-export type DriverEvent =
+type DriverEvent =
   | { kind: "activity" | "error"; text: string }
   | {
       kind: "checkpoint";

package/src/subagents/ui/dialog.ts

@@ -24,7 +24,7 @@ export interface DialogHost {
   requestRender(force?: boolean): void;
   terminal?: { rows: number };
 }
-export interface DialogEditorHost extends DialogHost {
+interface DialogEditorHost extends DialogHost {
   terminal: { rows: number };
 }
 export interface DialogRow {
@@ -97,7 +97,7 @@ export function frameDialog(
 }
 
 /** A multiline editor inside the same bounded shell as the surrounding form. */
-export class DialogEditor {
+class DialogEditor {
   private editor: Editor;
   private initialText: string;
   constructor(
@@ -180,7 +180,7 @@ export function dialogEditor(
 }
 
 /** Bounded, two-column menu shared by settings and agent definitions. */
-export class DialogMenu {
+class DialogMenu {
   private selected = 0;
   private viewport = 1;
   constructor(

package/src/subagents/ui/import-picker.ts

@@ -71,7 +71,7 @@ function wrapText(text: string, columns: number): string[] {
  * Checkbox dialog for choosing external agents to migrate.
  * Selection only — the caller imports; this does not read or write agent files.
  */
-export class ImportPicker {
+class ImportPicker {
   private cursor = 0;
   private viewport = 1;
   private readonly checked = new Set<string>();

package/src/subagents/ui/model-picker.ts

@@ -84,7 +84,7 @@ function describeModel(model: AvailableModel, scopedIdentities: ReadonlySet<stri
   return [name, annotation].filter(Boolean).join(" · ");
 }
 
-export class OrderedModelEditorComponent extends Container {
+class OrderedModelEditorComponent extends Container {
   private readonly tui: {
     requestRender(force?: boolean): void;
     terminal?: { rows: number };

package/src/subagents/ui/status-ui.ts

@@ -31,7 +31,6 @@ import {
 } from "./ui.ts";
 import { LiveAgentView, fillViewport, type AgentViewportState } from "./live-agent-view.ts";
 
-export { buildStatusTree, type StatusRow };
 
 const ROOT = "/root";
 const INACTIVE_STATES = new Set(["paused", "stopped", "failed", "completed"]);
@@ -81,7 +80,7 @@ export interface AgentTreeState {
   collapsed: Set<string>;
 }
 
-export class StatusDialog {
+class StatusDialog {
   private state: AgentTreeState;
   private get selectedPath(): string {
     return this.state.selectedPath;
@@ -530,7 +529,7 @@ export class AgentNavigationController {
 
 const navigationByService = new WeakMap<ThreadService, AgentNavigationController>();
 
-export async function showAgentTree(
+async function showAgentTree(
   ctx: ExtensionContext,
   service: ThreadService,
   selectedPath?: string,

package/src/subagents/ui/ui.ts

@@ -55,7 +55,7 @@ export type ThreadController = Pick<
 >;
 
 /** Plain terminal-safe text: never pass agent-supplied terminal commands through. */
-export function sanitizeText(text: string): string {
+function sanitizeText(text: string): string {
   return stripTerminalSequences(text).replace(/[\x00-\x1f\x7f-\x9f]/g, " ");
 }
 
@@ -200,7 +200,7 @@ function isLive(thread: ThreadView): boolean {
   );
 }
 
-export function renderThreads(
+function renderThreads(
   threads: ThreadView[],
   width: number,
   theme: AgentBadgeTheme,
@@ -453,7 +453,7 @@ function takeWidgetRows(rows: StatusRow[], budget: number): StatusRow[] {
 }
 
 /** Themed agent tree above the editor. Synthetic /root is the main conversation and is omitted. */
-export function renderAgentTree(
+function renderAgentTree(
   threads: ThreadView[],
   width: number,
   theme: AgentBadgeTheme,
@@ -493,7 +493,7 @@ export function renderAgentTree(
 }
 
 /** One-line counts for real agents; starting agents count as running, including tokens. */
-export function renderAgentSummary(
+function renderAgentSummary(
   threads: ThreadView[],
   width: number,
   theme: Pick<Theme, "fg">,
@@ -682,7 +682,7 @@ export async function showThreads(
 }
 
 /** Parse editor argv, rejecting shell operators instead of evaluating a shell command. */
-export function editorArguments(command: string): string[] {
+function editorArguments(command: string): string[] {
   const args = parseShell(command, process.env);
   if (!args.length || args.some((arg) => typeof arg !== "string") || !args[0]) {
     throw new Error(