@jwilger/pi-development-system 0.42.0 → 0.44.0

package/agents/reviewer.md

@@ -53,4 +53,4 @@ Use exactly this packet; the coordinator parses it.
 no-blocking | blocking
 ```
 
-Severity: **blocking** = demonstrable defect or broken non-negotiable; **should-fix** = real defect or missing test with a realistic trigger; **nit** = style, naming, report-only. Zero findings is a valid result. End with **Not verified**: checks you could not run.
+Severity: **blocking** = demonstrable defect or broken non-negotiable; **should-fix** = real defect or missing test with a realistic trigger; **nit** = style or naming; do not report these unless asked, because nothing stores them. Zero findings is a valid result. End with **Not verified**: checks you could not run.

package/extensions/development-system.ts

@@ -1,7 +1,6 @@
 import { readFileSync } from "node:fs";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { cadenceLine, DEFAULT_PUSH_MINUTES } from "../src/context/cadence.ts";
-import { registerCompactionResync } from "../src/context/compaction.ts";
 import { appendContextTail, renderContextTail } from "../src/context/context-tail.ts";
 import { registerModelAdvice } from "../src/context/model-advice.ts";
 import { renderStatus, renderStatusLine, STATUS_KEY } from "../src/context/status.ts";
@@ -114,7 +113,6 @@ export function createDevelopmentSystem(pi: ExtensionAPI) {
   });
   registerTestGuard({ pi, state, approvals, jev: (ctx) => jevHolder.forContext(ctx) });
   registerTestEvidence({ pi, state });
-  registerCompactionResync({ pi, state });
   registerModelAdvice({
     pi,
     state,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.42.0",
+  "version": "0.44.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/code-review/SKILL.md

@@ -48,8 +48,9 @@ The verdict must agree with the findings.
 
 - **blocking**: a demonstrable defect or a broken non-negotiable.
 - **should-fix**: a real defect or missing test with a realistic trigger.
-- **nit**: style or report-only. Nits never reset the streak; they go to
-  `docs/decisions/followups.md`.
+- **nit**: style or report-only. Reviewers should not send these. If one arrives it
+  never resets the streak, and nothing stores it: fix it now, or drop it and say why
+  in your reply. A finding nobody will act on is not worth recording.
 - **false-positive**: refuted; ignored.
 
 Jev may raise a finding's severity when it is at least 0.8 confident; it never

package/src/core/review-flow.ts

@@ -143,16 +143,17 @@ export function adoptSeverity(
 const where = (f: Finding): string =>
   f.path === undefined ? "" : ` \`${f.path}${f.line === undefined ? "" : `:${f.line}`}\``;
 
-/** The nits of a round, as a section for docs/decisions/followups.md. */
-export function renderFollowups(
-  slice: SliceRef,
-  round: number,
-  findings: readonly Finding[],
-): string | undefined {
+/**
+ * Nits are never stored. Each is reported back so the coordinator fixes it now or drops it
+ * with a stated reason; a finding nobody will act on is not worth recording.
+ */
+export function nitLines(findings: readonly Finding[]): string[] {
   const nits = findings.filter((f) => f.severity === "nit");
-  if (nits.length === 0) return undefined;
-  const lines = nits.map((f) => `- ${f.lens}${where(f)} — ${f.summary}`);
-  return `\n## From ${slice} review round ${round}\n\n${lines.join("\n")}\n`;
+  if (nits.length === 0) return [];
+  return [
+    "Nits are not stored anywhere: fix each now, or drop it and say why in your reply.",
+    ...nits.map((f) => `- nit ${f.lens}${where(f)} — ${f.summary}`),
+  ];
 }
 
 /** The task text for a fresh reviewer: slice, lenses, how to see the diff, and the packet to return. */

package/src/review/review-tools.ts

@@ -1,5 +1,3 @@
-import { appendFile, mkdir } from "node:fs/promises";
-import { join } from "node:path";
 import type { ExtensionContext, ToolDefinition } from "@earendil-works/pi-coding-agent";
 import { type Static, Type } from "typebox";
 import type { Exec } from "../core/exec.ts";
@@ -16,7 +14,7 @@ import {
 import {
   adoptSeverity,
   combinePackets,
-  renderFollowups,
+  nitLines,
   reviewerTask,
   reviewLabel,
   reviewOf,
@@ -209,7 +207,7 @@ export function createReviewRecordTool(
     name: "devsys_review_record",
     label: "Record review round",
     description:
-      "Record one review round from the reviewer's packet(s): parses findings, lets Jev adjust severity when confident, files nits in docs/decisions/followups.md, and returns the clean-round count and the next action.",
+      "Record one review round from the reviewer's packet(s): parses findings, lets Jev adjust severity when confident, and returns the clean-round count and the next action.",
     promptSnippet: "Record a reviewer packet as a review round",
     parameters: RecordParameters,
     exposure: "direct",
@@ -259,27 +257,7 @@ export function createReviewRecordTool(
 
       const merged = combinePackets(packets);
       const { findings, notes } = await adjusted(deps, ctx, merged.findings, snap.value.sample);
-      // File the nits first: if this fails nothing is recorded and a retry cannot count the round twice.
-      const followups = renderFollowups(slice, expected, findings);
-      let reviewed = snap.value;
-      if (followups !== undefined) {
-        try {
-          const dir = join(ctx.cwd, "docs", "decisions");
-          await mkdir(dir, { recursive: true });
-          await appendFile(join(dir, "followups.md"), followups);
-        } catch (cause) {
-          return reply(
-            `could not write docs/decisions/followups.md (${cause instanceof Error ? cause.message : String(cause)}); the round was not recorded, retry`,
-            true,
-          );
-        }
-        // The file is part of the work tree, so writing it changed the diff. The round covers the
-        // reviewed code plus its own follow-up note; otherwise `done` would be stale on arrival.
-        const after = await snapshotDiff(deps.exec, ctx.cwd, params.diffRange?.trim() || "HEAD");
-        if (!after.ok)
-          return reply(`cannot read the diff after filing follow-ups: ${after.error}`, true);
-        reviewed = after.value;
-      }
+      const reviewed = snap.value;
       const review = addRound(
         { ...before, required },
         {
@@ -298,6 +276,7 @@ export function createReviewRecordTool(
           `Round ${review.rounds.length} recorded: ${counts("blocking")} blocking, ${counts("should-fix")} should-fix, ${counts("nit")} nit, ${counts("false-positive")} false-positive.`,
           reviewLabel(review),
           ...notes,
+          ...nitLines(findings),
           `next: ${nextAction(review, reviewed.digest)}`,
           ...(range === "HEAD" ? [] : [GATE_RANGE_NOTE]),
         ].join("\n"),

package/src/context/compaction.ts

@@ -1,29 +0,0 @@
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import type { SessionState } from "../state/session-state.ts";
-import { renderStateBlock } from "./state-block.ts";
-
-export const RESYNC_ENTRY_TYPE = "devsys-resync";
-
-/**
- * pi lets `session_before_compact` only REPLACE the whole summary (summary, firstKeptEntryId,
- * tokensBefore), which would mean writing our own summariser and paying another model call. So the
- * summary is left to pi, and once it lands we re-state the working state as one message the next
- * request sees. State itself lives in session entries and the per-turn context tail, so nothing is
- * lost; this just makes it visible to the model again.
- */
-export function registerCompactionResync(deps: { pi: ExtensionAPI; state: SessionState }): void {
-  deps.pi.on("session_compact", () => {
-    const state = deps.state.get();
-    if (state.phase === "idle" && state.openDepartures.length === 0) return;
-    // triggerTurn:false: while a run is active pi would otherwise steer the message, and the queued
-    // message would force an extra model turn after automatic compaction.
-    deps.pi.sendMessage(
-      {
-        customType: RESYNC_ENTRY_TYPE,
-        content: `[devsys resync] Context was compacted. Current working state:\n\n${renderStateBlock(state)}`,
-        display: true,
-      },
-      { triggerTurn: false },
-    );
-  });
-}

package/src/context/state-block.ts

@@ -1,30 +0,0 @@
-import type { DevsysState } from "../core/types.ts";
-import { activeReview } from "./status.ts";
-
-const MAX_DEPARTURES = 8;
-
-/** The durable working state as a short markdown block, for compaction resync and the like. */
-export function renderStateBlock(state: DevsysState): string {
-  const departures = state.openDepartures.map(
-    (d) => `  - ${d.gate} — ${d.chosen.replace(/\s+/g, " ")}`,
-  );
-  const shown =
-    departures.length <= MAX_DEPARTURES
-      ? departures
-      : [
-          ...departures.slice(0, MAX_DEPARTURES - 1),
-          `  - …and ${departures.length - MAX_DEPARTURES + 1} more`,
-        ];
-  const run = state.lastTestRun;
-  return [
-    "## Development System State",
-    `- phase: ${state.phase}`,
-    `- sizing: ${state.sizing ?? "unset"}`,
-    `- slice: ${state.activeSlice ?? "none"}`,
-    `- open departures: ${state.openDepartures.length === 0 ? "none" : state.openDepartures.length}`,
-    ...shown,
-    `- ${activeReview(state) ?? "review: none"}`,
-    `- last test run: ${run === undefined ? "none" : `exit ${run.exitCode} — ${run.summary}`}`,
-    `- last push: ${state.lastPushAt ?? "none"}`,
-  ].join("\n");
-}