@jwilger/pi-development-system 0.39.0 → 0.41.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.39.0",
+  "version": "0.41.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/context/compaction.ts

@@ -15,10 +15,15 @@ export function registerCompactionResync(deps: { pi: ExtensionAPI; state: Sessio
   deps.pi.on("session_compact", () => {
     const state = deps.state.get();
     if (state.phase === "idle" && state.openDepartures.length === 0) return;
-    deps.pi.sendMessage({
-      customType: RESYNC_ENTRY_TYPE,
-      content: `[devsys resync] Context was compacted. Current working state:\n\n${renderStateBlock(state)}`,
-      display: true,
-    });
+    // triggerTurn:false: while a run is active pi would otherwise steer the message, and the queued
+    // message would force an extra model turn after automatic compaction.
+    deps.pi.sendMessage(
+      {
+        customType: RESYNC_ENTRY_TYPE,
+        content: `[devsys resync] Context was compacted. Current working state:\n\n${renderStateBlock(state)}`,
+        display: true,
+      },
+      { triggerTurn: false },
+    );
   });
 }

package/src/context/model-advice.ts

@@ -39,7 +39,10 @@ export function registerModelAdvice(deps: ModelAdviceDeps): void {
     });
     if (advice === undefined) return;
     told.add(key);
-    deps.pi.sendMessage({ customType: ADVICE_ENTRY_TYPE, content: advice, display: true });
+    deps.pi.sendMessage(
+      { customType: ADVICE_ENTRY_TYPE, content: advice, display: true },
+      { triggerTurn: false },
+    );
   };
 
   deps.pi.on("session_start", (_event, ctx) => {

package/src/context/turn-verifier.ts

@@ -32,13 +32,14 @@ export function assistantParts(message: AgentMessage): Parts | undefined {
 const LIST_ITEM = /^(?:\d+[.)]|[-*+])\s/;
 
 const QUESTION_END = /\?(?:\s*\([^()]{0,40}\))?[\s)"'*_`]*$/;
-/** A lead-in that introduces options ("Want me to:", "Which next:") before a bare list. */
-const LEAD_IN = /:\s*$/;
+/** A lead-in that asks for a choice ("Want me to:", "Which next:"), not a status summary ("Changes:"). */
+const CHOICE_LEAD_IN =
+  /\b(?:want me to|would you like|should i|shall i|which|do you want|let me know|choose|pick)\b[^\n]*:\s*$/i;
 
 /**
  * True when the message ends by asking the user something: the last non-empty line, or the last line
  * before an option list, ends with a question mark (optionally followed by a short parenthetical
- * like "(y/n)"), or a bare option list follows a colon lead-in.
+ * like "(y/n)"), or a bare option list follows a lead-in that asks for a choice. A plain "Summary:" list is not a question.
  */
 export function asksUser(text: string): boolean {
   const lines = text
@@ -50,7 +51,7 @@ export function asksUser(text: string): boolean {
   if (QUESTION_END.test(last)) return true;
   const lead = lines.filter((l) => !LIST_ITEM.test(l)).at(-1);
   if (lead === undefined) return false;
-  return QUESTION_END.test(lead) || (LIST_ITEM.test(last) && LEAD_IN.test(lead));
+  return QUESTION_END.test(lead) || (LIST_ITEM.test(last) && CHOICE_LEAD_IN.test(lead));
 }
 
 /** True when a scope.expansion departure already covers the slice: the remedy the note asks for exists. */

package/src/subagents/VENDORED.md

@@ -40,3 +40,4 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 6. Empty scope (I5 review): `orch/runtime.ts` `availableScopedModels` treats an empty `/scoped-models` as no restriction (pi's meaning) instead of "matches nothing", because every devsys agent declares `models:` and would otherwise be unspawnable by default. Pinned models are also re-applied on resume (`resolveInitialSettings`), since a restored session may hold only inherited history.
 7. Bundled agents outside `src/subagents`: `agents/researcher.md` (devsys `models:` family list) and `agents/reviewer.md` (devsys `models:` list and packet format; description rewritten; upstream `icon` and `modelSuggestions` removed) differ from upstream; `agents/{advisor,implementer,lens-*}.md` are new. The agent file format itself is unchanged.
+8. Thread cap (I7b.1): `orch/manager.ts` `archiveFinished` replaces the hard "Total thread limit reached" check. At `maxThreads` the oldest finished (completed/failed/stopped) thread without a retained descendant is dropped from the registry to make room; the limit is refused only when every kept thread is live, paused or a parent of one. Upstream kept finished threads forever, so long autonomous runs stalled on their own history. A dropped thread cannot be resumed with `agent_steer` (its session file stays on disk).

package/src/subagents/orch/manager.ts

@@ -257,8 +257,7 @@ export class ThreadManager {
         : level > maxLevels
     )
       throw new Error("Agent depth limit reached");
-    if (this.records.size >= (this.options.maxThreads ?? DEFAULT_MANAGER_SETTINGS.maxThreads))
-      throw new Error("Total thread limit reached");
+    this.archiveFinished(this.options.maxThreads ?? DEFAULT_MANAGER_SETTINGS.maxThreads);
     this.assertCapacity();
     const type = structuredClone(this.options.getType(args.type));
     if (overrides !== undefined) type.spawnOverrides = { ...overrides };
@@ -761,6 +760,24 @@ export class ThreadManager {
       }
     }
   }
+  /**
+   * devsys: a finished thread must never block new work, or long autonomous runs stall
+   * on their own history. Make room for one more thread by dropping the oldest finished
+   * thread that has no retained descendant; live and paused threads are never dropped.
+   * Throws only when every retained thread is still live, paused or a parent of one.
+   */
+  private archiveFinished(limit: number): void {
+    while (this.records.size >= limit) {
+      const paths = [...this.records.keys()];
+      const victim = paths.find((path) => {
+        const state = this.records.get(path)?.view.state;
+        const finished = state === "completed" || state === "failed" || state === "stopped";
+        return finished && !paths.some((other) => isDescendant(other, path));
+      });
+      if (victim === undefined) throw new Error("Total thread limit reached");
+      this.records.delete(victim);
+    }
+  }
   private assertCapacity(): void {
     if (
       [...this.records.values()].filter((record) => active(record.view)).length >=

package/src/subagents/ui/settings-ui.ts

@@ -34,7 +34,7 @@ const FIELDS = [
   {
     id: "maxThreads",
     label: "Retained threads",
-    help: "How many agent sessions can be kept for follow-up work, including completed and paused agents.\nAt the limit, new agents cannot start.\nPositive safe integer.",
+    help: "How many agent sessions can be kept for follow-up work, including completed and paused agents.\nAt the limit the oldest finished agent is dropped to make room; new agents are refused only when every kept agent is still active, paused or has a kept child.\nPositive safe integer.",
   },
 ] as const;