@jwilger/pi-development-system 0.32.0 → 0.34.0

package/agents/reviewer.md

@@ -31,7 +31,7 @@ You are a reviewer. You find defects you can demonstrate from the code and propo
 
 ## What counts
 
-Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. Zero findings is a valid result: write `- none` under Findings.
+Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. Zero findings is a valid result: write `- none` under Findings. Findings holds only finding lines; put what you checked and refuted under Sources inspected.
 
 A fix is the smallest local change or deletion that removes the demonstrated defect. Do not propose new abstractions, frameworks, or broad refactors.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.32.0",
+  "version": "0.34.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/prompts/devsys-review.md

@@ -6,5 +6,5 @@ Review the work in progress with the code-review skill.
 
 1. Call `devsys_review_start` (slice and diff range: $ARGUMENTS; omit either to use the active slice and `HEAD`; only the `HEAD` range clears the commit gate).
 2. Run the `agent_spawn` payload it returns, unchanged.
-3. Pass the reviewer's packet verbatim to `devsys_review_record` with the same `diffDigest` and `diffRange` the start reply gave.
+3. Pass the reviewer's packet verbatim to `devsys_review_record` with the same `slice`, `diffDigest` and `diffRange` the start reply gave.
 4. Report `review: N/R clean` and the next action. If the next action is `fix-findings`, list each blocking and should-fix finding with its `path:line`.

package/skills/code-review/SKILL.md

@@ -18,7 +18,7 @@ Review is a soft gate (`review.unsatisfied`): skipping it needs a recorded depar
 2. Run that `agent_spawn` unchanged. The reviewer is a top-level agent, not a
    child of this conversation, so it does not inherit your context.
 3. Pass the reviewer's packet, verbatim, to `devsys_review_record` with the
-   `diffDigest` the start reply gave, and the same `diffRange` if you gave one
+   `slice` and `diffDigest` the start reply gave, and the same `diffRange` if you gave one
    (`packets: [...]`; all lens packets of one
    round in one call). A packet is recorded once, in the round its header names;
    if the diff changed since the start, the round is refused: start again.

package/src/core/review-flow.ts

@@ -177,6 +177,6 @@ export function reviewerTask(input: {
     "### Verdict",
     "no-blocking | blocking",
     "",
-    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. With zero findings (a valid result) write `- none` under Findings.",
+    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. With zero findings (a valid result) write `- none` under Findings. Findings holds only finding lines: put what you checked and refuted under Sources inspected or after the verdict.",
   ].join("\n");
 }

package/src/core/review-packet.ts

@@ -18,15 +18,19 @@ const HEADER = new RegExp(
 // Reviewers add text after the location (`fn`, a second location); the first backticked one is the finding's.
 const FINDING = /^-\s*\[([^\]]+)\]\s+(\S+)\s+(?:`([^`]+)`[^—–]*?\s+)?[—–-]\s+(.+)$/;
 // An indented line under a finding is its detail (trigger, fix), unless it is itself a finding.
-const isDetail = (line: string): boolean => /^\s+/.test(line) && !/^\s*-\s*\[/.test(line);
+const isDetail = (line: string): boolean =>
+  /^\s+/.test(line) && !/^\s*(?:[-*+]|\d+[.)])\s*\[/.test(line);
 
-const section = (text: string, name: string): string | undefined => {
+// `until` ends a section; by default any heading does. Findings ends only at a known section so a stray
+// heading inside it (### Nits) makes its lines errors instead of silently cutting the findings off.
+const section = (text: string, name: string, until = /^###?\s/m): string | undefined => {
   const match = new RegExp(`^###\\s+${name}\\s*$`, "im").exec(text);
   if (match === null) return undefined;
   const rest = text.slice(match.index + match[0].length);
-  const next = /^###?\s/m.exec(rest);
+  const next = until.exec(rest);
   return next === null ? rest : rest.slice(0, next.index);
 };
+const AFTER_FINDINGS = /^###?\s+(?:Verdict|Sources inspected|Not verified)\b/im;
 
 const isSeverity = (value: string): value is Severity =>
   (SEVERITIES as readonly string[]).includes(value);
@@ -82,7 +86,13 @@ export function parseReviewPacket(text: string): ReviewPacket | ParseError {
     );
   }
   const findings: Finding[] = [];
-  const lines = (section(text, "Findings") ?? "")
+  const findingsText = section(text, "Findings", AFTER_FINDINGS);
+  if (findingsText === undefined) {
+    return parseError(
+      'missing "### Findings" section: write "- none" under it when there are no findings',
+    );
+  }
+  const lines = findingsText
     .split("\n")
     .filter((l) => !isDetail(l))
     .map((l) => l.trim())

package/src/review/review-tools.ts

@@ -157,7 +157,7 @@ export function createReviewStartTool(
         [
           `${reviewLabel(review)}; round ${round}; diff ${snap.value.digest}. ${basis}`,
           `lenses: ${lenses.join(", ")}`,
-          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with diffDigest "${snap.value.digest}"${range === "HEAD" ? "" : ` and diffRange "${range}"`}:`,
+          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with slice "${slice}", diffDigest "${snap.value.digest}"${range === "HEAD" ? "" : ` and diffRange "${range}"`}:`,
           JSON.stringify(spawn),
         ].join("\n"),
       );