@jwilger/pi-development-system 0.30.0 → 0.32.0

package/agents/reviewer.md

@@ -31,7 +31,7 @@ You are a reviewer. You find defects you can demonstrate from the code and propo
 
 ## What counts
 
-Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. Zero findings is a valid result.
+Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. Zero findings is a valid result: write `- none` under Findings.
 
 A fix is the smallest local change or deletion that removes the demonstrated defect. Do not propose new abstractions, frameworks, or broad refactors.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.30.0",
+  "version": "0.32.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/core/review-flow.ts

@@ -177,6 +177,6 @@ export function reviewerTask(input: {
     "### Verdict",
     "no-blocking | blocking",
     "",
-    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. Zero findings is a valid result.",
+    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. With zero findings (a valid result) write `- none` under Findings.",
   ].join("\n");
 }

package/src/core/review-packet.ts

@@ -15,7 +15,10 @@ const HEADER = new RegExp(
   `^##\\s+Review\\s+${SEP}\\s+(.+?)\\s+${SEP}\\s+round\\s+(\\S+)\\s+${SEP}\\s+lenses:\\s*(.*)$`,
   "m",
 );
-const FINDING = /^-\s*\[([^\]]+)\]\s+(\S+)\s+(?:`([^`]+)`\s+)?[—–-]\s+(.+)$/;
+// Reviewers add text after the location (`fn`, a second location); the first backticked one is the finding's.
+const FINDING = /^-\s*\[([^\]]+)\]\s+(\S+)\s+(?:`([^`]+)`[^—–]*?\s+)?[—–-]\s+(.+)$/;
+// An indented line under a finding is its detail (trigger, fix), unless it is itself a finding.
+const isDetail = (line: string): boolean => /^\s+/.test(line) && !/^\s*-\s*\[/.test(line);
 
 const section = (text: string, name: string): string | undefined => {
   const match = new RegExp(`^###\\s+${name}\\s*$`, "im").exec(text);
@@ -81,8 +84,9 @@ export function parseReviewPacket(text: string): ReviewPacket | ParseError {
   const findings: Finding[] = [];
   const lines = (section(text, "Findings") ?? "")
     .split("\n")
+    .filter((l) => !isDetail(l))
     .map((l) => l.trim())
-    .filter((l) => l !== "" && !/^-?\s*none\.?$/i.test(l));
+    .filter((l) => l !== "" && !/^(?:-\s*)?[([]?(?:none|no findings?)[)\]]?\.?$/i.test(l));
   for (const [i, line] of lines.entries()) {
     const finding = parseFinding(line, lenses, i + 1);
     if (isParseError(finding)) return finding;

package/src/core/review.ts

@@ -71,7 +71,11 @@ export const startReview = (slice: SliceRef, required: number): ReviewState => (
 
 export const addRound = (state: ReviewState, round: Omit<ReviewRound, "n">): ReviewState => ({
   ...state,
-  rounds: [...state.rounds, { ...round, n: state.rounds.length + 1 }],
+  // Only the last round's per-file digests are ever compared, so earlier ones are not carried along.
+  rounds: [
+    ...state.rounds.map(({ files: _files, ...earlier }) => earlier),
+    { ...round, n: state.rounds.length + 1 },
+  ],
 });
 
 /** Review lenses Jev can select (plan I6.2). A lens applies at probability ≥ LENS_THRESHOLD. */

package/src/review/digest.ts

@@ -69,7 +69,7 @@ export async function snapshotDiff(
     const untracked = listed.filter((p) => !p.endsWith("/"));
     if (untracked.length > MAX_UNTRACKED) {
       return err(
-        `${untracked.length} untracked files (more than ${MAX_UNTRACKED}); commit or ignore some so they can be reviewed`,
+        `${untracked.length} untracked files (more than ${MAX_UNTRACKED}); stage (git add) or ignore some so they can be reviewed`,
       );
     }
     const files: Record<string, string> = {};