@jwilger/pi-development-system 0.29.0 → 0.31.0

package/agents/reviewer.md

@@ -31,7 +31,7 @@ You are a reviewer. You find defects you can demonstrate from the code and propo
 
 ## What counts
 
-Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. Zero findings is a valid result.
+Look for correctness bugs, regressions in existing behavior, security issues, and changed behavior with no test. Each finding needs a realistic triggering input or state. Before reporting, try to refute it: a covering test, a nearby guard, a type that rules the case out. Drop it if the refute holds; if it nearly holds, say what evidence is missing. Do not report untraced speculation or nits. Report style only if asked, labeled as style, after defects. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. Zero findings is a valid result: write `- none` under Findings.
 
 A fix is the smallest local change or deletion that removes the demonstrated defect. Do not propose new abstractions, frameworks, or broad refactors.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.29.0",
+  "version": "0.31.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/core/review-flow.ts

@@ -31,7 +31,7 @@ export type DiffNow = {
 };
 
 // The departure log is the system's own record (devsys_record_departure writes it), not work under review.
-const DECISION_LOG = /^docs\/decisions\/\d{4}-\d{2}\.md$/;
+export const DECISION_LOG = /^docs\/decisions\/\d{4}-\d{2}\.md$/;
 
 /** Every file in the current diff was in the last round's diff, byte for byte: a part of what was reviewed. */
 const coveredByLastRound = (review: ReviewState, now: DiffNow): boolean => {
@@ -177,6 +177,6 @@ export function reviewerTask(input: {
     "### Verdict",
     "no-blocking | blocking",
     "",
-    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. Zero findings is a valid result.",
+    "Severity: blocking = demonstrable defect or broken non-negotiable; should-fix = real defect or missing test with a realistic trigger; nit = style or report-only. The verdict is `blocking` when any finding is blocking or should-fix, otherwise `no-blocking`. With zero findings (a valid result) write `- none` under Findings.",
   ].join("\n");
 }

package/src/core/review-packet.ts

@@ -82,7 +82,7 @@ export function parseReviewPacket(text: string): ReviewPacket | ParseError {
   const lines = (section(text, "Findings") ?? "")
     .split("\n")
     .map((l) => l.trim())
-    .filter((l) => l !== "" && !/^-?\s*none\.?$/i.test(l));
+    .filter((l) => l !== "" && !/^(?:-\s*)?[([]?(?:none|no findings?)[)\]]?\.?$/i.test(l));
   for (const [i, line] of lines.entries()) {
     const finding = parseFinding(line, lenses, i + 1);
     if (isParseError(finding)) return finding;

package/src/gates/commit-guard.ts

@@ -14,7 +14,7 @@ import {
 } from "../core/commit-message.ts";
 import type { Exec } from "../core/exec.ts";
 import { resolveGit } from "../core/git-invocations.ts";
-import { reviewGap } from "../core/review-flow.ts";
+import { DECISION_LOG, reviewGap } from "../core/review-flow.ts";
 import { type GateId, isParseError, parseGateId } from "../core/types.ts";
 import type { Jev } from "../jev/client.ts";
 import { judgeCommit, MIX_THRESHOLD, RATIONALE_FLOOR } from "../jev/questions/commit.ts";
@@ -176,7 +176,9 @@ const stagedThenEdited = (
     .filter((i) => (i.sub === "commit" || i.sub === "add") && !isDryRun(i) && inThisDir(i, cwd))
     .flatMap((i) => i.args.filter((a) => !a.startsWith("-")).map(cleanPath));
   const covered = (name: string) => named.some((n) => name === n || name.startsWith(`${n}/`));
-  return names.staged.filter((name) => names.unstaged.includes(name) && !covered(name));
+  return names.staged.filter(
+    (name) => names.unstaged.includes(name) && !covered(name) && !DECISION_LOG.test(name),
+  );
 };
 
 const cleanPath = (arg: string): string => arg.replace(/^(\.\/)+/, "").replace(/\/+$/, "");