@jwilger/pi-development-system 0.27.1 → 0.29.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.27.1",
+  "version": "0.29.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/prompts/devsys-review.md

@@ -4,7 +4,7 @@ argument-hint: "[slice] [diffRange]"
 ---
 Review the work in progress with the code-review skill.
 
-1. Call `devsys_review_start` (slice and diff range: $ARGUMENTS; omit either to use the active slice and `HEAD`).
+1. Call `devsys_review_start` (slice and diff range: $ARGUMENTS; omit either to use the active slice and `HEAD`; only the `HEAD` range clears the commit gate).
 2. Run the `agent_spawn` payload it returns, unchanged.
 3. Pass the reviewer's packet verbatim to `devsys_review_record` with the same `diffDigest` and `diffRange` the start reply gave.
 4. Report `review: N/R clean` and the next action. If the next action is `fix-findings`, list each blocking and should-fix finding with its `path:line`.

package/skills/code-review/SKILL.md

@@ -12,7 +12,8 @@ Review is a soft gate (`review.unsatisfied`): skipping it needs a recorded depar
 ## Run a round
 
 1. `devsys_review_start` (slice defaults to the active slice; `diffRange` defaults
-   to `HEAD`: everything uncommitted, untracked files included). It computes the
+   to `HEAD`: everything uncommitted, untracked files included; the commit gate
+   checks that range, so use it for a review meant to clear a commit). It computes the
    diff digest, lets Jev choose lenses, and returns an exact `agent_spawn` payload.
 2. Run that `agent_spawn` unchanged. The reviewer is a top-level agent, not a
    child of this conversation, so it does not inherit your context.

package/src/core/review-flow.ts

@@ -30,11 +30,16 @@ export type DiffNow = {
   readonly files?: Readonly<Record<string, string>>;
 };
 
+// The departure log is the system's own record (devsys_record_departure writes it), not work under review.
+const DECISION_LOG = /^docs\/decisions\/\d{4}-\d{2}\.md$/;
+
 /** Every file in the current diff was in the last round's diff, byte for byte: a part of what was reviewed. */
 const coveredByLastRound = (review: ReviewState, now: DiffNow): boolean => {
   const reviewed = review.rounds.at(-1)?.files;
   if (reviewed === undefined || now.files === undefined) return false;
-  return Object.entries(now.files).every(([path, digest]) => reviewed[path] === digest);
+  return Object.entries(now.files).every(
+    ([path, digest]) => reviewed[path] === digest || DECISION_LOG.test(path),
+  );
 };
 
 export function reviewGap(state: DevsysState, slice: SliceRef, now: DiffNow): string | undefined {
@@ -73,10 +78,13 @@ export function splitDiffByFile(diff: string): Record<string, string> {
   // git ends its output with a newline: drop it so the last section digests like any other.
   for (const line of diff.replace(/\n$/, "").split("\n")) {
     // Git quotes unusual paths ("b/na\303\257ve.md"); strip the quotes rather than lose the section.
-    const header = /^diff --git "?a\/.*?"? "?b\/(.*?)"?$/.exec(line);
-    if (header !== null) {
+    // Without renames both sides are the same path, which pins a path that contains " b/".
+    const header =
+      /^diff --git ("?)a\/(.*)\1 \1b\/\2\1$/.exec(line)?.[2] ??
+      /^diff --git "?a\/.*?"? "?b\/(.*?)"?$/.exec(line)?.[1];
+    if (header !== undefined) {
       flush();
-      path = unquote(header[1] ?? line);
+      path = unquote(header);
       lines = [];
     }
     lines.push(line);

package/src/review/review-tools.ts

@@ -38,6 +38,9 @@ export type ReviewToolDeps = {
   now?: () => Date;
 };
 
+const GATE_RANGE_NOTE =
+  "Note: the commit gate checks the uncommitted diff (range HEAD). A review of another range does not clear it; review the default range before committing.";
+
 const reply = (payload: string, isError = false) => ({
   content: [{ type: "text" as const, text: payload }],
   details: undefined,
@@ -123,7 +126,7 @@ export function createReviewStartTool(
       const action = nextAction(review, snap.value.digest);
       if (action === "done") {
         return reply(
-          `${reviewLabel(review)}. Review of ${slice} is already satisfied on this diff; nothing to run.`,
+          `${reviewLabel(review)}. Review of ${slice} is already satisfied on this diff; nothing to run.${range === "HEAD" ? "" : ` ${GATE_RANGE_NOTE}`}`,
         );
       }
 
@@ -230,7 +233,8 @@ export function createReviewRecordTool(
       }
       const config = await loadConfig(ctx.cwd);
       if (!config.ok) return reply(`${CONFIG_FILE}: ${config.error.message}`, true);
-      const snap = await snapshotDiff(deps.exec, ctx.cwd, params.diffRange?.trim() || "HEAD");
+      const range = params.diffRange?.trim() || "HEAD";
+      const snap = await snapshotDiff(deps.exec, ctx.cwd, range);
       if (!snap.ok) return reply(`cannot read the diff: ${snap.error}`, true);
 
       if (params.diffDigest !== snap.value.digest) {
@@ -295,6 +299,7 @@ export function createReviewRecordTool(
           reviewLabel(review),
           ...notes,
           `next: ${nextAction(review, reviewed.digest)}`,
+          ...(range === "HEAD" ? [] : [GATE_RANGE_NOTE]),
         ].join("\n"),
       );
     },