@jwilger/pi-development-system 0.26.0 → 0.27.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.26.0",
+  "version": "0.27.1",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/code-review/SKILL.md

@@ -22,7 +22,8 @@ Review is a soft gate (`review.unsatisfied`): skipping it needs a recorded depar
    round in one call). A packet is recorded once, in the round its header names;
    if the diff changed since the start, the round is refused: start again.
 4. Read the reply: `review: N/R clean` and `next:`.
-   - `fix-findings`: fix every blocking and should-fix finding, then start a new round.
+   - `fix-findings`: fix every blocking and should-fix finding, then start a new round
+     (starting again on an unchanged diff is refused).
    - `review`: the streak is short (or the diff changed with findings); start another round.
    - `stale-diff`: the diff changed after a satisfied review; one more round.
    - `done`: commit.
@@ -60,7 +61,9 @@ commit keeps the clean rounds already earned unless findings come back.
 ## Rules of thumb
 
 - Fix the findings before the next round. Do not argue a finding away; if it is
-  wrong, the reviewer marks it a false positive with evidence (Jev can only suggest).
+  wrong, record a `review.unsatisfied` departure with the evidence
+  (`devsys_record_departure`). Starting a round again on an unchanged diff after
+  findings is refused, so a finding is cleared by a fix, never by a re-roll.
 - Do not widen a review into an audit of the tree. The reviewer reads the diff and
   what it depends on.
 - Never edit the packet to make it pass.

package/src/core/review-flow.ts

@@ -70,7 +70,8 @@ export function splitDiffByFile(diff: string): Record<string, string> {
   const flush = () => {
     if (path !== undefined) out[path] = lines.join("\n");
   };
-  for (const line of diff.split("\n")) {
+  // git ends its output with a newline: drop it so the last section digests like any other.
+  for (const line of diff.replace(/\n$/, "").split("\n")) {
     // Git quotes unusual paths ("b/na\303\257ve.md"); strip the quotes rather than lose the section.
     const header = /^diff --git "?a\/.*?"? "?b\/(.*?)"?$/.exec(line);
     if (header !== null) {
@@ -156,7 +157,7 @@ export function reviewerTask(input: {
   const lenses = input.lenses.join(", ");
   return [
     `Review slice ${input.slice}, round ${input.round}, through these lenses: ${lenses}.`,
-    `See the change with \`git diff ${input.diffRange}\` (and \`git diff --stat ${input.diffRange}\`), plus any untracked files listed by \`git status --short\` (git diff does not show them; read them directly). Read the callers, callees and tests it depends on, no more.`,
+    `See the change with \`git diff ${input.diffRange}\` (and \`git diff --stat ${input.diffRange}\`), plus any untracked files listed by \`git ls-files --others --exclude-standard\` (git diff does not show them; read them directly). Read the callers, callees and tests it depends on, no more.`,
     "Do not modify files; report demonstrable defects with a realistic trigger and the smallest local repair.",
     "Return exactly the review packet from your instructions, with exactly this header (slice and round must not change):",
     "",

package/src/review/digest.ts

@@ -46,6 +46,8 @@ export async function snapshotDiff(
       // can hide an edit whose converted text is unchanged.
       "--submodule=short",
       "--no-textconv",
+      // diff.ignoreSubmodules=all would hide a bump that `git add` still stages.
+      "--ignore-submodules=dirty",
     ];
     const [diff, stat, others] = await Promise.all([
       exec("git", [...plain, "--full-index", "--no-renames", range], { cwd, timeout: 15_000 }),