@jwilger/pi-development-system 0.24.0 → 0.26.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.24.0",
+  "version": "0.26.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/prompts/devsys-review.md

@@ -6,5 +6,5 @@ Review the work in progress with the code-review skill.
 
 1. Call `devsys_review_start` (slice and diff range: $ARGUMENTS; omit either to use the active slice and `HEAD`).
 2. Run the `agent_spawn` payload it returns, unchanged.
-3. Pass the reviewer's packet verbatim to `devsys_review_record`.
+3. Pass the reviewer's packet verbatim to `devsys_review_record` with the same `diffDigest` and `diffRange` the start reply gave.
 4. Report `review: N/R clean` and the next action. If the next action is `fix-findings`, list each blocking and should-fix finding with its `path:line`.

package/skills/code-review/SKILL.md

@@ -17,7 +17,8 @@ Review is a soft gate (`review.unsatisfied`): skipping it needs a recorded depar
 2. Run that `agent_spawn` unchanged. The reviewer is a top-level agent, not a
    child of this conversation, so it does not inherit your context.
 3. Pass the reviewer's packet, verbatim, to `devsys_review_record` with the
-   `diffDigest` the start reply gave (`packets: [...]`; all lens packets of one
+   `diffDigest` the start reply gave, and the same `diffRange` if you gave one
+   (`packets: [...]`; all lens packets of one
    round in one call). A packet is recorded once, in the round its header names;
    if the diff changed since the start, the round is refused: start again.
 4. Read the reply: `review: N/R clean` and `next:`.
@@ -59,7 +60,7 @@ commit keeps the clean rounds already earned unless findings come back.
 ## Rules of thumb
 
 - Fix the findings before the next round. Do not argue a finding away; if it is
-  wrong, the reviewer or Jev marks it a false positive with evidence.
+  wrong, the reviewer marks it a false positive with evidence (Jev can only suggest).
 - Do not widen a review into an audit of the tree. The reviewer reads the diff and
   what it depends on.
 - Never edit the packet to make it pass.

package/src/context/status.ts

@@ -14,7 +14,9 @@ const ciLabel = (state: DevsysState): string | undefined => {
 };
 
 const activeReview = (state: DevsysState): string | undefined => {
-  const review = state.activeSlice === undefined ? undefined : reviewOf(state, state.activeSlice);
+  // Without an active slice (before /devsys-start exists) show the most recent review instead of nothing.
+  const review =
+    state.activeSlice === undefined ? state.reviews?.at(-1) : reviewOf(state, state.activeSlice);
   return review === undefined ? undefined : reviewLabel(review);
 };
 

package/src/review/digest.ts

@@ -33,7 +33,20 @@ export async function snapshotDiff(
   try {
     // Plain, parseable output whatever the user's git config says: an external diff driver or
     // forced colour removes the `diff --git` headers the per-file digests are cut from.
-    const plain = ["-c", "core.quotePath=false", "diff", "--no-ext-diff", "--no-color"];
+    const plain = [
+      "-c",
+      "core.quotePath=false",
+      "diff",
+      "--no-ext-diff",
+      "--no-color",
+      // diff.mnemonicPrefix / diff.noprefix change the `a/` `b/` header prefixes the file keys are cut from.
+      "--src-prefix=a/",
+      "--dst-prefix=b/",
+      // Every changed path gets a `diff --git` section: no submodule log summaries, no textconv that
+      // can hide an edit whose converted text is unchanged.
+      "--submodule=short",
+      "--no-textconv",
+    ];
     const [diff, stat, others] = await Promise.all([
       exec("git", [...plain, "--full-index", "--no-renames", range], { cwd, timeout: 15_000 }),
       exec("git", [...plain, "--stat", range], { cwd, timeout: 15_000 }),

package/src/review/review-tools.ts

@@ -127,6 +127,14 @@ export function createReviewStartTool(
         );
       }
 
+      if (action === "fix-findings") {
+        return reply(
+          `${reviewLabel(review)}. Round ${review.rounds.length} of ${slice} has blocking or should-fix findings and the diff has not changed since: fix them first, then start again. ` +
+            "Re-running the review on unchanged code does not clear a finding. If a finding is wrong, record a `review.unsatisfied` departure with the evidence (devsys_record_departure).",
+          true,
+        );
+      }
+
       const round = review.rounds.length + 1;
       const resolved = resolveSlot(
         config.value.models,
@@ -146,7 +154,7 @@ export function createReviewStartTool(
         [
           `${reviewLabel(review)}; round ${round}; diff ${snap.value.digest}. ${basis}`,
           `lenses: ${lenses.join(", ")}`,
-          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with diffDigest "${snap.value.digest}":`,
+          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with diffDigest "${snap.value.digest}"${range === "HEAD" ? "" : ` and diffRange "${range}"`}:`,
           JSON.stringify(spawn),
         ].join("\n"),
       );