@jwilger/pi-development-system 0.23.0 → 0.25.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.23.0",
+  "version": "0.25.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/prompts/devsys-review.md

@@ -6,5 +6,5 @@ Review the work in progress with the code-review skill.
 
 1. Call `devsys_review_start` (slice and diff range: $ARGUMENTS; omit either to use the active slice and `HEAD`).
 2. Run the `agent_spawn` payload it returns, unchanged.
-3. Pass the reviewer's packet verbatim to `devsys_review_record`.
+3. Pass the reviewer's packet verbatim to `devsys_review_record` with the same `diffDigest` and `diffRange` the start reply gave.
 4. Report `review: N/R clean` and the next action. If the next action is `fix-findings`, list each blocking and should-fix finding with its `path:line`.

package/skills/code-review/SKILL.md

@@ -17,7 +17,8 @@ Review is a soft gate (`review.unsatisfied`): skipping it needs a recorded depar
 2. Run that `agent_spawn` unchanged. The reviewer is a top-level agent, not a
    child of this conversation, so it does not inherit your context.
 3. Pass the reviewer's packet, verbatim, to `devsys_review_record` with the
-   `diffDigest` the start reply gave (`packets: [...]`; all lens packets of one
+   `diffDigest` the start reply gave, and the same `diffRange` if you gave one
+   (`packets: [...]`; all lens packets of one
    round in one call). A packet is recorded once, in the round its header names;
    if the diff changed since the start, the round is refused: start again.
 4. Read the reply: `review: N/R clean` and `next:`.
@@ -59,7 +60,7 @@ commit keeps the clean rounds already earned unless findings come back.
 ## Rules of thumb
 
 - Fix the findings before the next round. Do not argue a finding away; if it is
-  wrong, the reviewer or Jev marks it a false positive with evidence.
+  wrong, the reviewer marks it a false positive with evidence (Jev can only suggest).
 - Do not widen a review into an audit of the tree. The reviewer reads the diff and
   what it depends on.
 - Never edit the packet to make it pass.

package/src/gates/commit-guard.ts

@@ -146,7 +146,7 @@ async function reviewNeeds(
       },
     ];
   }
-  const stale = stagedThenEdited(names, command);
+  const stale = stagedThenEdited(names, command, ctx.cwd);
   return stale.length === 0
     ? []
     : [
@@ -157,21 +157,35 @@ async function reviewNeeds(
       ];
 }
 
+type Invocations = ReturnType<typeof resolveGit>["invocations"];
+
 /** Files staged and also changed since staging; empty when the commit stages everything itself. */
 const stagedThenEdited = (
   names: { staged: readonly string[]; unstaged: readonly string[] },
   command: string,
+  cwd: string,
 ): string[] => {
-  const invocations = resolveGit(command).invocations;
-  if (stagesAllTracked(invocations)) return [];
-  // A path that is an argument of the commit or add itself is committed (or re-staged) from the work tree,
-  // which was reviewed. Message text is one argument and never equals a path.
-  const named = new Set(
-    invocations.filter((i) => i.sub === "commit" || i.sub === "add").flatMap((i) => i.args),
-  );
-  return names.staged.filter((name) => names.unstaged.includes(name) && !named.has(name));
+  // Only what runs before or at the first commit can change what that commit records.
+  const all = resolveGit(command).invocations;
+  const firstCommit = all.findIndex((i) => i.sub === "commit");
+  const upto = firstCommit === -1 ? all : all.slice(0, firstCommit + 1);
+  if (stagesAllTracked(upto, cwd)) return [];
+  // A path (or a directory holding it) that is an argument of the commit or add itself is committed or
+  // re-staged from the work tree, which was reviewed. Message text is one argument and never equals a path.
+  const named = upto
+    .filter((i) => (i.sub === "commit" || i.sub === "add") && !isDryRun(i) && inThisDir(i, cwd))
+    .flatMap((i) => i.args.filter((a) => !a.startsWith("-")).map(cleanPath));
+  const covered = (name: string) => named.some((n) => name === n || name.startsWith(`${n}/`));
+  return names.staged.filter((name) => names.unstaged.includes(name) && !covered(name));
 };
 
+const cleanPath = (arg: string): string => arg.replace(/^(\.\/)+/, "").replace(/\/+$/, "");
+const isDryRun = (i: Invocations[number]): boolean =>
+  i.sub === "add" && i.args.some((a) => a === "-n" || a === "--dry-run");
+/** The invocation runs in the session's directory (no `cd`/`-C`, or one that leads back to it). */
+const inThisDir = (i: Invocations[number], cwd: string): boolean =>
+  i.dir === undefined || resolve(cwd, i.dir) === resolve(cwd);
+
 const STAGE_ALL = new Set(["-A", "--all", "-u", "--update", "."]);
 const BOOLEAN_SHORT = /[enqsvz]/;
 
@@ -187,15 +201,13 @@ function clusterHasA(arg: string): boolean {
 
 /**
  * The command re-stages every tracked change of this repository before it commits: `commit -a`, or
- * `git add -A|-u|.` with no pathspec, in the same directory, ahead of the commit. Read from parsed
- * invocations, not message text.
+ * `git add -A|-u|.` with no pathspec, in this directory. Read from parsed invocations, not message text.
  */
-function stagesAllTracked(invocations: ReturnType<typeof resolveGit>["invocations"]): boolean {
-  const firstCommit = invocations.findIndex((i) => i.sub === "commit");
-  return invocations.some((i, index) => {
-    if (i.dir !== undefined) return false;
+function stagesAllTracked(invocations: Invocations, cwd: string): boolean {
+  return invocations.some((i) => {
+    if (!inThisDir(i, cwd) || isDryRun(i)) return false;
     if (i.sub === "commit") return i.args.some((a) => a === "--all" || clusterHasA(a));
-    if (i.sub !== "add" || (firstCommit !== -1 && index > firstCommit)) return false;
+    if (i.sub !== "add") return false;
     const paths = i.args.filter((a) => !a.startsWith("-"));
     return i.args.some((a) => STAGE_ALL.has(a)) && paths.every((a) => a === ".");
   });

package/src/review/digest.ts

@@ -33,7 +33,16 @@ export async function snapshotDiff(
   try {
     // Plain, parseable output whatever the user's git config says: an external diff driver or
     // forced colour removes the `diff --git` headers the per-file digests are cut from.
-    const plain = ["-c", "core.quotePath=false", "diff", "--no-ext-diff", "--no-color"];
+    const plain = [
+      "-c",
+      "core.quotePath=false",
+      "diff",
+      "--no-ext-diff",
+      "--no-color",
+      // diff.mnemonicPrefix / diff.noprefix change the `a/` `b/` header prefixes the file keys are cut from.
+      "--src-prefix=a/",
+      "--dst-prefix=b/",
+    ];
     const [diff, stat, others] = await Promise.all([
       exec("git", [...plain, "--full-index", "--no-renames", range], { cwd, timeout: 15_000 }),
       exec("git", [...plain, "--stat", range], { cwd, timeout: 15_000 }),

package/src/review/review-tools.ts

@@ -146,7 +146,7 @@ export function createReviewStartTool(
         [
           `${reviewLabel(review)}; round ${round}; diff ${snap.value.digest}. ${basis}`,
           `lenses: ${lenses.join(", ")}`,
-          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with diffDigest "${snap.value.digest}":`,
+          `Spawn the reviewer with agent_spawn using exactly this payload, then pass its packet to devsys_review_record with diffDigest "${snap.value.digest}"${range === "HEAD" ? "" : ` and diffRange "${range}"`}:`,
           JSON.stringify(spawn),
         ].join("\n"),
       );