@jwilger/pi-development-system 0.15.0 → 0.17.0

package/agents/advisor.md

@@ -1,6 +1,5 @@
 ---
 name: advisor
-icon: ''
 description: "Read-only decision support for hard design, planning or trade-off questions: returns a recommendation, the alternatives considered, and the cost if the recommendation is wrong. Does not implement."
 thinkingLevel: high
 color: accent

package/agents/implementer.md

@@ -1,6 +1,5 @@
 ---
 name: implementer
-icon: ''
 description: "Implements exactly one task record test-first: failing test, minimal code, passing run, then reports Run/Expected evidence. Edits only the files the task names; stops and reports when the task is unclear or needs a decision."
 thinkingLevel: medium
 color: success

package/agents/lens-cagan.md

@@ -1,6 +1,5 @@
 ---
 name: lens-cagan
-icon: ''
 description: "Read-only product risk lens: value, usability, feasibility and viability risks; outcome versus output; whether the work builds to learn or builds to earn. Reviews planning and product artifacts as Cagan; advisory critique, never customer evidence."
 thinkingLevel: high
 color: accent

package/agents/lens-perri.md

@@ -1,6 +1,5 @@
 ---
 name: lens-perri
-icon: ''
 description: "Read-only anti-feature-factory lens: output versus outcome, roadmap-as-promises, escaping the build trap. Reviews planning and product artifacts as Perri; advisory critique, never customer evidence."
 thinkingLevel: high
 color: accent

package/agents/lens-pichler.md

@@ -1,6 +1,5 @@
 ---
 name: lens-pichler
-icon: ''
 description: "Read-only product-strategy and backlog lens: vision, goal-based roadmap, product-model coherence, decisions with owners. Reviews planning and product artifacts as Pichler; advisory critique, never customer evidence."
 thinkingLevel: high
 color: accent

package/agents/lens-rumelt.md

@@ -1,6 +1,5 @@
 ---
 name: lens-rumelt
-icon: ''
 description: "Read-only strategy-kernel lens: diagnosis, guiding policy, coherent actions; flags fluff, goals-as-strategy and bad strategy. Reviews planning and product artifacts as Rumelt; advisory critique, never customer evidence."
 thinkingLevel: high
 color: accent

package/agents/lens-torres.md

@@ -1,6 +1,5 @@
 ---
 name: lens-torres
-icon: ''
 description: "Read-only continuous-discovery lens: outcome at the root, one opportunity at a time, at least two solutions compared, assumptions made specific and tested. Reviews planning and product artifacts as Torres; advisory critique, never customer evidence."
 thinkingLevel: high
 color: accent

package/agents/reviewer.md

@@ -1,6 +1,5 @@
 ---
 name: reviewer
-icon: ''
 description: Fresh-context, non-mutating review of one slice's diff for demonstrable defects, with severity, path:line, and the smallest local repair; emits the devsys review packet. Not for implementing fixes or style quotas.
 thinkingLevel: high
 color: warning

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.15.0",
+  "version": "0.17.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/delegation/SKILL.md

@@ -34,8 +34,8 @@ agent_spawn({path: "/impl-add-flag", type: "implementer", task: "...",
 
 - Jev judges difficulty and risk; the project's `[routing]` table (slots, never
   model ids) decides. Jev offline means `routine/low`.
-- If the result says the slot is unresolvable, spawning without a pin fails the same
-  way (the agent's own `models:` list is the same candidate set). Run `/devsys-models`
+- If the result says the slot is unresolvable, spawning without a pin usually fails the
+  same way (the agent's own `models:` list defaults to the same candidates). Run `/devsys-models`
   to fix the matrix, or pin a model you know works.
 - A pin is an explicit choice: it bypasses `/scoped-models` and the agent's `models:`
   list, so only pin what the route (or you, with a stated reason) selected.

package/src/core/routing.ts

@@ -55,7 +55,7 @@ export function recommendRoute(input: {
   if (!resolved.ok) {
     return {
       ...route,
-      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin will fail the same way, so run /devsys-models to fix the matrix or pin a model you know works.`,
+      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin usually fails the same way (its models: list defaults to the same candidates), so run /devsys-models to fix the matrix or pin a model you know works.`,
     };
   }
   return {

package/src/subagents/VENDORED.md

@@ -39,3 +39,4 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 6. Empty scope (I5 review): `orch/runtime.ts` `availableScopedModels` treats an empty `/scoped-models` as no restriction (pi's meaning) instead of "matches nothing", because every devsys agent declares `models:` and would otherwise be unspawnable by default. Pinned models are also re-applied on resume (`resolveInitialSettings`), since a restored session may hold only inherited history.
+7. Bundled agents outside `src/subagents`: `agents/researcher.md` (devsys `models:` family list) and `agents/reviewer.md` (devsys `models:` list and packet format; description rewritten; upstream `icon` and `modelSuggestions` removed) differ from upstream; `agents/{advisor,implementer,lens-*}.md` are new. The agent file format itself is unchanged.

package/src/subagents/orch/runtime.ts

@@ -153,6 +153,11 @@ export function createDriverFactory(
   getInheritedTools: () => InheritedToolSource = () => ({ tools: [], activeNames: [] }),
 ): DriverFactory & {
   resolveAgentSettings(type: AgentType, parentPath: string): ResolvedAgentSettings;
+  resolveInitialSettings(
+    type: AgentType,
+    parentPath?: string | null,
+    restored?: ReturnType<SessionManager["buildSessionContext"]>,
+  ): { provider?: string; id?: string; thinkingLevel: ThinkingLevel };
 } {
   // Keep resolved settings even after disposal: descendants inherit settings, not the caller's history.
   const resolved = new Map<string, { provider: string; id: string; thinking: ThinkingLevel }>();
@@ -800,5 +805,6 @@ export function createDriverFactory(
       },
     };
   };
-  return Object.assign(createDriver, { resolveAgentSettings });
+  // devsys: resolveInitialSettings is exposed so resume behaviour can be tested directly.
+  return Object.assign(createDriver, { resolveAgentSettings, resolveInitialSettings });
 }

package/src/subagents/types.ts

@@ -69,7 +69,7 @@ export interface ThreadView {
   /** Cumulative output tokens. Live views include the in-progress message. */
   outputTokens?: number;
   /** devsys: per-spawn model/thinkingLevel pin requested through agent_spawn, when any. */
-  pinned?: SpawnOverrides;
+  pinned?: { model?: string; thinkingLevel?: ThinkingLevel };
 }
 export type DriverEvent =
   | { kind: "activity" | "error"; text: string }