@jwilger/pi-development-system 0.14.0 → 0.16.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.14.0",
+  "version": "0.16.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/delegation/SKILL.md

@@ -34,8 +34,8 @@ agent_spawn({path: "/impl-add-flag", type: "implementer", task: "...",
 
 - Jev judges difficulty and risk; the project's `[routing]` table (slots, never
   model ids) decides. Jev offline means `routine/low`.
-- If the result says the slot is unresolvable, spawning without a pin fails the same
-  way (the agent's own `models:` list is the same candidate set). Run `/devsys-models`
+- If the result says the slot is unresolvable, spawning without a pin usually fails the
+  same way (the agent's own `models:` list defaults to the same candidates). Run `/devsys-models`
   to fix the matrix, or pin a model you know works.
 - A pin is an explicit choice: it bypasses `/scoped-models` and the agent's `models:`
   list, so only pin what the route (or you, with a stated reason) selected.

package/src/core/routing.ts

@@ -55,7 +55,7 @@ export function recommendRoute(input: {
   if (!resolved.ok) {
     return {
       ...route,
-      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin will fail the same way, so run /devsys-models to fix the matrix or pin a model you know works.`,
+      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin usually fails the same way (its models: list defaults to the same candidates), so run /devsys-models to fix the matrix or pin a model you know works.`,
     };
   }
   return {

package/src/core/spawn-overrides.ts

@@ -16,7 +16,7 @@ export type Settings = {
   readonly thinkingLevel: ThinkingLevel;
 };
 
-const MODEL_REF = /^[^\s/]+\/\S+$/;
+const MODEL_REF = /^[^\s/*]+\/[^\s*]+$/;
 
 const isLevel = (value: unknown): value is ThinkingLevel =>
   THINKING_LEVELS.some((level) => level === value);
@@ -66,7 +66,7 @@ export type ModelSource = "current" | "preferences" | "restored" | "inherited";
  * thread keeps the model it was already running instead of falling back to the preferences.
  */
 export function modelSource(input: {
-  mode: "use-current" | "pick-first-scoped" | "pick-first";
+  mode: "use-current" | "pick-first-scoped" | "pick-first-available";
   pinned: boolean;
   hasPreferences: boolean;
   hasRestored: boolean;

package/src/subagents/VENDORED.md

@@ -38,3 +38,5 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
+6. Empty scope (I5 review): `orch/runtime.ts` `availableScopedModels` treats an empty `/scoped-models` as no restriction (pi's meaning) instead of "matches nothing", because every devsys agent declares `models:` and would otherwise be unspawnable by default. Pinned models are also re-applied on resume (`resolveInitialSettings`), since a restored session may hold only inherited history.
+7. Bundled agents outside `src/subagents`: `agents/researcher.md` and `agents/reviewer.md` differ from upstream (devsys `models:` family lists; the reviewer's packet format); `agents/{advisor,implementer,lens-*}.md` are new. The agent file format itself is unchanged.

package/src/subagents/orch/runtime.ts

@@ -153,6 +153,11 @@ export function createDriverFactory(
   getInheritedTools: () => InheritedToolSource = () => ({ tools: [], activeNames: [] }),
 ): DriverFactory & {
   resolveAgentSettings(type: AgentType, parentPath: string): ResolvedAgentSettings;
+  resolveInitialSettings(
+    type: AgentType,
+    parentPath?: string | null,
+    restored?: ReturnType<SessionManager["buildSessionContext"]>,
+  ): { provider?: string; id?: string; thinkingLevel: ThinkingLevel };
 } {
   // Keep resolved settings even after disposal: descendants inherit settings, not the caller's history.
   const resolved = new Map<string, { provider: string; id: string; thinking: ThinkingLevel }>();
@@ -165,6 +170,8 @@ export function createDriverFactory(
       .map((model) => ({ model }));
   const availableScopedModels = (scopedModels: readonly ScopedModel[]) => {
     const available = new Set(availableModelCandidates().map(({ model }) => modelIdentity(model)));
+    // devsys: an empty scope means no /scoped-models restriction in pi, not "matches nothing".
+    if (scopedModels.length === 0) return [...availableModelCandidates()];
     return scopedModels.filter(({ model }) => available.has(modelIdentity(model)));
   };
   const selectTypeModelPreference = (
@@ -232,9 +239,12 @@ export function createDriverFactory(
         : undefined;
     const thinkingLevel =
       savedThinking ?? type.thinkingLevel ?? parent?.thinking ?? ctx.thinkingLevel ?? "off";
-    // devsys: a per-spawn pin from agent_spawn wins; restored sessions already persist their choice.
-    if (restored === undefined)
-      return applySpawnOverrides({ provider, id, thinkingLevel }, type.spawnOverrides);
+    // devsys: a per-spawn pin from agent_spawn wins. On resume the thinking level is the saved one,
+    // but the pinned model still applies: the restored session may only hold inherited history.
+    const pins = type.spawnOverrides;
+    if (restored === undefined) return applySpawnOverrides({ provider, id, thinkingLevel }, pins);
+    if (pins?.model !== undefined)
+      return applySpawnOverrides({ provider, id, thinkingLevel }, { model: pins.model });
     return { provider, id, thinkingLevel };
   };
   const resolveAgentSettings = (type: AgentType, parentPath: string): ResolvedAgentSettings => {
@@ -795,5 +805,6 @@ export function createDriverFactory(
       },
     };
   };
-  return Object.assign(createDriver, { resolveAgentSettings });
+  // devsys: resolveInitialSettings is exposed so resume behaviour can be tested directly.
+  return Object.assign(createDriver, { resolveAgentSettings, resolveInitialSettings });
 }

package/src/subagents/types.ts

@@ -69,7 +69,7 @@ export interface ThreadView {
   /** Cumulative output tokens. Live views include the in-progress message. */
   outputTokens?: number;
   /** devsys: per-spawn model/thinkingLevel pin requested through agent_spawn, when any. */
-  pinned?: SpawnOverrides;
+  pinned?: { model?: string; thinkingLevel?: ThinkingLevel };
 }
 export type DriverEvent =
   | { kind: "activity" | "error"; text: string }