@jwilger/pi-development-system 0.13.0 → 0.15.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.13.0",
+  "version": "0.15.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/delegation/SKILL.md

@@ -34,8 +34,11 @@ agent_spawn({path: "/impl-add-flag", type: "implementer", task: "...",
 
 - Jev judges difficulty and risk; the project's `[routing]` table (slots, never
   model ids) decides. Jev offline means `routine/low`.
-- If the result says the slot is unresolvable, omit `model`: the agent type's own
-  preference list applies. Run `/devsys-models` to fix the matrix.
+- If the result says the slot is unresolvable, spawning without a pin fails the same
+  way (the agent's own `models:` list is the same candidate set). Run `/devsys-models`
+  to fix the matrix, or pin a model you know works.
+- A pin is an explicit choice: it bypasses `/scoped-models` and the agent's `models:`
+  list, so only pin what the route (or you, with a stated reason) selected.
 - You may override the route. Say why in your reply; overriding downwards for
   risky work is a judgement call worth a line in the decision log.
 

package/src/core/routing.ts

@@ -55,7 +55,7 @@ export function recommendRoute(input: {
   if (!resolved.ok) {
     return {
       ...route,
-      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); omit \`model\` so the agent type's defaults apply, or run /devsys-models.`,
+      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin will fail the same way, so run /devsys-models to fix the matrix or pin a model you know works.`,
     };
   }
   return {

package/src/core/spawn-overrides.ts

@@ -16,7 +16,7 @@ export type Settings = {
   readonly thinkingLevel: ThinkingLevel;
 };
 
-const MODEL_REF = /^[^\s/]+\/\S+$/;
+const MODEL_REF = /^[^\s/*]+\/[^\s*]+$/;
 
 const isLevel = (value: unknown): value is ThinkingLevel =>
   THINKING_LEVELS.some((level) => level === value);
@@ -57,3 +57,21 @@ export function applySpawnOverrides(
     ...(overrides.thinkingLevel === undefined ? {} : { thinkingLevel: overrides.thinkingLevel }),
   };
 }
+
+export type ModelSource = "current" | "preferences" | "restored" | "inherited";
+
+/**
+ * Where a subagent's starting model comes from. A per-spawn pin disqualifies the type's
+ * preference list (the pin itself is applied afterwards for fresh spawns), so a resumed pinned
+ * thread keeps the model it was already running instead of falling back to the preferences.
+ */
+export function modelSource(input: {
+  mode: "use-current" | "pick-first-scoped" | "pick-first-available";
+  pinned: boolean;
+  hasPreferences: boolean;
+  hasRestored: boolean;
+}): ModelSource {
+  if (input.mode === "use-current") return "current";
+  if (!input.pinned && input.hasPreferences) return "preferences";
+  return input.hasRestored ? "restored" : "inherited";
+}

package/src/jev/questions/route.ts

@@ -56,7 +56,7 @@ export function medianLabel<T extends string>(
     let cumulative = 0;
     for (const level of levels) {
       cumulative += (answer.probabilities[level] ?? 0) / total;
-      if (cumulative >= 0.5) return level;
+      if (cumulative > 0.5) return level;
     }
   }
   return levels.find((level) => level === answer.choice);

package/src/subagents/VENDORED.md

@@ -12,7 +12,7 @@
 1. Every `*.ts` file starts with `// @ts-nocheck`: upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). `biome.json` excludes `src/subagents`. Both are deliberate: the code is verbatim, and reformatting or retyping it would make upstream diffs unreadable.
 2. Relative `.js` import specifiers were rewritten to `.ts` (upstream relies on a TypeScript-aware loader; this repo's tests run under Node's native type stripping).
 3. `prefs/config.ts`: the bundled-agents directory is `../../../agents/` (was `../../agents/`) because the sources moved one level deeper.
-4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` applies them last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned.
+4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` skips the type's preference list when a model is pinned (via `modelSource` in `src/core/spawn-overrides.ts`, so resumed threads keep their model), applies the pin last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned; `ThreadView.pinned` (`types.ts`) is filled in `orch/manager.ts` `view()` so `agent_status` reports the pins. A pin therefore bypasses `/scoped-models`.
 5. Family preferences (I5.3): `prefs/models.ts` `selectPreferredModel` resolves each `models:` entry with `resolveCandidate` from `src/core/models.ts`, so `provider/gpt-*-sol` picks the newest available match; exact ids behave as before.
 
 ## MIT notice
@@ -38,3 +38,4 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
+6. Empty scope (I5 review): `orch/runtime.ts` `availableScopedModels` treats an empty `/scoped-models` as no restriction (pi's meaning) instead of "matches nothing", because every devsys agent declares `models:` and would otherwise be unspawnable by default. Pinned models are also re-applied on resume (`resolveInitialSettings`), since a restored session may hold only inherited history.

package/src/subagents/orch/runtime.ts

@@ -26,7 +26,7 @@ import { selectTools } from "../prefs/config.ts";
 import { TranscriptChannel } from "./transcript.ts";
 import type { InheritedToolSource } from "./inherited-tools.ts";
 import type { ModelSelectionMode, ToolFilteringMode } from "../prefs/settings.ts";
-import { applySpawnOverrides } from "../../core/spawn-overrides.ts";
+import { applySpawnOverrides, modelSource } from "../../core/spawn-overrides.ts";
 import {
   modelIdentity,
   getModelPreferences,
@@ -165,6 +165,8 @@ export function createDriverFactory(
       .map((model) => ({ model }));
   const availableScopedModels = (scopedModels: readonly ScopedModel[]) => {
     const available = new Set(availableModelCandidates().map(({ model }) => modelIdentity(model)));
+    // devsys: an empty scope means no /scoped-models restriction in pi, not "matches nothing".
+    if (scopedModels.length === 0) return [...availableModelCandidates()];
     return scopedModels.filter(({ model }) => available.has(modelIdentity(model)));
   };
   const selectTypeModelPreference = (
@@ -202,13 +204,19 @@ export function createDriverFactory(
     const mode = getModelSelection();
     // devsys: an explicit per-spawn model pin bypasses preference/scope policy (also on resume).
     const pinned = type.spawnOverrides?.model !== undefined;
-    const preferences = mode === "use-current" || pinned ? undefined : getModelPreferences(type);
+    const preferences = pinned ? undefined : getModelPreferences(type);
+    const source = modelSource({
+      mode,
+      pinned,
+      hasPreferences: preferences !== undefined,
+      hasRestored: restored?.model !== undefined,
+    });
     let provider = parent?.provider ?? ctx.model?.provider;
     let id = parent?.id ?? ctx.model?.id;
-    if (mode === "use-current") {
+    if (source === "current") {
       provider = ctx.model?.provider;
       id = ctx.model?.id;
-    } else if (preferences !== undefined) {
+    } else if (source === "preferences") {
       const filtering = mode === "pick-first-scoped";
       const candidates = filtering
         ? availableScopedModels(normalizeScopedModels(ctx.scopedModels))
@@ -216,7 +224,7 @@ export function createDriverFactory(
       ({ provider, id } = parseModelIdentity(
         selectTypeModelPreference(type, candidates, filtering)!,
       ));
-    } else if (restored?.model) {
+    } else if (source === "restored" && restored?.model) {
       provider = restored.model.provider;
       id = restored.model.modelId;
     }
@@ -226,9 +234,12 @@ export function createDriverFactory(
         : undefined;
     const thinkingLevel =
       savedThinking ?? type.thinkingLevel ?? parent?.thinking ?? ctx.thinkingLevel ?? "off";
-    // devsys: a per-spawn pin from agent_spawn wins; restored sessions already persist their choice.
-    if (restored === undefined)
-      return applySpawnOverrides({ provider, id, thinkingLevel }, type.spawnOverrides);
+    // devsys: a per-spawn pin from agent_spawn wins. On resume the thinking level is the saved one,
+    // but the pinned model still applies: the restored session may only hold inherited history.
+    const pins = type.spawnOverrides;
+    if (restored === undefined) return applySpawnOverrides({ provider, id, thinkingLevel }, pins);
+    if (pins?.model !== undefined)
+      return applySpawnOverrides({ provider, id, thinkingLevel }, { model: pins.model });
     return { provider, id, thinkingLevel };
   };
   const resolveAgentSettings = (type: AgentType, parentPath: string): ResolvedAgentSettings => {