@jwilger/pi-development-system 0.12.0 → 0.14.0

package/agents/implementer.md

@@ -32,7 +32,7 @@ You are an implementer. You receive exactly one task record and nothing else: do
 - Touch only the files the task lists. If the task needs another file, a new dependency, or a design choice, call agent_pause naming what you need. Do not invent policy to make something pass.
 - Never weaken, skip or delete a test to get green, and never add a lint suppression without a stated reason.
 - Do not commit, push or run git history commands; the coordinator delivers.
-- Follow the repo's skills and `principles/NON-NEGOTIABLES.md`; they are loaded in your context.
+- You start with no skills or repository rules loaded and no devsys guards running in your session: the rules in this list are the whole contract. If the task conflicts with one, stop and ask.
 
 ## Finish
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.12.0",
+  "version": "0.14.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/delegation/SKILL.md

@@ -28,14 +28,17 @@ implementer and reviewer work. It returns a slot, a thinking level and, when one
 resolves on this machine, a model. Pass them through:
 
 ```text
-agent_spawn({path: "/root/add-flag", type: "implementer", task: "...",
+agent_spawn({path: "/impl-add-flag", type: "implementer", task: "...",
              model: "<from route>", thinkingLevel: "<from route>"})
 ```
 
 - Jev judges difficulty and risk; the project's `[routing]` table (slots, never
   model ids) decides. Jev offline means `routine/low`.
-- If the result says the slot is unresolvable, omit `model`: the agent type's own
-  preference list applies. Run `/devsys-models` to fix the matrix.
+- If the result says the slot is unresolvable, spawning without a pin fails the same
+  way (the agent's own `models:` list is the same candidate set). Run `/devsys-models`
+  to fix the matrix, or pin a model you know works.
+- A pin is an explicit choice: it bypasses `/scoped-models` and the agent's `models:`
+  list, so only pin what the route (or you, with a stated reason) selected.
 - You may override the route. Say why in your reply; overriding downwards for
   risky work is a judgement call worth a line in the decision log.
 
@@ -48,8 +51,10 @@ you deliver after review.
 
 ## The reviewer is always fresh
 
-A reviewer that watched the work being written shares its blind spots. Spawn it
-with `/root/<name>` paths that do not inherit your reasoning, give it the diff
+A reviewer that watched the work being written shares its blind spots. A path
+under `/root/...` inherits your whole conversation, so spawn reviewers and
+implementers at a top-level independent path (one segment, for example
+`/review-1` or `/impl-add-flag`): independent roots start with no history. Give it the diff
 range and the packet format (`agents/reviewer.md`), and never tell it what you
 concluded. Fix every blocking and should-fix finding, then ask for a new round.
 

package/src/core/routing.ts

@@ -55,7 +55,7 @@ export function recommendRoute(input: {
   if (!resolved.ok) {
     return {
       ...route,
-      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); omit \`model\` so the agent type's defaults apply, or run /devsys-models.`,
+      note: `${prefix}No model with credentials resolves slot "${route.slot}" (unresolvable); an agent spawned without a pin will fail the same way, so run /devsys-models to fix the matrix or pin a model you know works.`,
     };
   }
   return {

package/src/core/spawn-overrides.ts

@@ -57,3 +57,21 @@ export function applySpawnOverrides(
     ...(overrides.thinkingLevel === undefined ? {} : { thinkingLevel: overrides.thinkingLevel }),
   };
 }
+
+export type ModelSource = "current" | "preferences" | "restored" | "inherited";
+
+/**
+ * Where a subagent's starting model comes from. A per-spawn pin disqualifies the type's
+ * preference list (the pin itself is applied afterwards for fresh spawns), so a resumed pinned
+ * thread keeps the model it was already running instead of falling back to the preferences.
+ */
+export function modelSource(input: {
+  mode: "use-current" | "pick-first-scoped" | "pick-first";
+  pinned: boolean;
+  hasPreferences: boolean;
+  hasRestored: boolean;
+}): ModelSource {
+  if (input.mode === "use-current") return "current";
+  if (!input.pinned && input.hasPreferences) return "preferences";
+  return input.hasRestored ? "restored" : "inherited";
+}

package/src/jev/questions/route.ts

@@ -56,7 +56,7 @@ export function medianLabel<T extends string>(
     let cumulative = 0;
     for (const level of levels) {
       cumulative += (answer.probabilities[level] ?? 0) / total;
-      if (cumulative >= 0.5) return level;
+      if (cumulative > 0.5) return level;
     }
   }
   return levels.find((level) => level === answer.choice);

package/src/subagents/VENDORED.md

@@ -12,7 +12,7 @@
 1. Every `*.ts` file starts with `// @ts-nocheck`: upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). `biome.json` excludes `src/subagents`. Both are deliberate: the code is verbatim, and reformatting or retyping it would make upstream diffs unreadable.
 2. Relative `.js` import specifiers were rewritten to `.ts` (upstream relies on a TypeScript-aware loader; this repo's tests run under Node's native type stripping).
 3. `prefs/config.ts`: the bundled-agents directory is `../../../agents/` (was `../../agents/`) because the sources moved one level deeper.
-4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` applies them last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned.
+4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` skips the type's preference list when a model is pinned (via `modelSource` in `src/core/spawn-overrides.ts`, so resumed threads keep their model), applies the pin last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned; `ThreadView.pinned` (`types.ts`) is filled in `orch/manager.ts` `view()` so `agent_status` reports the pins. A pin therefore bypasses `/scoped-models`.
 5. Family preferences (I5.3): `prefs/models.ts` `selectPreferredModel` resolves each `models:` entry with `resolveCandidate` from `src/core/models.ts`, so `provider/gpt-*-sol` picks the newest available match; exact ids behave as before.
 
 ## MIT notice

package/src/subagents/orch/manager.ts

@@ -730,6 +730,8 @@ export class ThreadManager {
       ...record.view,
       sessionFile: record.driver ? record.driver.sessionFile : record.view.sessionFile,
     });
+    // devsys: show per-spawn pins so agent_status reports what the thread was told to run on.
+    if (record.definition?.spawnOverrides) view.pinned = { ...record.definition.spawnOverrides };
     if (record.liveInputTokens) view.inputTokens = (view.inputTokens ?? 0) + record.liveInputTokens;
     if (record.liveOutputTokens)
       view.outputTokens = (view.outputTokens ?? 0) + record.liveOutputTokens;

package/src/subagents/orch/runtime.ts

@@ -26,7 +26,7 @@ import { selectTools } from "../prefs/config.ts";
 import { TranscriptChannel } from "./transcript.ts";
 import type { InheritedToolSource } from "./inherited-tools.ts";
 import type { ModelSelectionMode, ToolFilteringMode } from "../prefs/settings.ts";
-import { applySpawnOverrides } from "../../core/spawn-overrides.ts";
+import { applySpawnOverrides, modelSource } from "../../core/spawn-overrides.ts";
 import {
   modelIdentity,
   getModelPreferences,
@@ -200,13 +200,21 @@ export function createDriverFactory(
       ? resolved.get(`${ctx.sessionManager.getSessionId()}:${parentPath}`)
       : undefined;
     const mode = getModelSelection();
-    const preferences = mode === "use-current" ? undefined : getModelPreferences(type);
+    // devsys: an explicit per-spawn model pin bypasses preference/scope policy (also on resume).
+    const pinned = type.spawnOverrides?.model !== undefined;
+    const preferences = pinned ? undefined : getModelPreferences(type);
+    const source = modelSource({
+      mode,
+      pinned,
+      hasPreferences: preferences !== undefined,
+      hasRestored: restored?.model !== undefined,
+    });
     let provider = parent?.provider ?? ctx.model?.provider;
     let id = parent?.id ?? ctx.model?.id;
-    if (mode === "use-current") {
+    if (source === "current") {
       provider = ctx.model?.provider;
       id = ctx.model?.id;
-    } else if (preferences !== undefined) {
+    } else if (source === "preferences") {
       const filtering = mode === "pick-first-scoped";
       const candidates = filtering
         ? availableScopedModels(normalizeScopedModels(ctx.scopedModels))
@@ -214,7 +222,7 @@ export function createDriverFactory(
       ({ provider, id } = parseModelIdentity(
         selectTypeModelPreference(type, candidates, filtering)!,
       ));
-    } else if (restored?.model) {
+    } else if (source === "restored" && restored?.model) {
       provider = restored.model.provider;
       id = restored.model.modelId;
     }

package/src/subagents/types.ts

@@ -68,6 +68,8 @@ export interface ThreadView {
   inputTokens?: number;
   /** Cumulative output tokens. Live views include the in-progress message. */
   outputTokens?: number;
+  /** devsys: per-spawn model/thinkingLevel pin requested through agent_spawn, when any. */
+  pinned?: SpawnOverrides;
 }
 export type DriverEvent =
   | { kind: "activity" | "error"; text: string }