@jwilger/pi-development-system 0.1.0 → 0.1.2

package/extensions/development-system.ts

@@ -10,22 +10,28 @@ const nonNegotiables = readFileSync(
 );
 
 /** Composition root: wires modules, holds no logic. */
-export default function developmentSystem(pi: ExtensionAPI): void {
+export function createDevelopmentSystem(pi: ExtensionAPI) {
   const state = createSessionState(pi);
 
-  const refreshStatus = (ctx: ExtensionContext) => {
-    ctx.ui.setStatus(STATUS_KEY, renderStatusLine(state.get()));
+  let lastCtx: ExtensionContext | undefined;
+
+  const refreshStatus = () => {
+    lastCtx?.ui.setStatus(STATUS_KEY, renderStatusLine(state.get()));
   };
 
-  pi.on("session_start", (_event, ctx) => {
-    state.rebuildFrom(ctx.sessionManager.getBranch().flatMap(toCustomEntry));
-    refreshStatus(ctx);
-  });
+  const rebuild = (ctx: ExtensionContext) => {
+    lastCtx = ctx;
+    state.rebuildFrom(
+      ctx.sessionManager
+        .getBranch()
+        .flatMap((e) => (e.type === "custom" ? [{ customType: e.customType, data: e.data }] : [])),
+    );
+    refreshStatus();
+  };
 
-  pi.on("session_tree", (_event, ctx) => {
-    state.rebuildFrom(ctx.sessionManager.getBranch().flatMap(toCustomEntry));
-    refreshStatus(ctx);
-  });
+  state.onChange(refreshStatus);
+  pi.on("session_start", (_event, ctx) => rebuild(ctx));
+  pi.on("session_tree", (_event, ctx) => rebuild(ctx));
 
   pi.on("before_agent_start", (event) => {
     applyPromptSection(event, state.get(), nonNegotiables);
@@ -37,12 +43,10 @@ export default function developmentSystem(pi: ExtensionAPI): void {
       ctx.ui.notify(renderStatus(state.get()), "info");
     },
   });
+
+  return { state };
 }
 
-function toCustomEntry(entry: unknown): Array<{ customType: string; data: unknown }> {
-  if (typeof entry !== "object" || entry === null) return [];
-  const e = entry as { type?: unknown; customType?: unknown; data?: unknown };
-  return e.type === "custom" && typeof e.customType === "string"
-    ? [{ customType: e.customType, data: e.data }]
-    : [];
+export default function developmentSystem(pi: ExtensionAPI): void {
+  createDevelopmentSystem(pi);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.1.0",
+  "version": "0.1.2",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/principles/NON-NEGOTIABLES.md

@@ -10,7 +10,7 @@ Amend/rebase/reset of pushed refs, `--force*`, deleting shared branches. Because
 ## 2. Never weaken verification to make a gate pass
 Deleting, skipping or loosening tests; suppressing a lint; editing expected values to match output; `--no-verify`. Because a green gate must mean the same thing afterwards. (Changing a test because the *requirement* changed is a recorded departure, not this.)
 
-## 3. Never claim something was verified, run or green when it was not
+## 3. Never claim something was verified, run, or green that was not
 Because the record of evidence is the product. Evidence comes before claims.
 
 ## 4. Never push on a red trunk
@@ -22,8 +22,8 @@ Stop, record, ask. Because a gate you can route around is not a gate.
 ## 6. Never violate repo-local delivery policy
 Delivery mode, protected branches, required reviews. Because the repo, not this tool, owns policy.
 
-## 7. Never let secrets leave the machine unsanitised
-Commits, logs, eval cases, subagent prompts. Because exfiltration is irreversible.
+## 7. Never let secrets leave the machine without sanitisation
+In commits, logs, eval cases, or subagent prompts. Because exfiltration is irreversible.
 
 ## 8. Never commit without a rationale-bearing Conventional Commit, or add AI attribution trailers
 No `Co-Authored-By`, no `Generated-by`. Because the message is the durable why; attribution noise is not.

package/src/core/types.ts

@@ -5,9 +5,7 @@ export type ParseError = { readonly kind: "parse-error"; readonly message: strin
 export const parseError = (message: string): ParseError => ({ kind: "parse-error", message });
 
 export const isParseError = (value: unknown): value is ParseError =>
-  typeof value === "object" &&
-  value !== null &&
-  (value as { kind?: unknown }).kind === "parse-error";
+  typeof value === "object" && value !== null && "kind" in value && value.kind === "parse-error";
 
 export type Tier = "hard" | "soft" | "advisory";
 

package/src/state/session-state.ts

@@ -28,13 +28,37 @@ const JEV: ReadonlyArray<JevStatus> = ["online", "offline", "unknown"];
 const isRecord = (v: unknown): v is Record<string, unknown> =>
   typeof v === "object" && v !== null && !Array.isArray(v);
 
+const isString = (v: unknown): v is string => typeof v === "string";
+
+/** Structural check for a persisted Departure; I1.1's parseDeparture should supersede it. */
+function isDeparture(v: unknown): v is Departure {
+  if (!isRecord(v)) return false;
+  const scope = v["scope"];
+  const scopeOk =
+    isRecord(scope) &&
+    (scope["kind"] === "session" ||
+      (scope["kind"] === "slice" && isString(scope["slice"])) ||
+      (scope["kind"] === "once" && isString(scope["toolCallId"])));
+  return (
+    scopeOk &&
+    ["id", "gate", "default", "chosen", "why", "costIfWrong", "recordedAt"].every((k) =>
+      isString(v[k]),
+    ) &&
+    (v["tier"] === "soft" || v["tier"] === "hard") &&
+    (v["approver"] === "agent" || v["approver"] === "user") &&
+    (v["revisitWhen"] === undefined || isString(v["revisitWhen"]))
+  );
+}
+
 /** Boundary parse for persisted state: the only place state is cast from `unknown`. */
 export function parseDevsysState(input: unknown): DevsysState | ParseError {
   if (!isRecord(input)) return parseError("devsys state must be an object");
   const { phase, sizing, activeSlice, openDepartures, jev, lastPushAt } = input;
   if (!PHASES.includes(phase as Phase)) return parseError(`unknown phase: ${String(phase)}`);
   if (!JEV.includes(jev as JevStatus)) return parseError(`unknown jev status: ${String(jev)}`);
-  if (!Array.isArray(openDepartures)) return parseError("openDepartures must be an array");
+  if (!Array.isArray(openDepartures) || !openDepartures.every(isDeparture)) {
+    return parseError("openDepartures must be an array of valid departures");
+  }
   if (sizing !== undefined && !SIZINGS.includes(sizing as Sizing)) {
     return parseError(`unknown sizing: ${String(sizing)}`);
   }
@@ -47,7 +71,7 @@ export function parseDevsysState(input: unknown): DevsysState | ParseError {
   return {
     phase: phase as Phase,
     jev: jev as JevStatus,
-    openDepartures: openDepartures as Departure[],
+    openDepartures: openDepartures,
     ...(sizing !== undefined ? { sizing: sizing as Sizing } : {}),
     ...(activeSlice !== undefined ? { activeSlice: activeSlice as SliceRef } : {}),
     ...(lastPushAt !== undefined ? { lastPushAt } : {}),
@@ -58,6 +82,8 @@ export type SessionState = {
   get(): DevsysState;
   update(fn: (s: DevsysState) => DevsysState): void;
   rebuildFrom(entries: ReadonlyArray<{ customType: string; data: unknown }>): void;
+  /** Registers a listener run after every update(); returns an unsubscribe function. */
+  onChange(listener: (state: DevsysState) => void): () => void;
 };
 
 /**
@@ -66,11 +92,19 @@ export type SessionState = {
  */
 export function createSessionState(api: ExtensionAPI): SessionState {
   let current: DevsysState = initialState();
+  const listeners = new Set<(state: DevsysState) => void>();
   return {
     get: () => current,
     update(fn) {
       current = fn(current);
       api.appendEntry(STATE_ENTRY_TYPE, current);
+      for (const listener of listeners) listener(current);
+    },
+    onChange(listener) {
+      listeners.add(listener);
+      return () => {
+        listeners.delete(listener);
+      };
     },
     rebuildFrom(entries) {
       let rebuilt: DevsysState = initialState();