@justmpm/firebase-audit 0.5.3 → 0.5.5

package/README.md

@@ -163,20 +163,22 @@ Limites assumidos: Emulator não prova índice (produção exige, ele deixa pass
 - `UNKNOWN` — impossível resolver estaticamente (ex: `where(fieldVar, ...)`)
 - `CONFLICTING` — interno, duas evidências se contradizem (ex: typo `order.delete` vs `orders.delete`)
 
-### 10 checks do V1
+### 9 checks implementados (+ avisos de infra e Storage/AppCheck)
 
 | # | Check | Sev | Conf |
 |---|-------|-----|------|
-| FBA001 | `allow write/create/update/delete: if true` | ERROR | CONFIRMED |
-| FBA002 | `allow read: if true` (pode ser público proposital) | WARNING | CONFIRMED |
-| FBA003 | Admin SDK dentro de boundary Client | ERROR | PROBABLE |
+| FBA001 | `allow write/create/update/delete` público | ERROR | CONFIRMED/PROBABLE |
+| FBA002 | `allow read/get/list` público (pode ser proposital) | WARNING | CONFIRMED/PROBABLE |
+| FBA003 | Admin SDK em arquivo de cliente (+ origem indefinida como INFO) | ERROR/INFO | PROBABLE/UNKNOWN |
 | FBA004 | Permission usada e não declarada | ERROR | CONFIRMED |
-| FBA005 | Claim nas Rules não declarada no contrato (pega typo `admn`) | WARNING | PROBABLE |
-| FBA006 | Query provavelmente exige composto não encontrado | WARNING | PROBABLE |
-| FBA007 | Índice local sem query observada | INFO | NOT_OBSERVED |
-| FBA008 | Rule sem operação observada | INFO | NOT_OBSERVED |
-| FBA009 | Adapter não resolvido | WARNING | UNKNOWN |
-| FBA010 | Query shape dinâmica | INFO | UNKNOWN |
+| FBA009 | Adapter não observado (com hint de portaria tenant) | WARNING/INFO | UNKNOWN/NOT_OBSERVED |
+| FBA010 | Permissão dinâmica (não resolvida estaticamente) | INFO | UNKNOWN |
+| FBA011 | Role referencia permission não declarada | ERROR | CONFIRMED |
+| FBA012 | Rule ampla vs contrato admin-only | WARNING | PROBABLE |
+| FBA013 | Role sem permissions | WARNING | CONFIRMED |
+| AUTH_ANON_ALLOWED | `auth != null` sozinho (anônimo passa) | INFO | PROBABLE |
+| STORAGE_* | Escrita aberta / curinga total / leitura aberta / anônimo (por bloco do match) | ERROR/WARNING/INFO | CONFIRMED/PROBABLE |
+| APPCHECK_* | Carimbo observado / verificação manual (onRequest por rota) | INFO | CONFIRMED/PROBABLE |
 
 Detalhes que quebram se deixar pra depois: `write` = create+update+delete (guardar origem), `OR` nas Rules (`isAdmin() || public==true`), `resource` vs `request.resource`, `collectionGroup` com escopo próprio, `databaseId` nomeado desde o dia 1.
 
@@ -193,12 +195,13 @@ Detalhes que quebram se deixar pra depois: `write` = create+update+delete (guard
 
 ## 2. Escopo
 
-**V1 — scan estático:** Discovery + 10 checks + `firebase-audit scan [--json|--strict]`. Zero-config, valor imediato.
-**V2 — check com contrato:** YAML + `Code ↔ Contract ↔ Rules` (mismatch muito amplo, role sem permissão, etc.).
-**V3 — verify:** gera cenários → roda no Emulator → tabela ALLOW/DENY + coverage.
-**V4 — drift:** local vs implantado (`LOCAL_ONLY / REMOTE_ONLY / MATCHED`).
+**Scan:** Discovery + checks + `firebase-audit scan [--json|--strict]`. Zero-config, valor imediato.
+**Check com contrato:** YAML + `Code ↔ Contract ↔ Rules` (mismatch muito amplo, role sem permissão, etc.).
+**Verify:** gera matriz papel×operação×path → roda no Emulator → cobertura `ruleCoverage` (não substitui scan).
+**Drift:** local vs implantado (`LOCAL_ONLY / REMOTE_ONLY / MATCHED`).
 
-Fora do V1: Storage, Realtime DB, Hosting, App Check, Functions complexas, IAM, Data Connect.
+**Escopo atual:** Firestore Rules + Storage Rules (vitrine vs cofre, por bloco) + AppCheck (carimbo, não autorização) + contrato + índices.
+**Fora de escopo (declarado em `summary.skipped`):** Realtime DB, Hosting, Functions complexas, IAM, Data Connect, isolamento por tenant, bancos/buckets extras além do default.
 
 ---
 

package/dist/{chunk-PWJ4DI24.js → chunk-CHC7ZHUK.js}

@@ -1,9 +1,9 @@
 import {
   scan
-} from "./chunk-4BBFPTOR.js";
+} from "./chunk-ME6WO45S.js";
 import {
   verify
-} from "./chunk-Y4VXWSKX.js";
+} from "./chunk-DIO36A3I.js";
 import {
   drift
 } from "./chunk-XZ32YQQC.js";
@@ -152,7 +152,7 @@ function createMcpServer() {
       try {
         assertCwd(cwd);
         const { resolve } = await import("path");
-        const { model } = await scan(cwd);
+        const { summary: scanSummary, model } = await scan(cwd);
         const res = verify(model, { coverageFile: coverage ? resolve(cwd, coverage) : void 0 });
         const roles = model.authorization.roles.length > 0 ? model.authorization.roles.map((r) => r.name) : ["anonymous", "user", "admin"];
         const truncated = res.cases.length > 50;
@@ -169,8 +169,10 @@ function createMcpServer() {
                   truncated,
                   uncovered: res.uncovered.slice(0, 20),
                   uncoveredTotal: res.uncovered.length,
+                  uncoveredNote: res.uncoveredNote,
                   coveragePct: res.coveragePct,
-                  findings: res.findings
+                  findings: res.findings,
+                  scan: { errors: scanSummary.errors, warnings: scanSummary.warnings, note: "verify n\xE3o substitui scan/check" }
                 },
                 null,
                 2
@@ -201,6 +203,7 @@ function createMcpServer() {
       try {
         const { resolve: resolveP, isAbsolute } = await import("path");
         const base = cwd && cwd.length > 0 ? cwd : process.cwd();
+        assertCwd(base);
         const resPath = (p) => {
           if (p === null || p === void 0) return null;
           return isAbsolute(p) ? p : resolveP(base, p);

package/dist/{chunk-Y4VXWSKX.js → chunk-DIO36A3I.js}

@@ -102,8 +102,9 @@ function verify(model, opts = {}) {
       }
     }
   }
+  const uncoveredNote = "uncovered lista os paths do modelo \u2014 atribui\xE7\xE3o contador\u2192path indispon\xEDvel (s\xF3 coverage 100% esvazia)";
   if (coveragePct === 100) {
-    return { cases, uncovered: [], findings, coveragePct };
+    return { cases, uncovered: [], findings, coveragePct, uncoveredNote };
   }
   const seenPaths = /* @__PURE__ */ new Set();
   for (const rule of model.rules) {
@@ -112,7 +113,7 @@ function verify(model, opts = {}) {
     seenPaths.add(rule.path);
     uncovered.push(rule.path);
   }
-  return { cases, uncovered, findings, coveragePct };
+  return { cases, uncovered, findings, coveragePct, uncoveredNote };
 }
 
 export {

package/dist/{chunk-7EWTBIKJ.js → chunk-FECVBQUO.js}

@@ -162,21 +162,47 @@ function inlineHelpersInCondition(condition, detailed) {
   }
   return out;
 }
+function isSingleCall(condition) {
+  const m = /^([A-Za-z_][A-Za-z0-9_]*)\s*\(/.exec(condition.trim());
+  if (!m) return null;
+  const open = condition.indexOf("(", m[0].length - 1);
+  let depth = 0;
+  let quote = null;
+  for (let i = open; i < condition.length; i++) {
+    const c = condition[i];
+    if (quote) {
+      if (c === quote && condition[i - 1] !== "\\") quote = null;
+      continue;
+    }
+    if (c === '"' || c === "'" || c === "`") {
+      quote = c;
+      continue;
+    }
+    if (c === "(") depth += 1;
+    else if (c === ")") {
+      depth -= 1;
+      if (depth === 0) {
+        const rest = condition.slice(i + 1).replace(/;$/, "").trim();
+        if (rest !== "") return null;
+        return { name: m[1], args: condition.slice(open + 1, i) };
+      }
+    }
+  }
+  return null;
+}
 function resolveHelperCondition(condition, functions) {
-  const t = condition.trim().replace(/;$/, "").trim();
-  const call = /^([A-Za-z_][A-Za-z0-9_]*)\s*\((.*)\)$/.exec(t);
-  if (!call) return condition;
-  const body = functions.get(call[1]);
+  const single = isSingleCall(condition);
+  if (!single) return condition;
+  const body = functions.get(single.name);
   if (body === void 0) return condition;
   return body;
 }
 function resolveHelperConditionDetailed(condition, detailed) {
-  const t = condition.trim().replace(/;$/, "").trim();
-  const call = /^([A-Za-z_][A-Za-z0-9_]*)\s*\((.*)\)$/.exec(t);
-  if (!call) return condition;
-  const fn = detailed.get(call[1]);
+  const single = isSingleCall(condition);
+  if (!single) return condition;
+  const fn = detailed.get(single.name);
   if (!fn) return condition;
-  const args = call[2].length === 0 ? [] : call[2].split(",").map((s) => s.trim());
+  const args = single.args.length === 0 ? [] : single.args.split(",").map((s) => s.trim());
   return inlineHelperArgs(fn.body, fn.params, args);
 }
 function extractRules(rulesFile, relFile) {
@@ -275,7 +301,10 @@ function isPublicCondition(condition) {
     return { isPublic: false, confidence: "CONFIRMED" };
   }
   if (low === "true") return { isPublic: true, confidence: "CONFIRMED" };
-  if (/(^|\|\|)true($|\|\|)/.test(low)) return { isPublic: true, confidence: "PROBABLE" };
+  for (const part of low.split("||")) {
+    const branch = stripOuterParens(part.replace(/return/g, "").replace(/;/g, "").trim());
+    if (branch === "true") return { isPublic: true, confidence: "PROBABLE" };
+  }
   if (low.includes("request.auth==null") || low.includes("request.auth===null")) {
     return { isPublic: true, confidence: "CONFIRMED" };
   }

package/dist/{chunk-4BBFPTOR.js → chunk-ME6WO45S.js}

@@ -9,7 +9,7 @@ import {
   resolveHelperConditionDetailed,
   stripOuterParens,
   stripRuleComments
-} from "./chunk-7EWTBIKJ.js";
+} from "./chunk-FECVBQUO.js";
 
 // src/scan.ts
 import { readFileSync as readFileSync3, existsSync as existsSync3 } from "fs";
@@ -51,18 +51,35 @@ function discover(rootDir) {
   if (firebaseJson) {
     try {
       const raw = JSON.parse(readFileSync(firebaseJson, "utf-8"));
-      if (typeof raw.firestore?.rules === "string") {
-        const p = join(rootDir, raw.firestore.rules);
+      const first = (v) => Array.isArray(v) ? v[0] : v;
+      const fs = first(raw.firestore);
+      const st = first(raw.storage);
+      if (typeof fs?.rules === "string") {
+        const p = join(rootDir, fs.rules);
         if (existsSync(p)) rulesFile = p;
       }
-      if (typeof raw.firestore?.indexes === "string") {
-        const p = join(rootDir, raw.firestore.indexes);
+      if (typeof fs?.indexes === "string") {
+        const p = join(rootDir, fs.indexes);
         if (existsSync(p)) indexesFile = p;
       }
-      if (typeof raw.storage?.rules === "string") {
-        const p = join(rootDir, raw.storage.rules);
+      if (typeof st?.rules === "string") {
+        const p = join(rootDir, st.rules);
         if (existsSync(p)) storageFile = p;
       }
+      const fns = raw.functions;
+      if (typeof fns === "string" && fns.length > 0) {
+        const p = join(rootDir, fns);
+        try {
+          if (statSync(p).isDirectory()) functionsDir = p;
+        } catch {
+        }
+      } else if (fns && typeof fns === "object" && typeof fns.source === "string" && fns.source.length > 0) {
+        const p = join(rootDir, fns.source);
+        try {
+          if (statSync(p).isDirectory()) functionsDir = p;
+        } catch {
+        }
+      }
     } catch {
     }
   }
@@ -105,7 +122,7 @@ function classifyOrigin(file, content) {
   if (content.includes("firebase-admin") || content.includes("firebase-functions")) {
     return "CLIENT";
   }
-  if (rel.includes("src/") || rel.includes("app/") || rel.includes("components/")) {
+  if (hasSeg("src", "app", "components")) {
     return "CLIENT";
   }
   return "UNKNOWN";
@@ -139,7 +156,7 @@ async function enrichWithGraph(rootDir, d) {
     const ai = await import("@justmpm/ai-tool");
     const res = await ai.map({ cwd: rootDir, format: "json" });
     const files = Array.isArray(res.files) ? res.files : [];
-    const code = files.map((f) => String(f.path).replace(/\\/g, "/")).filter((p) => /\.(ts|tsx|js|jsx|mjs|cjs)$/.test(p)).filter((p) => !p.includes("node_modules/") && !/(^|\/)dist\//.test(p)).slice(0, 500);
+    const code = files.map((f) => String(f.path).replace(/\\/g, "/")).filter((p) => /\.(ts|tsx|js|jsx|mjs|cjs)$/.test(p)).filter((p) => !p.includes("node_modules/") && !/(^|\/)(dist|build|\.next|coverage|lib)\//.test(p)).slice(0, 500);
     const { readFileSync: readSync, existsSync: existsSyncFn, statSync: statSync2 } = await import("fs");
     const { join: joinP } = await import("path");
     for (const rel of code) {
@@ -253,7 +270,7 @@ async function runChecks(model, rootDir, opts = {}) {
   const declared = new Set(model.authorization.permissions.map((p) => p.name));
   if (permissionCalls.literals.length === 0 && permissionCalls.dynamic.length === 0) {
     const tenantHint = [...helperDetailed.keys()].find(
-      (n) => /tenant|isMember|isSignedIn|_member/i.test(n)
+      (n) => /tenant|isMember|_member/i.test(n)
     );
     findings.push(
       make(
@@ -367,7 +384,7 @@ async function runChecks(model, rootDir, opts = {}) {
     const condResolved = resolveHelperConditionDetailed(condRaw, helperDetailed);
     const condInlined = inlineHelpersInCondition(condRaw, helperDetailed);
     const cond = condResolved !== condRaw ? condResolved : condInlined !== condRaw ? condInlined : condRaw;
-    const isInvertedAdmin = /admin\s*==\s*false/i.test(cond) || /admin\s*!=\s*true/i.test(cond) || /admin\s*!==\s*true/i.test(cond) || /!\s*request\.auth\.token\.admin\b/i.test(cond) || /!\s*\(\s*request\.auth\.token\.admin\b/i.test(cond) || /!\s*\(\s*.*admin\s*==\s*true/i.test(cond);
+    const isInvertedAdmin = /admin\s*==\s*false/i.test(cond) || /admin\s*!=\s*true/i.test(cond) || /admin\s*!==\s*true/i.test(cond) || /!\s*request\.auth\.token\.admin\b/i.test(cond) || /!\s*\(\s*request\.auth\.token\.admin\b/i.test(cond) || /!\s*\([^()]*admin\s*==\s*true/i.test(cond);
     const normClaim = (c) => c.toLowerCase().replace(/[_-]/g, "");
     const isAdminCall = /\bisadmin\s*\(([^)]*)\)/i.exec(condRaw) ?? /\bisadmin\s*\(([^)]*)\)/i.exec(cond);
     let isAdminBodyHasAdmin = false;
@@ -511,6 +528,22 @@ async function runChecks(model, rootDir, opts = {}) {
           }
         )
       );
+    } else if (origin === "UNKNOWN" && !isTestPath(hit.file)) {
+      findings.push(
+        make(
+          "ADMIN_ORIGIN_UNKNOWN",
+          "INFO",
+          "UNKNOWN",
+          `Admin SDK em arquivo de origem indefinida (${hit.file}). Se for cliente, Rules n\xE3o valem \u2014 revise manualmente.`,
+          `ADMIN_ORIGIN_UNKNOWN:${hit.file}:${hit.line}`,
+          {
+            file: hit.file,
+            line: hit.line,
+            evidence: [ev("admin-import-unknown", hit.text, "UNKNOWN", hit.file, hit.line)],
+            fix: "Mova para functions/, server/ ou scripts/ se for server; se for cliente, troque por Client SDK."
+          }
+        )
+      );
     }
   }
   return findings;
@@ -582,6 +615,10 @@ async function collectAdminImports(rootDir) {
     "import $DEFAULT from '$MODULE'",
     'import * as $NS from "$MODULE"',
     "import * as $NS from '$MODULE'",
+    'export { $$$ITEMS } from "$MODULE"',
+    "export { $$$ITEMS } from '$MODULE'",
+    'export * from "$MODULE"',
+    "export * from '$MODULE'",
     'import "$MODULE"',
     "import '$MODULE'",
     'const $X = require("$MODULE")',
@@ -780,7 +817,7 @@ var RoleNameSchema = z.string().regex(/^[a-z][a-z0-9_-]*$/);
 var AuditYamlSchema = z.strictObject({
   $schema: z.string().optional(),
   authorization: z.strictObject({
-    adapter: z.strictObject({ function: z.string().min(1) }).optional(),
+    adapter: z.strictObject({ function: z.string().min(1) }).nullish(),
     roles: z.record(RoleNameSchema, z.strictObject({ permissions: z.array(PermissionNameSchema) })),
     permissions: z.record(
       PermissionNameSchema,
@@ -788,9 +825,10 @@ var AuditYamlSchema = z.strictObject({
     ),
     claims: z.strictObject({
       enabled: z.boolean(),
-      roleKey: z.string().min(1),
+      // Reservado para o futuro (nenhum check consome ainda): opcional.
+      roleKey: z.string().min(1).optional(),
       samples: z.record(RoleNameSchema, z.record(z.string().min(1), z.json())).optional()
-    }).optional()
+    }).nullish()
   })
 });
 var RESERVED_CLAIM_KEYS = [
@@ -844,11 +882,40 @@ async function scan(rootDir, opts = {}) {
   try {
     if (d.firebaseJson && existsSync3(d.firebaseJson)) {
       const raw = JSON.parse(readFileSync3(d.firebaseJson, "utf-8"));
-      for (const [kind, rel, label] of [
-        ["rules", raw.firestore?.rules, "firestore.rules"],
-        ["indexes", raw.firestore?.indexes, "firestore.indexes"],
-        ["storage-rules", raw.storage?.rules, "storage.rules"]
-      ]) {
+      const asList = (v) => v === void 0 ? [] : Array.isArray(v) ? v : [v];
+      const entries = [];
+      for (const f of asList(raw.firestore)) {
+        entries.push({ kind: "rules", rel: f.rules, label: "firestore.rules" });
+        entries.push({ kind: "indexes", rel: f.indexes, label: "firestore.indexes" });
+      }
+      for (const s of asList(raw.storage)) {
+        entries.push({ kind: "storage-rules", rel: s.rules, label: "storage.rules" });
+      }
+      if (Array.isArray(raw.firestore) && raw.firestore.length > 1) {
+        findings_pre.push({
+          rule: "FIREBASE_JSON_ARRAY",
+          severity: "INFO",
+          confidence: "CONFIRMED",
+          message: `firebase.json com ${raw.firestore.length} databases \u2014 este scan audita s\xF3 o default. Bancos nomeados (databaseId) fora do escopo.`,
+          fingerprint: "FIREBASE_JSON_ARRAY:firestore",
+          evidence: [
+            { id: "ev-config-array-fs", kind: "config-parse", summary: `${raw.firestore.length} databases`, confidence: "CONFIRMED" }
+          ]
+        });
+      }
+      if (Array.isArray(raw.storage) && raw.storage.length > 1) {
+        findings_pre.push({
+          rule: "FIREBASE_JSON_ARRAY",
+          severity: "INFO",
+          confidence: "CONFIRMED",
+          message: `firebase.json com ${raw.storage.length} buckets \u2014 este scan audita s\xF3 o default. Buckets extras fora do escopo.`,
+          fingerprint: "FIREBASE_JSON_ARRAY:storage",
+          evidence: [
+            { id: "ev-config-array-st", kind: "config-parse", summary: `${raw.storage.length} buckets`, confidence: "CONFIRMED" }
+          ]
+        });
+      }
+      for (const [kind, rel, label] of entries.map((e) => [e.kind, e.rel, e.label])) {
         if (typeof rel === "string" && rel.length > 0) {
           if (!existsSync3(join3(rootDir, rel))) {
             findings_pre.push({
@@ -1120,7 +1187,7 @@ async function scan(rootDir, opts = {}) {
               severity: "ERROR",
               confidence: "CONFIRMED",
               message: `Storage com escrita aberta (${where}). Qualquer cliente pode escrever \u2014 cofre aberto, n\xE3o vitrine.`,
-              fingerprint: `STORAGE_PUBLIC_WRITE:${m.matchPath}:${m.target}:${key}`,
+              fingerprint: `STORAGE_PUBLIC_WRITE:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
               file: relStorage,
               line: m.line,
               evidence: [{ id: evId("write"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "CONFIRMED", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
@@ -1135,7 +1202,7 @@ async function scan(rootDir, opts = {}) {
                 severity: "WARNING",
                 confidence: "PROBABLE",
                 message: `Storage com leitura aberta em curinga total (${where}). Vale para tudo \u2014 se a inten\xE7\xE3o era s\xF3 logo, restrinja a /logos/{id}.`,
-                fingerprint: `STORAGE_ALL_PATHS_OPEN:${m.matchPath}:${m.target}:${key}`,
+                fingerprint: `STORAGE_ALL_PATHS_OPEN:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
                 file: relStorage,
                 line: m.line,
                 evidence: [{ id: evId("all"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
@@ -1148,7 +1215,7 @@ async function scan(rootDir, opts = {}) {
                 severity: "INFO",
                 confidence: "PROBABLE",
                 message: enumerates ? `Storage com leitura aberta (${where}). Pode ser vitrine proposital \u2014 mas allow read/list permite enumerar a pasta; para vitrine segura prefira allow get. Confirme que o write segue restrito.` : `Storage com leitura aberta (${where}). Pode ser vitrine proposital (logos) \u2014 confirme que o write segue restrito.`,
-                fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${m.target}:${key}`,
+                fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
                 file: relStorage,
                 line: m.line,
                 evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
@@ -1164,7 +1231,7 @@ async function scan(rootDir, opts = {}) {
             severity: "INFO",
             confidence: "PROBABLE",
             message: `Storage aceita qualquer autenticado incluindo an\xF4nimo (${where}). Exija claim/provider para dados sens\xEDveis.`,
-            fingerprint: `STORAGE_ANON_ALLOWED:${m.matchPath}:${m.target}:${key}`,
+            fingerprint: `STORAGE_ANON_ALLOWED:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
             file: relStorage,
             line: m.line,
             evidence: [{ id: evId("anon"), kind: "anon-allowed", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
@@ -1172,17 +1239,33 @@ async function scan(rootDir, opts = {}) {
           });
           continue;
         }
-        if (!hasAuth && m.condition !== void 0 && (ops.has("read") || ops.has("get") || ops.has("list"))) {
-          findings.push({
-            rule: "STORAGE_PUBLIC_READ",
-            severity: "INFO",
-            confidence: "PROBABLE",
-            message: `Storage com leitura condicionada sem request.auth (${where}). Se a condi\xE7\xE3o for verdadeira para an\xF4nimo, ele l\xEA \u2014 confirme que \xE9 vitrine.`,
-            fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${m.target}:${key}`,
-            file: relStorage,
-            line: m.line,
-            evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target} sem auth`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }]
-          });
+        if (!hasAuth && m.condition !== void 0) {
+          const canWrite = ops.has("write") || ops.has("create") || ops.has("update") || ops.has("delete");
+          const canRead = ops.has("read") || ops.has("get") || ops.has("list");
+          if (canWrite) {
+            findings.push({
+              rule: "STORAGE_PUBLIC_WRITE",
+              severity: "ERROR",
+              confidence: "PROBABLE",
+              message: `Storage com escrita condicionada sem request.auth (${where}). Se a condi\xE7\xE3o for verdadeira para an\xF4nimo, ele escreve \u2014 cofre prov\xE1vel.`,
+              fingerprint: `STORAGE_PUBLIC_WRITE:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
+              file: relStorage,
+              line: m.line,
+              evidence: [{ id: evId("write"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target} sem auth`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
+              fix: "Exigir request.auth (e dono/tenant) em qualquer condi\xE7\xE3o de write."
+            });
+          } else if (canRead) {
+            findings.push({
+              rule: "STORAGE_PUBLIC_READ",
+              severity: "INFO",
+              confidence: "PROBABLE",
+              message: `Storage com leitura condicionada sem request.auth (${where}). Se a condi\xE7\xE3o for verdadeira para an\xF4nimo, ele l\xEA \u2014 confirme que \xE9 vitrine.`,
+              fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${normalizeTarget(m.target)}:${key}`,
+              file: relStorage,
+              line: m.line,
+              evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target} sem auth`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }]
+            });
+          }
         }
       }
     } catch {
@@ -1210,20 +1293,23 @@ async function scan(rootDir, opts = {}) {
         rule: "APPCHECK_ENFORCED",
         severity: "INFO",
         confidence: "CONFIRMED",
-        message: `enforceAppCheck observado (${appcheck.occurrences} ocorr\xEAncia(s) em ${appcheck.files} arquivo(s)). Carimbo do app oficial \u2014 n\xE3o prova quem \xE9 o usu\xE1rio nem o tenant. Autoriza\xE7\xE3o segue nas Rules/guardas.`,
+        message: `enforceAppCheck observado (${appcheck.occurrences} ocorr\xEAncia(s) em ${appcheck.files} arquivo(s), fora de onRequest). Carimbo do app oficial \u2014 n\xE3o prova quem \xE9 o usu\xE1rio nem o tenant. Autoriza\xE7\xE3o segue nas Rules/guardas.`,
         fingerprint: "APPCHECK_ENFORCED",
         evidence: [{ id: "ev-appcheck", kind: "appcheck", summary: `${appcheck.occurrences} ocorr\xEAncias`, confidence: "CONFIRMED" }]
       });
-    } else if (appcheck.manual === 0) {
+    } else if (appcheck.manual === 0 && appcheck.ignoredOnRequest === 0) {
       skipped.push("functions sem enforceAppCheck literal nem verifyToken observado \u2014 AppCheck sem cobertura afirmativa (config via vari\xE1vel conta como n\xE3o observada; onRequest exige verifica\xE7\xE3o manual por rota)");
     }
+    if (appcheck.ignoredOnRequest > 0) {
+      skipped.push(`enforceAppCheck em onRequest ignorado pelo runtime (${appcheck.ignoredOnRequest} ocorr\xEAncia(s)) \u2014 onRequest exige verifyToken por rota`);
+    }
     if (appcheck.limitHit) {
       skipped.push("functions: teto de varredura atingido \u2014 AppCheck parcial neste scan");
     }
   } else {
     skipped.push("functions n\xE3o observadas \u2014 AppCheck fora deste scan");
   }
-  skipped.push("isolamento por tenant (ownerId/tenantId) n\xE3o verificado \u2014 fora dos checks implementados, nunca verde silencioso");
+  skipped.push("isolamento por tenant (ownerId/tenantId) e mismatch de papel n\xE3o-admin fora dos checks \u2014 coberto s\xF3 via verify/Emulator, nunca verde silencioso");
   const modelCheck = ProjectModelSchema.safeParse(model);
   if (!modelCheck.success) {
     findings.push({
@@ -1283,17 +1369,18 @@ async function countAppCheckEnforced(rootDir) {
   try {
     const { readdirSync, readFileSync: readSync, statSync: stat } = await import("fs");
     const { join: joinP } = await import("path");
-    const { stripRuleComments: strip } = await import("./rules-GTGZWN5U.js");
+    const { stripRuleComments: strip } = await import("./rules-W4VUUQM4.js");
     const roots = [joinP(rootDir, "functions")];
     let occurrences = 0;
     const files = /* @__PURE__ */ new Set();
     let manual = 0;
+    let ignoredOnRequest = 0;
     let limitHit = false;
     const stack = [...roots];
     let guard = 0;
     const isTestFile = (p) => {
       const n = p.replace(/\\/g, "/");
-      return /\.test\.[tj]sx?$/.test(n) || /\.spec\.[tj]sx?$/.test(n) || /(^|\/)__tests__\//.test(n);
+      return /\.test\.[tj]sx?$/.test(n) || /\.spec\.[tj]sx?$/.test(n) || /(^|\/)__tests__\//.test(n) || /(^|\/)(test|tests|testing)\//.test(n);
     };
     while (stack.length > 0 && guard < 200) {
       guard += 1;
@@ -1309,8 +1396,11 @@ async function countAppCheckEnforced(rootDir) {
         const name = e.name;
         const abs = joinP(cur, name);
         let isDir = false;
+        let size = 0;
         try {
-          isDir = stat(abs).isDirectory();
+          const st = stat(abs);
+          isDir = st.isDirectory();
+          size = st.size;
         } catch {
           continue;
         }
@@ -1321,12 +1411,25 @@ async function countAppCheckEnforced(rootDir) {
         }
         if (!/\.(ts|js|mjs|cjs|py)$/.test(name)) continue;
         if (isTestFile(abs)) continue;
+        if (size > 100 * 1024) continue;
         try {
-          const text = strip(readSync(abs, "utf-8"));
-          const hits = text.match(/enforceAppCheck\s*:\s*true|enforce_app_check\s*=\s*True/g);
-          if (hits) {
-            occurrences += hits.length;
-            files.add(abs);
+          let text = strip(readSync(abs, "utf-8"));
+          if (name.endsWith(".py")) {
+            text = text.split("\n").map((l) => {
+              const idx = l.indexOf("#");
+              return idx === -1 ? l : l.slice(0, idx);
+            }).join("\n");
+          }
+          for (const em of text.matchAll(/enforceAppCheck\s*:\s*true|enforce_app_check\s*=\s*True/g)) {
+            const before = text.slice(Math.max(0, (em.index ?? 0) - 600), em.index ?? 0);
+            const triggers = [...before.matchAll(/on(Request|Call|request|call)\s*[\(.]/g)].map((t) => t[1].toLowerCase());
+            const last = triggers[triggers.length - 1];
+            if (last === "request") {
+              ignoredOnRequest += 1;
+            } else {
+              occurrences += 1;
+              files.add(abs);
+            }
           }
           const manualHits = text.match(/verifyToken\s*\(|verify_token\s*\(|consumeAppCheckToken|getLimitedUseToken|getAppCheck\s*\(/g);
           if (manualHits) manual += manualHits.length;
@@ -1334,15 +1437,17 @@ async function countAppCheckEnforced(rootDir) {
         }
       }
     }
-    return { occurrences, files: files.size, manual, limitHit };
+    return { occurrences, files: files.size, manual, ignoredOnRequest, limitHit };
   } catch {
-    return { occurrences: 0, files: 0, manual: 0, limitHit: false };
+    return { occurrences: 0, files: 0, manual: 0, ignoredOnRequest: 0, limitHit: false };
   }
 }
 function isOpenStorageCondition(condition) {
   if (condition === void 0) return true;
   const norm = stripOuterParens(condition).toLowerCase().replace(/\s+/g, "");
   if (norm === "" || norm === "true") return true;
+  if (/^!\(.*request\.auth(===|==)null/.test(norm)) return false;
+  if (/^!\(.*request\.auth(!==|!=)null/.test(norm)) return true;
   if (/(^|\|\|)true($|\|\|)/.test(norm)) return true;
   if (norm.includes("request.auth==null") || norm.includes("request.auth===null")) return true;
   return false;
@@ -1353,13 +1458,24 @@ function parseStorageAllows(clean) {
   const matchRe = /match\s+/g;
   let mm;
   while ((mm = matchRe.exec(clean)) !== null) {
-    const lineStart = clean.lastIndexOf("\n", mm.index) + 1;
-    const lineEnd = clean.indexOf("\n", mm.index);
-    const line = clean.slice(lineStart, lineEnd === -1 ? void 0 : lineEnd);
-    const brace = line.lastIndexOf("{");
-    if (brace === -1) continue;
-    const path = line.slice(mm.index - lineStart + 5, brace).trim() || "/(unknown)";
-    const openBrace = lineStart + brace;
+    const from = mm.index + mm[0].length;
+    let openBrace = -1;
+    let scan2 = from;
+    while (scan2 < clean.length) {
+      const b = clean.indexOf("{", scan2);
+      if (b === -1) break;
+      const between = clean.slice(from, b);
+      if (/match\s|allow\s|;/.test(between)) break;
+      const after = clean.slice(b + 1, b + 12).trimStart().replace(/^\n+/, "");
+      const eol = clean.slice(b + 1).match(/^[ \t]*(\n|$)/) !== null;
+      if (/^(allow|match|function|\})/.test(after) || eol) {
+        openBrace = b;
+        break;
+      }
+      scan2 = b + 1;
+    }
+    if (openBrace === -1) continue;
+    const path = clean.slice(from, openBrace).trim() || "/(unknown)";
     let depth = 0;
     let quote = null;
     let end = clean.length;

package/dist/cli.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 import {
   scan
-} from "./chunk-4BBFPTOR.js";
-import "./chunk-7EWTBIKJ.js";
+} from "./chunk-ME6WO45S.js";
+import "./chunk-FECVBQUO.js";
 
 // src/cli.ts
 import { createRequire } from "module";
@@ -46,7 +46,12 @@ Uso: firebase-audit scan [--json] [--strict] [--adapter=fn] [--cwd=path]`);
     console.error(`Valor inv\xE1lido para --strict: ${strictArg} (use --strict, --strict=true ou --strict=false)`);
     process.exit(1);
   }
-  const asJson = args.includes("--json") || args.includes("--json=true");
+  const asJsonArg = getArg("json");
+  const asJson = args.includes("--json") || asJsonArg === "true";
+  if (asJsonArg !== void 0 && asJsonArg !== "true" && asJsonArg !== "false") {
+    console.error(`Valor inv\xE1lido para --json: ${asJsonArg} (use --json, --json=true ou --json=false)`);
+    process.exit(1);
+  }
   const knownFlags = /* @__PURE__ */ new Set(["--json", "--strict", "--help", "-h", "help", "--version", "-v", "--coverage", "--local", "--remote"]);
   for (const a of args.slice(1)) {
     const base = a.includes("=") ? a.slice(0, a.indexOf("=")) : a;
@@ -59,34 +64,42 @@ Uso: firebase-audit scan|check|verify|drift [--json] ...`);
   const adapterArg = getArg("adapter");
   const cwdArg = getArg("cwd");
   if (cwdArg) {
-    const { existsSync: existsCwd } = await import("fs");
+    const { existsSync: existsCwd, statSync: statCwd } = await import("fs");
     const { resolve: resolveCwd } = await import("path");
     const abs = resolveCwd(process.cwd(), cwdArg);
-    if (!existsCwd(abs)) {
-      console.error(`Diret\xF3rio --cwd n\xE3o existe: ${cwdArg}`);
+    let isDir = false;
+    try {
+      isDir = existsCwd(abs) && statCwd(abs).isDirectory();
+    } catch {
+      isDir = false;
+    }
+    if (!isDir) {
+      console.error(`Diret\xF3rio --cwd n\xE3o existe ou n\xE3o \xE9 diret\xF3rio: ${cwdArg}`);
       process.exit(1);
     }
   }
   const { resolve: resolveRoot } = await import("path");
   const rootDir = cwdArg ? resolveRoot(process.cwd(), cwdArg) : process.cwd();
   if (cmd === "verify") {
-    const { scan: scanForVerify } = await import("./scan-LJ3TCHMR.js");
-    const { verify } = await import("./verify-WBVSESHD.js");
+    const { scan: scanForVerify } = await import("./scan-HE5WAMWJ.js");
+    const { verify } = await import("./verify-DECP4IUW.js");
     const { resolve: resolveVerify } = await import("path");
     const coverageArg = getArg("coverage");
     const coveragePath = coverageArg ? resolveVerify(rootDir, coverageArg) : void 0;
-    const { model } = await scanForVerify(rootDir, { adapterFn: adapterArg });
+    const { model, summary: scanSummary } = await scanForVerify(rootDir, { adapterFn: adapterArg });
     const res = verify(model, { coverageFile: coveragePath });
     const roles = model.authorization.roles.length > 0 ? model.authorization.roles.map((r) => r.name) : ["anonymous", "user", "admin"];
     const rolesReduced = model.authorization.roles.length === 0;
+    const scanRef = { errors: scanSummary.errors, warnings: scanSummary.warnings };
     if (asJson) {
-      console.log(JSON.stringify({ roles, rolesReduced, cases: res.cases.slice(0, 50), casesTotal: res.cases.length, truncated: res.cases.length > 50, uncovered: res.uncovered.slice(0, 20), uncoveredTotal: res.uncovered.length, coveragePct: res.coveragePct, findings: res.findings }, null, 2));
+      console.log(JSON.stringify({ roles, rolesReduced, cases: res.cases.slice(0, 50), casesTotal: res.cases.length, truncated: res.cases.length > 50, uncovered: res.uncovered.slice(0, 20), uncoveredTotal: res.uncovered.length, uncoveredNote: res.uncoveredNote, coveragePct: res.coveragePct, findings: res.findings, scan: scanRef }, null, 2));
       return;
     }
     const covStr = res.coveragePct === null ? "sem cobertura observada" : `${res.coveragePct}% de express\xF5es visitadas`;
     const rolesNote = rolesReduced ? "pap\xE9is reduzidos (sem contrato: anonymous/user/admin)" : `${roles.length} pap\xE9is do contrato (${roles.join(", ")})`;
     console.log(`
 FIREBASE AUDIT verify \u2014 ${res.cases.length} casos planejados (${rolesNote}), ${res.uncovered.length} paths sem cobertura (${covStr}).`);
+    console.log(`Scan est\xE1tico junto: ${scanRef.errors} errors, ${scanRef.warnings} warnings \u2014 verify n\xE3o substitui scan/check.`);
     for (const f of res.findings) {
       const icon = f.severity === "ERROR" ? "\u274C" : f.severity === "WARNING" ? "\u26A0" : "\u2139";
       console.log(`
@@ -145,6 +158,9 @@ FIREBASE AUDIT drift \u2014 MATCHED ${counts("MATCHED")}, LOCAL_ONLY ${counts("L
     return;
   }
   const { findings, summary } = await scan(rootDir, { strict, adapterFn: adapterArg });
+  if (!strict && summary.errors > 0) {
+    console.error(`\u26A0 scan encontrou ${summary.errors} ERROR(s) mas sai 0 \u2014 use 'check' no CI para reprovar.`);
+  }
   if (asJson) {
     console.log(JSON.stringify({ summary, findings }, null, 2));
     if (strict && summary.errors > 0) process.exit(2);
@@ -169,7 +185,7 @@ ${icon} ${f.rule} [${f.confidence}]${where}
     if (f.fix) console.log(`   \u2192 ${f.fix}`);
   }
   console.log(`
-SUMMARY: ${summary.errors} errors, ${summary.warnings} warnings, ${summary.infos} infos (${summary.passedChecks}/${summary.totalChecks} checks FBA passaram)`);
+SUMMARY: ${summary.errors} errors, ${summary.warnings} warnings, ${summary.infos} infos (${summary.passedChecks}/${summary.totalChecks} checks FBA passaram${summary.infra.length > 0 ? `, ${summary.infra.length} achado(s) fora dos FBA` : ""})`);
   console.log(`Olhei: ${summary.checked.join(", ")}`);
   console.log(`Pulei: ${summary.skipped.join(" | ") || "nada"}
 `);

package/dist/index.d.ts

@@ -577,9 +577,9 @@ declare const FindingSchema: z.ZodObject<{
 declare const AuditYamlSchema: z.ZodObject<{
     $schema: z.ZodOptional<z.ZodString>;
     authorization: z.ZodObject<{
-        adapter: z.ZodOptional<z.ZodObject<{
+        adapter: z.ZodOptional<z.ZodNullable<z.ZodObject<{
             function: z.ZodString;
-        }, z.core.$strict>>;
+        }, z.core.$strict>>>;
         roles: z.ZodRecord<z.ZodString, z.ZodObject<{
             permissions: z.ZodArray<z.ZodString>;
         }, z.core.$strict>>;
@@ -595,11 +595,11 @@ declare const AuditYamlSchema: z.ZodObject<{
                 write: "write";
             }>;
         }, z.core.$strict>>;
-        claims: z.ZodOptional<z.ZodObject<{
+        claims: z.ZodOptional<z.ZodNullable<z.ZodObject<{
             enabled: z.ZodBoolean;
-            roleKey: z.ZodString;
+            roleKey: z.ZodOptional<z.ZodString>;
             samples: z.ZodOptional<z.ZodRecord<z.ZodString, z.ZodRecord<z.ZodString, z.ZodJSONSchema>>>;
-        }, z.core.$strict>>;
+        }, z.core.$strict>>>;
     }, z.core.$strict>;
 }, z.core.$strict>;
 /** Chaves OIDC/Firebase reservadas — nunca em custom claims (1000 bytes, só acesso). */
@@ -639,7 +639,8 @@ interface DiscoveryResult {
 declare function discover(rootDir: string): DiscoveryResult;
 /** Segmentos de servidor (fail-closed: `api` genérico NÃO é server, ver classifyOrigin). */
 declare const SERVER_HINTS_SEGMENTS: string[];
-/** Heurística CLIENT vs SERVER: caminho manda primeiro (grafo ai-tool preenche listas na Fase 3). */
+/** Heurística CLIENT vs SERVER: caminho manda primeiro (grafo ai-tool preenche listas na Fase 3).
+ * Segmentos ancorados — nunca substring solta (`myapp/` não é `app/`). */
 declare function classifyOrigin(file: string, content: string): "CLIENT" | "SERVER" | "UNKNOWN";
 declare function emptyModel(rootDir: string, d: DiscoveryResult): ProjectModel;
 /**
@@ -806,6 +807,8 @@ interface VerifyResult {
     findings: Finding[];
     /** 0-100 quando o coverage tem visitCount avaliável; null = não observada. */
     coveragePct: number | null;
+    /** Como ler `uncovered`: atribuição por expressão indisponível (só 100% esvazia). */
+    uncoveredNote: string;
 }
 /** Gera matriz role × operação × path a partir do modelo (sem executar nada).
  * Mapeamento: read≡get+list, write≡create+update+delete (mesma semântica do opsFrom).

package/dist/index.js

@@ -1,7 +1,7 @@
 import {
   createMcpServer,
   startMcpServer
-} from "./chunk-PWJ4DI24.js";
+} from "./chunk-CHC7ZHUK.js";
 import {
   AccessOriginSchema,
   AuditYamlSchema,
@@ -33,7 +33,7 @@ import {
   runChecks,
   scan,
   validateClaimSamples
-} from "./chunk-4BBFPTOR.js";
+} from "./chunk-ME6WO45S.js";
 import {
   buildFullPath,
   conditionKeyForFingerprint,
@@ -55,11 +55,11 @@ import {
   resolveHelperConditionDetailed,
   stripOuterParens,
   stripRuleComments
-} from "./chunk-7EWTBIKJ.js";
+} from "./chunk-FECVBQUO.js";
 import {
   planVerify,
   verify
-} from "./chunk-Y4VXWSKX.js";
+} from "./chunk-DIO36A3I.js";
 import {
   drift
 } from "./chunk-XZ32YQQC.js";

package/dist/mcp-cli.js

@@ -1,10 +1,10 @@
 #!/usr/bin/env node
 import {
   startMcpServer
-} from "./chunk-PWJ4DI24.js";
-import "./chunk-4BBFPTOR.js";
-import "./chunk-7EWTBIKJ.js";
-import "./chunk-Y4VXWSKX.js";
+} from "./chunk-CHC7ZHUK.js";
+import "./chunk-ME6WO45S.js";
+import "./chunk-FECVBQUO.js";
+import "./chunk-DIO36A3I.js";
 import "./chunk-XZ32YQQC.js";
 
 // src/mcp-cli.ts

package/dist/mcp.js

@@ -1,10 +1,10 @@
 import {
   createMcpServer,
   startMcpServer
-} from "./chunk-PWJ4DI24.js";
-import "./chunk-4BBFPTOR.js";
-import "./chunk-7EWTBIKJ.js";
-import "./chunk-Y4VXWSKX.js";
+} from "./chunk-CHC7ZHUK.js";
+import "./chunk-ME6WO45S.js";
+import "./chunk-FECVBQUO.js";
+import "./chunk-DIO36A3I.js";
 import "./chunk-XZ32YQQC.js";
 export {
   createMcpServer,

package/dist/{rules-GTGZWN5U.js → rules-W4VUUQM4.js}

@@ -19,7 +19,7 @@ import {
   resolveHelperConditionDetailed,
   stripOuterParens,
   stripRuleComments
-} from "./chunk-7EWTBIKJ.js";
+} from "./chunk-FECVBQUO.js";
 export {
   buildFullPath,
   conditionKeyForFingerprint,

package/dist/scan-HE5WAMWJ.js

@@ -0,0 +1,7 @@
+import {
+  scan
+} from "./chunk-ME6WO45S.js";
+import "./chunk-FECVBQUO.js";
+export {
+  scan
+};

package/dist/{verify-WBVSESHD.js → verify-DECP4IUW.js}

@@ -1,7 +1,7 @@
 import {
   planVerify,
   verify
-} from "./chunk-Y4VXWSKX.js";
+} from "./chunk-DIO36A3I.js";
 export {
   planVerify,
   verify

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@justmpm/firebase-audit",
-  "version": "0.5.3",
+  "version": "0.5.5",
   "description": "Auditor de consistência e segurança para projetos Firebase: código + Rules + índices + contrato vs comportamento. Static-first, nunca inventa certeza.",
   "keywords": [
     "firebase",

package/skill/SKILL.md

@@ -35,4 +35,5 @@ Use `drift` para comparar índices locais vs implantados (MATCHED/LOCAL_ONLY/REM
 ## Limites honestos
 
 - AppCheck: varredura TS/Python por texto (`enforceAppCheck`, `verifyToken` e afins). Config via variável conta como não observada; `onRequest` exige revisão rota a rota.
-- Isolamento por tenant (ownerId/tenantId): fora dos checks — revise manualmente ou no Emulator.
+- Isolamento por tenant (ownerId/tenantId) e mismatch de papel não-admin: fora dos checks — revise manualmente ou no Emulator.
+- `graph: true` é prévia opt-in da biblioteca (nenhum check consome ainda).

package/dist/scan-LJ3TCHMR.js

@@ -1,7 +0,0 @@
-import {
-  scan
-} from "./chunk-4BBFPTOR.js";
-import "./chunk-7EWTBIKJ.js";
-export {
-  scan
-};