@justmpm/firebase-audit 0.5.2 → 0.5.3

package/dist/{chunk-UKEKA2NQ.js → chunk-4BBFPTOR.js}

@@ -844,9 +844,10 @@ async function scan(rootDir, opts = {}) {
   try {
     if (d.firebaseJson && existsSync3(d.firebaseJson)) {
       const raw = JSON.parse(readFileSync3(d.firebaseJson, "utf-8"));
-      for (const [kind, rel] of [
-        ["rules", raw.firestore?.rules],
-        ["indexes", raw.firestore?.indexes]
+      for (const [kind, rel, label] of [
+        ["rules", raw.firestore?.rules, "firestore.rules"],
+        ["indexes", raw.firestore?.indexes, "firestore.indexes"],
+        ["storage-rules", raw.storage?.rules, "storage.rules"]
       ]) {
         if (typeof rel === "string" && rel.length > 0) {
           if (!existsSync3(join3(rootDir, rel))) {
@@ -854,7 +855,7 @@ async function scan(rootDir, opts = {}) {
               rule: "RULES_CONFIG_MISMATCH",
               severity: "WARNING",
               confidence: "CONFIRMED",
-              message: `firebase.json aponta firestore.${kind} para "${rel}" inexistente \u2014 usando default. Corrija o path.`,
+              message: `firebase.json aponta ${label} para "${rel}" inexistente \u2014 usando default. Corrija o path.`,
               fingerprint: `RULES_CONFIG_MISMATCH:${kind}:${rel}`,
               evidence: [
                 { id: `ev-config-${kind}`, kind: "config-mismatch", summary: rel, confidence: "CONFIRMED" }
@@ -1078,8 +1079,21 @@ async function scan(rootDir, opts = {}) {
   }
   const checksFindings = await runChecks(model, rootDir, { adapterFn: opts.adapterFn ?? model.authorization.adapter ?? void 0 });
   const findings = [...findings_pre, ...checksFindings];
-  const checked = ["firestore.rules", "indexes", "contract", "client-code"];
+  const checked = [];
+  if (d.firestoreRulesFile && existsSync3(d.firestoreRulesFile)) checked.push("firestore.rules");
+  if (d.firestoreIndexesFile && existsSync3(d.firestoreIndexesFile)) checked.push("indexes");
+  if (d.auditYamlFile && existsSync3(d.auditYamlFile)) checked.push("contract");
+  checked.push("client-code");
   const skipped = [];
+  if (!d.firestoreRulesFile || !existsSync3(d.firestoreRulesFile)) {
+    skipped.push("firestore.rules n\xE3o observado \u2014 FBA001/FBA002 sem cobertura");
+  }
+  if (!d.firestoreIndexesFile || !existsSync3(d.firestoreIndexesFile)) {
+    skipped.push("firestore.indexes.json n\xE3o observado \u2014 drift de \xEDndices sem base local");
+  }
+  if (!d.auditYamlFile || !existsSync3(d.auditYamlFile)) {
+    skipped.push("firebase-audit.yaml n\xE3o observado \u2014 permiss\xF5es seguem UNKNOWN sem contrato");
+  }
   if (d.storageRulesFile && existsSync3(d.storageRulesFile)) {
     checked.push("storage.rules");
     try {
@@ -1092,48 +1106,83 @@ async function scan(rootDir, opts = {}) {
         return `ev-storage-${prefix}-${evCounter}`;
       };
       for (const m of parseStorageAllows(clean)) {
-        if (!isOpenStorageCondition(m.condition)) continue;
         const ops = expandStorageOps(m.target);
         const key = conditionKeyForFingerprint(m.condition);
-        const wildcard = /\{[^}]*=\*\*\}/.test(m.matchPath) || m.matchPath.toLowerCase().includes("allpaths");
+        const normCond = (m.condition ?? "").toLowerCase().replace(/\s+/g, "");
+        const hasAuth = normCond.includes("request.auth");
+        const bareAuth = (/request\.auth(!==|!=)null/.test(normCond) || /request\.auth\.uid(!==|!=)null/.test(normCond)) && !normCond.includes("request.auth.token") && !normCond.includes("sign_in_provider");
+        const wildcard = /\{\s*\w+\s*=\s*\*\*\s*\}/.test(m.matchPath);
         const where = `${relStorage}:${m.line} (${m.matchPath}, allow ${m.target})`;
-        if (ops.has("write") || ops.has("create") || ops.has("update") || ops.has("delete")) {
-          findings.push({
-            rule: "STORAGE_PUBLIC_WRITE",
-            severity: "ERROR",
-            confidence: "CONFIRMED",
-            message: `Storage com escrita aberta (${where}). Qualquer cliente pode escrever \u2014 cofre aberto, n\xE3o vitrine.`,
-            fingerprint: `STORAGE_PUBLIC_WRITE:${m.matchPath}:${m.target}:${key}`,
-            file: relStorage,
-            line: m.line,
-            evidence: [{ id: evId("write"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "CONFIRMED", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
-            fix: "Exigir request.auth (e dono/tenant) no write. Deixe get aberto s\xF3 em pasta de vitrine como logos/."
-          });
-        } else if (ops.has("read") || ops.has("get") || ops.has("list")) {
-          if (wildcard) {
-            findings.push({
-              rule: "STORAGE_ALL_PATHS_OPEN",
-              severity: "WARNING",
-              confidence: "PROBABLE",
-              message: `Storage com leitura aberta em curinga total (${where}). Vale para tudo \u2014 se a inten\xE7\xE3o era s\xF3 logo, restrinja a /logos/{id}.`,
-              fingerprint: `STORAGE_ALL_PATHS_OPEN:${m.matchPath}:${m.target}:${key}`,
-              file: relStorage,
-              line: m.line,
-              evidence: [{ id: evId("all"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
-              fix: "Troque o curinga total por pastas expl\xEDcitas (ex: /logos/{logoId}) com get: if true e write restrito."
-            });
-          } else {
+        if (isOpenStorageCondition(m.condition)) {
+          if (ops.has("write") || ops.has("create") || ops.has("update") || ops.has("delete")) {
             findings.push({
-              rule: "STORAGE_PUBLIC_READ",
-              severity: "INFO",
-              confidence: "PROBABLE",
-              message: `Storage com leitura aberta (${where}). Pode ser vitrine proposital (logos) \u2014 confirme que o write segue restrito.`,
-              fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${m.target}:${key}`,
+              rule: "STORAGE_PUBLIC_WRITE",
+              severity: "ERROR",
+              confidence: "CONFIRMED",
+              message: `Storage com escrita aberta (${where}). Qualquer cliente pode escrever \u2014 cofre aberto, n\xE3o vitrine.`,
+              fingerprint: `STORAGE_PUBLIC_WRITE:${m.matchPath}:${m.target}:${key}`,
               file: relStorage,
               line: m.line,
-              evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }]
+              evidence: [{ id: evId("write"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "CONFIRMED", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
+              fix: "Exigir request.auth (e dono/tenant) no write. Deixe get aberto s\xF3 em pasta de vitrine como logos/."
             });
+            continue;
           }
+          if (ops.has("read") || ops.has("get") || ops.has("list")) {
+            if (wildcard) {
+              findings.push({
+                rule: "STORAGE_ALL_PATHS_OPEN",
+                severity: "WARNING",
+                confidence: "PROBABLE",
+                message: `Storage com leitura aberta em curinga total (${where}). Vale para tudo \u2014 se a inten\xE7\xE3o era s\xF3 logo, restrinja a /logos/{id}.`,
+                fingerprint: `STORAGE_ALL_PATHS_OPEN:${m.matchPath}:${m.target}:${key}`,
+                file: relStorage,
+                line: m.line,
+                evidence: [{ id: evId("all"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
+                fix: "Troque o curinga total por pastas expl\xEDcitas (ex: /logos/{logoId}) com get: if true e write restrito."
+              });
+            } else {
+              const enumerates = ops.has("read") || ops.has("list");
+              findings.push({
+                rule: "STORAGE_PUBLIC_READ",
+                severity: "INFO",
+                confidence: "PROBABLE",
+                message: enumerates ? `Storage com leitura aberta (${where}). Pode ser vitrine proposital \u2014 mas allow read/list permite enumerar a pasta; para vitrine segura prefira allow get. Confirme que o write segue restrito.` : `Storage com leitura aberta (${where}). Pode ser vitrine proposital (logos) \u2014 confirme que o write segue restrito.`,
+                fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${m.target}:${key}`,
+                file: relStorage,
+                line: m.line,
+                evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
+                fix: enumerates ? "Para vitrine, troque allow read por allow get (sem list) na pasta p\xFAblica." : void 0
+              });
+            }
+            continue;
+          }
+        }
+        if (bareAuth && (ops.has("read") || ops.has("get") || ops.has("list") || ops.has("write") || ops.has("create") || ops.has("update") || ops.has("delete"))) {
+          findings.push({
+            rule: "STORAGE_ANON_ALLOWED",
+            severity: "INFO",
+            confidence: "PROBABLE",
+            message: `Storage aceita qualquer autenticado incluindo an\xF4nimo (${where}). Exija claim/provider para dados sens\xEDveis.`,
+            fingerprint: `STORAGE_ANON_ALLOWED:${m.matchPath}:${m.target}:${key}`,
+            file: relStorage,
+            line: m.line,
+            evidence: [{ id: evId("anon"), kind: "anon-allowed", summary: `${m.matchPath} allow ${m.target}`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }],
+            fix: "Exigir claim (token.admin/role) ou provider diferente de anonymous para dados sens\xEDveis."
+          });
+          continue;
+        }
+        if (!hasAuth && m.condition !== void 0 && (ops.has("read") || ops.has("get") || ops.has("list"))) {
+          findings.push({
+            rule: "STORAGE_PUBLIC_READ",
+            severity: "INFO",
+            confidence: "PROBABLE",
+            message: `Storage com leitura condicionada sem request.auth (${where}). Se a condi\xE7\xE3o for verdadeira para an\xF4nimo, ele l\xEA \u2014 confirme que \xE9 vitrine.`,
+            fingerprint: `STORAGE_PUBLIC_READ:${m.matchPath}:${m.target}:${key}`,
+            file: relStorage,
+            line: m.line,
+            evidence: [{ id: evId("read"), kind: "storage-public", summary: `${m.matchPath} allow ${m.target} sem auth`, confidence: "PROBABLE", location: { file: relStorage, start: { line: m.line, column: 0 } } }]
+          });
         }
       }
     } catch {
@@ -1166,7 +1215,7 @@ async function scan(rootDir, opts = {}) {
         evidence: [{ id: "ev-appcheck", kind: "appcheck", summary: `${appcheck.occurrences} ocorr\xEAncias`, confidence: "CONFIRMED" }]
       });
     } else if (appcheck.manual === 0) {
-      skipped.push("functions sem enforceAppCheck nem verifyToken observado \u2014 AppCheck sem cobertura afirmativa (onRequest exige verifica\xE7\xE3o manual por rota)");
+      skipped.push("functions sem enforceAppCheck literal nem verifyToken observado \u2014 AppCheck sem cobertura afirmativa (config via vari\xE1vel conta como n\xE3o observada; onRequest exige verifica\xE7\xE3o manual por rota)");
     }
     if (appcheck.limitHit) {
       skipped.push("functions: teto de varredura atingido \u2014 AppCheck parcial neste scan");
@@ -1270,16 +1319,16 @@ async function countAppCheckEnforced(rootDir) {
           stack.push(abs);
           continue;
         }
-        if (!/\.(ts|js|mjs|cjs)$/.test(name)) continue;
+        if (!/\.(ts|js|mjs|cjs|py)$/.test(name)) continue;
         if (isTestFile(abs)) continue;
         try {
           const text = strip(readSync(abs, "utf-8"));
-          const hits = text.match(/enforceAppCheck\s*:\s*true/g);
+          const hits = text.match(/enforceAppCheck\s*:\s*true|enforce_app_check\s*=\s*True/g);
           if (hits) {
             occurrences += hits.length;
             files.add(abs);
           }
-          const manualHits = text.match(/verifyToken\s*\(/g);
+          const manualHits = text.match(/verifyToken\s*\(|verify_token\s*\(|consumeAppCheckToken|getLimitedUseToken|getAppCheck\s*\(/g);
           if (manualHits) manual += manualHits.length;
         } catch {
         }

package/dist/{chunk-AXTYJMA7.js → chunk-PWJ4DI24.js}

@@ -1,6 +1,6 @@
 import {
   scan
-} from "./chunk-UKEKA2NQ.js";
+} from "./chunk-4BBFPTOR.js";
 import {
   verify
 } from "./chunk-Y4VXWSKX.js";
@@ -28,6 +28,16 @@ function readPkgText(rel) {
     return null;
   }
 }
+function assertCwd(cwd) {
+  const { existsSync: existsSync2, statSync } = require2("node:fs");
+  let ok = false;
+  try {
+    ok = existsSync2(cwd) && statSync(cwd).isDirectory();
+  } catch {
+    ok = false;
+  }
+  if (!ok) throw new Error(`Diret\xF3rio n\xE3o existe: ${cwd}`);
+}
 var FALLBACK_SKILL = [
   "# firebase-audit-skill (fallback)",
   "",
@@ -79,6 +89,7 @@ function createMcpServer() {
     },
     async ({ cwd, adapter, strict }) => {
       try {
+        assertCwd(cwd);
         const res = await scan(cwd, { adapterFn: adapter, strict });
         return {
           content: [
@@ -108,6 +119,7 @@ function createMcpServer() {
     },
     async ({ cwd, adapter }) => {
       try {
+        assertCwd(cwd);
         const res = await scan(cwd, { adapterFn: adapter, strict: true });
         return {
           content: [
@@ -115,7 +127,8 @@ function createMcpServer() {
               type: "text",
               text: JSON.stringify({ summary: res.summary, findings: res.findings }, null, 2)
             }
-          ]
+          ],
+          isError: res.summary.errors > 0
         };
       } catch (err) {
         return {
@@ -137,6 +150,7 @@ function createMcpServer() {
     },
     async ({ cwd, coverage }) => {
       try {
+        assertCwd(cwd);
         const { resolve } = await import("path");
         const { model } = await scan(cwd);
         const res = verify(model, { coverageFile: coverage ? resolve(cwd, coverage) : void 0 });

package/dist/cli.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   scan
-} from "./chunk-UKEKA2NQ.js";
+} from "./chunk-4BBFPTOR.js";
 import "./chunk-7EWTBIKJ.js";
 
 // src/cli.ts
@@ -32,8 +32,6 @@ Exit codes: 0 ok informativo; 2 quando --strict/check encontra ERROR. scan sozin
 Uso: firebase-audit scan [--json] [--strict] [--adapter=fn] [--cwd=path]`);
     process.exit(1);
   }
-  const strict = args.includes("--strict") || cmd === "check";
-  const asJson = args.includes("--json") || args.includes("--json=true");
   const getArg = (name) => {
     const pref = `--${name}=`;
     const hit = args.find((a) => a.startsWith(pref));
@@ -42,6 +40,13 @@ Uso: firebase-audit scan [--json] [--strict] [--adapter=fn] [--cwd=path]`);
     if (idx !== -1 && args[idx + 1] && !args[idx + 1].startsWith("--")) return args[idx + 1];
     return void 0;
   };
+  const strictArg = getArg("strict");
+  const strict = args.includes("--strict") || strictArg === "true" || cmd === "check";
+  if (strictArg !== void 0 && strictArg !== "true" && strictArg !== "false") {
+    console.error(`Valor inv\xE1lido para --strict: ${strictArg} (use --strict, --strict=true ou --strict=false)`);
+    process.exit(1);
+  }
+  const asJson = args.includes("--json") || args.includes("--json=true");
   const knownFlags = /* @__PURE__ */ new Set(["--json", "--strict", "--help", "-h", "help", "--version", "-v", "--coverage", "--local", "--remote"]);
   for (const a of args.slice(1)) {
     const base = a.includes("=") ? a.slice(0, a.indexOf("=")) : a;
@@ -65,7 +70,7 @@ Uso: firebase-audit scan|check|verify|drift [--json] ...`);
   const { resolve: resolveRoot } = await import("path");
   const rootDir = cwdArg ? resolveRoot(process.cwd(), cwdArg) : process.cwd();
   if (cmd === "verify") {
-    const { scan: scanForVerify } = await import("./scan-OEN65GHM.js");
+    const { scan: scanForVerify } = await import("./scan-LJ3TCHMR.js");
     const { verify } = await import("./verify-WBVSESHD.js");
     const { resolve: resolveVerify } = await import("path");
     const coverageArg = getArg("coverage");

package/dist/index.js

@@ -1,7 +1,7 @@
 import {
   createMcpServer,
   startMcpServer
-} from "./chunk-AXTYJMA7.js";
+} from "./chunk-PWJ4DI24.js";
 import {
   AccessOriginSchema,
   AuditYamlSchema,
@@ -33,7 +33,7 @@ import {
   runChecks,
   scan,
   validateClaimSamples
-} from "./chunk-UKEKA2NQ.js";
+} from "./chunk-4BBFPTOR.js";
 import {
   buildFullPath,
   conditionKeyForFingerprint,

package/dist/mcp-cli.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 import {
   startMcpServer
-} from "./chunk-AXTYJMA7.js";
-import "./chunk-UKEKA2NQ.js";
+} from "./chunk-PWJ4DI24.js";
+import "./chunk-4BBFPTOR.js";
 import "./chunk-7EWTBIKJ.js";
 import "./chunk-Y4VXWSKX.js";
 import "./chunk-XZ32YQQC.js";

package/dist/mcp.js

@@ -1,8 +1,8 @@
 import {
   createMcpServer,
   startMcpServer
-} from "./chunk-AXTYJMA7.js";
-import "./chunk-UKEKA2NQ.js";
+} from "./chunk-PWJ4DI24.js";
+import "./chunk-4BBFPTOR.js";
 import "./chunk-7EWTBIKJ.js";
 import "./chunk-Y4VXWSKX.js";
 import "./chunk-XZ32YQQC.js";

package/dist/{scan-OEN65GHM.js → scan-LJ3TCHMR.js}

@@ -1,6 +1,6 @@
 import {
   scan
-} from "./chunk-UKEKA2NQ.js";
+} from "./chunk-4BBFPTOR.js";
 import "./chunk-7EWTBIKJ.js";
 export {
   scan

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@justmpm/firebase-audit",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Auditor de consistência e segurança para projetos Firebase: código + Rules + índices + contrato vs comportamento. Static-first, nunca inventa certeza.",
   "keywords": [
     "firebase",

package/skill/SKILL.md

@@ -28,5 +28,11 @@ Skill para agentes usarem o `@justmpm/firebase-audit` do jeito certo.
 firebase emulators:exec --only firestore "npm test"
 ```
 
-Matriz `anon/user/admin x read/create/update/delete` com `@firebase/rules-unit-testing`.
+Matriz papel×operação×path (`read` = `get` + `list`) com `@firebase/rules-unit-testing`.
 Cobertura em `ruleCoverage` (JSON). Emulator não prova índice. Sem contrato, papéis reduzidos (anonymous/user/admin).
+Use `drift` para comparar índices locais vs implantados (MATCHED/LOCAL_ONLY/REMOTE_ONLY).
+
+## Limites honestos
+
+- AppCheck: varredura TS/Python por texto (`enforceAppCheck`, `verifyToken` e afins). Config via variável conta como não observada; `onRequest` exige revisão rota a rota.
+- Isolamento por tenant (ownerId/tenantId): fora dos checks — revise manualmente ou no Emulator.