@justeattakeaway/stylelint-config-pie 0.6.0 → 0.7.0

package/{.eslintrc.js → .eslintrc.cjs}

@@ -2,7 +2,6 @@ module.exports = {
     env: {
         browser: true,
         es6: true,
-        jest: true,
         node: true,
     },
     extends: [require.resolve('@justeattakeaway/eslint-config-pie/strict')],

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## 0.7.0
+
+### Minor Changes
+
+- [Changed] - stylelint to latest version 16 ([#1280](https://github.com/justeattakeaway/pie/pull/1280)) by [@raoufswe](https://github.com/raoufswe)
+
+### Patch Changes
+
+- Updated dependencies [[`a3305634e`](https://github.com/justeattakeaway/pie/commit/a3305634e069e32415bc8fb89e03a85a384560ea)]:
+  - @justeattakeaway/stylelint-no-logical-props-shorthands@0.3.0
+
+## 0.6.1
+
+### Patch Changes
+
+- Updated dependencies [[`e3da38b60`](https://github.com/justeattakeaway/pie/commit/e3da38b60c5074da5422115ad16116a7413227f1)]:
+  - @justeattakeaway/stylelint-no-logical-props-shorthands@0.2.0
+
 ## 0.6.0
 
 ### Minor Changes

package/__tests__/rules/base.test.js

@@ -1,5 +1,5 @@
-const stylelint = require('stylelint');
-const baseConfig = require('../../rules/base');
+import stylelint from 'stylelint';
+import baseConfig from '../../rules/base';
 
 describe('base Stylelint rules', () => {
     describe('alpha-value-notation', () => {

package/__tests__/rules/strict.test.js

@@ -1,5 +1,5 @@
-const stylelint = require('stylelint');
-const strictConfig = require('../../rules/strict');
+import stylelint from 'stylelint';
+import strictConfig from '../../rules/strict';
 
 describe('strict Stylelint rules', () => {
     describe('color-named', () => {

package/index.js

@@ -1,7 +1,11 @@
-module.exports = {
+import baseRules from './rules/base';
+import strictRules from './rules/strict';
+import orderingRules from './rules/ordering';
+
+export default {
     extends: [
-        './rules/base.js',
-        './rules/strict.js',
-        './rules/ordering.js'
+        baseRules,
+        strictRules,
+        orderingRules
     ],
 };

package/package.json

@@ -1,8 +1,9 @@
 {
   "name": "@justeattakeaway/stylelint-config-pie",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "Shareable Stylelint config for use with any front-end web projects across JET.",
   "license": "Apache-2.0",
+  "type": "module",
   "keywords": [
     "PIE",
     "stylelint",
@@ -17,22 +18,19 @@
     "./ordering": "./rules/ordering.js"
   },
   "peerDependencies": {
-    "stylelint": "14.x",
-    "stylelint-config-standard-scss": "5.x",
-    "stylelint-order": "5.x"
+    "stylelint": "16.x",
+    "stylelint-config-standard-scss": "13.x",
+    "stylelint-order": "6.x"
   },
   "dependencies": {
-    "@justeattakeaway/stylelint-no-logical-props-shorthands": "0.1.0"
+    "@justeattakeaway/stylelint-no-logical-props-shorthands": "0.3.0"
   },
   "scripts": {
     "lint:scripts": "run -T eslint .",
     "lint:scripts:fix": "run -T eslint . --fix",
-    "test": "run -T jest",
+    "test": "run -T vitest run --config ../../../vite.config.js --environment node",
     "test:ci": "yarn test"
   },
-  "jest": {
-    "testEnvironment": "jsdom"
-  },
   "volta": {
     "extends": "../../../package.json"
   }

package/rules/base.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
     extends: 'stylelint-config-standard-scss',
     plugins: [
         '@justeattakeaway/stylelint-no-logical-props-shorthands',
@@ -14,22 +14,8 @@ module.exports = {
                 ignoreAtRules: ['if', 'else', 'include', 'use', 'forward'],
             }
         ],
-        'at-rule-name-case': 'lower',
-        'at-rule-name-space-after': 'always',
         'at-rule-no-vendor-prefix': true,
-        'block-closing-brace-newline-after': [
-            'always',
-            {
-                ignoreAtRules: ['if', 'else'],
-            }
-        ],
-        'block-closing-brace-newline-before': 'always',
-        'block-closing-brace-space-before': 'always-single-line',
-        'block-opening-brace-newline-after': 'always',
-        'block-opening-brace-space-after': 'always-single-line',
-        'block-opening-brace-space-before': 'always',
         'color-function-notation': 'legacy',
-        'color-hex-case': 'lower',
         'color-hex-length': 'short',
         'color-no-invalid-hex': true,
         'comment-empty-line-before': [
@@ -41,29 +27,21 @@ module.exports = {
         ],
         'comment-whitespace-inside': 'always',
         'custom-property-pattern': '^([a-z][a-z0-9]*)(-[-a-z0-9]+)*$',
-        'declaration-bang-space-after': 'never',
-        'declaration-bang-space-before': 'always',
         'declaration-block-no-duplicate-properties': [
             true, {
                 ignore: ['consecutive-duplicates-with-different-values'],
             }
         ],
-        'declaration-block-no-shorthand-property-overrides': true,
-        'declaration-block-semicolon-newline-after': 'always',
-        'declaration-block-semicolon-newline-before': 'never-multi-line',
-        'declaration-block-semicolon-space-before': 'never',
-        'declaration-block-trailing-semicolon': 'always',
-        'declaration-colon-newline-after': 'always-multi-line',
-        'declaration-colon-space-after': 'always-single-line',
-        'declaration-colon-space-before': 'never',
+        'declaration-block-no-redundant-longhand-properties': [
+            true, {
+                // Excluding margin/padding logical operators to avoid "stylelint-no-logical-props-shorthands" conflict
+                ignoreShorthands: ['/margin-inline/', '/margin-block/', 'padding-inline', 'padding-block'],
+            }
+        ],
         'declaration-empty-line-before': null,
         'font-family-name-quotes': 'always-where-recommended',
         'font-weight-notation': 'numeric',
         'function-calc-no-unspaced-operator': true,
-        'function-comma-newline-after': 'never-multi-line',
-        'function-comma-newline-before': 'never-multi-line',
-        'function-comma-space-after': 'always',
-        'function-comma-space-before': 'never',
         'function-linear-gradient-no-nonstandard-direction': true,
         'function-name-case': [
             'lower',
@@ -71,30 +49,10 @@ module.exports = {
                 ignoreFunctions: ['/zIndex/'],
             }
         ],
-        'function-parentheses-space-inside': 'never',
         'function-url-quotes': 'always',
-        'function-whitespace-after': 'always',
-        indentation: 4,
         'keyframes-name-pattern': '^([a-z0-9]+)(((([A-Z]){1}([a-z0-9]+))?)+)',
         'length-zero-no-unit': true,
-        'max-empty-lines': 2,
-        'max-line-length': [
-            120,
-            {
-                ignore: ['non-comments'],
-                ignorePattern: '/hsl\\(/',
-            }
-        ],
-        'media-feature-colon-space-after': 'always',
-        'media-feature-colon-space-before': 'never',
-        'media-feature-name-case': 'lower',
         'media-feature-name-no-vendor-prefix': true,
-        'media-feature-parentheses-space-inside': 'never',
-        'media-feature-range-operator-space-after': 'always',
-        'media-feature-range-operator-space-before': 'always',
-        'media-query-list-comma-newline-before': null,
-        'media-query-list-comma-space-after': 'always-single-line',
-        'media-query-list-comma-space-before': 'never',
         'no-descending-specificity': [
             true,
             {
@@ -102,12 +60,7 @@ module.exports = {
             }
         ],
         'no-duplicate-selectors': null,
-        'no-eol-whitespace': true,
-        'no-missing-end-of-source-newline': true,
-        'number-leading-zero': 'always',
         'number-max-precision': 3,
-        'number-no-trailing-zeros': true,
-        'property-case': 'lower',
         'property-no-unknown': true,
         // TODO - we need to figure out what exceptions to add to this
         'property-no-vendor-prefix': null,
@@ -127,24 +80,12 @@ module.exports = {
         'scss/dollar-variable-pattern': null,
         'selector-attribute-quotes': 'always',
         'selector-class-pattern': null,
-        'selector-combinator-space-after': 'always',
-        'selector-combinator-space-before': 'always',
-        'selector-descendant-combinator-no-non-space': true,
-        'selector-list-comma-newline-after': 'always',
-        'selector-list-comma-newline-before': 'never-multi-line',
-        'selector-list-comma-space-before': 'never',
-        'selector-max-empty-lines': 0,
         // TODO - Test * > * works
         'selector-max-universal': [1, { ignoreAfterCombinators: ['>'] }],
         'selector-no-vendor-prefix': true,
         'selector-pseudo-element-colon-notation': 'single',
         'selector-type-case': 'lower',
-        'string-quotes': 'single',
         'unit-no-unknown': true,
-        'value-list-comma-newline-after': 'always-multi-line',
-        'value-list-comma-newline-before': 'never-multi-line',
-        'value-list-comma-space-after': 'always-single-line',
-        'value-list-comma-space-before': 'never',
         'value-no-vendor-prefix': true,
     },
 };

package/rules/ordering.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
     plugins: ['stylelint-order'],
     rules: {
         'order/order': [

package/rules/strict.js

@@ -1,8 +1,7 @@
-module.exports = {
+export default {
     rules: {
         'color-named': 'never',
         'max-nesting-depth': 3,
-        'media-query-list-comma-newline-after': 'always-multi-line',
         'selector-max-compound-selectors': 5,
         'selector-max-id': 0,
     },