@justeattakeaway/generator-pie-component 0.22.2 → 0.23.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +3 -36
- package/package.json +2 -1
package/README.md
CHANGED
|
@@ -42,44 +42,11 @@ An interactive prompt should now be displayed asking for a component name.
|
|
|
42
42
|
|
|
43
43
|
Once you have completed all the prompts, your scaffolded component will be generated! 🎉
|
|
44
44
|
|
|
45
|
-
The newly generated `package.json` file will most likely contain references to the local monorepo packages. Please replace its versions with the latest published version:
|
|
46
|
-
|
|
47
|
-
```sh
|
|
48
|
-
cd packages/components/pie-{{COMPONENT_NAME}}
|
|
49
|
-
npx npm-check-updates "@justeattakeaway/*" -u
|
|
50
|
-
```
|
|
51
|
-
|
|
52
|
-
_Note: If this step fails, ensure you have installed the repository dependencies with `yarn`. Otherwise, this (and any other commands) will fail._
|
|
53
|
-
|
|
54
|
-
### Setting up Storybook:
|
|
55
|
-
|
|
56
|
-
- Add the component to the storybook package.json dependencies:
|
|
57
|
-
|
|
58
|
-
```json
|
|
59
|
-
"@justeattakeaway/pie-{{COMPONENT_NAME}}": "0.0.0",
|
|
60
|
-
```
|
|
61
|
-
|
|
62
45
|
### Setting up Visual Regression Testing:
|
|
63
46
|
|
|
64
47
|
- Create a Percy project for the component on the Percy website.
|
|
65
|
-
-
|
|
66
|
-
|
|
67
|
-
```sh
|
|
68
|
-
"test:visual": "run -T cross-env-shell PERCY_TOKEN=${PERCY_TOKEN_PIE_COMPONENT_NAME} percy exec --allowed-hostname cloudfront.net -- npx playwright test -c ./playwright-lit-visual.config.ts",
|
|
69
|
-
```
|
|
70
|
-
|
|
71
|
-
- Add the token environment variable to `github/workflows/ci.yml` as follows:
|
|
72
|
-
|
|
73
|
-
```sh
|
|
74
|
-
PERCY_TOKEN_PIE_COMPONENT_NAME: ${{ secrets.PERCY_TOKEN_PIE_COMPONENT_NAME }}
|
|
75
|
-
```
|
|
76
|
-
|
|
77
|
-
- Now you need to add this token as a repository secret in GitHub. It must be named `PERCY_TOKEN_PIE_COMPONENT_NAME` and the value should be the Percy token for the component. Visual tests will not work/run if this is not set up correctly.
|
|
78
|
-
|
|
79
|
-
### Setting up the project label for GitHub:
|
|
80
|
-
|
|
81
|
-
- Create a label for the component [on GitHub](https://github.com/justeattakeaway/pie/issues/labels).
|
|
82
|
-
- Add the new label to `project-labeler.yml` under the `Component projects` section
|
|
48
|
+
- From the "Project settings" page, copy the project token value.
|
|
49
|
+
- You need to add the new token value as a repository secret in GitHub. It must be named `PERCY_TOKEN_PIE_COMPONENT_NAME`. Visual tests will not work/run if this is not set up correctly.
|
|
83
50
|
|
|
84
51
|
## Local development
|
|
85
52
|
|
|
@@ -107,4 +74,4 @@ In order to contribute to the `generator-pie-component`, it's advised to link yo
|
|
|
107
74
|
|
|
108
75
|
To do this, run `yarn link` from the root of the `generator-pie-component` folder in the mono-repo.
|
|
109
76
|
|
|
110
|
-
Once you have done this, running `yo @justeattakeaway/
|
|
77
|
+
Once you have done this, running `npx yo @justeattakeaway/pie-component` will run your local copy of the generator (rather than the version installed globally via NPM/Yarn).
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@justeattakeaway/generator-pie-component",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.23.0",
|
|
4
4
|
"description": "A generator for PIE Web Components",
|
|
5
5
|
"author": "Just Eat Takeaway.com - Design System Team",
|
|
6
6
|
"files": [
|
|
@@ -22,6 +22,7 @@
|
|
|
22
22
|
],
|
|
23
23
|
"dependencies": {
|
|
24
24
|
"chalk": "5.3.0",
|
|
25
|
+
"yaml": "2.5.1",
|
|
25
26
|
"yeoman-generator": "5.9.0"
|
|
26
27
|
},
|
|
27
28
|
"devDependencies": {
|