@justair/justair-library 7.6.0-alpha.f80fd11 → 7.6.0

package/dist/utils/subscribedDevices.d.ts

@@ -11,9 +11,7 @@ export const VISIBLE_SITE_MONITOR_FILTER: Readonly<{
     isPrivate: Readonly<{
         $ne: true;
     }>;
-    isActive: Readonly<{
-        $ne: false;
-    }>;
+    isActive: true;
 }>;
 export function projectSubscribedMonitors(subscribedDevices?: Array<{
     deviceId: import("mongoose").Types.ObjectId;

package/dist/utils/subscribedDevices.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"subscribedDevices.d.ts","sourceRoot":"","sources":["../../src/utils/subscribedDevices.js"],"names":[],"mappings":"AA0FA;;;;;;;;GASG;AAyCH;;;;;;;GAGG;AA6LI,8DANI,KAAK,CAAC;IAAE,QAAQ,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,CAAC;IAC1D,UAAU,EAAE,OAAO,6BAA6B,EAAE,UAAU,CAAA;CAAE,CAAC,8BACzD;IAAE,qBAAqB,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,KAC7E,OAAO,CAAC,KAAK,CAAC,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,GAAG,IAAI,GAAG,SAAS,CAAC,CAAC,CAAA;CAAE,GAC9D,OAAO,CAAC,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CA0BxD;AAuEM,0DAPI,KAAK,CAAC;IAAE,GAAG,EAAE,GAAG,CAAC;IAAC,iBAAiB,CAAC,EAAE,KAAK,CAAC;QAClD,QAAQ,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,CAAC;QAC5C,UAAU,EAAE,OAAO,6BAA6B,EAAE,UAAU,CAAA;KAAE,CAAC,CAAA;CAAE,CAAC,mCAC5D;IAAE,0BAA0B,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,KAClF,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAA;CAAE,GACnD,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAmErE"}
+{"version":3,"file":"subscribedDevices.d.ts","sourceRoot":"","sources":["../../src/utils/subscribedDevices.js"],"names":[],"mappings":"AA0FA;;;;;;;;GASG;AA+CH;;;;;GAGG;AA6LI,8DANI,KAAK,CAAC;IAAE,QAAQ,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,CAAC;IAC1D,UAAU,EAAE,OAAO,6BAA6B,EAAE,UAAU,CAAA;CAAE,CAAC,8BACzD;IAAE,qBAAqB,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,KAC7E,OAAO,CAAC,KAAK,CAAC,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,GAAG,IAAI,GAAG,SAAS,CAAC,CAAC,CAAA;CAAE,GAC9D,OAAO,CAAC,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CA0BxD;AA0EM,0DAPI,KAAK,CAAC;IAAE,GAAG,EAAE,GAAG,CAAC;IAAC,iBAAiB,CAAC,EAAE,KAAK,CAAC;QAClD,QAAQ,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,CAAC;QAC5C,UAAU,EAAE,OAAO,6BAA6B,EAAE,UAAU,CAAA;KAAE,CAAC,CAAA;CAAE,CAAC,mCAC5D;IAAE,0BAA0B,CAAC,EAAE,CAAC,OAAO,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,KAClF,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAA;CAAE,GACnD,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,OAAO,UAAU,EAAE,KAAK,CAAC,QAAQ,EAAE,CAAC,CAAC,CAmErE"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@justair/justair-library",
-  "version": "7.6.0-alpha.f80fd11",
+  "version": "7.6.0",
   "description": "JustAir Internal Library",
   "main": "src/index.js",
   "type": "module",

package/src/index.js

@@ -293,16 +293,16 @@ export {
   // being retired rather than kept in step with it. Nothing should store this
   // result — see the module header for the five bugs a stored copy caused.
   //
+  // Both resolvers are only correct for users whose subscribedDevices has been
+  // backfilled from subscribedMonitors — read the PRECONDITION block in the
+  // module header before pointing a service at either of them.
+  //
   //   resolveSubscribedMonitorIdsByUser — the batch form. One Sites lookup for
   //                              a whole cohort. What alert runs, org pages and
   //                              session responses should call.
   //   projectSubscribedMonitors — the single-user rule the batch form is built
   //                              on. Named after the field being retired; it
   //                              gets renamed when that field is dropped.
-  //
-  // Only correct for users whose subscribedDevices has been backfilled from
-  // subscribedMonitors — see the PRECONDITION block in the module header
-  // before pointing a service at these.
   //   VISIBLE_SITE_MONITOR_FILTER — the privacy predicate every consumer must
   //                              apply when turning a Site into monitor ids.
   //                              Sites.monitorIds is unfiltered; reading it

package/src/utils/subscribedDevices.js

@@ -116,15 +116,20 @@ export const SUBSCRIBED_DEVICES_ERRORS = Object.freeze({
 //     "_id",
 //   ).lean();
 //
-// `isActive: { $ne: false }` for the same reason, one step weaker than it
-// looks: `isActive` is `default: true` and NOT `required` (models/monitors.js),
-// so a monitor written before the field existed carries no key. An exact
-// `isActive: true` match would drop it out of every Site's audience silently —
-// the same class of bug as an exact `isPrivate: false` match, and the two
-// halves of this predicate should fail the same way. Both clauses are
-// deliberately permissive on a missing key: the cost of over-including a stale
-// monitor is a redundant alert, the cost of under-including is a person who
-// stops being alerted at all.
+// `isActive: true` is an EXACT match, and that asymmetry with the `$ne` above
+// is DELIBERATE — do not "fix" it to `{ $ne: false }`. The two clauses answer
+// different questions. `isPrivate` is a privacy gate: a monitor with no
+// `isPrivate` key was never marked private, so excluding it would hide a
+// monitor its followers are entitled to see. `isActive` is an eligibility
+// gate: a monitor only earns a place in an alert audience by positively
+// asserting it is active. A document with no `isActive` key has made no such
+// assertion, and the safe reading of "we don't know" is to leave it out rather
+// than alert on it.
+//
+// So the failure modes are not symmetric and should not be made symmetric.
+// Over-including here means alerting people about a monitor nobody confirmed
+// is live; under-including means one unconfirmed monitor is missing from an
+// audience until someone sets the flag. This predicate takes the second.
 //
 // `monitorState: "Deployed"` is deliberately NOT here. That is an
 // alerting-eligibility rule, not a visibility rule, and it belongs to the
@@ -137,10 +142,11 @@ export const SUBSCRIBED_DEVICES_ERRORS = Object.freeze({
 // top-level-only freeze still lets a consumer write
 // `VISIBLE_SITE_MONITOR_FILTER.isPrivate.$ne = false` — and because every
 // consumer spreads THIS instance, that one write flips the privacy predicate
-// for the whole process. Freeze each nested operator object too.
+// for the whole process. `isPrivate` is the only nested object here; freeze it
+// too, and freeze any operator object a future clause introduces.
 export const VISIBLE_SITE_MONITOR_FILTER = Object.freeze({
   isPrivate: Object.freeze({ $ne: true }),
-  isActive: Object.freeze({ $ne: false }),
+  isActive: true,
 });
 
 // Dedupe by string form, keep the caller's ObjectId instances. Two equal
@@ -398,10 +404,13 @@ export const projectSubscribedMonitors = async (
 // to nothing, so their alerts stop) is the subscription-identity question
 // tracked in TODOS, and is deliberately not papered over here.
 //
-// Users are keyed by `String(user._id)`, so callers look up with the same. A
-// user with no `_id` throws rather than being skipped: skipping would silently
-// remove a real person from an alert audience, which is the failure mode this
-// whole module exists to avoid.
+// Users are keyed by `String(user._id)`, so callers look up with the same.
+// Anything in the cohort that is not a user object carrying an `_id` — a
+// missing `_id`, a `null` slot, a bare id string — throws COHORT_USER_MISSING_ID
+// rather than being skipped. Skipping would silently remove a real person from
+// an alert audience, which is the failure mode this whole module exists to
+// avoid, and a caller cannot tell a dropped entry apart from one that resolved
+// to nothing.
 //
 // Consumers can shrink the cohort by pushing the AQI-capability predicate into
 // the Users query, so rows that can never alert are not loaded at all.

package/src/utils/tests/subscribedDevices.test.js

@@ -665,15 +665,17 @@ describe('resolveSubscribedMonitorIdsByUser — rejects what would otherwise fai
 });
 
 describe('VISIBLE_SITE_MONITOR_FILTER', () => {
-  test('both clauses use $ne, so a document missing the key survives', () => {
-    // $ne matches both the negated value and a MISSING key. isPrivate has no
-    // key on documents written before it existed; isActive is `default: true`
-    // and NOT required (models/monitors.js), so it has the same gap. An exact
-    // match on either would drop those monitors out of every Site's audience
-    // with no error anywhere.
+  test('privacy uses $ne, eligibility uses an exact match — deliberately', () => {
+    // The asymmetry is the point, and this test exists to stop it being
+    // "fixed". isPrivate is a privacy gate: $ne keeps a monitor that was never
+    // marked private, which its followers are entitled to see. isActive is an
+    // eligibility gate: a monitor earns a place in an alert audience only by
+    // positively asserting it is active, so a document that has made no such
+    // assertion stays out. Confirmed product decision — flipping either half
+    // is a behaviour change, not a cleanup.
     expect(VISIBLE_SITE_MONITOR_FILTER).toEqual({
       isPrivate: { $ne: true },
-      isActive: { $ne: false },
+      isActive: true,
     });
   });
 
@@ -683,12 +685,12 @@ describe('VISIBLE_SITE_MONITOR_FILTER', () => {
     // predicate for every consumer that spreads this instance.
     expect(Object.isFrozen(VISIBLE_SITE_MONITOR_FILTER)).toBe(true);
     expect(Object.isFrozen(VISIBLE_SITE_MONITOR_FILTER.isPrivate)).toBe(true);
-    expect(Object.isFrozen(VISIBLE_SITE_MONITOR_FILTER.isActive)).toBe(true);
   });
 
   test('a nested write is rejected rather than shared with every consumer', () => {
+    // ES modules are strict, so a write to a frozen property throws rather
+    // than failing silently.
     expect(() => {
-      'use strict';
       VISIBLE_SITE_MONITOR_FILTER.isPrivate.$ne = false;
     }).toThrow(TypeError);