@justair/justair-library 6.14.0-alpha.e751b16 → 6.14.0

package/dist/models/users.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"users.d.ts","sourceRoot":"","sources":["../../src/models/users.js"],"names":[],"mappings":"AA2CA,8BAiFE;AA2BF,wBAAmD;AA/InD,iDAA4D;AAC5D,6CAAmD;AAUnD,4DAsBC"}
+{"version":3,"file":"users.d.ts","sourceRoot":"","sources":["../../src/models/users.js"],"names":[],"mappings":"AA2CA,8BAiFE;AA+BF,wBAAmD;AAnJnD,iDAA4D;AAC5D,6CAAmD;AAUnD,4DAsBC"}

package/dist/utils/quietHours.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"quietHours.d.ts","sourceRoot":"","sources":["../../src/utils/quietHours.js"],"names":[],"mappings":"AAkBA;;;GAGG;AAEH,kDAAmD;AAKnD;;;;GAIG;AAuBI,uDACgD;AAEhD,4DAUN;AAOM;;;;;;;;;KAsCN;AASM,iEASN;AAKM,uEAaN;AAWM;;;;;;;EA2CN"}
+{"version":3,"file":"quietHours.d.ts","sourceRoot":"","sources":["../../src/utils/quietHours.js"],"names":[],"mappings":"AAkBA;;;GAGG;AAEH,kDAAmD;AAKnD;;;;GAIG;AAuBI,uDACgD;AAEhD,4DAUN;AAOM;;;;;;;;;KAsCN;AASM,iEASN;AAKM,uEAaN;AAeM;;;;;;;EA6CN"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@justair/justair-library",
-  "version": "6.14.0-alpha.e751b16",
+  "version": "6.14.0",
   "description": "JustAir Internal Library",
   "main": "src/index.js",
   "type": "module",

package/src/models/users.js

@@ -141,7 +141,11 @@ usersSchema.pre("validate", function (next) {
   });
   for (const error of errors) {
     if (CROSS_FIELD_QUIET_HOURS_CODES.has(error.code)) {
+      // The pair is the unit of a cross-field rule: attach to BOTH paths so
+      // consumers surfacing per-field ValidationError entries highlight both
+      // inputs, whichever side was set/unset.
       this.invalidate("quietHoursStart", error.message);
+      this.invalidate("quietHoursEnd", error.message);
     }
   }
   next();

package/src/utils/quietHours.js

@@ -151,11 +151,15 @@ export const isInQuietWindow = (minutesNow, window) => {
 
 // Resolves a user's stored fields into an evaluable { window, timezone },
 // never throwing on corrupt data (JA-3020 D16). Fallback semantics:
-//   - fields null/undefined        → defaults, no warning (the normal case)
-//   - invalid timezone             → DEFAULT_TIMEZONE + warning
-//   - half-set or malformed pair   → DEFAULT_QUIET_HOURS + warning
-//   - stored equal pair            → window: null (no suppression) + warning
-//     (JA-3020 D11 — "always quiet" must never arise from corrupt data)
+//   - fields null/undefined          → defaults, no warning (the normal case)
+//   - invalid timezone               → DEFAULT_TIMEZONE + warning
+//   - half-set or malformed pair     → DEFAULT_QUIET_HOURS + warning (corrupt
+//     data keeps the protective default; a malformed-AND-identical pair like
+//     "25:00"/"25:00" is classified FORMAT by the validator and lands here)
+//   - well-formed equal pair         → window: null (no suppression) + warning
+//     (JA-3020 D11 — ambiguous intent must never become "always quiet")
+// Branching consumes the validator's stable error codes — never re-derives
+// the classification from the raw values.
 // Callers log `warnings` (once per run, not per user) and evaluate with
 // isInQuietWindow(getZoneMinutes(now, timezone), window).
 export const resolveQuietHours = (user) => {
@@ -184,7 +188,9 @@ export const resolveQuietHours = (user) => {
     });
     if (errors.length === 0) {
       window = { start: quietHoursStart, end: quietHoursEnd };
-    } else if (quietHoursStart === quietHoursEnd) {
+    } else if (
+      errors.some((e) => e.code === QUIET_HOURS_ERRORS.EQUAL_PAIR)
+    ) {
       window = null;
       warnings.push(
         `stored quiet hours are an equal pair ("${quietHoursStart}") — treating as no suppression`

package/src/utils/tests/quietHours.test.js

@@ -327,6 +327,19 @@ describe('resolveQuietHours', () => {
     expect(isInQuietWindow(0, resolved.window)).toBe(false);
   });
 
+  test('malformed-AND-identical pair is corrupt data, not an equal pair — default window + invalid warning', () => {
+    const resolved = resolveQuietHours({
+      quietHoursStart: '25:00',
+      quietHoursEnd: '25:00',
+    });
+    // FORMAT classification wins: the user keeps the protective default
+    // window instead of losing suppression entirely.
+    expect(resolved.window).toEqual(DEFAULT_QUIET_HOURS);
+    expect(resolved.warnings).toHaveLength(1);
+    expect(resolved.warnings[0]).toMatch(/invalid/);
+    expect(resolved.warnings[0]).not.toMatch(/equal pair/);
+  });
+
   test('corrupt window and corrupt timezone warn independently', () => {
     const resolved = resolveQuietHours({
       quietHoursStart: 'bad',