@juspay/shooter 1.5.0 → 1.6.1

package/src/lib/modules/client/terminal/LaunchSheet.svelte

@@ -1,23 +1,10 @@
 <script lang="ts">
-  import type { CreateTerminalResponse } from '$generated/types';
+  import type { CreateTerminalResponse, LaunchSheetProps, Preset } from '$lib/types';
 
   import { Banner, Button, Choicebox, Input, Select } from '@juspay/svelte-ui-components';
   import { onMount } from 'svelte';
 
-  interface Props {
-    apiKey: string;
-    onClose: () => void;
-    onLaunch: (response: CreateTerminalResponse) => void;
-    open: boolean;
-  }
-
-  interface Preset {
-    args: string[];
-    command: string;
-    label: string;
-  }
-
-  const { apiKey, onClose, onLaunch, open }: Props = $props();
+  const { apiKey, onClose, onLaunch, open }: LaunchSheetProps = $props();
 
   const presets: Preset[] = [
     { args: [], command: 'claude', label: 'Claude Code' },
@@ -45,7 +32,7 @@
       if (!response.ok) {
         return;
       }
-      const data: { projects: { fullPath: string }[] } = await response.json();
+      const data = (await response.json()) as { projects: { fullPath: string }[] };
       const paths = data.projects
         .map((p) => p.fullPath)
         .filter((p): p is string => typeof p === 'string' && p.length > 0);
@@ -104,12 +91,14 @@
       });
 
       if (!response.ok) {
-        const data = await response.json().catch(() => ({}));
-        launchError = data.error || `Failed to launch (${response.status})`;
+        const data = (await response.json().catch(() => ({}))) as Record<string, unknown>;
+        launchError =
+          (typeof data.error === 'string' ? data.error : '') ||
+          `Failed to launch (${response.status})`;
         return;
       }
 
-      const result: CreateTerminalResponse = await response.json();
+      const result = (await response.json()) as CreateTerminalResponse;
       onLaunch(result);
     } catch {
       launchError = 'Network error — is the server running?';
@@ -152,7 +141,7 @@
             <Choicebox
               mode="radio"
               selected={selectedPreset === i}
-              onclick={() => {
+              onclick={(): void => {
                 selectPreset(i);
               }}
               classes="preset-choice"
@@ -171,7 +160,7 @@
             : [{ id: '', label: 'No recent projects' }]}
           value={selectedCwd ? [selectedCwd] : projectPaths.length > 0 ? [projectPaths[0]] : ['']}
           placeholder="Select a project"
-          onchange={(value) => {
+          onchange={(value: string[]): void => {
             selectedCwd = value[0] || '';
           }}
           classes="launch-select"

package/src/lib/modules/client/terminal/QuickKeys.svelte

@@ -1,16 +1,9 @@
 <script lang="ts">
-  import { Button } from '@juspay/svelte-ui-components';
-
-  interface Props {
-    onKey: (key: string) => void;
-  }
+  import type { QuickKey, QuickKeysProps } from '$lib/types';
 
-  interface QuickKey {
-    escape: string;
-    label: string;
-  }
+  import { Button } from '@juspay/svelte-ui-components';
 
-  const { onKey }: Props = $props();
+  const { onKey }: QuickKeysProps = $props();
 
   const keys: QuickKey[] = [
     { escape: '\x03', label: 'Ctrl+C' },
@@ -27,7 +20,7 @@
   {#each keys as k (k.label)}
     <Button
       classes="btn-quick-key"
-      onclick={() => {
+      onclick={(): void => {
         onKey(k.escape);
       }}
       text={k.label}

package/src/lib/modules/client/terminal/ShortcutsHelp.svelte

@@ -1,14 +1,11 @@
 <script lang="ts">
+  import type { ShortcutsHelpProps } from '$lib/types';
+
   import { KeyboardInput, Modal } from '@juspay/svelte-ui-components';
 
   import { getShortcutList } from './keyboard-shortcuts';
 
-  interface Props {
-    onClose: () => void;
-    open: boolean;
-  }
-
-  const { onClose, open }: Props = $props();
+  const { onClose, open }: ShortcutsHelpProps = $props();
   const shortcuts = getShortcutList();
 </script>
 

package/src/lib/modules/client/terminal/keyboard-shortcuts.ts

@@ -5,17 +5,15 @@
  * Uses capture-phase window keydown to intercept before xterm.
  */
 
+import type { ShortcutManagerOptions } from '$lib/types';
+
 export const isMac =
   typeof navigator !== 'undefined' && /Mac|iPhone|iPad/.test(navigator.userAgent);
 
 export const modLabel = isMac ? '⌘' : 'Ctrl';
 
-interface ShortcutManagerOptions {
-  onHelp: () => void;
-}
-
-export function createShortcutManager(options: ShortcutManagerOptions) {
-  function handler(e: KeyboardEvent) {
+export function createShortcutManager(options: ShortcutManagerOptions): { destroy: () => void } {
+  function handler(e: KeyboardEvent): void {
     const mod = isMac ? e.metaKey : e.ctrlKey;
     if (!mod) {
       return;
@@ -38,7 +36,7 @@ export function createShortcutManager(options: ShortcutManagerOptions) {
   window.addEventListener('keydown', handler, true); // capture phase
 
   return {
-    destroy() {
+    destroy(): void {
       window.removeEventListener('keydown', handler, true);
     },
   };

package/src/lib/modules/client/terminal/xterm-wrapper.ts

@@ -1,29 +1,7 @@
 // IMPORTANT: This module must NEVER be imported at module top level in a Svelte component.
 // Always call createTerminal() inside onMount() only.
 
-import type { FitAddon } from '@xterm/addon-fit';
-import type { Terminal } from '@xterm/xterm';
-
-interface TerminalInstance {
-  dispose: () => void;
-  fitAddon: FitAddon | null;
-  sendInput: (data: string) => void;
-  term: Terminal;
-}
-
-interface TerminalOptions {
-  apiKey?: string;
-  container: HTMLElement;
-  fontSize?: number;
-  getTicket: () => Promise<string>;
-  onActivity?: (active: boolean) => void;
-  onCwd?: (path: string) => void;
-  onDisconnect?: () => void;
-  onExit?: (code: number) => void;
-  onReconnect?: () => void;
-  terminalId?: string;
-  wsUrl: string;
-}
+import type { TerminalInstance, TerminalOptions, WsTerminalInboundMessage } from '$lib/types';
 
 export async function createTerminal(options: TerminalOptions): Promise<TerminalInstance> {
   // Dynamic imports — only loaded client-side
@@ -97,8 +75,8 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
     const pasteTermId = options.terminalId;
     const pasteApiKey = options.apiKey;
 
-    pasteListener = (e: ClipboardEvent) => {
-      void (async () => {
+    pasteListener = (e: ClipboardEvent): void => {
+      void (async (): Promise<void> => {
         try {
           if (!e.clipboardData) {
             return;
@@ -117,13 +95,15 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
 
           // Read image as base64
           const reader = new FileReader();
-          const base64 = await new Promise<string>((resolve, reject) => {
-            reader.onload = () => {
-              resolve(reader.result as string);
-            };
-            reader.onerror = reject;
-            reader.readAsDataURL(blob);
-          });
+          const base64 = await new Promise<string>(
+            (resolve, reject: (reason?: unknown) => void) => {
+              reader.onload = (): void => {
+                resolve(reader.result as string);
+              };
+              reader.onerror = reject;
+              reader.readAsDataURL(blob);
+            }
+          );
 
           // Upload to server
           const res = await fetch(`/api/terminals/${pasteTermId}/paste-image`, {
@@ -154,7 +134,7 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
   let reconnectDelay = 1000;
   let disposed = false;
 
-  async function connect() {
+  async function connect(): Promise<void> {
     if (disposed) {
       return;
     }
@@ -180,35 +160,35 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
 
     ws = new WebSocket(`${options.wsUrl}?ticket=${ticket}`);
 
-    ws.onopen = () => {
+    ws.onopen = (): void => {
       reconnectDelay = 1000; // Reset backoff
       options.onReconnect?.();
     };
 
-    ws.onmessage = (event) => {
-      const msg = JSON.parse(event.data);
+    ws.onmessage = (event: MessageEvent): void => {
+      const msg = JSON.parse(event.data as string) as WsTerminalInboundMessage;
       if (msg.type === 'output') {
-        term.write(msg.data);
+        term.write(msg.data ?? '');
       } else if (msg.type === 'scrollback') {
-        term.write(msg.data);
+        term.write(msg.data ?? '');
       } else if (msg.type === 'exit') {
-        term.write(`\r\n\x1b[90m[Process exited with code ${msg.code}]\x1b[0m\r\n`);
+        term.write(`\r\n\x1b[90m[Process exited with code ${String(msg.code)}]\x1b[0m\r\n`);
         // Process exited — stop reconnection and notify parent
         disposed = true;
         if (reconnectTimer) {
           clearTimeout(reconnectTimer);
         }
-        options.onExit?.(msg.code);
+        options.onExit?.(msg.code ?? 0);
       } else if (msg.type === 'output-dropped') {
-        term.write(`\r\n\x1b[33m[${msg.bytes} bytes dropped]\x1b[0m\r\n`);
+        term.write(`\r\n\x1b[33m[${String(msg.bytes)} bytes dropped]\x1b[0m\r\n`);
       } else if (msg.type === 'activity') {
-        options.onActivity?.(msg.active);
+        options.onActivity?.(msg.active ?? false);
       } else if (msg.type === 'cwd') {
-        options.onCwd?.(msg.path);
+        options.onCwd?.(msg.path ?? '');
       }
     };
 
-    ws.onclose = () => {
+    ws.onclose = (): void => {
       if (disposed) {
         return;
       }
@@ -231,7 +211,7 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
   });
 
   // Handle resize — skip when container is hidden (display:none → size 0)
-  const resizeObserver = new ResizeObserver(() => {
+  const resizeObserver = new ResizeObserver((): void => {
     if (!options.container.offsetWidth || !options.container.offsetHeight) {
       return;
     }
@@ -242,7 +222,7 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
   });
   resizeObserver.observe(options.container);
 
-  function dispose() {
+  function dispose(): void {
     disposed = true;
     if (reconnectTimer) {
       clearTimeout(reconnectTimer);
@@ -255,7 +235,7 @@ export async function createTerminal(options: TerminalOptions): Promise<Terminal
     term.dispose();
   }
 
-  function sendInput(data: string) {
+  function sendInput(data: string): void {
     if (ws?.readyState === WebSocket.OPEN) {
       ws.send(JSON.stringify({ data, type: 'input' }));
     }

package/src/lib/modules/server/apn/library-apns.ts

@@ -1,9 +1,9 @@
+import type { LibraryResult as APNsLibraryResult, NotificationPayload } from '$lib/types';
+
 import { env } from '$env/dynamic/private';
 // APNs service using proven library instead of manual implementation
 import apn from '@parse/node-apn';
 
-import type { LibraryResult as APNsLibraryResult, NotificationPayload } from './types';
-
 import { toErrorMessage } from '../utils/error';
 
 export class LibraryAPNsService {
@@ -79,7 +79,10 @@ export class LibraryAPNsService {
 
     notification.badge = payload.badge ?? 1;
     notification.sound = payload.sound ?? 'default';
-    notification.topic = this.bundleId!;
+    if (!this.bundleId) {
+      throw new Error('APNs bundleId is required but was not configured');
+    }
+    notification.topic = this.bundleId;
 
     if (payload.category) {
       notification.aps.category = payload.category;

package/src/lib/modules/server/apn/notification-history.ts

@@ -1,8 +1,8 @@
 // In-memory notification history store.
 // Same pattern as pending-requests.ts — suitable for single-instance deployments.
 
-export type { NotificationRecord } from '$generated/types';
-import type { NotificationRecord } from '$generated/types';
+export type { NotificationRecord } from '$lib/types';
+import type { NotificationRecord } from '$lib/types';
 
 const MAX_HISTORY = 100;
 

package/src/lib/modules/server/apn/notification-sessions.ts

@@ -1,9 +1,7 @@
-import type { NotificationSession } from '$generated/types';
+import type { Session } from '$lib/types';
 
 import { getNotifications, type NotificationRecord } from './notification-history';
 
-export type Session = NotificationSession;
-
 const SESSION_GAP_MS = 30 * 60 * 1000; // 30 min gap = new session
 const ACTIVE_THRESHOLD_MS = 5 * 60 * 1000; // active if last event < 5 min ago
 

package/src/lib/modules/server/apn/pending-requests.ts

@@ -1,7 +1,7 @@
 // Shared in-memory store for pending permission requests.
 // Used by /api/notify (creates entries) and /api/response (reads/updates).
 
-import type { PendingRequest } from '$generated/types';
+import type { PendingRequest } from '$lib/types';
 
 export type { PendingRequest };
 

package/src/lib/modules/server/apn/types.ts

@@ -1,52 +1,2 @@
-import type {
-  Error as APNsError,
-  ErrorData,
-  LibraryFailedItem,
-  LibrarySentItem,
-  RawResponse,
-  SentDetail,
-} from '$generated/types';
-
-// Composite types built from generated primitives. These use arrays and
-// union constructs that type-crafter does not emit, so they stay as local
-// definitions.
-
-export interface LibraryResult {
-  failed: LibraryFailedItem[];
-  sent: LibrarySentItem[];
-}
-
-export interface NotificationPayload {
-  badge: null | number;
-  body: null | string;
-  category?: null | string;
-  data: null | Record<string, unknown>;
-  message: null | string;
-  sound: null | string;
-  title: string;
-}
-
-export interface NotificationResult {
-  apnsId: null | string;
-  details: null | SentDetail[];
-  error: ErrorData | null | string;
-  errorData: ErrorData | null;
-  errors: APNsError[] | null;
-  failed: number;
-  headers: null | Record<string, unknown>;
-  response: null | RawResponse;
-  responseBody: null | string;
-  sent: number;
-  status: null | number;
-  statusCode: null | number;
-  success: boolean;
-}
-
-export type {
-  APNsError as Error,
-  ErrorData,
-  LibraryFailedItem,
-  LibrarySentItem,
-  RawResponse,
-  SentDetail,
-};
+// All APNs composite types have been moved to $lib/types/apn.ts.
+// Import from '$lib/types' instead of this file.

package/src/lib/modules/server/cli/index.ts

@@ -1,35 +1,6 @@
-import type { Options as CLIOptions } from '$generated/types';
+import type { CLICommand, Options as CLIOptions, CLIResult } from '$lib/types';
 
 export { CLIRunner, createRunner, sleep } from './runner';
-export type { ExitCallback, OutputCallback } from './runner';
-
-// Types generated by type-crafter
-export type { CLIOptions };
-
-// Types defined in YAML spec (cli.yaml) but not generated by type-crafter
-// because they contain $ref or array constructs.
-// TODO: Remove once type-crafter supports these constructs.
-export interface CLICommand {
-  args: string[];
-  name: string;
-  options: CLIOptions;
-}
-
-export interface CLIResult {
-  error: null | string;
-  exitCode: number;
-  output: null | string;
-  success: boolean;
-}
-
-export interface CLIRunnerConfig {
-  args: null | string[];
-  cols: null | number;
-  command: string;
-  cwd: null | string;
-  rows: null | number;
-  useLoginShell: boolean | null;
-}
 
 const DEFAULT_OPTIONS: CLIOptions = {
   dryRun: false,

package/src/lib/modules/server/cli/runner.ts

@@ -1,19 +1,11 @@
-import pty, { type IPty } from 'node-pty';
-
-import type { CLIRunnerConfig } from './index';
-
-export type ExitCallback = (code: number, signal?: number) => void;
-export type OutputCallback = (data: string) => void;
+import type {
+  CLIRunnerConfig,
+  ExitCallback,
+  CLIRunnerInternalConfig as InternalConfig,
+  OutputCallback,
+} from '$lib/types';
 
-interface InternalConfig {
-  args: string[];
-  cols: number;
-  command: string;
-  cwd: string;
-  env: NodeJS.ProcessEnv;
-  rows: number;
-  useLoginShell: boolean;
-}
+import pty, { type IPty } from 'node-pty';
 
 export class CLIRunner {
   private config: InternalConfig;

package/src/lib/modules/server/fcm/fcm-service.ts

@@ -1,6 +1,6 @@
-import admin from 'firebase-admin';
+import type { NotificationPayload } from '$lib/types';
 
-import type { NotificationPayload } from '../apn/types.js';
+import admin from 'firebase-admin';
 
 let app: admin.app.App | null = null;