@juspay/neurolink 9.64.0 → 9.65.1

package/dist/lib/providers/googleNativeGemini3.js

@@ -17,6 +17,61 @@ import { logger } from "../utils/logger.js";
 import { convertZodToJsonSchema, ensureNestedSchemaTypes, inlineJsonSchema, isZodSchema, normalizeJsonSchemaObject, } from "../utils/schemaConversion.js";
 import { createNativeThinkingConfig } from "../utils/thinkingConfig.js";
 // ── Functions ──
+/**
+ * Google's `function_declarations[].name` validator regex.
+ *
+ * Empirically (and per the Vertex/AI Studio API error message), the server
+ * enforces `[A-Za-z_][A-Za-z0-9_.:-]{0,127}`. Tool names that don't match
+ * fail with HTTP 400 "Invalid function name", which surfaces as a misleading
+ * tool-calling failure for the whole request.
+ *
+ * MCP-imported or user-registered tools may legally contain characters
+ * outside this set (e.g. `/`, spaces, unicode), so we sanitize defensively
+ * before sending to Google. The sanitized name is also used as the
+ * `executeMap` key so the round-trip from Google's function-call response
+ * back to our executor still works.
+ */
+const GOOGLE_FN_NAME_REGEX = /^[A-Za-z_][A-Za-z0-9_.:-]{0,127}$/;
+const GOOGLE_FN_NAME_MAX_LENGTH = 128;
+export function sanitizeForGoogleFunctionName(name) {
+    if (GOOGLE_FN_NAME_REGEX.test(name)) {
+        return name;
+    }
+    let sanitized = name.replace(/[^A-Za-z0-9_.:-]/g, "_");
+    if (!/^[A-Za-z_]/.test(sanitized)) {
+        sanitized = `_${sanitized}`;
+    }
+    if (sanitized.length > GOOGLE_FN_NAME_MAX_LENGTH) {
+        sanitized = sanitized.slice(0, GOOGLE_FN_NAME_MAX_LENGTH);
+    }
+    return sanitized;
+}
+/**
+ * Resolve a sanitized Gemini tool name to one that is both unique within
+ * the current request and at most 128 characters. When the candidate
+ * collides with an already-used name we append `_2`, `_3`, … — but
+ * reserve room for the suffix by truncating the base first so the
+ * resolved name never exceeds Google's `function_declarations[].name`
+ * limit.
+ *
+ * @param base       The already-sanitized candidate name.
+ * @param isTaken    Predicate that returns true if `name` is already used.
+ */
+export function resolveUniqueGoogleFunctionName(base, isTaken) {
+    if (!isTaken(base)) {
+        return base;
+    }
+    let suffix = 2;
+    while (true) {
+        const suffixStr = `_${suffix}`;
+        const trimmedBase = base.slice(0, GOOGLE_FN_NAME_MAX_LENGTH - suffixStr.length);
+        const candidate = `${trimmedBase}${suffixStr}`;
+        if (!isTaken(candidate)) {
+            return candidate;
+        }
+        suffix++;
+    }
+}
 /**
  * Sanitize a JSON Schema for Gemini's proto-based API.
  *
@@ -102,6 +157,40 @@ export function sanitizeSchemaForGemini(schema) {
             result[branch] = sanitizeSchemaForGemini(result[branch]);
         }
     }
+    // JSON Schema Draft-4 `exclusiveMinimum: true` / `exclusiveMaximum: true`
+    // (boolean form) is rejected by Gemini's OpenAPI 3.0 validator, which
+    // expects a numeric bound. zod-to-json-schema's openApi3 target still
+    // emits the Draft-4 form for `z.number().positive()` etc. Translate to
+    // the numeric form when paired with `minimum`/`maximum`, or drop.
+    if (typeof result.exclusiveMinimum === "boolean") {
+        if (result.exclusiveMinimum === true &&
+            typeof result.minimum === "number") {
+            result.exclusiveMinimum = result.minimum;
+            delete result.minimum;
+        }
+        else {
+            delete result.exclusiveMinimum;
+        }
+    }
+    if (typeof result.exclusiveMaximum === "boolean") {
+        if (result.exclusiveMaximum === true &&
+            typeof result.maximum === "number") {
+            result.exclusiveMaximum = result.maximum;
+            delete result.maximum;
+        }
+        else {
+            delete result.exclusiveMaximum;
+        }
+    }
+    // Clamp `maximum`/`minimum` past int32 — Gemini's protobuf serializer
+    // treats `type: "integer"` as int32 and rejects bounds beyond ~2.1e9.
+    const INT32_MAX = 2147483647;
+    if (typeof result.maximum === "number" && result.maximum > INT32_MAX) {
+        delete result.maximum;
+    }
+    if (typeof result.minimum === "number" && result.minimum < -INT32_MAX) {
+        delete result.minimum;
+    }
     return result;
 }
 /**
@@ -117,8 +206,27 @@ export function sanitizeSchemaForGemini(schema) {
 export function sanitizeToolsForGemini(tools) {
     const sanitized = {};
     const dropped = [];
+    const renamed = [];
+    const originalNameMap = new Map();
     for (const [name, tool] of Object.entries(tools)) {
         try {
+            // Sanitize the tool name to fit Google's function_declarations regex.
+            // Without this, MCP-imported or user-registered tools whose names contain
+            // characters outside [A-Za-z_][A-Za-z0-9_.:-]{0,127} cause the entire
+            // request to 400 with "Invalid function name", surfacing as a misleading
+            // tool-calling failure. Distinct originals that collapse onto the same
+            // sanitized name (e.g. "my/tool" and "my-tool" → "my_tool") are
+            // disambiguated with a numeric suffix that preserves Google's 128-char
+            // ceiling.
+            const candidate = sanitizeForGoogleFunctionName(name);
+            const safeName = resolveUniqueGoogleFunctionName(candidate, (n) => n in sanitized);
+            // Always record the mapping so downstream code can translate every
+            // safeName back to the original — including the no-rename identity
+            // mapping, which simplifies the lookup path.
+            originalNameMap.set(safeName, name);
+            if (safeName !== name) {
+                renamed.push({ from: name, to: safeName });
+            }
             // Access the legacy `parameters` field that may exist on older AI SDK tools.
             // AI SDK v6 uses `inputSchema`, but v3/v4 tools and third-party wrappers use `parameters`.
             const legacyTool = tool;
@@ -134,8 +242,8 @@ export function sanitizeToolsForGemini(tools) {
                 // additionalProperties are removed. The resulting schema is Gemini-compatible
                 // but loses some type constraints from the original Zod schema.
                 const sanitizedSchema = sanitizeSchemaForGemini(inlined);
-                sanitized[name] = createAISDKTool({
-                    description: tool.description || `Tool: ${name}`,
+                sanitized[safeName] = createAISDKTool({
+                    description: tool.description || `Tool: ${safeName}`,
                     inputSchema: aiJsonSchema(sanitizedSchema),
                     execute: tool.execute,
                 });
@@ -147,14 +255,14 @@ export function sanitizeToolsForGemini(tools) {
                 const rawSchema = params
                     .jsonSchema;
                 const sanitizedSchema = sanitizeSchemaForGemini(inlineJsonSchema(rawSchema));
-                sanitized[name] = createAISDKTool({
-                    description: tool.description || `Tool: ${name}`,
+                sanitized[safeName] = createAISDKTool({
+                    description: tool.description || `Tool: ${safeName}`,
                     inputSchema: aiJsonSchema(sanitizedSchema),
                     execute: tool.execute,
                 });
             }
             else {
-                sanitized[name] = tool;
+                sanitized[safeName] = tool;
             }
         }
         catch (error) {
@@ -163,7 +271,12 @@ export function sanitizeToolsForGemini(tools) {
             dropped.push(name);
         }
     }
-    return { tools: sanitized, dropped };
+    if (renamed.length > 0) {
+        logger.warn(`[Gemini] ${renamed.length} tool name(s) sanitized for Google's function-name regex: ${renamed
+            .map((r) => `"${r.from}" -> "${r.to}"`)
+            .join(", ")}`);
+    }
+    return { tools: sanitized, dropped, originalNameMap };
 }
 export function normalizeToolsForJsonSchemaProvider(tools) {
     const normalizedTools = {};
@@ -212,11 +325,29 @@ export function buildNativeToolDeclarations(tools) {
     const functionDeclarations = [];
     const executeMap = new Map();
     const skippedTools = [];
+    const renamedTools = [];
+    // Disambiguate distinct originals that collapse onto the same sanitized
+    // name (e.g. "my/tool" and "my-tool" both → "my_tool") via
+    // resolveUniqueGoogleFunctionName, which appends `_N` while keeping the
+    // final string within Google's 128-char limit. Track all assigned names
+    // regardless of whether the tool has an `execute` function (tools without
+    // execute are still pushed to functionDeclarations). The originalNameMap
+    // lets the calling stream loop translate Google-returned function-call
+    // names back to the consumer-facing identifier so the sanitization is
+    // transport-only.
+    const usedNames = new Set();
+    const originalNameMap = new Map();
     for (const [name, tool] of Object.entries(tools)) {
         try {
+            const candidate = sanitizeForGoogleFunctionName(name);
+            const safeName = resolveUniqueGoogleFunctionName(candidate, (n) => usedNames.has(n));
+            originalNameMap.set(safeName, name);
+            if (safeName !== name) {
+                renamedTools.push({ from: name, to: safeName });
+            }
             const decl = {
-                name,
-                description: tool.description || `Tool: ${name}`,
+                name: safeName,
+                description: tool.description || `Tool: ${safeName}`,
             };
             // Access legacy `parameters` (AI SDK v3/v4) or current `inputSchema` (v6)
             const legacyTool = tool;
@@ -241,8 +372,9 @@ export function buildNativeToolDeclarations(tools) {
                 decl.parametersJsonSchema = sanitizeSchemaForGemini(inlineJsonSchema(rawSchema));
             }
             functionDeclarations.push(decl);
+            usedNames.add(safeName);
             if (tool.execute) {
-                executeMap.set(name, tool.execute);
+                executeMap.set(decl.name, tool.execute);
             }
         }
         catch (err) {
@@ -253,7 +385,16 @@ export function buildNativeToolDeclarations(tools) {
     if (skippedTools.length > 0) {
         logger.warn(`[buildNativeToolDeclarations] ${skippedTools.length} tool(s) skipped due to schema errors: ${skippedTools.join(", ")}`);
     }
-    return { toolsConfig: [{ functionDeclarations }], executeMap };
+    if (renamedTools.length > 0) {
+        logger.warn(`[buildNativeToolDeclarations] ${renamedTools.length} tool name(s) sanitized for Google's function-name regex: ${renamedTools
+            .map((r) => `"${r.from}" -> "${r.to}"`)
+            .join(", ")}`);
+    }
+    return {
+        toolsConfig: [{ functionDeclarations }],
+        executeMap,
+        originalNameMap,
+    };
 }
 /**
  * Build the native @google/genai config object shared by stream and generate.
@@ -493,27 +634,42 @@ export function extractTextFromParts(rawResponseParts) {
  * @param executeMap - Map of tool name to execute function
  * @param failedTools - Mutable map tracking per-tool failure counts
  * @param allToolCalls - Mutable array accumulating all tool call records
- * @param options - Optional settings for execution tracking and cancellation
+ * @param options - Optional settings for execution tracking and cancellation,
+ *                  plus an `originalNameMap` (Google-safe → consumer-supplied
+ *                  identifier) so the sanitization stays transport-only and
+ *                  consumers see the names they registered.
  * @returns Array of function responses for conversation history
  */
 export async function executeNativeToolCalls(logLabel, stepFunctionCalls, executeMap, failedTools, allToolCalls, options) {
     const functionResponses = [];
+    // Translate a Google-safe sanitized name back to the consumer-facing
+    // original name. Falls back to the safe name if the map is missing or
+    // doesn't contain the call (e.g. tool added mid-conversation).
+    const externalName = (safeName) => options?.originalNameMap?.get(safeName) ?? safeName;
+    // Note: tool:start / tool:end events are emitted by ToolsManager's
+    // `execute` wrapper (see src/lib/core/modules/ToolsManager.ts:355 and :790)
+    // around every tool's execute function. The native paths invoke that same
+    // wrapped execute via the executeMap, so emitting here would duplicate.
     for (const call of stepFunctionCalls) {
-        allToolCalls.push({ toolName: call.name, args: call.args });
+        const exposedName = externalName(call.name);
+        allToolCalls.push({ toolName: exposedName, args: call.args });
         // Check if this tool has already exceeded retry limit
         const failedInfo = failedTools.get(call.name);
         if (failedInfo && failedInfo.count >= DEFAULT_TOOL_MAX_RETRIES) {
-            logger.warn(`${logLabel} Tool "${call.name}" has exceeded retry limit (${DEFAULT_TOOL_MAX_RETRIES}), skipping execution`);
+            logger.warn(`${logLabel} Tool "${exposedName}" has exceeded retry limit (${DEFAULT_TOOL_MAX_RETRIES}), skipping execution`);
             const errorOutput = {
-                error: `TOOL_PERMANENTLY_FAILED: The tool "${call.name}" has failed ${failedInfo.count} times and will not be retried. Last error: ${failedInfo.lastError}. Please proceed without using this tool or inform the user that this functionality is unavailable.`,
+                error: `TOOL_PERMANENTLY_FAILED: The tool "${exposedName}" has failed ${failedInfo.count} times and will not be retried. Last error: ${failedInfo.lastError}. Please proceed without using this tool or inform the user that this functionality is unavailable.`,
                 status: "permanently_failed",
                 do_not_retry: true,
             };
+            // Wire transport-side `name: call.name` (Google needs the sanitized
+            // form to match the function declaration) while exposing the
+            // consumer-facing name in toolExecutions metadata.
             functionResponses.push({
                 functionResponse: { name: call.name, response: errorOutput },
             });
             options?.toolExecutions?.push({
-                name: call.name,
+                name: exposedName,
                 input: call.args,
                 output: errorOutput,
             });
@@ -534,7 +690,7 @@ export async function executeNativeToolCalls(logLabel, stepFunctionCalls, execut
                     functionResponse: { name: call.name, response: { result } },
                 });
                 options?.toolExecutions?.push({
-                    name: call.name,
+                    name: exposedName,
                     input: call.args,
                     output: result,
                 });
@@ -549,12 +705,12 @@ export async function executeNativeToolCalls(logLabel, stepFunctionCalls, execut
                 currentFailInfo.count++;
                 currentFailInfo.lastError = errorMessage;
                 failedTools.set(call.name, currentFailInfo);
-                logger.warn(`${logLabel} Tool "${call.name}" failed (attempt ${currentFailInfo.count}/${DEFAULT_TOOL_MAX_RETRIES}): ${errorMessage}`);
+                logger.warn(`${logLabel} Tool "${exposedName}" failed (attempt ${currentFailInfo.count}/${DEFAULT_TOOL_MAX_RETRIES}): ${errorMessage}`);
                 // Determine if this is a permanent failure
                 const isPermanentFailure = currentFailInfo.count >= DEFAULT_TOOL_MAX_RETRIES;
                 const errorOutput = {
                     error: isPermanentFailure
-                        ? `TOOL_PERMANENTLY_FAILED: The tool "${call.name}" has failed ${currentFailInfo.count} times with error: ${errorMessage}. This tool will not be retried. Please proceed without using this tool or inform the user that this functionality is unavailable.`
+                        ? `TOOL_PERMANENTLY_FAILED: The tool "${exposedName}" has failed ${currentFailInfo.count} times with error: ${errorMessage}. This tool will not be retried. Please proceed without using this tool or inform the user that this functionality is unavailable.`
                         : `TOOL_EXECUTION_ERROR: ${errorMessage}. Retry attempt ${currentFailInfo.count}/${DEFAULT_TOOL_MAX_RETRIES}.`,
                     status: isPermanentFailure ? "permanently_failed" : "failed",
                     do_not_retry: isPermanentFailure,
@@ -565,7 +721,7 @@ export async function executeNativeToolCalls(logLabel, stepFunctionCalls, execut
                     functionResponse: { name: call.name, response: errorOutput },
                 });
                 options?.toolExecutions?.push({
-                    name: call.name,
+                    name: exposedName,
                     input: call.args,
                     output: errorOutput,
                 });
@@ -574,7 +730,7 @@ export async function executeNativeToolCalls(logLabel, stepFunctionCalls, execut
         else {
             // Tool not found is a permanent error
             const errorOutput = {
-                error: `TOOL_NOT_FOUND: The tool "${call.name}" does not exist. Do not attempt to call this tool again.`,
+                error: `TOOL_NOT_FOUND: The tool "${exposedName}" does not exist. Do not attempt to call this tool again.`,
                 status: "permanently_failed",
                 do_not_retry: true,
             };
@@ -582,7 +738,7 @@ export async function executeNativeToolCalls(logLabel, stepFunctionCalls, execut
                 functionResponse: { name: call.name, response: errorOutput },
             });
             options?.toolExecutions?.push({
-                name: call.name,
+                name: exposedName,
                 input: call.args,
                 output: errorOutput,
             });
@@ -656,22 +812,113 @@ export function buildGeminiResponseSchema(schema) {
  *  - The current user input should be appended AFTER calling this helper
  *    so the prior turns appear first in chronological order.
  */
-export function prependConversationMessages(contents, conversationMessages) {
+export function prependConversationMessages(contents, 
+// Accept either the full ChatMessage shape (when callers pass real Redis-
+// backed history) or the reduced MinimalChatMessage shape (tests / synthetic
+// callers). Only role, content, tool, args, and metadata.* are read here.
+conversationMessages) {
     if (!conversationMessages || conversationMessages.length === 0) {
         return;
     }
+    // Walk prior turns building ordered segments. Tool_call / tool_result rows
+    // get grouped by (turnCounter, stepIndex) so parallel calls within a step
+    // stay together and don't bleed across turn boundaries. Regular user/
+    // assistant messages act as those boundaries.
+    //
+    // Without this reconstruction, a text-only mapper would strip tool rows
+    // from history — leaving the model unaware of any tools it called in
+    // prior turns. The grouped emit (model with functionCall parts → user
+    // with functionResponse parts) is what @google/genai's own
+    // automaticFunctionCalling produces, so the SDK validates it as a
+    // well-formed multi-turn conversation.
+    const stepMap = new Map();
+    const segments = [];
+    let turnCounter = 0;
+    const makeKey = (stepIndex) => `${turnCounter}:${stepIndex ?? "undefined"}`;
+    const getOrCreateStep = (stepIndex) => {
+        const key = makeKey(stepIndex);
+        const existing = stepMap.get(key);
+        if (existing) {
+            return existing;
+        }
+        const step = {
+            type: "tool_step",
+            callParts: [],
+            resultParts: [],
+        };
+        stepMap.set(key, step);
+        segments.push(step);
+        return step;
+    };
     for (const msg of conversationMessages) {
-        if (msg.role !== "user" && msg.role !== "assistant") {
+        if (msg.role === "tool_call") {
+            const step = getOrCreateStep(msg.metadata?.stepIndex);
+            const fcPart = {
+                functionCall: {
+                    name: msg.tool || "unknown",
+                    args: msg.args || {},
+                },
+            };
+            if (msg.metadata?.thoughtSignature) {
+                fcPart.thoughtSignature = msg.metadata.thoughtSignature;
+            }
+            step.callParts.push(fcPart);
             continue;
         }
-        const text = typeof msg.content === "string" ? msg.content : "";
-        if (text.length === 0) {
+        if (msg.role === "tool_result") {
+            const step = getOrCreateStep(msg.metadata?.stepIndex);
+            let responsePayload;
+            try {
+                responsePayload =
+                    msg.content !== undefined && msg.content !== null
+                        ? { result: JSON.parse(msg.content) }
+                        : { result: "success" };
+            }
+            catch {
+                responsePayload = { result: msg.content ?? "success" };
+            }
+            step.resultParts.push({
+                functionResponse: {
+                    name: msg.tool || "unknown",
+                    response: responsePayload,
+                },
+            });
+            continue;
+        }
+        // Regular (user / assistant) message — acts as a turn boundary.
+        const role = msg.role === "assistant" ? "model" : msg.role;
+        if (role !== "user" && role !== "model") {
             continue;
         }
-        contents.push({
-            role: msg.role === "assistant" ? "model" : "user",
-            parts: [{ text }],
-        });
+        if (!msg.content || msg.content.trim().length === 0) {
+            continue;
+        }
+        // Increment turn counter BEFORE pushing the segment so any tool_calls
+        // that follow this message get a fresh (turnCounter, stepIndex) namespace.
+        turnCounter++;
+        const textPart = { text: msg.content };
+        if (msg.metadata?.thoughtSignature) {
+            textPart.thoughtSignature = msg.metadata.thoughtSignature;
+        }
+        segments.push({ type: "regular", role, parts: [textPart] });
+    }
+    // Emit in order: each ToolStep → model turn (calls) + user turn (results)
+    // — same ordering @google/genai's automaticFunctionCalling produces.
+    for (const seg of segments) {
+        if (seg.type === "regular") {
+            contents.push({ role: seg.role, parts: seg.parts });
+            continue;
+        }
+        if (seg.callParts.length === 0) {
+            if (seg.resultParts.length > 0) {
+                logger.debug("[GoogleNativeGemini3] Dropping orphan tool_result segment with no matching tool_call rows", { resultCount: seg.resultParts.length });
+            }
+            continue;
+        }
+        contents.push({ role: "model", parts: seg.callParts });
+        if (seg.resultParts.length > 0) {
+            contents.push({ role: "user", parts: seg.resultParts });
+        }
     }
 }
 /**