npm - @jupyterlab/notebook-extension - Versions diffs - 4.6.2 → 4.6.3 - Mend

@jupyterlab/notebook-extension 4.6.2 → 4.6.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (8) hide show

package/lib/index.js +10 -4
package/lib/index.js.map +1 -1
package/lib/tool-widgets/activeCellToolWidget.d.ts +40 -2
package/lib/tool-widgets/activeCellToolWidget.js +160 -29
package/lib/tool-widgets/activeCellToolWidget.js.map +1 -1
package/package.json +31 -31
package/src/index.ts +10 -4
package/src/tool-widgets/activeCellToolWidget.tsx +187 -38

package/lib/index.js CHANGED Viewed

@@ -811,12 +811,18 @@ const activeCellTool = {
     activate: (
     // Register the custom field.
     app, tracker, formRegistry, languages) => {
+        // The field renderer is used by rjsf as a React component, so it runs on
+        // every rebuild of the metadata form. The tool is created once and reused:
+        // constructing one per render would rebuild the prompt and the preview from
+        // scratch (showing them empty until the next update) and would leave a
+        // connection to the cell model behind for every abandoned instance.
+        const tool = new ActiveCellTool({
+            tracker,
+            languages
+        });
         const component = {
             fieldRenderer: (props) => {
-                return new ActiveCellTool({
-                    tracker,
-                    languages
-                }).render(props);
+                return tool.render(props);
             }
         };
         formRegistry.addRenderer('@jupyterlab/notebook-extension:active-cell-tool.renderer', component);