@jupyterlab/notebook-extension 4.6.1 → 4.6.3

package/lib/index.js

@@ -811,12 +811,18 @@ const activeCellTool = {
     activate: (
     // Register the custom field.
     app, tracker, formRegistry, languages) => {
+        // The field renderer is used by rjsf as a React component, so it runs on
+        // every rebuild of the metadata form. The tool is created once and reused:
+        // constructing one per render would rebuild the prompt and the preview from
+        // scratch (showing them empty until the next update) and would leave a
+        // connection to the cell model behind for every abandoned instance.
+        const tool = new ActiveCellTool({
+            tracker,
+            languages
+        });
         const component = {
             fieldRenderer: (props) => {
-                return new ActiveCellTool({
-                    tracker,
-                    languages
-                }).render(props);
+                return tool.render(props);
             }
         };
         formRegistry.addRenderer('@jupyterlab/notebook-extension:active-cell-tool.renderer', component);
@@ -1561,13 +1567,17 @@ function activateNotebookHandler(app, factory, extensions, executor, palette, de
         setSideBySideOutputRatio(factory.notebookConfig.sideBySideOutputRatio);
         const sideBySideMarginStyle = `.jp-mod-sideBySide.jp-Notebook .jp-Notebook-cell {
       margin-left: ${factory.notebookConfig.sideBySideLeftMarginOverride} !important;
-      margin-right: ${factory.notebookConfig.sideBySideRightMarginOverride} !important;`;
+      margin-right: ${factory.notebookConfig.sideBySideRightMarginOverride} !important;
+    }`;
         const sideBySideMarginTag = document.getElementById(SIDE_BY_SIDE_STYLE_ID);
         if (sideBySideMarginTag) {
-            sideBySideMarginTag.innerText = sideBySideMarginStyle;
+            sideBySideMarginTag.textContent = sideBySideMarginStyle;
         }
         else {
-            document.head.insertAdjacentHTML('beforeend', `<style id="${SIDE_BY_SIDE_STYLE_ID}">${sideBySideMarginStyle}}</style>`);
+            const style = document.createElement('style');
+            style.id = SIDE_BY_SIDE_STYLE_ID;
+            style.textContent = sideBySideMarginStyle;
+            document.head.appendChild(style);
         }
         factory.autoStartDefault = settings.get('autoStartDefaultKernel')
             .composite;