@jupyterlab/debugger 4.6.0-alpha.2 → 4.6.0-alpha.4

package/src/panels/callstack/model.ts

@@ -1,12 +1,13 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
 import { DebuggerDisplayRegistry } from '../../displayregistry';
-import { IDebugger, IDebuggerDisplayRegistry } from '../../tokens';
-import { INotebookTracker } from '@jupyterlab/notebook';
-import { IConsoleTracker } from '@jupyterlab/console';
+import type { IDebugger, IDebuggerDisplayRegistry } from '../../tokens';
+import type { INotebookTracker } from '@jupyterlab/notebook';
+import type { IConsoleTracker } from '@jupyterlab/console';
 /**
  * A model for a callstack.
  */

package/src/panels/kernelSources/body.tsx

@@ -13,10 +13,11 @@ import {
 
 import { showErrorMessage } from '@jupyterlab/apputils';
 
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
-import { IDebugger } from '../../tokens';
-import { IRenderMime } from '@jupyterlab/rendermime';
+import type { IDebugger } from '../../tokens';
+import type { IRenderMime } from '@jupyterlab/rendermime';
 
 /**
  * The class for each source row.

package/src/panels/kernelSources/filter.tsx

@@ -5,10 +5,10 @@ import { UseSignal } from '@jupyterlab/ui-components';
 
 import React from 'react';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 import { Search } from '@jupyter/react-components';
-import { TranslationBundle } from '@jupyterlab/translation';
+import type { TranslationBundle } from '@jupyterlab/translation';
 
 /**
  * The class name added to the filebrowser crumbs node.

package/src/panels/kernelSources/index.tsx

@@ -3,7 +3,8 @@
 import * as React from 'react';
 import { ReactWidget } from '@jupyterlab/apputils';
 
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
 import { showErrorMessage } from '@jupyterlab/apputils';
 
@@ -13,7 +14,7 @@ import {
   ToolbarButton
 } from '@jupyterlab/ui-components';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 import { KernelSourcesBody } from './body';
 import { KernelSourcesFilter } from './filter';

package/src/panels/kernelSources/model.ts

@@ -1,11 +1,12 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
 import { Debouncer } from '@lumino/polling';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 /**
  * The rate limit for the filter debouncer

package/src/panels/sources/body.ts

@@ -1,7 +1,10 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { CodeEditorWrapper, IEditorServices } from '@jupyterlab/codeeditor';
+import type {
+  CodeEditorWrapper,
+  IEditorServices
+} from '@jupyterlab/codeeditor';
 
 import { Signal } from '@lumino/signaling';
 
@@ -11,7 +14,7 @@ import { Debugger } from '../..';
 
 import { EditorHandler } from '../../handlers/editor';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 /**
  * The body for a Sources Panel.

package/src/panels/sources/index.tsx

@@ -3,8 +3,9 @@
 | Distributed under the terms of the Modified BSD License.
 |----------------------------------------------------------------------------*/
 
-import { IEditorServices } from '@jupyterlab/codeeditor';
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { IEditorServices } from '@jupyterlab/codeeditor';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 import {
   PanelWithToolbar,
   ReactWidget,
@@ -12,7 +13,7 @@ import {
   viewBreakpointIcon
 } from '@jupyterlab/ui-components';
 import React from 'react';
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 import { SourcesBody } from './body';
 import { SourcePathComponent } from './sourcepath';
 

package/src/panels/sources/model.ts

@@ -1,11 +1,12 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
 import { DebuggerDisplayRegistry } from '../../displayregistry';
-import { IDebugger, IDebuggerDisplayRegistry } from '../../tokens';
-import { IEditorMimeTypeService } from '@jupyterlab/codeeditor';
+import type { IDebugger, IDebuggerDisplayRegistry } from '../../tokens';
+import type { IEditorMimeTypeService } from '@jupyterlab/codeeditor';
 
 /**
  * The model to keep track of the current source being displayed.

package/src/panels/sources/sourcepath.tsx

@@ -2,9 +2,9 @@
 // Distributed under the terms of the Modified BSD License.
 
 import { UseSignal } from '@jupyterlab/ui-components';
-import { TranslationBundle } from '@jupyterlab/translation';
+import type { TranslationBundle } from '@jupyterlab/translation';
 import React from 'react';
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 /**
  * A React component to display the path to a source.

package/src/panels/variables/grid.ts

@@ -1,17 +1,17 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { IThemeManager } from '@jupyterlab/apputils';
+import type { IThemeManager } from '@jupyterlab/apputils';
 
-import { ITranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
 
-import { CommandRegistry } from '@lumino/commands';
+import type { CommandRegistry } from '@lumino/commands';
 
-import { Message } from '@lumino/messaging';
+import type { Message } from '@lumino/messaging';
 
 import { Panel } from '@lumino/widgets';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 import type * as GridPanelModule from './gridpanel';
 

package/src/panels/variables/gridpanel.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { CommandRegistry } from '@lumino/commands';
+import type { CommandRegistry } from '@lumino/commands';
 import {
   BasicKeyHandler,
   BasicMouseHandler,
@@ -10,17 +10,15 @@ import {
   DataModel,
   TextRenderer
 } from '@lumino/datagrid';
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 import { Panel } from '@lumino/widgets';
 
-import { IThemeManager } from '@jupyterlab/apputils';
-import {
-  ITranslator,
-  nullTranslator,
-  TranslationBundle
-} from '@jupyterlab/translation';
+import type { IThemeManager } from '@jupyterlab/apputils';
+import type { ITranslator, TranslationBundle } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 import { Debugger } from '../../';
 
 /**
@@ -344,7 +342,10 @@ namespace Private {
     node = palette.querySelector('.jp-mod-selection');
     const selectionFillColor = getComputedStyle(node!).color;
     node = palette.querySelector('.jp-mod-text');
-    const textColor = getComputedStyle(node!).color;
+    const textStyle = getComputedStyle(node!);
+    const textColor = textStyle.color;
+    const fontFamily = textStyle.fontFamily;
+    const fontSize = textStyle.fontSize;
     document.body.removeChild(palette);
     return {
       style: {
@@ -358,7 +359,7 @@ namespace Private {
         selectionFillColor
       },
       textRenderer: new TextRenderer({
-        font: '12px sans-serif',
+        font: `${fontSize} ${fontFamily}`,
         textColor,
         backgroundColor: '',
         verticalAlignment: 'center',

package/src/panels/variables/index.ts

@@ -1,17 +1,18 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { IThemeManager } from '@jupyterlab/apputils';
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { IThemeManager } from '@jupyterlab/apputils';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 import {
   PanelWithToolbar,
   tableRowsIcon,
   ToolbarButton,
   treeViewIcon
 } from '@jupyterlab/ui-components';
-import { CommandRegistry } from '@lumino/commands';
-import { Panel, Widget } from '@lumino/widgets';
-import { IDebugger } from '../../tokens';
+import type { CommandRegistry } from '@lumino/commands';
+import type { Panel, Widget } from '@lumino/widgets';
+import type { IDebugger } from '../../tokens';
 import { VariablesBodyGrid } from './grid';
 import { ScopeSwitcher } from './scope';
 import { VariablesBodyTree } from './tree';
@@ -141,6 +142,7 @@ export class Variables extends PanelWithToolbar {
  */
 export const convertType = (variable: IDebugger.IVariable): string | number => {
   const { type, value } = variable;
+  // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check
   switch (type) {
     case 'int':
       return parseInt(value, 10);

package/src/panels/variables/mimerenderer.ts

@@ -4,16 +4,14 @@
  */
 
 import { MainAreaWidget } from '@jupyterlab/apputils';
-import { IRenderMimeRegistry, MimeModel } from '@jupyterlab/rendermime';
-import {
-  ITranslator,
-  nullTranslator,
-  TranslationBundle
-} from '@jupyterlab/translation';
+import type { IRenderMimeRegistry } from '@jupyterlab/rendermime';
+import { MimeModel } from '@jupyterlab/rendermime';
+import type { ITranslator, TranslationBundle } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 import { PromiseDelegate } from '@lumino/coreutils';
 import { Panel } from '@lumino/widgets';
 import { murmur2 } from '../../hash';
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 const RENDERER_PANEL_CLASS = 'jp-VariableRendererPanel';
 const RENDERER_PANEL_RENDERER_CLASS = 'jp-VariableRendererPanel-renderer';

package/src/panels/variables/model.ts

@@ -1,9 +1,10 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
 /**
  * A model for a variable explorer.

package/src/panels/variables/scope.tsx

@@ -3,16 +3,13 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
-import {
-  ITranslator,
-  nullTranslator,
-  TranslationBundle
-} from '@jupyterlab/translation';
+import type { ITranslator, TranslationBundle } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 import { HTMLSelect, ReactWidget, UseSignal } from '@jupyterlab/ui-components';
 import React, { useState } from 'react';
-import { IDebugger } from '../../tokens';
-import { VariablesBodyGrid } from './grid';
-import { VariablesBodyTree } from './tree';
+import type { IDebugger } from '../../tokens';
+import type { VariablesBodyGrid } from './grid';
+import type { VariablesBodyTree } from './tree';
 
 /**
  * A React component to handle scope changes.

package/src/panels/variables/tree.tsx

@@ -1,7 +1,8 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
 import {
   getTreeItemElement,
@@ -13,9 +14,9 @@ import { Button, TreeItem, TreeView } from '@jupyter/react-components';
 
 import { ArrayExt } from '@lumino/algorithm';
 
-import { CommandRegistry } from '@lumino/commands';
+import type { CommandRegistry } from '@lumino/commands';
 
-import { DebugProtocol } from '@vscode/debugprotocol';
+import type { DebugProtocol } from '@vscode/debugprotocol';
 
 import React, { useCallback, useEffect, useMemo, useState } from 'react';
 
@@ -23,9 +24,9 @@ import { convertType } from '.';
 
 import { Debugger } from '../../debugger';
 
-import { IDebugger } from '../../tokens';
+import type { IDebugger } from '../../tokens';
 
-import { VariablesModel } from './model';
+import type { VariablesModel } from './model';
 
 /**
  * The body for tree of variables.
@@ -367,7 +368,7 @@ const VariableComponent = (props: IVariableComponentProps): JSX.Element => {
       }}
     >
       <span className="jp-DebuggerVariables-name">{variable.name}</span>
-      {details && (
+      {details != null && (
         <span className="jp-DebuggerVariables-detail">{details}</span>
       )}
       {hasMimeRenderer && showDetailsButton && (

package/src/service.ts

@@ -1,27 +1,25 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { KernelSpec, Session } from '@jupyterlab/services';
+import type { KernelSpec, Session } from '@jupyterlab/services';
 
-import {
-  ITranslator,
-  nullTranslator,
-  TranslationBundle
-} from '@jupyterlab/translation';
+import type { ITranslator, TranslationBundle } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
-import { IDisposable } from '@lumino/disposable';
+import type { IDisposable } from '@lumino/disposable';
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
-import { DebugProtocol } from '@vscode/debugprotocol';
+import type { DebugProtocol } from '@vscode/debugprotocol';
 
 import { Debugger } from './debugger';
 
-import { VariablesModel } from './panels/variables/model';
+import type { VariablesModel } from './panels/variables/model';
 
-import { IDebugger } from './tokens';
-import { IDebuggerDisplayRegistry } from './tokens';
-import { IEditorMimeTypeService } from '@jupyterlab/codeeditor';
+import type { IDebugger } from './tokens';
+import type { IDebuggerDisplayRegistry } from './tokens';
+import type { IEditorMimeTypeService } from '@jupyterlab/codeeditor';
 
 /**
  * A concrete implementation of the IDebugger interface.
@@ -167,7 +165,7 @@ export class DebuggerService implements IDebugger, IDisposable {
    * Whether there exists a thread in stopped state.
    */
   hasStoppedThreads(): boolean {
-    return this._model?.stoppedThreads.size > 0 ?? false;
+    return this._model.stoppedThreads.size > 0;
   }
 
   /**
@@ -218,12 +216,12 @@ export class DebuggerService implements IDebugger, IDisposable {
       if (!this.session) {
         throw new Error('No active debugger session');
       }
-      await this.session.sendRequest('continue', {
-        threadId: this._currentThread()
-      });
       this._model.stoppedThreads.delete(this._currentThread());
       this._clearModel();
       this._clearSignals();
+      await this.session.sendRequest('continue', {
+        threadId: this._currentThread()
+      });
     } catch (err) {
       console.error('Error:', err.message);
     }

package/src/session.ts

@@ -1,17 +1,19 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { KernelMessage, Session } from '@jupyterlab/services';
+import type { KernelMessage, Session } from '@jupyterlab/services';
 
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
 import { PromiseDelegate } from '@lumino/coreutils';
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal } from '@lumino/signaling';
+import { Signal } from '@lumino/signaling';
 
-import { DebugProtocol } from '@vscode/debugprotocol';
+import type { DebugProtocol } from '@vscode/debugprotocol';
 
-import { IDebugger } from './tokens';
+import type { IDebugger } from './tokens';
 
 /**
  * A concrete implementation of IDebugger.ISession.

package/src/sidebar.ts

@@ -1,11 +1,12 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { IThemeManager } from '@jupyterlab/apputils';
+import type { IThemeManager } from '@jupyterlab/apputils';
 
-import { IEditorServices } from '@jupyterlab/codeeditor';
+import type { IEditorServices } from '@jupyterlab/codeeditor';
 
-import { ITranslator, nullTranslator } from '@jupyterlab/translation';
+import type { ITranslator } from '@jupyterlab/translation';
+import { nullTranslator } from '@jupyterlab/translation';
 
 import { bugIcon, SidePanel } from '@jupyterlab/ui-components';
 
@@ -21,7 +22,7 @@ import { KernelSources as KernelSourcesPanel } from './panels/kernelSources';
 
 import { Variables as VariablesPanel } from './panels/variables';
 
-import { IDebugger } from './tokens';
+import type { IDebugger } from './tokens';
 
 /**
  * A debugger sidebar.

package/src/sources.ts

@@ -1,14 +1,17 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { JupyterFrontEnd } from '@jupyterlab/application';
+import type { JupyterFrontEnd } from '@jupyterlab/application';
 import { DOMUtils, MainAreaWidget, WidgetTracker } from '@jupyterlab/apputils';
-import { CodeEditorWrapper, IEditorServices } from '@jupyterlab/codeeditor';
-import { IConsoleTracker } from '@jupyterlab/console';
-import { IEditorTracker } from '@jupyterlab/fileeditor';
-import { INotebookTracker } from '@jupyterlab/notebook';
+import type {
+  CodeEditorWrapper,
+  IEditorServices
+} from '@jupyterlab/codeeditor';
+import type { IConsoleTracker } from '@jupyterlab/console';
+import type { IEditorTracker } from '@jupyterlab/fileeditor';
+import type { INotebookTracker } from '@jupyterlab/notebook';
 import { textEditorIcon } from '@jupyterlab/ui-components';
-import { IDebugger } from './tokens';
+import type { IDebugger } from './tokens';
 
 /**
  * The source and editor manager for a debugger instance.

package/src/tokens.ts

@@ -1,25 +1,26 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 
-import { CodeEditor, CodeEditorWrapper } from '@jupyterlab/codeeditor';
+import type { CodeEditor, CodeEditorWrapper } from '@jupyterlab/codeeditor';
 
-import { KernelMessage, Session } from '@jupyterlab/services';
+import type { KernelMessage, Session } from '@jupyterlab/services';
 
-import { ISharedText } from '@jupyter/ydoc';
+import type { ISharedText } from '@jupyter/ydoc';
 
-import { ReadonlyJSONObject, Token } from '@lumino/coreutils';
+import type { ReadonlyJSONObject } from '@lumino/coreutils';
+import { Token } from '@lumino/coreutils';
 
-import { IDisposable, IObservableDisposable } from '@lumino/disposable';
+import type { IDisposable, IObservableDisposable } from '@lumino/disposable';
 
-import { ISignal, Signal } from '@lumino/signaling';
+import type { ISignal, Signal } from '@lumino/signaling';
 
-import { Panel } from '@lumino/widgets';
+import type { Panel } from '@lumino/widgets';
 
-import { DebugProtocol } from '@vscode/debugprotocol';
+import type { DebugProtocol } from '@vscode/debugprotocol';
 
-import { DebuggerHandler } from './handler';
+import type { DebuggerHandler } from './handler';
 
-import { IDebuggerSourceDisplayProvider } from './displayregistry';
+import type { IDebuggerSourceDisplayProvider } from './displayregistry';
 
 /**
  * An interface describing an application's visual debugger.
@@ -758,11 +759,10 @@ export namespace IDebugger {
    * #### Notes
    * This is experimental API
    */
-  export interface IVariableSelection
-    extends Pick<
-      DebugProtocol.Variable,
-      'name' | 'type' | 'variablesReference' | 'value'
-    > {}
+  export interface IVariableSelection extends Pick<
+    DebugProtocol.Variable,
+    'name' | 'type' | 'variablesReference' | 'value'
+  > {}
 
   /**
    * Debugger sidebar interface.

package/style/variables.css

@@ -87,6 +87,8 @@
 
 .jp-DebuggerVariables-colorPalette .jp-mod-text {
   color: var(--jp-content-font-color0);
+  font-family: var(--jp-datagrid-font-family, var(--jp-content-font-family));
+  font-size: var(--jp-datagrid-font-size, 12px);
 }
 
 .jp-VariableRendererPanel {