@jupyterlab/debugger 4.5.0-alpha.4 → 4.5.0-beta.0

package/src/panels/breakpoints/model.ts

@@ -30,6 +30,28 @@ export class BreakpointsModel implements IDebugger.Model.IBreakpoints {
     return this._clicked;
   }
 
+  /**
+   * Signal emitted when the selected breakpoint changes.
+   */
+  get selectedChanged(): Signal<this, IDebugger.IBreakpoint> {
+    return this._selectedChanged;
+  }
+
+  /**
+   * Get selected breakpoint
+   */
+  get selectedBreakpoint(): IDebugger.IBreakpoint {
+    return this._selectedBreakpoint;
+  }
+
+  /**
+   * Set selected breakpoint
+   */
+  set selectedBreakpoint(selected: IDebugger.IBreakpoint) {
+    this._selectedBreakpoint = selected;
+    this._selectedChanged.emit(selected);
+  }
+
   /**
    * Get all the breakpoints.
    */
@@ -71,4 +93,6 @@ export class BreakpointsModel implements IDebugger.Model.IBreakpoints {
   private _changed = new Signal<this, IDebugger.IBreakpoint[]>(this);
   private _restored = new Signal<this, void>(this);
   private _clicked = new Signal<this, IDebugger.IBreakpoint>(this);
+  private _selectedBreakpoint: IDebugger.IBreakpoint;
+  private _selectedChanged = new Signal<this, IDebugger.IBreakpoint>(this);
 }

package/src/service.ts

@@ -256,11 +256,15 @@ export class DebuggerService implements IDebugger, IDisposable {
       expression,
       frameId
     });
+
     if (!reply.success) {
       return null;
     }
+
+    // TODO - Should this be here?
+    this._model.variables.scopes = [];
+
     // get the frames to retrieve the latest state of the variables
-    this._clearModel();
     await this._getAllFrames();
 
     return reply.body;
@@ -593,7 +597,6 @@ export class DebuggerService implements IDebugger, IDisposable {
 
     // Update the local model and finish kernel configuration.
     this._model.breakpoints.setBreakpoints(path, updatedBreakpoints);
-    await this.session.sendRequest('configurationDone', {});
   }
 
   /**

package/src/tokens.ts

@@ -855,6 +855,16 @@ export namespace IDebugger {
        */
       readonly restored: ISignal<this, void>;
 
+      /**
+       * Signal emitted when the breakpoints are restored.
+       */
+      readonly selectedChanged: Signal<this, IDebugger.IBreakpoint>;
+
+      /**
+       * Selected breakpoint
+       */
+      selectedBreakpoint: IDebugger.IBreakpoint | null;
+
       /**
        * Get the breakpoints for a given id (path).
        *

package/style/breakpoints.css

@@ -18,6 +18,7 @@
 .jp-DebuggerBreakpoint {
   display: flex;
   align-items: center;
+  height: 24px;
 }
 
 .jp-DebuggerBreakpoint:hover {
@@ -25,11 +26,12 @@
   cursor: pointer;
 }
 
-.jp-DebuggerBreakpoint-marker {
-  font-size: 20px;
-  padding-right: 5px;
-  content: '●';
-  color: var(--jp-error-color1);
+.jp-DebuggerBreakpoint-container {
+  height: 24px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+  margin-right: 10px;
 }
 
 .jp-DebuggerBreakpoint-source {
@@ -56,7 +58,6 @@
 }
 
 [data-jp-debugger='true'] .cm-breakpoint-gutter .cm-gutterElement:empty::after {
-  content: '●';
   color: var(--jp-error-color1);
   opacity: 0;
 }
@@ -66,11 +67,8 @@
 }
 
 .cm-breakpoint-gutter .cm-gutterElement {
-  color: var(--jp-error-color1);
-  padding-left: 5px;
-  font-size: 20px;
-  position: relative;
-  top: -5px;
+  padding-top: 1.1px;
+  height: 18.2px;
 }
 
 [data-jp-debugger='true'].jp-Editor