@jupyter-notebook/terminal-extension 7.0.3 → 7.0.4

package/lib/index.js

@@ -1,8 +1,9 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
 import { IRouter, } from '@jupyterlab/application';
-import { PageConfig } from '@jupyterlab/coreutils';
+import { PageConfig, URLExt } from '@jupyterlab/coreutils';
 import { ITerminalTracker } from '@jupyterlab/terminal';
+import { INotebookPathOpener, defaultNotebookPathOpener, } from '@jupyter-notebook/application';
 import { find } from '@lumino/algorithm';
 /**
  * A plugin to open terminals in a new tab
@@ -41,9 +42,11 @@ const opener = {
 const redirect = {
     id: '@jupyter-notebook/terminal-extension:redirect',
     requires: [ITerminalTracker],
+    optional: [INotebookPathOpener],
     autoStart: true,
-    activate: (app, tracker) => {
+    activate: (app, tracker, notebookPathOpener) => {
         const baseUrl = PageConfig.getBaseUrl();
+        const opener = notebookPathOpener !== null && notebookPathOpener !== void 0 ? notebookPathOpener : defaultNotebookPathOpener;
         tracker.widgetAdded.connect((send, terminal) => {
             const widget = find(app.shell.widgets('main'), (w) => w.id === terminal.id);
             if (widget) {
@@ -51,7 +54,11 @@ const redirect = {
                 return;
             }
             const name = terminal.content.session.name;
-            window.open(`${baseUrl}terminals/${name}`, '_blank');
+            opener.open({
+                prefix: URLExt.join(baseUrl, 'terminals'),
+                path: name,
+                target: '_blank',
+            });
             // dispose the widget since it is not used on this page
             terminal.dispose();
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jupyter-notebook/terminal-extension",
-  "version": "7.0.3",
+  "version": "7.0.4",
   "description": "Jupyter Notebook - Terminal Extension",
   "homepage": "https://github.com/jupyter/notebook",
   "bugs": {
@@ -38,9 +38,10 @@
     "watch": "tsc -b --watch"
   },
   "dependencies": {
-    "@jupyterlab/application": "^4.0.5",
-    "@jupyterlab/coreutils": "^6.0.5",
-    "@jupyterlab/terminal": "^4.0.5",
+    "@jupyter-notebook/application": "^7.0.4",
+    "@jupyterlab/application": "^4.0.6",
+    "@jupyterlab/coreutils": "^6.0.6",
+    "@jupyterlab/terminal": "^4.0.6",
     "@lumino/algorithm": "^2.0.1"
   },
   "devDependencies": {