@jupyter-notebook/application 7.0.0-alpha.12 → 7.0.0-alpha.13

package/lib/panelhandler.d.ts

@@ -60,6 +60,10 @@ export declare class SidePanelHandler extends PanelHandler {
      * Signal fired when a widget is removed from the panel
      */
     get widgetRemoved(): ISignal<SidePanelHandler, Widget>;
+    /**
+     * Get the close button element.
+     */
+    get closeButton(): HTMLButtonElement;
     /**
      * Expand the sidebar.
      *
@@ -118,6 +122,7 @@ export declare class SidePanelHandler extends PanelHandler {
     private _widgetPanel;
     private _currentWidget;
     private _lastCurrentWidget;
+    private _closeButton;
     private _widgetAdded;
     private _widgetRemoved;
 }

package/lib/panelhandler.js

@@ -67,18 +67,19 @@ export class SidePanelHandler extends PanelHandler {
         this._lastCurrentWidget = null;
         this._widgetPanel = new StackedPanel();
         this._widgetPanel.widgetRemoved.connect(this._onWidgetRemoved, this);
-        const closeButton = document.createElement('button');
+        this._closeButton = document.createElement('button');
         closeIcon.element({
-            container: closeButton,
+            container: this._closeButton,
             height: '16px',
             width: 'auto'
         });
-        closeButton.onclick = () => {
+        this._closeButton.onclick = () => {
             this.collapse();
             this.hide();
         };
-        closeButton.className = 'jp-Button jp-SidePanel-collapse';
-        const icon = new Widget({ node: closeButton });
+        this._closeButton.className = 'jp-Button jp-SidePanel-collapse';
+        this._closeButton.title = 'Collapse side panel';
+        const icon = new Widget({ node: this._closeButton });
         this._panel.addWidget(icon);
         this._panel.addWidget(this._widgetPanel);
     }
@@ -126,6 +127,12 @@ export class SidePanelHandler extends PanelHandler {
     get widgetRemoved() {
         return this._widgetRemoved;
     }
+    /**
+     * Get the close button element.
+     */
+    get closeButton() {
+        return this._closeButton;
+    }
     /**
      * Expand the sidebar.
      *

package/lib/shell.d.ts

@@ -1,5 +1,6 @@
 import { JupyterFrontEnd } from '@jupyterlab/application';
 import { DocumentRegistry } from '@jupyterlab/docregistry';
+import { ITranslator } from '@jupyterlab/translation';
 import { Token } from '@lumino/coreutils';
 import { ISignal } from '@lumino/signaling';
 import { Widget } from '@lumino/widgets';
@@ -54,6 +55,11 @@ export declare class NotebookShell extends Widget implements JupyterFrontEnd.ISh
      * Promise that resolves when the main widget is loaded
      */
     get restored(): Promise<void>;
+    /**
+     * Getter and setter for the translator.
+     */
+    get translator(): ITranslator;
+    set translator(value: ITranslator);
     /**
      * Activate a widget in its area.
      */
@@ -108,6 +114,7 @@ export declare class NotebookShell extends Widget implements JupyterFrontEnd.ISh
     private _rightHandler;
     private _spacer;
     private _main;
+    private _translator;
     private _currentChanged;
     private _mainWidgetLoaded;
 }

package/lib/shell.js

@@ -1,5 +1,6 @@
 // Copyright (c) Jupyter Development Team.
 // Distributed under the terms of the Modified BSD License.
+import { nullTranslator } from '@jupyterlab/translation';
 import { find } from '@lumino/algorithm';
 import { PromiseDelegate, Token } from '@lumino/coreutils';
 import { Signal } from '@lumino/signaling';
@@ -19,6 +20,7 @@ const DEFAULT_RANK = 900;
 export class NotebookShell extends Widget {
     constructor() {
         super();
+        this._translator = nullTranslator;
         this._currentChanged = new Signal(this);
         this._mainWidgetLoaded = new PromiseDelegate();
         this.id = 'main';
@@ -30,8 +32,11 @@ export class NotebookShell extends Widget {
         const topWrapper = (this._topWrapper = new Panel());
         const menuWrapper = (this._menuWrapper = new Panel());
         this._topHandler.panel.id = 'top-panel';
+        this._topHandler.panel.node.setAttribute('role', 'banner');
         this._menuHandler.panel.id = 'menu-panel';
+        this._menuHandler.panel.node.setAttribute('role', 'navigation');
         this._main.id = 'main-panel';
+        this._main.node.setAttribute('role', 'main');
         this._spacer = new Widget();
         this._spacer.id = 'spacer-widget';
         // create wrappers around the top and menu areas
@@ -43,7 +48,9 @@ export class NotebookShell extends Widget {
         const leftHandler = this._leftHandler;
         const rightHandler = this._rightHandler;
         leftHandler.panel.id = 'jp-left-stack';
+        leftHandler.panel.node.setAttribute('role', 'complementary');
         rightHandler.panel.id = 'jp-right-stack';
+        rightHandler.panel.node.setAttribute('role', 'complementary');
         // Hide the side panels by default.
         leftHandler.hide();
         rightHandler.hide();
@@ -134,6 +141,21 @@ export class NotebookShell extends Widget {
     get restored() {
         return this._mainWidgetLoaded.promise;
     }
+    /**
+     * Getter and setter for the translator.
+     */
+    get translator() {
+        var _a;
+        return (_a = this._translator) !== null && _a !== void 0 ? _a : nullTranslator;
+    }
+    set translator(value) {
+        if (value !== this._translator) {
+            this._translator = value;
+            const trans = value.load('notebook');
+            this._leftHandler.closeButton.title = trans.__('Collapse %1 side panel', this._leftHandler.area);
+            this._rightHandler.closeButton.title = trans.__('Collapse %1 side panel', this._rightHandler.area);
+        }
+    }
     /**
      * Activate a widget in its area.
      */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jupyter-notebook/application",
-  "version": "7.0.0-alpha.12",
+  "version": "7.0.0-alpha.13",
   "description": "Jupyter Notebook - Application",
   "homepage": "https://github.com/jupyter/notebook",
   "bugs": {
@@ -43,11 +43,11 @@
     "watch": "tsc -b --watch"
   },
   "dependencies": {
-    "@jupyterlab/application": "^4.0.0-alpha.18",
-    "@jupyterlab/coreutils": "^6.0.0-alpha.18",
-    "@jupyterlab/docregistry": "^4.0.0-alpha.18",
-    "@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.18",
-    "@jupyterlab/ui-components": "^4.0.0-alpha.33",
+    "@jupyterlab/application": "^4.0.0-alpha.19",
+    "@jupyterlab/coreutils": "^6.0.0-alpha.19",
+    "@jupyterlab/docregistry": "^4.0.0-alpha.19",
+    "@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.19",
+    "@jupyterlab/ui-components": "^4.0.0-alpha.34",
     "@lumino/algorithm": "^2.0.0-beta.0",
     "@lumino/coreutils": "^2.0.0-beta.0",
     "@lumino/messaging": "^2.0.0-beta.0",
@@ -58,7 +58,7 @@
   "devDependencies": {
     "@babel/core": "^7.11.6",
     "@babel/preset-env": "^7.12.1",
-    "@jupyterlab/testutils": "^4.0.0-alpha.18",
+    "@jupyterlab/testutils": "^4.0.0-alpha.19",
     "@types/jest": "^29.2.5",
     "jest": "^29.3.1",
     "rimraf": "^3.0.2",