@jupyter-notebook/application-extension 7.0.0-beta.1 → 7.0.0-beta.3

package/lib/index.js

@@ -380,20 +380,23 @@ const topVisibility = {
             execute: () => {
                 top.setHidden(top.isVisible);
                 if (settingRegistry) {
-                    void settingRegistry.set(pluginId, 'visible', top.isVisible);
+                    void settingRegistry.set(pluginId, 'visible', top.isVisible ? 'yes' : 'no');
                 }
             },
             isToggled: () => top.isVisible,
         });
-        let settingsOverride = false;
+        let adjustToScreen = false;
         if (settingRegistry) {
             const loadSettings = settingRegistry.load(pluginId);
             const updateSettings = (settings) => {
-                const visible = settings.get('visible').composite;
+                // 'visible' property from user preferences or default settings
+                let visible = settings.get('visible').composite;
                 if (settings.user.visible !== undefined) {
-                    settingsOverride = true;
-                    top.setHidden(!visible);
+                    visible = settings.user.visible;
                 }
+                top.setHidden(visible === 'no');
+                // adjust to screen from user preferences or default settings
+                adjustToScreen = visible === 'automatic';
             };
             Promise.all([loadSettings, app.restored])
                 .then(([settings]) => {
@@ -410,7 +413,7 @@ const topVisibility = {
             palette.addItem({ command: CommandIDs.toggleTop, category: 'View' });
         }
         const onChanged = () => {
-            if (settingsOverride) {
+            if (!adjustToScreen) {
                 return;
             }
             if (app.format === 'desktop') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jupyter-notebook/application-extension",
-  "version": "7.0.0-beta.1",
+  "version": "7.0.0-beta.3",
   "description": "Jupyter Notebook - Application Extension",
   "homepage": "https://github.com/jupyter/notebook",
   "bugs": {
@@ -38,19 +38,18 @@
     "watch": "tsc -b --watch"
   },
   "dependencies": {
-    "@jupyter-notebook/application": "^7.0.0-beta.1",
-    "@jupyter-notebook/ui-components": "^7.0.0-beta.1",
-    "@jupyterlab/application": "^4.0.0-rc.0",
-    "@jupyterlab/apputils": "^4.0.0-rc.0",
-    "@jupyterlab/celltags": "^4.0.0-alpha.20",
-    "@jupyterlab/codeeditor": "^4.0.0-rc.0",
-    "@jupyterlab/console": "^4.0.0-rc.0",
-    "@jupyterlab/coreutils": "^6.0.0-rc.0",
-    "@jupyterlab/docmanager": "^4.0.0-rc.0",
-    "@jupyterlab/docregistry": "^4.0.0-rc.0",
-    "@jupyterlab/mainmenu": "^4.0.0-rc.0",
-    "@jupyterlab/settingregistry": "^4.0.0-rc.0",
-    "@jupyterlab/translation": "^4.0.0-rc.0",
+    "@jupyter-notebook/application": "^7.0.0-beta.3",
+    "@jupyter-notebook/ui-components": "^7.0.0-beta.3",
+    "@jupyterlab/application": "^4.0.0",
+    "@jupyterlab/apputils": "^4.0.0",
+    "@jupyterlab/codeeditor": "^4.0.0",
+    "@jupyterlab/console": "^4.0.0",
+    "@jupyterlab/coreutils": "^6.0.0",
+    "@jupyterlab/docmanager": "^4.0.0",
+    "@jupyterlab/docregistry": "^4.0.0",
+    "@jupyterlab/mainmenu": "^4.0.0",
+    "@jupyterlab/settingregistry": "^4.0.0",
+    "@jupyterlab/translation": "^4.0.0",
     "@lumino/coreutils": "^2.1.1",
     "@lumino/disposable": "^2.1.1",
     "@lumino/widgets": "^2.1.1"

package/schema/menus.json

@@ -13,6 +13,10 @@
           {
             "command": "notebook:trust",
             "rank": 20
+          },
+          {
+            "command": "application:close",
+            "disabled": true
           }
         ]
       },

package/schema/top.json

@@ -18,10 +18,11 @@
   },
   "properties": {
     "visible": {
-      "type": "boolean",
+      "type": "string",
+      "enum": ["yes", "no", "automatic"],
       "title": "Top Bar Visibility",
-      "description": "Whether to show the top bar or not",
-      "default": true
+      "description": "Whether to show the top bar or not, yes for always showing, no for always not showing, automatic for adjusting to screen size",
+      "default": "automatic"
     }
   },
   "additionalProperties": false,