@jungjaehoon/mama-os 0.22.1 → 0.24.0

package/dist/api/graph-api.js

@@ -29,6 +29,7 @@ const os_1 = __importDefault(require("os"));
 const js_yaml_1 = __importDefault(require("js-yaml"));
 const auth_middleware_js_1 = require("./auth-middleware.js");
 const trusted_proxy_js_1 = require("../security/trusted-proxy.js");
+const types_js_1 = require("../cli/config/types.js");
 const agent_handler_js_1 = require("./agent-handler.js");
 const ui_command_handler_js_1 = require("./ui-command-handler.js");
 const entity_review_handler_js_1 = require("./entity-review-handler.js");
@@ -125,8 +126,8 @@ const codeActRateBuckets = new Map();
 // Model pattern helpers (used in multiple validation functions)
 const isClaudeModel = (model) => /^claude-/i.test(model);
 const isCodexModel = (model) => /^(gpt-|o\d|codex)/i.test(model);
-const supportedManagedBackends = ['claude', 'codex', 'codex-mcp'];
-const isCodexFamilyBackend = (backend) => backend === 'codex' || backend === 'codex-mcp';
+const supportedManagedBackends = ['claude', 'codex'];
+const isCodexFamilyBackend = (backend) => backend === 'codex';
 const VALIDATION_TRIGGER_TYPES = new Set([
     'agent_test',
     'delegate_run',
@@ -136,6 +137,10 @@ const VALIDATION_TRIGGER_TYPES = new Set([
 const isOpus46Model = (model) => /^claude-opus-4-6(?:$|-)/i.test(model) || model.toLowerCase() === 'claude-opus-4-latest';
 const VALID_EFFORT_LEVELS = new Set(['low', 'medium', 'high', 'max']);
 function normalizeLegacyManagedBackend(backend, configPath) {
+    if (typeof backend === 'string' && backend.toLowerCase() === 'codex-mcp') {
+        console.warn(`[GraphAPI] Deprecated backend "codex-mcp" at ${configPath}; using "codex" app-server for compatibility.`);
+        return 'codex';
+    }
     if (typeof backend === 'string' && backend.toLowerCase() === 'gemini') {
         console.warn(`[GraphAPI] Deprecated backend "gemini" at ${configPath}; using "claude" for compatibility.`);
         return 'claude';
@@ -150,6 +155,9 @@ function normalizeLegacyManagedModel(agent, configPath) {
     }
     return false;
 }
+function isLegacyGeminiBackend(backend) {
+    return typeof backend === 'string' && backend.toLowerCase() === 'gemini';
+}
 function isRecord(value) {
     return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
@@ -162,8 +170,11 @@ function migrateLegacyManagedBackends(config) {
         const agent = { ...next.agent };
         const backend = normalizeLegacyManagedBackend(agent.backend, 'agent.backend');
         if (backend !== agent.backend) {
+            const migrateModel = isLegacyGeminiBackend(agent.backend);
             agent.backend = backend;
-            normalizeLegacyManagedModel(agent, 'agent.model');
+            if (migrateModel) {
+                normalizeLegacyManagedModel(agent, 'agent.model');
+            }
             next.agent = agent;
             migrated = true;
         }
@@ -193,7 +204,9 @@ function migrateLegacyManagedBackends(config) {
                 const inheritedBackendWasNormalized = !hasExplicitBackend && normalizedInheritedBackend !== inheritedBackend;
                 if (normalizedBackend !== priorEffectiveBackend || inheritedBackendWasNormalized) {
                     agent.backend = normalizedBackend;
-                    normalizeLegacyManagedModel(agent, `multi_agent.agents.${agentId}.model`);
+                    if (isLegacyGeminiBackend(priorEffectiveBackend)) {
+                        normalizeLegacyManagedModel(agent, `multi_agent.agents.${agentId}.model`);
+                    }
                     agents[agentId] = agent;
                     agentsMigrated = true;
                     migrated = true;
@@ -2384,39 +2397,12 @@ async function handleGetConfigRequest(_req, res) {
                 quiet_start: 23,
                 quiet_end: 8,
             },
-            roles: config.roles || {
-                definitions: {
-                    os_agent: {
-                        model: 'claude-sonnet-4-6',
-                        maxTurns: 20,
-                        allowedTools: ['*'],
-                        systemControl: true,
-                        sensitiveAccess: true,
-                    },
-                    chat_bot: {
-                        model: 'claude-sonnet-4-6',
-                        maxTurns: 10,
-                        allowedTools: [
-                            'mama_search',
-                            'mama_recall',
-                            'context_compile',
-                            'mama_load_checkpoint',
-                            'Read',
-                            'discord_send',
-                        ],
-                        blockedTools: ['Bash', 'Write', 'mama_save', 'mama_update'],
-                        systemControl: false,
-                        sensitiveAccess: false,
-                    },
-                },
-                sourceMapping: {
-                    viewer: 'os_agent',
-                    discord: 'chat_bot',
-                    telegram: 'chat_bot',
-                    slack: 'chat_bot',
-                    chatwork: 'chat_bot',
-                },
-            },
+            roles: config.roles
+                ? {
+                    definitions: { ...types_js_1.DEFAULT_ROLES.definitions, ...config.roles.definitions },
+                    sourceMapping: { ...types_js_1.DEFAULT_ROLES.sourceMapping, ...config.roles.sourceMapping },
+                }
+                : types_js_1.DEFAULT_ROLES,
             multi_agent: config.multi_agent
                 ? {
                     enabled: config.multi_agent.enabled || false,
@@ -2740,7 +2726,7 @@ function validateConfigUpdate(config) {
         }
         if (config.agent.backend &&
             !supportedManagedBackends.includes(String(config.agent.backend).toLowerCase())) {
-            errors.push('agent.backend must be "claude", "codex", or "codex-mcp"');
+            errors.push('agent.backend must be "claude" or "codex"');
         }
         if (config.agent.backend && config.agent.model && typeof config.agent.model === 'string') {
             const backend = String(config.agent.backend).toLowerCase();
@@ -2774,7 +2760,7 @@ function validateConfigUpdate(config) {
             if (backendRaw !== undefined) {
                 const backend = String(backendRaw).toLowerCase();
                 if (!supportedManagedBackends.includes(backend)) {
-                    errors.push(`multi_agent.agents.${agentId}.backend must be "claude", "codex", or "codex-mcp"`);
+                    errors.push(`multi_agent.agents.${agentId}.backend must be "claude" or "codex"`);
                     continue;
                 }
                 if (typeof modelRaw === 'string' && modelRaw.trim()) {
@@ -2790,12 +2776,48 @@ function validateConfigUpdate(config) {
     }
     return errors;
 }
+function canonicalRolesJson(value) {
+    if (Array.isArray(value)) {
+        return `[${value.map(canonicalRolesJson).join(',')}]`;
+    }
+    if (value && typeof value === 'object') {
+        const entries = Object.entries(value)
+            .sort(([a], [b]) => a.localeCompare(b))
+            .map(([k, v]) => `${JSON.stringify(k)}:${canonicalRolesJson(v)}`);
+        return `{${entries.join(',')}}`;
+    }
+    return JSON.stringify(value) ?? 'undefined';
+}
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function saveMAMAConfig(config) {
     const configDir = path_1.default.dirname(MAMA_CONFIG_PATH);
     if (!fs_1.default.existsSync(configDir)) {
         fs_1.default.mkdirSync(configDir, { recursive: true });
     }
+    // Prune role entries identical to shipped defaults (review R3-m1): this UI
+    // save path bypasses config-manager.saveConfig, and without the prune it
+    // would freeze default definitions into config.yaml (B1 silent-death class).
+    if (config.roles && types_js_1.DEFAULT_ROLES) {
+        const definitions = {};
+        for (const [name, def] of Object.entries(config.roles.definitions ?? {})) {
+            const defaultDef = types_js_1.DEFAULT_ROLES.definitions[name];
+            if (!defaultDef || canonicalRolesJson(def) !== canonicalRolesJson(defaultDef)) {
+                definitions[name] = def;
+            }
+        }
+        const sourceMapping = {};
+        for (const [source, role] of Object.entries(config.roles.sourceMapping ?? {})) {
+            if (types_js_1.DEFAULT_ROLES.sourceMapping[source] !== role) {
+                sourceMapping[source] = role;
+            }
+        }
+        if (Object.keys(definitions).length === 0 && Object.keys(sourceMapping).length === 0) {
+            delete config.roles;
+        }
+        else {
+            config.roles = { definitions, sourceMapping };
+        }
+    }
     const content = js_yaml_1.default.dump(config, {
         indent: 2,
         lineWidth: 120,
@@ -3090,7 +3112,7 @@ async function handleMultiAgentUpdateAgentRequest(req, res, pathname, options =
         if (body.backend !== undefined &&
             (typeof body.backend !== 'string' ||
                 !supportedManagedBackends.includes(String(body.backend).toLowerCase()))) {
-            validationErrors.push('backend must be "claude", "codex", or "codex-mcp"');
+            validationErrors.push('backend must be "claude" or "codex"');
         }
         const nextBackend = (body.backend !== undefined ? String(body.backend).toLowerCase() : currentAgent.backend);
         const nextModel = (body.model !== undefined ? body.model : currentAgent.model);