@junctionpanel/server 0.1.56 → 0.1.58

package/dist/server/server/session.js

@@ -109,6 +109,13 @@ function normalizeAgentRunOptions(runOptions) {
         ...(runOptions.extra ? { extra: runOptions.extra } : {}),
     };
 }
+function isLoopbackAddress(remoteAddress) {
+    if (!remoteAddress) {
+        return false;
+    }
+    const normalized = remoteAddress.trim().toLowerCase();
+    return normalized === '127.0.0.1' || normalized === '::1' || normalized === '::ffff:127.0.0.1';
+}
 /**
  * Session represents a single connected client session.
  * It owns all state management, orchestration logic, and message processing.
@@ -135,7 +142,7 @@ export class Session {
         this.checkoutDiffSubscriptions = new Map();
         this.checkoutDiffTargets = new Map();
         this.workspaceGitOperationStates = sharedWorkspaceGitOperationStates;
-        const { clientId, userId, onMessage, onBinaryMessage, onLifecycleIntent, logger, downloadTokenStore, junctionHome, agentManager, agentStorage, createAgentMcpTransport, terminalManager, agentProviderRuntimeSettings, } = options;
+        const { clientId, userId, onMessage, onBinaryMessage, onLifecycleIntent, logger, downloadTokenStore, junctionHome, agentManager, agentStorage, createAgentMcpTransport, terminalManager, agentProviderRuntimeSettings, connectionContext, } = options;
         this.clientId = clientId;
         this.userId = userId;
         this.sessionId = uuidv4();
@@ -148,6 +155,14 @@ export class Session {
         this.agentStorage = agentStorage;
         this.createAgentMcpTransport = createAgentMcpTransport;
         this.terminalManager = terminalManager;
+        this.connectionContext = {
+            clientType: connectionContext?.clientType ?? 'browser',
+            transport: connectionContext?.transport ?? 'direct',
+            host: connectionContext?.host ?? null,
+            origin: connectionContext?.origin ?? null,
+            userAgent: connectionContext?.userAgent ?? null,
+            remoteAddress: connectionContext?.remoteAddress ?? null,
+        };
         if (this.terminalManager) {
             this.unsubscribeTerminalsChanged = this.terminalManager.subscribeTerminalsChanged((event) => this.handleTerminalsChanged(event));
         }
@@ -157,6 +172,9 @@ export class Session {
             module: 'session',
             clientId: this.clientId,
             sessionId: this.sessionId,
+            transport: this.connectionContext.transport,
+            clientType: this.connectionContext.clientType,
+            remoteAddress: this.connectionContext.remoteAddress,
         });
         this.providerRegistry = buildProviderRegistry(this.sessionLogger, {
             runtimeSettings: this.agentProviderRuntimeSettings,
@@ -1119,6 +1137,13 @@ export class Session {
         this.sessionLogger.warn({ streamId: frame.streamId, messageType: frame.messageType }, 'Unhandled terminal binary frame');
     }
     async handleRestartServerRequest(requestId, reason) {
+        this.assertLifecycleControlAllowed('restart', requestId, reason);
+        this.requestServerRestart(requestId, reason, {
+            logLevel: 'warn',
+            logMessage: 'Restart requested via websocket',
+        });
+    }
+    requestServerRestart(requestId, reason, options) {
         const payload = {
             status: 'restart_requested',
             clientId: this.clientId,
@@ -1127,7 +1152,9 @@ export class Session {
             payload.reason = reason;
         }
         payload.requestId = requestId;
-        this.sessionLogger.warn({ reason }, 'Restart requested via websocket');
+        const logLevel = options?.logLevel ?? 'warn';
+        const logMessage = options?.logMessage ?? 'Restart requested';
+        this.sessionLogger[logLevel]({ reason, requestId }, logMessage);
         this.emit({
             type: 'status',
             payload,
@@ -1140,6 +1167,7 @@ export class Session {
         });
     }
     async handleShutdownServerRequest(requestId) {
+        this.assertLifecycleControlAllowed('shutdown', requestId);
         this.sessionLogger.warn('Shutdown requested via websocket');
         this.emit({
             type: 'status',
@@ -1155,6 +1183,25 @@ export class Session {
             requestId,
         });
     }
+    assertLifecycleControlAllowed(action, requestId, reason) {
+        const allowed = this.connectionContext.clientType === 'cli'
+            && this.connectionContext.transport === 'direct'
+            && isLoopbackAddress(this.connectionContext.remoteAddress);
+        if (allowed) {
+            return;
+        }
+        this.sessionLogger.warn({
+            action,
+            requestId,
+            reason: reason ?? null,
+            clientType: this.connectionContext.clientType,
+            transport: this.connectionContext.transport,
+            remoteAddress: this.connectionContext.remoteAddress,
+            host: this.connectionContext.host,
+            origin: this.connectionContext.origin,
+        }, 'Rejected lifecycle request from unauthorized client');
+        throw new SessionRequestError('lifecycle_forbidden', `Only direct localhost CLI sessions can ${action} the daemon.`);
+    }
     emitLifecycleIntent(intent) {
         if (!this.onLifecycleIntent) {
             return;
@@ -2119,7 +2166,10 @@ export class Session {
                     requestId: msg.requestId,
                 },
             });
-            await this.handleRestartServerRequest(msg.requestId, 'settings_update');
+            this.requestServerRestart(msg.requestId, 'settings_update', {
+                logLevel: 'info',
+                logMessage: 'Restart requested after daemon provider settings update',
+            });
         }
         catch (error) {
             this.sessionLogger.error({ err: error, provider: msg.provider }, 'Failed to update daemon provider settings');
@@ -3493,7 +3543,6 @@ export class Session {
                         || includePr
                         || (previousHasLoadedPullRequest && !gitIdentityChanged);
                 target.latestPayloadHasFullGitData = !snapshot.git.isGit || fullGit;
-                this.updateWorkspaceStatusPrPolling(target);
                 const fingerprint = this.workspaceStatusSnapshotFingerprint(snapshot);
                 if (fingerprint !== target.latestFingerprint) {
                     target.latestFingerprint = fingerprint;