@juicesharp/rpiv-voice 1.7.0 → 1.8.1

package/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to `@juicesharp/rpiv-voice` are documented here.
 Format: [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 Versioning: [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.8.1] - 2026-05-17
+
+### Fixed
+- Voice settings now persist to disk before applying in memory, preventing contradictory success/failure notifications on write failure.
+
+## [1.8.0] - 2026-05-16
+
 ## [1.7.0] - 2026-05-15
 
 ## [1.6.1] - 2026-05-14

package/config/voice-config.ts

@@ -1,25 +1,20 @@
 /**
- * voice-config — best-effort persistence of optional rpiv-voice settings
- * (custom model path, named mic device) at `~/.config/rpiv-voice/voice.json`.
+ * voice-config — persistence of optional rpiv-voice settings at
+ * `~/.config/rpiv-voice/voice.json`.
  *
- * Both load and save are crash-resistant: malformed JSON or filesystem errors
- * resolve to "no config". The file is created with 0600 perms because it may
- * one day hold device IDs that the user doesn't want world-readable.
+ * Load is crash-resistant: malformed JSON or missing file resolves to an
+ * empty config (warning emitted via `rpiv-config.loadJsonConfig`).
+ *
+ * Save returns a `boolean`; the caller (voice-session shell) notifies the
+ * user on failure so the UI never lies about persistence ("saved" while the
+ * disk write actually failed). chmod to 0600 is best-effort and never gates
+ * the return — see `rpiv-config.saveJsonConfig` for the full contract.
  */
 
-import { chmodSync, existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
-import { homedir } from "node:os";
-import { dirname, join } from "node:path";
+import { configPath, loadJsonConfig, saveJsonConfig } from "@juicesharp/rpiv-config";
 
 // ── Filesystem layout ────────────────────────────────────────────────────────
-const CONFIG_DIR_NAME = "rpiv-voice";
-const CONFIG_FILE_NAME = "voice.json";
-const CONFIG_DIR = join(homedir(), ".config", CONFIG_DIR_NAME);
-const CONFIG_PATH = join(CONFIG_DIR, CONFIG_FILE_NAME);
-
-// ── Permissions & formatting ─────────────────────────────────────────────────
-const CONFIG_FILE_MODE = 0o600;
-const JSON_INDENT = 2;
+const CONFIG_PATH = configPath("rpiv-voice", "voice.json");
 
 // ── Module-level singleton key (cleared by test/setup beforeEach) ────────────
 const VOICE_STATE_KEY = Symbol.for("rpiv-voice");
@@ -32,9 +27,7 @@ export interface VoiceConfig {
 /**
  * The hallucination filter defaults to ENABLED. We only persist the off-state
  * to keep voice.json minimal, which means "field absent" must be read as
- * "enabled". Centralizing this rule here keeps the three readers in sync —
- * persisted config, pipeline runtime options, and the in-flight settings
- * draft all decode the absence the same way.
+ * "enabled".
  */
 export function isHallucinationFilterEnabled(config: { hallucinationFilterEnabled?: boolean }): boolean {
 	return config.hallucinationFilterEnabled !== false;
@@ -42,36 +35,18 @@ export function isHallucinationFilterEnabled(config: { hallucinationFilterEnable
 
 /**
  * The equalizer defaults to DISABLED. Mirror of the hallucination-filter
- * decoding rule but with the inverted polarity: only the on-state is
- * persisted, "field absent" reads as "disabled".
+ * decoding rule but with the inverted polarity.
  */
 export function isEqualizerEnabled(config: { equalizerEnabled?: boolean }): boolean {
 	return config.equalizerEnabled === true;
 }
 
 export function loadVoiceConfig(): VoiceConfig {
-	if (!existsSync(CONFIG_PATH)) return {};
-	try {
-		const parsed = JSON.parse(readFileSync(CONFIG_PATH, "utf-8")) as unknown;
-		if (parsed === null || typeof parsed !== "object") return {};
-		return parsed as VoiceConfig;
-	} catch {
-		return {};
-	}
+	return loadJsonConfig<VoiceConfig>(CONFIG_PATH);
 }
 
-export function saveVoiceConfig(config: VoiceConfig): void {
-	try {
-		mkdirSync(dirname(CONFIG_PATH), { recursive: true });
-		writeFileSync(CONFIG_PATH, `${JSON.stringify(config, null, JSON_INDENT)}\n`, "utf-8");
-	} catch {
-		// best-effort
-	}
-	try {
-		chmodSync(CONFIG_PATH, CONFIG_FILE_MODE);
-	} catch {
-		// best-effort — perms are advisory; the user's umask still wins.
-	}
+export function saveVoiceConfig(config: VoiceConfig): boolean {
+	return saveJsonConfig(CONFIG_PATH, config);
 }
 
 export function __resetState(): void {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@juicesharp/rpiv-voice",
-	"version": "1.7.0",
+	"version": "1.8.1",
 	"private": false,
 	"description": "Pi extension. Voice dictation via /voice — local on-device STT with sherpa-onnx Whisper (base multilingual int8), microphone capture via decibri.",
 	"keywords": [
@@ -78,6 +78,7 @@
 		]
 	},
 	"dependencies": {
+		"@juicesharp/rpiv-config": "^1.8.1",
 		"sherpa-onnx-node": "^1.13.0",
 		"decibri": "^3.4.0"
 	},

package/state/state-reducer.ts

@@ -16,7 +16,7 @@ export type Effect =
 	| { kind: "stop_mic" }
 	| { kind: "set_pipeline_paused"; paused: boolean }
 	| { kind: "set_hallucination_filter"; enabled: boolean }
-	| { kind: "save_config"; config: VoiceConfig }
+	| { kind: "save_config"; config: VoiceConfig; successMessage?: string }
 	| { kind: "done"; result: VoiceResult };
 
 export interface VoiceResult {
@@ -145,13 +145,21 @@ function stepFocus(current: SettingsFieldKey, delta: 1 | -1): SettingsFieldKey {
 	return order[next] ?? current;
 }
 
+// Success notify is attached to the save_config effect (rather than a separate
+// notify effect) so the imperative shell can fire it ONLY when persistence
+// succeeds. A plain two-effect list ran both notifies unconditionally on
+// failure because `return` inside runEffect()'s switch case exits the method,
+// not the outer effect loop — review I1 caught this.
 const settingsSave: Handler<"settings_save"> = (state, _action, _ctx) => {
 	const config = configFromDraft(state.settingsDraft);
 	return {
 		state,
 		effects: [
-			{ kind: "save_config", config },
-			{ kind: "notify", level: "info", message: t("notify.settings_saved", "Voice settings saved") },
+			{
+				kind: "save_config",
+				config,
+				successMessage: t("notify.settings_saved", "Voice settings saved"),
+			},
 		],
 	};
 };

package/state/voice-session.ts

@@ -11,6 +11,7 @@ import { TranscriptView } from "../view/components/transcript-view.js";
 import { OverlayView } from "../view/overlay-view.js";
 import { VoiceOverlayPropsAdapter } from "../view/props-adapter.js";
 import { DictationScreenStrategy, SettingsScreenStrategy } from "../view/screen-content-strategy.js";
+import { t } from "./i18n-bridge.js";
 import { routeKey, type VoiceAction } from "./key-router.js";
 import {
 	selectEqualizerFieldProps,
@@ -158,7 +159,20 @@ export class VoiceSession {
 				this.deps.setHallucinationFilterEnabled(effect.enabled);
 				return;
 			case "save_config":
-				saveVoiceConfig(effect.config);
+				if (saveVoiceConfig(effect.config)) {
+					// Success notify only fires if the reducer asked for one (Ctrl-S
+					// path); the implicit close_settings save omits the message and
+					// stays silent. Conditional fire-on-success keeps the user out
+					// of the contradictory "Failed … / Saved" state the review caught.
+					if (effect.successMessage) {
+						this.deps.notify(effect.successMessage, "info");
+					}
+				} else {
+					this.deps.notify(
+						t("notify.settings_save_failed", "Failed to save voice settings — change not persisted"),
+						"error",
+					);
+				}
 				return;
 			case "done":
 				this.done(effect.result);