@juicesharp/rpiv-pi 1.8.2 → 1.9.0

package/README.md

@@ -21,7 +21,7 @@ Skill-based development workflow for [Pi Agent](https://github.com/badlogic/pi-m
 
 - **A pipeline of chained AI skills** - discover → research → design → plan → implement → validate, each producing a reviewable artifact under `.rpiv/artifacts/`.
 - **Named subagents for parallel analysis** - `codebase-analyzer`, `codebase-locator`, `codebase-pattern-finder`, `claim-verifier`, and 8 more, dispatched automatically by skills.
-- **Session lifecycle hooks** - agent profiles, guidance files, and pipeline directories scaffold themselves on first launch.
+- **Session lifecycle hooks** - agent profiles and guidance files install themselves on first launch.
 
 ## Prerequisites
 
@@ -93,7 +93,7 @@ pi install npm:@juicesharp/rpiv-pi
 On first Pi Agent session start, rpiv-pi automatically:
 - Copies agent profiles to `~/.pi/agent/agents/` (user-global, shared across all projects)
 - Detects outdated or removed agents on subsequent starts
-- Migrates legacy pipeline-artifact content into `.rpiv/artifacts/` (one-way) and scaffolds the artifact directories
+- Migrates legacy pipeline-artifact content into `.rpiv/artifacts/` (one-way) when an old `thoughts/shared/` tree is found; otherwise `.rpiv/artifacts/` is created lazily by the first skill that writes an artifact
 - Shows a warning if any sibling plugins are missing
 
 ## Usage

package/extensions/rpiv-core/session-hooks.test.ts

@@ -66,23 +66,13 @@ describe("registerSessionHooks — event wiring", () => {
 });
 
 describe("session_start hook — migration", () => {
-	it("scaffolds .rpiv/artifacts/ dirs on fresh project", async () => {
+	it("does NOT create .rpiv/artifacts/ on fresh project (no migration source) — issue #31", async () => {
 		const { pi, captured } = createMockPi({ exec: stubGitExec({}) as never });
 		registerSessionHooks(pi);
 		const handler = captured.events.get("session_start")?.[0];
 		const ctx = createMockCtx({ cwd: projectDir, hasUI: true });
 		await handler?.({ reason: "startup" } as never, ctx as never);
-		for (const d of [
-			".rpiv/artifacts/discover",
-			".rpiv/artifacts/research",
-			".rpiv/artifacts/designs",
-			".rpiv/artifacts/plans",
-			".rpiv/artifacts/handoffs",
-			".rpiv/artifacts/reviews",
-			".rpiv/artifacts/solutions",
-		]) {
-			expect(existsSync(join(projectDir, d))).toBe(true);
-		}
+		expect(existsSync(join(projectDir, ".rpiv", "artifacts"))).toBe(false);
 	});
 
 	it("migrates thoughts/shared/ to .rpiv/artifacts/ with content preservation", async () => {
@@ -124,6 +114,42 @@ describe("session_start hook — migration", () => {
 		expect(existsSync(join(projectDir, "thoughts"))).toBe(true);
 	});
 
+	it("does NOT create .rpiv/artifacts/ when thoughts/shared/ exists but is empty", async () => {
+		// Edge case: thoughts/shared/ pre-exists (created by tool, partial migration, etc.) but holds no entries.
+		// Migration must not leak an empty .rpiv/artifacts/ tree, and must not delete the empty source.
+		mkdirSync(join(projectDir, "thoughts", "shared"), { recursive: true });
+
+		const { pi, captured } = createMockPi({ exec: stubGitExec({}) as never });
+		registerSessionHooks(pi);
+		const handler = captured.events.get("session_start")?.[0];
+		const ctx = createMockCtx({ cwd: projectDir, hasUI: true });
+		await handler?.({ reason: "startup" } as never, ctx as never);
+
+		expect(existsSync(join(projectDir, ".rpiv", "artifacts"))).toBe(false);
+		expect(existsSync(join(projectDir, "thoughts", "shared"))).toBe(true);
+	});
+
+	it("preserves loose files at thoughts/shared/ root (copies them, not just subdirectories)", async () => {
+		// Regression: prior implementation filtered to directories only, dropping loose .md files
+		// at the shared/ root on rmSync. Now cpSync copies both files and directories.
+		const oldShared = join(projectDir, "thoughts", "shared");
+		mkdirSync(oldShared, { recursive: true });
+		writeFileSync(join(oldShared, "loose.md"), "loose content");
+		const oldResearch = join(oldShared, "research");
+		mkdirSync(oldResearch, { recursive: true });
+		writeFileSync(join(oldResearch, "nested.md"), "nested content");
+
+		const { pi, captured } = createMockPi({ exec: stubGitExec({}) as never });
+		registerSessionHooks(pi);
+		const handler = captured.events.get("session_start")?.[0];
+		const ctx = createMockCtx({ cwd: projectDir, hasUI: true });
+		await handler?.({ reason: "startup" } as never, ctx as never);
+
+		expect(existsSync(join(projectDir, ".rpiv", "artifacts", "loose.md"))).toBe(true);
+		expect(existsSync(join(projectDir, ".rpiv", "artifacts", "research", "nested.md"))).toBe(true);
+		expect(existsSync(join(projectDir, "thoughts"))).toBe(false);
+	});
+
 	it("no-ops when thoughts/shared/ does not exist (fresh project)", async () => {
 		const { pi, captured } = createMockPi({ exec: stubGitExec({}) as never });
 		registerSessionHooks(pi);
@@ -131,8 +157,8 @@ describe("session_start hook — migration", () => {
 		const ctx = createMockCtx({ cwd: projectDir, hasUI: true });
 		await handler?.({ reason: "startup" } as never, ctx as never);
 
-		// Artifact dirs created but no thoughts/ tree exists
-		expect(existsSync(join(projectDir, ".rpiv", "artifacts"))).toBe(true);
+		// No migration source → no .rpiv/artifacts/ tree, no thoughts/ tree
+		expect(existsSync(join(projectDir, ".rpiv", "artifacts"))).toBe(false);
 		expect(existsSync(join(projectDir, "thoughts"))).toBe(false);
 	});
 

package/extensions/rpiv-core/session-hooks.ts

@@ -30,17 +30,6 @@ import {
 import { ARTIFACTS_SUBDIR, clearInjectionState, handleToolCallGuidance, injectRootGuidance } from "./guidance.js";
 import { findMissingSiblings } from "./package-checks.js";
 
-const ARTIFACTS_ROOT = `.rpiv/${ARTIFACTS_SUBDIR}`;
-const ARTIFACTS_DIRS = [
-	`${ARTIFACTS_ROOT}/discover`,
-	`${ARTIFACTS_ROOT}/research`,
-	`${ARTIFACTS_ROOT}/designs`,
-	`${ARTIFACTS_ROOT}/plans`,
-	`${ARTIFACTS_ROOT}/handoffs`,
-	`${ARTIFACTS_ROOT}/reviews`,
-	`${ARTIFACTS_ROOT}/solutions`,
-] as const;
-
 const msgAgentsAdded = (n: number) => `Copied ${n} rpiv-pi agent(s) to ~/.pi/agent/agents/`;
 const msgAgentsHealed = (parts: string[]) => `Synced bundled agent(s): ${parts.join(", ")}.`;
 const msgAgentsDrift = (parts: string[]) => `${parts.join(", ")} agent(s). Run /rpiv-update-agents to sync.`;
@@ -135,46 +124,40 @@ function resetInjectionState(): void {
 
 function migrateThoughtsToArtifacts(cwd: string): void {
 	const oldShared = join(cwd, "thoughts", "shared");
-	const newArtifacts = join(cwd, ".rpiv", ARTIFACTS_SUBDIR);
-
-	// Phase 1: Migrate existing thoughts/shared/ → .rpiv/artifacts/
-	if (existsSync(oldShared)) {
-		try {
-			mkdirSync(newArtifacts, { recursive: true });
-
-			const entries = readdirSync(oldShared, { withFileTypes: true }).filter((d) => d.isDirectory());
-
-			for (const entry of entries) {
-				const src = join(oldShared, entry.name);
-				const dest = join(newArtifacts, entry.name);
-				cpSync(src, dest, { recursive: true, errorOnExist: false, force: true });
-				if (!existsSync(dest)) {
-					console.warn(`[rpiv-pi] migration: failed to copy ${src} → ${dest}`);
-					return; // abort — don't delete source if copy failed
-				}
+	if (!existsSync(oldShared)) return;
+
+	try {
+		const entries = readdirSync(oldShared, { withFileTypes: true });
+		if (entries.length === 0) return; // empty source — nothing to copy, leave on disk
+
+		const newArtifacts = join(cwd, ".rpiv", ARTIFACTS_SUBDIR);
+		mkdirSync(newArtifacts, { recursive: true });
+
+		for (const entry of entries) {
+			const src = join(oldShared, entry.name);
+			const dest = join(newArtifacts, entry.name);
+			cpSync(src, dest, { recursive: true, errorOnExist: false, force: true });
+			if (!existsSync(dest)) {
+				console.warn(`[rpiv-pi] migration: failed to copy ${src} → ${dest}`);
+				return; // abort — don't delete source if copy failed
 			}
+		}
 
-			// All copies verified — safe to remove source
-			rmSync(oldShared, { recursive: true, force: true });
-
-			// Remove thoughts/ root only if empty (preserves thoughts/me/ etc.)
-			const thoughtsRoot = join(cwd, "thoughts");
-			try {
-				if (readdirSync(thoughtsRoot).length === 0) {
-					rmSync(thoughtsRoot, { recursive: true, force: true });
-				}
-			} catch {
-				// thoughts/ already gone or unreadable — not an error
+		// All copies verified — safe to remove source
+		rmSync(oldShared, { recursive: true, force: true });
+
+		// Remove thoughts/ root only if empty (preserves thoughts/me/ etc.)
+		const thoughtsRoot = join(cwd, "thoughts");
+		try {
+			if (readdirSync(thoughtsRoot).length === 0) {
+				rmSync(thoughtsRoot, { recursive: true, force: true });
 			}
-		} catch (e) {
-			console.warn(`[rpiv-pi] migration: ${e instanceof Error ? e.message : String(e)}`);
-			// Never crash session_start — migration is best-effort
+		} catch {
+			// thoughts/ already gone or unreadable — not an error
 		}
-	}
-
-	// Phase 2: Ensure artifact directories exist (mirrors old scaffolding)
-	for (const dir of ARTIFACTS_DIRS) {
-		mkdirSync(join(cwd, dir), { recursive: true });
+	} catch (e) {
+		console.warn(`[rpiv-pi] migration: ${e instanceof Error ? e.message : String(e)}`);
+		// Never crash session_start — migration is best-effort
 	}
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@juicesharp/rpiv-pi",
-  "version": "1.8.2",
+  "version": "1.9.0",
   "description": "A skill-based development workflow for Pi Agent. Five skills (research, design, plan, implement, validate) and the shared subagents that compose its ship-loop.",
   "keywords": [
     "pi-package",

package/skills/discover/SKILL.md

@@ -164,7 +164,7 @@ Compile interview output into the FRD. The interview's logical order (problem
    - Timestamp: run `date +"%Y-%m-%dT%H:%M:%S%z"` — raw for `date:` and `last_updated:`, first 19 chars (`T`→`_`, `:`→`-`) for filename slug.
    - Interviewer: from the User in the injected git context (fallback: `unknown`).
 
-2. **Write the FRD** using the Write tool. Frontmatter `status: complete`. All template sections present and filled. The directory `.rpiv/artifacts/discover/` is pre-scaffolded by `session-hooks.ts` — no `mkdir -p` needed in the skill.
+2. **Write the FRD** using the Write tool. Frontmatter `status: complete`. All template sections present and filled. The Write tool creates parent directories automatically — no `mkdir -p` needed in the skill.
 
 3. **Present and chain**:
    ```