@juicesharp/rpiv-pi 1.13.0 → 1.14.0

package/README.md

@@ -121,7 +121,6 @@ Skills compose. Pick the entry point that matches your intent:
 - **Review before shipping** - `/skill:code-review` ↔ `/skill:commit`. Order is your call: review `staged`/`working` before committing to catch issues at the smallest blast radius, or commit first and review the resulting branch (empty scope defaults to feature-branch-vs-default-branch, first-parent). Produces a Quality/Security/Dependencies artifact under `.rpiv/artifacts/reviews/` with claim-verifier-grounded findings and `status: approved | needs_changes`.
 - **Audit a specific scope** - `/skill:code-review <commit|staged|working|hash|A..B|branch>`. Targeted lenses over a commit, range, staged/working tree, or PR branch; advisor adjudication applies when configured (`/advisor`).
 - **Review-driven plan revision** - `/skill:code-review` → `/skill:revise <plan artifact>` → resume `/skill:implement`. When a mid-stream review surfaces structural findings that the existing plan can't absorb as spot fixes.
-- **Scaffold manual UI test specs** - `/skill:outline-test-cases` → `/skill:write-test-cases <feature>`. Outline first via Frontend-First Discovery to map project scope and avoid duplicate coverage, then generate flow-based manual test cases (with a regression suite) under `.rpiv/test-cases/<feature>/`.
 - **Hand off across sessions** - `/skill:create-handoff` → (new session) `/skill:resume-handoff <doc>`. Preserves context when stopping mid-task.
 - **Onboard a fresh repo** - `/skill:annotate-guidance` once, then use the rest of the pipeline normally. Use `annotate-inline` instead if the project follows the `CLAUDE.md` convention.
 
@@ -148,13 +147,6 @@ Invoke via `/skill:<name>` from inside a Pi Agent session.
 | `revise` | Plan artifact | Updated plan | Revise plans based on feedback |
 | `validate` | Plan artifact | Validation report | Verify plan execution |
 
-#### Testing
-
-| Skill | Input | Output | Description |
-|---|---|---|---|
-| `outline-test-cases` | - | `.rpiv/test-cases/` | Discover testable features with per-feature metadata |
-| `write-test-cases` | Outline metadata | Test case specs | Generate manual test specifications |
-
 #### Annotation
 
 | Skill | Input | Output | Description |
@@ -198,7 +190,6 @@ Agents are dispatched automatically by skills via the `Agent` tool - you don't i
 | `integration-scanner` | Maps inbound references, outbound dependencies, config registrations, and event subscriptions for a component |
 | `peer-comparator` | Compares a new file against a peer sibling and tags each invariant Mirrored / Missing / Diverged / Intentionally-absent |
 | `precedent-locator` | Finds similar past changes in git history - commits, blast radius, and follow-up fixes |
-| `test-case-locator` | Catalogs existing manual test cases under `.rpiv/test-cases/` and reports coverage stats |
 | `artifacts-analyzer` | Performs deep-dive analysis on a research topic in `.rpiv/artifacts/` |
 | `artifacts-locator` | Discovers relevant documents in the `.rpiv/artifacts/` directory |
 | `web-search-researcher` | Researches modern web-only information via deep search and fetch |

package/extensions/rpiv-core/artifact-collector.ts

@@ -0,0 +1,111 @@
+/**
+ * rpiv-flavoured artifact collection — the `.rpiv/artifacts/<bucket>/<file>.md`
+ * convention all rpiv-pi skills emit into. This module owns the
+ * convention; the framework (`@juicesharp/rpiv-workflow`) ships only
+ * the primitives (`ArtifactCollector`, `ArtifactParser`, handle
+ * constructors, `defineCollector`, etc.) and stays layout-agnostic.
+ *
+ * Two collectors:
+ *   - `rpivArtifactCollector` — accepts any `.rpiv/artifacts/<bucket>/...md`
+ *     path the agent announces in text (bucket-agnostic). Use when a
+ *     stage may emit to several sibling subfolders.
+ *   - `rpivBucketCollector(bucket)` — accepts only that one bucket's
+ *     paths. Use when the stage MUST land in a specific subfolder
+ *     (`research`, `plans`, etc.) — the collector halts the chain if the
+ *     agent strayed.
+ *
+ * One parser: `frontmatterParser` parses YAML frontmatter from the
+ * primary fs artifact into `Record<string, unknown>` — what
+ * `outputSchema` validates against for typed downstream narrowing.
+ *
+ * Pre-bundled outcome: `rpivArtifactMdOutcome` =
+ * `{ collector: rpivArtifactCollector, parser: frontmatterParser }` —
+ * the default rpiv-pi's built-in workflows wire into every
+ * `produces()` stage.
+ */
+
+import { existsSync, readFileSync } from "node:fs";
+import { isAbsolute, join } from "node:path";
+import { parseFrontmatter } from "@earendil-works/pi-coding-agent";
+import {
+	type ArtifactCollector,
+	type ArtifactParser,
+	defineParser,
+	type OutputSpec,
+	type ParseCtx,
+	transcriptPathCollector,
+} from "@juicesharp/rpiv-workflow";
+
+// ---------------------------------------------------------------------------
+// Collectors — text-scan over assistant transcript
+// ---------------------------------------------------------------------------
+
+const RPIV_ARTIFACT_PATTERN = /\.rpiv\/artifacts\/[\w.-]+\/[\w.-]+\.md/g;
+
+/** Bucket-agnostic — accepts any `.rpiv/artifacts/<bucket>/...md`. */
+export const rpivArtifactCollector: ArtifactCollector = transcriptPathCollector({ pattern: RPIV_ARTIFACT_PATTERN });
+
+/** Bucket-narrowed — accepts only `.rpiv/artifacts/<bucket>/...md`. */
+export function rpivBucketCollector(bucket: string): ArtifactCollector {
+	const escaped = bucket.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+	const pattern = new RegExp(`\\.rpiv/artifacts/${escaped}/[\\w.-]+\\.md`, "g");
+	return transcriptPathCollector({ pattern });
+}
+
+// ---------------------------------------------------------------------------
+// Parser — markdown frontmatter
+// ---------------------------------------------------------------------------
+
+/**
+ * Reads YAML frontmatter from the primary fs artifact. Files without
+ * frontmatter produce `data: {}`. Fatals when the announced path
+ * doesn't exist on disk (the agent claimed to write but didn't).
+ */
+export const frontmatterParser: ArtifactParser<undefined, "artifact-md", Record<string, unknown>> = defineParser({
+	parse(ctx: ParseCtx<undefined>) {
+		const primary = ctx.artifacts[0];
+		if (primary?.handle.kind !== "fs") {
+			return {
+				kind: "fatal",
+				message: `${ctx.skill}: frontmatterParser requires an fs artifact (got ${primary?.handle.kind ?? "none"})`,
+			};
+		}
+		const abs = isAbsolute(primary.handle.path) ? primary.handle.path : join(ctx.cwd, primary.handle.path);
+		if (!existsSync(abs)) {
+			return {
+				kind: "fatal",
+				message: `agent announced ${primary.handle.path} but file does not exist on disk`,
+			};
+		}
+		const content = readFileSync(abs, "utf-8");
+		const { frontmatter } = parseFrontmatter(content);
+		return {
+			kind: "ok",
+			payload: {
+				kind: "artifact-md",
+				data: frontmatter && typeof frontmatter === "object" ? (frontmatter as Record<string, unknown>) : {},
+			},
+		};
+	},
+});
+
+// ---------------------------------------------------------------------------
+// OutputSpec — pre-bundled wiring rpiv-pi workflows plug in
+// ---------------------------------------------------------------------------
+
+/** Default rpiv-pi produces outcome — bucket-agnostic text scan + frontmatter parse. */
+export const rpivArtifactMdOutcome: OutputSpec<unknown, "artifact-md", Record<string, unknown>> = {
+	collector: rpivArtifactCollector,
+	parser: frontmatterParser,
+};
+
+/**
+ * Per-bucket variant — narrows accepted paths to the supplied subfolder
+ * AND publishes the resulting `Output` under `state.named[bucket]` so
+ * downstream stages can reference it via `reads: [bucket, ...]` without
+ * restating the bucket on each producing stage. Multiple stages wiring
+ * the same bucket converge to one named slot (latest entry wins on read).
+ */
+export function rpivBucketOutcome(bucket: string): OutputSpec<unknown, "artifact-md", Record<string, unknown>> {
+	return { name: bucket, collector: rpivBucketCollector(bucket), parser: frontmatterParser };
+}