@juicesharp/rpiv-pi 0.4.0 → 0.4.2

package/README.md

@@ -3,12 +3,12 @@
 [![npm version](https://img.shields.io/npm/v/@juicesharp/rpiv-pi.svg)](https://www.npmjs.com/package/@juicesharp/rpiv-pi)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
-Skill-based development workflow for [Pi](https://github.com/badlogic/pi-mono) — research, design, plan, implement, validate. rpiv-pi extends the Pi coding agent with a pipeline of chained AI skills, named subagents for parallel analysis, and session lifecycle hooks for automatic context injection.
+Skill-based development workflow for [Pi Agent](https://github.com/badlogic/pi-mono) — discover, research, design, plan, implement, and validate. rpiv-pi extends Pi Agent with a pipeline of chained AI skills, named subagents for parallel analysis, and session lifecycle hooks for automatic context injection.
 
 ## Prerequisites
 
-- **[Pi CLI](https://github.com/badlogic/pi-mono)** — the `pi` command must be available
-- **Node.js** — required by Pi
+- **[Pi Agent](https://github.com/badlogic/pi-mono)** — the `pi` command must be available
+- **Node.js** — required by Pi Agent
 - **git** *(recommended)* — rpiv-pi works without it, but branch and commit context won't be available to skills
 
 ## Quick Start
@@ -19,15 +19,47 @@ Skill-based development workflow for [Pi](https://github.com/badlogic/pi-mono)
 pi install npm:@juicesharp/rpiv-pi
 ```
 
-2. Start a Pi session and install sibling plugins:
+2. Configure a model provider (pick one):
+
+   - **Subscription login** — start Pi Agent and run `/login` to authenticate with Anthropic Claude Pro/Max, ChatGPT Plus/Pro, GitHub Copilot, or Gemini.
+   - **BYOK (API key)** — edit `~/.pi/agent/models.json` and add a provider entry with `baseUrl`, `api`, `apiKey`, and `models[]`. Example (z.ai GLM coding plan):
+
+     ```json
+     {
+       "providers": {
+         "zai": {
+           "baseUrl": "https://api.z.ai/api/coding/paas/v4",
+           "api": "openai-completions",
+           "apiKey": "XXXXXXXXX",
+           "compat": {
+             "supportsDeveloperRole": false,
+             "thinkingFormat": "zai"
+           },
+           "models": [
+             {
+               "id": "glm-5.1",
+               "name": "glm-5.1 [coding plan]",
+               "reasoning": true,
+               "input": ["text"],
+               "cost": { "input": 0, "output": 0, "cacheRead": 0, "cacheWrite": 0 },
+               "contextWindow": 204800,
+               "maxTokens": 131072
+             }
+           ]
+         }
+       }
+     }
+     ```
+
+3. Start a Pi Agent session and install sibling plugins:
 
 ```
 /rpiv-setup
 ```
 
-3. Restart your Pi session.
+4. Restart your Pi Agent session.
 
-4. *(Optional)* Configure web search:
+5. *(Optional)* Configure web search:
 
 ```
 /web-search-config
@@ -35,7 +67,7 @@ pi install npm:@juicesharp/rpiv-pi
 
 ### First Session
 
-On first session start, rpiv-pi automatically:
+On first Pi Agent session start, rpiv-pi automatically:
 - Copies agent profiles to `<cwd>/.pi/agents/`
 - Detects outdated or removed agents on subsequent starts
 - Scaffolds `thoughts/shared/` directories for pipeline artifacts
@@ -57,7 +89,7 @@ Each skill produces an artifact consumed by the next. Run them in order, or jump
 
 ### Skills
 
-Invoke via `/skill:<name>` from inside a Pi session.
+Invoke via `/skill:<name>` from inside a Pi Agent session.
 
 #### Research & Design
 
@@ -137,7 +169,7 @@ rpiv-pi/
 └── thoughts/shared/        — pipeline artifact store
 ```
 
-Pi discovers extensions via `"extensions": ["./extensions"]` and skills via `"skills": ["./skills"]` in `package.json`.
+Pi Agent discovers extensions via `"extensions": ["./extensions"]` and skills via `"skills": ["./skills"]` in `package.json`.
 
 ## Configuration
 
@@ -146,22 +178,6 @@ Pi discovers extensions via `"extensions": ["./extensions"]` and skills via `"sk
 - **Agent concurrency** — `@tintinweb/pi-subagents` defaults to 4 concurrent agents; raise via `/agents → Settings → Max concurrency → 48` if skills stall on wide fan-outs
 - **Agent profiles** — editable at `<cwd>/.pi/agents/`; sync from bundled defaults with `/rpiv-update-agents` (overwrites rpiv-managed files, preserves your custom agents)
 
-## Upgrading from 0.3.x
-
-Tool logic was extracted into sibling plugins in 0.4.0. After upgrading:
-
-1. `pi install npm:@juicesharp/rpiv-pi`
-2. Start a Pi session.
-3. Run `/rpiv-setup` to install the four extracted plugins:
-   - `@juicesharp/rpiv-ask-user-question`
-   - `@juicesharp/rpiv-todo`
-   - `@juicesharp/rpiv-advisor`
-   - `@juicesharp/rpiv-web-tools`
-4. Restart the session.
-5. Re-run `/advisor` and `/web-search-config` — saved configuration at `~/.config/rpiv-pi/` is no longer read; each plugin now reads from its own config path.
-
-The `BRAVE_SEARCH_API_KEY` environment variable continues to work unchanged.
-
 ## Troubleshooting
 
 | Symptom | Cause | Fix |

package/extensions/rpiv-core/index.ts

@@ -25,6 +25,7 @@ import {
 	takeGitContextIfChanged,
 } from "./git-context.js";
 import { syncBundledAgents } from "./agents.js";
+import { spawnPiInstall } from "./pi-installer.js";
 import {
 	hasPiSubagentsInstalled,
 	hasRpivAskUserQuestionInstalled,
@@ -238,7 +239,7 @@ export default function (pi: ExtensionAPI) {
 			for (const { pkg } of missing) {
 				ctx.ui.notify(`Installing ${pkg}…`, "info");
 				try {
-					const result = await pi.exec("pi", ["install", pkg], { timeout: 120_000 });
+					const result = await spawnPiInstall(pkg, 120_000);
 					if (result.code === 0) {
 						succeeded.push(pkg);
 					} else {

package/extensions/rpiv-core/pi-installer.ts

@@ -0,0 +1,55 @@
+/**
+ * Windows-safe wrapper around `pi install <pkg>`.
+ *
+ * Pi's own `pi.exec` calls `child_process.spawn(cmd, args, { shell: false })`,
+ * which cannot launch `.cmd`/`.bat` shims on Windows — npm installs `pi` as
+ * `pi.cmd`, so on Windows the spawn ENOENTs silently and the caller sees only
+ * `exit 1`. We side-step it here by invoking via `cmd.exe /c` on Windows.
+ */
+
+import { spawn } from "node:child_process";
+
+export interface PiInstallResult {
+	code: number;
+	stdout: string;
+	stderr: string;
+}
+
+export function spawnPiInstall(pkg: string, timeoutMs: number): Promise<PiInstallResult> {
+	return new Promise((resolve) => {
+		const isWindows = process.platform === "win32";
+		const [cmd, args, spawnOpts] = isWindows
+			? (["cmd.exe", ["/c", "pi", "install", pkg], { windowsHide: true }] as const)
+			: (["pi", ["install", pkg], {}] as const);
+
+		let settled = false;
+		let stdout = "";
+		let stderr = "";
+
+		const proc = spawn(cmd, args, { ...spawnOpts, stdio: ["ignore", "pipe", "pipe"] });
+		proc.stdout?.on("data", (d) => (stdout += d.toString()));
+		proc.stderr?.on("data", (d) => (stderr += d.toString()));
+
+		const settle = (result: PiInstallResult) => {
+			if (settled) return;
+			settled = true;
+			clearTimeout(timer);
+			resolve(result);
+		};
+
+		const timer = setTimeout(() => {
+			proc.kill("SIGTERM");
+			setTimeout(() => {
+				if (!proc.killed) proc.kill("SIGKILL");
+			}, 5000);
+			settle({ code: 124, stdout, stderr: stderr + `\n[timed out after ${timeoutMs}ms]` });
+		}, timeoutMs);
+
+		proc.on("error", (err) => {
+			settle({ code: 1, stdout, stderr: stderr + (stderr ? "\n" : "") + err.message });
+		});
+		proc.on("close", (code) => {
+			settle({ code: code ?? 1, stdout, stderr });
+		});
+	});
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@juicesharp/rpiv-pi",
-  "version": "0.4.0",
-  "description": "Skill-based development workflow for Pi — research, design, plan, implement, review",
+  "version": "0.4.2",
+  "description": "Skill-based development workflow for Pi Agent — discover, research, design, plan, implement, validate",
   "keywords": ["pi-package", "pi-extension", "rpiv", "skills", "workflow"],
   "license": "MIT",
   "author": "juicesharp",