@juicesharp/rpiv-pi 0.12.1 → 0.12.2

package/extensions/subagent-widget/renderer-override.test.ts

@@ -0,0 +1,98 @@
+import type { Theme } from "@mariozechner/pi-coding-agent";
+import { Text } from "@mariozechner/pi-tui";
+import { describe, expect, it, vi } from "vitest";
+
+// Stub the full renderer so the terminal-state branch returns a recognisable sentinel
+// instead of executing nicobailon's real renderer (which needs a full Theme).
+// vi.hoisted is required because vi.mock factories are top-hoisted and can't close
+// over file-level consts.
+const { renderSubagentResultMock } = vi.hoisted(() => ({
+	renderSubagentResultMock: vi.fn(() => ({ __sentinel: "full-render" }) as unknown),
+}));
+vi.mock("pi-subagents/render", () => ({ renderSubagentResult: renderSubagentResultMock }));
+
+import { buildQuietRenderResult } from "./renderer-override.js";
+
+function makeTheme(): Theme {
+	return {
+		fg: (_c: string, t: string) => t,
+		bold: (t: string) => t,
+	} as unknown as Theme;
+}
+
+describe("buildQuietRenderResult — layout-stable quiet card", () => {
+	it("emits ONE Text line when progress.status === 'running'", () => {
+		const render = buildQuietRenderResult();
+		const out = render(
+			{ details: { results: [{ agent: "x", progress: { status: "running" } }] } },
+			{ expanded: false },
+			makeTheme(),
+		);
+		expect(out).toBeInstanceOf(Text);
+		expect(renderSubagentResultMock).not.toHaveBeenCalled();
+	});
+
+	it("emits ONE Text line when progress.status === 'pending'", () => {
+		const render = buildQuietRenderResult();
+		const out = render(
+			{ details: { results: [{ agent: "x", progress: { status: "pending" } }] } },
+			{ expanded: false },
+			makeTheme(),
+		);
+		expect(out).toBeInstanceOf(Text);
+	});
+
+	it("emits ONE Text line when progress is MISSING (pre-progress partial update)", () => {
+		const render = buildQuietRenderResult();
+		// First partialResult often arrives before pi-subagents stamps progress.
+		// Previously fell through to full renderer → N-line card mid-stream →
+		// layout shift → physical-row stacking. Now stays 1-line.
+		const out = render({ details: { results: [{ agent: "x" }] } }, { expanded: false }, makeTheme());
+		expect(out).toBeInstanceOf(Text);
+		expect(renderSubagentResultMock).not.toHaveBeenCalled();
+	});
+
+	it("emits ONE Text line when result.details itself is missing (very first frame)", () => {
+		const render = buildQuietRenderResult();
+		const out = render({}, { expanded: false }, makeTheme());
+		expect(out).toBeInstanceOf(Text);
+	});
+
+	it("delegates to full renderer once exitCode lands (terminal state)", () => {
+		renderSubagentResultMock.mockClear();
+		const render = buildQuietRenderResult();
+		const out = render(
+			{ details: { results: [{ agent: "x", exitCode: 0, progress: { status: "complete" } }] } },
+			{ expanded: false },
+			makeTheme(),
+		);
+		expect(renderSubagentResultMock).toHaveBeenCalledOnce();
+		expect((out as { __sentinel?: string }).__sentinel).toBe("full-render");
+	});
+
+	it("delegates to full renderer on error stopReason", () => {
+		renderSubagentResultMock.mockClear();
+		const render = buildQuietRenderResult();
+		const out = render(
+			{ details: { results: [{ agent: "x", stopReason: "error" }] } },
+			{ expanded: false },
+			makeTheme(),
+		);
+		expect(renderSubagentResultMock).toHaveBeenCalledOnce();
+		expect((out as { __sentinel?: string }).__sentinel).toBe("full-render");
+	});
+
+	it("treats exitCode present + status=running as NON-terminal (streaming finalisation window)", () => {
+		renderSubagentResultMock.mockClear();
+		const render = buildQuietRenderResult();
+		// Mid-transition frames can have exitCode set before progress.status
+		// leaves "running". Should stay quiet until status clears.
+		const out = render(
+			{ details: { results: [{ agent: "x", exitCode: 0, progress: { status: "running" } }] } },
+			{ expanded: false },
+			makeTheme(),
+		);
+		expect(out).toBeInstanceOf(Text);
+		expect(renderSubagentResultMock).not.toHaveBeenCalled();
+	});
+});

package/extensions/subagent-widget/renderer-override.ts

@@ -34,30 +34,45 @@ interface ProgressLike {
 interface ResultLike {
 	agent?: string;
 	progress?: ProgressLike;
+	exitCode?: number;
+	stopReason?: string;
 }
 interface DetailsLike {
 	results?: ResultLike[];
 }
 
-function buildQuietRenderResult(): (
+// Layout-stable quiet card height: while the subagent is non-terminal, emit EXACTLY
+// one `Text` line. If we fell through to the full renderer whenever progress.status
+// was missing (pre-progress partial updates), the card would flip 1-line ↔ N-line
+// every few frames mid-stream — same physical-row-stacking pathology that ghosted
+// the overlay rows before the run-tracker newline fix.
+//
+// Terminal state: exitCode or stopReason is present on the last SingleResult AND
+// progress.status is not in the running set. Anything else is treated as running,
+// including "no progress yet" (status === undefined) and the first tool_execution_*
+// frames before pi-subagents has stamped progress.
+function isTerminal(r: ResultLike | undefined): boolean {
+	if (!r) return false;
+	const status = r.progress?.status;
+	if (status === "pending" || status === "running") return false;
+	return r.exitCode != null || r.stopReason != null;
+}
+
+export function buildQuietRenderResult(): (
 	result: { details?: DetailsLike; content?: Array<{ type: string; text?: string }> },
 	options: { expanded: boolean },
 	theme: Theme,
 ) => unknown {
 	return (result, options, theme) => {
 		const r = result.details?.results?.[0];
-		const status: string | undefined = r?.progress?.status;
-		if (status !== "pending" && status !== "running") {
+		if (isTerminal(r)) {
 			return renderSubagentResult(result, options, theme);
 		}
-		// renderCall already shows "subagent <agent>" above — avoid repeating
-		// the identity. Todo-style glyph + status (single line), directly
-		// under the tool-call header. Glyphs mirror packages/rpiv-todo/
-		// todo-overlay.ts:28-35 for a consistent status language across
-		// overlays.
+		// Non-terminal → single-line status. Renders under the tool-call header,
+		// glyph at column 0 to align with "subagent <agent>" above. Glyphs mirror
+		// packages/rpiv-todo/todo-overlay.ts:28-35 for consistent status language.
+		const status = r?.progress?.status ?? "running";
 		const glyph = status === "pending" ? theme.fg("dim", "○") : theme.fg("warning", "◐");
-		// Glyph at column 0 — aligned directly under the "s" of "subagent"
-		// in the renderCall line above (pi prints that at column 0 too).
 		return new Text(`${glyph} ${theme.fg("muted", status)}`, 0, 0);
 	};
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@juicesharp/rpiv-pi",
-  "version": "0.12.1",
+  "version": "0.12.2",
   "description": "Skill-based development workflow for Pi Agent — discover, research, design, plan, implement, validate",
   "keywords": [
     "pi-package",