@juicesharp/rpiv-pi 0.12.0 → 0.12.1

package/extensions/subagent-widget/run-tracker.test.ts

@@ -199,3 +199,53 @@ describe("run-tracker __resetState", () => {
 		expect(hasAnyVisible()).toBe(false);
 	});
 });
+
+describe("run-tracker newline sanitization", () => {
+	it("collapses embedded newlines in single-mode task descriptions", () => {
+		__resetState();
+		onStart("t1", {
+			agent: "peer-comparator",
+			task: "Peer-mirror check.\n\nPeerPairs (orchestrator-computed):\n[list of tuples]\n\nFor each pair, Read BOTH files.",
+		});
+		const [run] = listRuns();
+		expect(run.description).not.toMatch(/[\r\n]/);
+		expect(run.description.startsWith("Peer-mirror check.")).toBe(true);
+		expect(run.description).toContain("PeerPairs (orchestrator-computed):");
+	});
+
+	it("collapses newlines in displayName too (defensive)", () => {
+		__resetState();
+		onStart("t1", { agent: "weird\nname", task: "x" });
+		const [run] = listRuns();
+		expect(run.displayName).not.toMatch(/[\r\n]/);
+		expect(run.displayName).toBe("weird name");
+	});
+
+	it("sanitizes errorMessage on terminal state", () => {
+		__resetState();
+		onStart("t1", { agent: "x", task: "t" });
+		onEnd(
+			"t1",
+			{
+				details: makeDetails("single", [
+					makeResult({
+						exitCode: 1,
+						stopReason: "error",
+						errorMessage: "boom\nat foo\nat bar",
+					}),
+				]),
+			},
+			true,
+		);
+		const [run] = listRuns();
+		expect(run.errorMessage).not.toMatch(/[\r\n]/);
+		expect(run.errorMessage).toBe("boom at foo at bar");
+	});
+
+	it("preserves single-line descriptions unchanged", () => {
+		__resetState();
+		onStart("t1", { agent: "scout", task: "probe auth module" });
+		const [run] = listRuns();
+		expect(run.description).toBe("probe auth module");
+	});
+});

package/extensions/subagent-widget/run-tracker.ts

@@ -21,6 +21,13 @@ interface SubagentArgs {
 	chain?: Array<{ agent: string; task: string }>;
 }
 
+// Multi-line skill prompts (e.g. peer-comparator with `PeerPairs (orchestrator-computed):` inlined)
+// must not ship embedded newlines into the widget's string[] output — pi-tui tracks logical lines
+// but the terminal splits on \n into physical rows it can't clear, leaving stale duplicate blocks.
+function oneLine(s: string): string {
+	return s.replace(/\s*[\r\n]+\s*/g, " ").trim();
+}
+
 function inferMode(args: SubagentArgs): RunMode {
 	if (args.chain && args.chain.length > 0) return "chain";
 	if (args.tasks && args.tasks.length > 0) return "parallel";
@@ -44,17 +51,17 @@ function deriveDisplay(args: SubagentArgs, mode: RunMode): { displayName: string
 		const steps = args.chain ?? [];
 		return {
 			displayName: `chain (${steps.length} steps)`,
-			description: steps.map((s) => s.agent).join(" → "),
+			description: oneLine(steps.map((s) => s.agent).join(" → ")),
 		};
 	}
 	if (mode === "parallel") {
 		const tasks = args.tasks ?? [];
 		return {
 			displayName: `parallel (${tasks.length} tasks)`,
-			description: tasks[0]?.agent ?? "",
+			description: oneLine(tasks[0]?.agent ?? ""),
 		};
 	}
-	return { displayName: args.agent ?? "subagent", description: args.task ?? "" };
+	return { displayName: oneLine(args.agent ?? "subagent"), description: oneLine(args.task ?? "") };
 }
 
 function deriveTerminalStatus(isError: boolean, results: readonly SingleResult[]): RunStatus {
@@ -107,7 +114,8 @@ export function onEnd(toolCallId: string, result: { details?: SubagentDetails }
 	run.completedAt = Date.now();
 	run.status = deriveTerminalStatus(isError, run.results);
 	const last = run.results[run.results.length - 1];
-	run.errorMessage = last?.errorMessage || (isError ? last?.stderr : undefined) || undefined;
+	const rawErr = last?.errorMessage || (isError ? last?.stderr : undefined) || undefined;
+	run.errorMessage = rawErr ? oneLine(rawErr) : undefined;
 	finishedAge.set(toolCallId, 0);
 }
 

package/extensions/subagent-widget/widget.render.test.ts

@@ -220,3 +220,49 @@ describe("SubagentWidget render — invalidate", () => {
 		expect(captured.length).toBe(2);
 	});
 });
+
+describe("SubagentWidget render — newline safety", () => {
+	it("never emits embedded newlines even with multi-line tasks (running)", () => {
+		onStart("t1", {
+			agent: "peer-comparator",
+			task: "Peer-mirror check.\n\nPeerPairs (orchestrator-computed):\n[list of (new_file, peer_file) tuples]\n\nFor each pair, Read BOTH files in full.",
+		});
+		onUpdate("t1", makeDetails("single", [makeResult()]));
+		const { ctx, captured } = makeUICtx();
+		const lines = renderOnce(new SubagentWidget(), ctx, captured);
+		for (const line of lines) {
+			expect(line).not.toMatch(/[\r\n]/);
+		}
+	});
+
+	it("never emits embedded newlines after the run completes (finished line)", () => {
+		onStart("t1", {
+			agent: "peer-comparator",
+			task: "Peer-mirror check.\n\nPeerPairs (orchestrator-computed):\n[list]",
+		});
+		onEnd("t1", { details: makeDetails("single", [makeResult()]) }, false);
+		const { ctx, captured } = makeUICtx();
+		const lines = renderOnce(new SubagentWidget(), ctx, captured);
+		for (const line of lines) {
+			expect(line).not.toMatch(/[\r\n]/);
+		}
+	});
+
+	it("never emits embedded newlines in error trail", () => {
+		onStart("t1", { agent: "scout", task: "x" });
+		onEnd(
+			"t1",
+			{
+				details: makeDetails("single", [
+					makeResult({ exitCode: 1, stopReason: "error", errorMessage: "boom\nstack\nmore" }),
+				]),
+			},
+			true,
+		);
+		const { ctx, captured } = makeUICtx();
+		const lines = renderOnce(new SubagentWidget(), ctx, captured);
+		for (const line of lines) {
+			expect(line).not.toMatch(/[\r\n]/);
+		}
+	});
+});

package/extensions/subagent-widget/widget.ts

@@ -21,6 +21,10 @@ import type { AgentProgress, SingleResult, TrackedRun } from "./types.js";
 // Strip SGR ANSI escapes to measure visible width for layout math.
 const ANSI_RE = /\x1b\[[0-9;]*m/g;
 const visibleLen = (s: string): number => s.replace(ANSI_RE, "").length;
+// Defensive: any \n in a returned string[] element splits into physical rows pi-tui can't
+// track, leaving stale artifacts every frame. Run-tracker sanitizes at ingest; this guard
+// covers any future caller that mutates description/displayName directly on the tracked run.
+const oneLine = (s: string): string => s.replace(/\s*[\r\n]+\s*/g, " ");
 
 export class SubagentWidget {
 	private uiCtx: ExtensionUIContext | undefined;
@@ -187,10 +191,10 @@ export class SubagentWidget {
 			const total = run.results.length;
 			descriptor = total > 0 ? `${done}/${total} done` : "starting";
 		} else {
-			descriptor = run.description;
+			descriptor = oneLine(run.description);
 		}
 
-		const prefix = `${theme.fg("dim", "├─")} ${theme.fg("accent", frame)} ${theme.bold(run.displayName)}`;
+		const prefix = `${theme.fg("dim", "├─")} ${theme.fg("accent", frame)} ${theme.bold(oneLine(run.displayName))}`;
 		const tail = `${theme.fg("dim", "·")} ${theme.fg("dim", stats)}`;
 		// Overhead: "  " between prefix+descriptor, " " between descriptor+tail.
 		const budget = Math.max(0, width - visibleLen(prefix) - 2 - 1 - visibleLen(tail));
@@ -221,11 +225,11 @@ export class SubagentWidget {
 			trail = theme.fg("warning", " aborted");
 		} else {
 			icon = theme.fg("error", "✗");
-			const msg = run.errorMessage ? `: ${run.errorMessage.slice(0, 60)}` : "";
+			const msg = run.errorMessage ? `: ${oneLine(run.errorMessage).slice(0, 60)}` : "";
 			trail = theme.fg("error", ` error${msg}`);
 		}
 		const body =
-			`${icon} ${theme.fg("dim", run.displayName)}  ${theme.fg("dim", run.description)} ` +
+			`${icon} ${theme.fg("dim", oneLine(run.displayName))}  ${theme.fg("dim", oneLine(run.description))} ` +
 			`${theme.fg("dim", "·")} ${theme.fg("dim", stats)}${trail}`;
 		return truncate(`${theme.fg("dim", "├─")} ${body}`);
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@juicesharp/rpiv-pi",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "Skill-based development workflow for Pi Agent — discover, research, design, plan, implement, validate",
   "keywords": [
     "pi-package",