@juicesharp/rpiv-advisor 1.0.15 → 1.0.17

package/advisor.ts

@@ -61,6 +61,7 @@ const CHECKMARK = " ✓";
 // Messages (static)
 const MSG_ADVISOR_DISABLED = "Advisor disabled";
 const MSG_REQUIRES_INTERACTIVE = "/advisor requires interactive mode";
+const MSG_ADVISOR_NUDGE = "Please advise on the executor's situation above.";
 
 // Errors (static)
 const ERR_NO_MODEL = "No advisor model is configured. The user can enable one with the /advisor command.";
@@ -206,6 +207,23 @@ export function stripInflightAdvisorCall(messages: Message[]): Message[] {
 	return [...messages.slice(0, -1), { ...last, content: filtered }];
 }
 
+// Some providers (recent Anthropic Claude models) reject payloads ending on an
+// assistant turn ("This model does not support assistant message prefill. The
+// conversation must end with a user message."). After stripInflightAdvisorCall
+// the tail can be assistant (e.g. the executor wrote thinking text before
+// calling advisor). Append a minimal user-role nudge to guarantee user-tail.
+export function ensureUserTailForAdvisor(messages: Message[]): Message[] {
+	if (messages.length === 0) return messages;
+	const last = messages[messages.length - 1];
+	if (last.role !== "assistant") return messages;
+	const nudge: Message = {
+		role: "user",
+		content: [{ type: "text", text: MSG_ADVISOR_NUDGE }],
+		timestamp: Date.now(),
+	};
+	return [...messages, nudge];
+}
+
 // Returns `undefined` when the registry is empty (no extensions loaded) so
 // callers can skip prepending an empty block that would still cost a cache unit.
 export function getInventoryMessage(tools: ToolInfo[]): Message | undefined {
@@ -337,7 +355,7 @@ async function executeAdvisor(
 	const agentMessages = branch
 		.filter((e): e is SessionEntry & { type: "message" } => e.type === "message")
 		.map((e) => e.message);
-	const branchMessages = stripInflightAdvisorCall(convertToLlm(agentMessages));
+	const branchMessages = ensureUserTailForAdvisor(stripInflightAdvisorCall(convertToLlm(agentMessages)));
 	const inventoryMessage = getInventoryMessage(pi.getAllTools());
 	const messages: Message[] = inventoryMessage ? [inventoryMessage, ...branchMessages] : branchMessages;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@juicesharp/rpiv-advisor",
-  "version": "1.0.15",
+  "version": "1.0.17",
   "description": "Pi extension: lets the model ask a stronger reviewer model for a second opinion before it acts",
   "keywords": [
     "pi-package",