@jterrazz/typescript 9.3.0 → 10.1.0

package/src/oxlint.test.ts

@@ -1,28 +1,28 @@
 import { expect, test } from 'vitest';
 
-import { compose, defineConfig, expo, hexagonal, next, node } from './oxlint.js';
+import { compose, defineConfig, hexagonal, layers } from './oxlint.js';
 
 test('concatenates and dedupes plugin lists', () => {
-    // Given - two fragments sharing one jsPlugin
+    // Given - two configs sharing one jsPlugin
     const merged = compose(
         { jsPlugins: ['a', 'b'], plugins: ['typescript'] },
         { jsPlugins: ['b', 'c'], plugins: ['typescript', 'import'] },
     );
 
     // Then - order preserved, duplicates dropped
-    expect(merged.jsPlugins).toEqual(['a', 'b', 'c']);
-    expect(merged.plugins).toEqual(['typescript', 'import']);
+    expect(merged.jsPlugins).toStrictEqual(['a', 'b', 'c']);
+    expect(merged.plugins).toStrictEqual(['typescript', 'import']);
 });
 
-test('shallow-merges rules with last fragment winning', () => {
-    // Given - two fragments disagreeing on one rule
+test('shallow-merges rules with the last config winning', () => {
+    // Given - two configs disagreeing on one rule
     const merged = compose(
         { rules: { curly: 'error', 'no-ternary': 'off' } },
         { rules: { curly: 'off', 'jterrazz/b4-given-then': 'error' } },
     );
 
-    // Then - the later fragment wins per key, others survive
-    expect(merged.rules).toEqual({
+    // Then - the later config wins per key, others survive
+    expect(merged.rules).toStrictEqual({
         curly: 'off',
         'jterrazz/b4-given-then': 'error',
         'no-ternary': 'off',
@@ -30,13 +30,13 @@ test('shallow-merges rules with last fragment winning', () => {
 });
 
 test('concatenates overrides in order without deduping', () => {
-    // Given - two fragments each shipping an override
+    // Given - two configs each shipping an override
     const first = { files: ['**/*.specification.ts'], rules: {} };
     const second = { files: ['src/**'], rules: {} };
     const merged = compose({ overrides: [first] }, { overrides: [second] });
 
     // Then - both overrides survive, in composition order
-    expect(merged.overrides).toEqual([first, second]);
+    expect(merged.overrides).toStrictEqual([first, second]);
 });
 
 test('concatenates and dedupes ignorePatterns', () => {
@@ -47,40 +47,94 @@ test('concatenates and dedupes ignorePatterns', () => {
     );
 
     // Then - one entry each
-    expect(merged.ignorePatterns).toEqual(['dist/**', 'node_modules/**', '**/_fixtures/**']);
+    expect(merged.ignorePatterns).toStrictEqual(['dist/**', 'node_modules/**', '**/_fixtures/**']);
 });
 
-test('takes unknown scalar keys from the last fragment', () => {
-    // Given - fragments disagreeing on a scalar key
-    const merged = compose({ somethingElse: 1 }, { somethingElse: 2 });
+test('takes a key the merge tables do not name from the last config that sets it', () => {
+    // Given - configs disagreeing on `categories`, a key the merge tables leave out
+    const merged = compose(
+        { categories: { correctness: 'off' } },
+        { categories: { correctness: 'error' } },
+    );
+
+    /*
+     * No config this package SHIPS carries a `categories` — every rule is
+     * decided by name — and that is exactly why it is the key available here.
+     */
 
-    // Then - last wins
-    expect(merged.somethingElse).toBe(2);
+    // Then - last wins, which is the rule for every key the three tables leave out
+    expect(merged.categories).toStrictEqual({ correctness: 'error' });
 });
 
-test('ignores null and undefined fragments', () => {
-    // Given - a composition with holes (conditional fragments)
+test('ignores null and undefined configs', () => {
+    // Given - a composition with holes (a conditional fragment)
     const merged = compose(
-        undefined as unknown as Record<string, unknown>,
+        // @ts-expect-error - a conditional fragment is undefined at runtime, which the merge must survive
+        undefined,
         { rules: { curly: 'error' } },
-        null as unknown as Record<string, unknown>,
+        null,
     );
 
     // Then - the holes contribute nothing
-    expect(merged.rules).toEqual({ curly: 'error' });
+    expect(merged.rules).toStrictEqual({ curly: 'error' });
+});
+
+test('gives a layer map one override per layer, complete', () => {
+    // Given - a two-layer map
+    const fragment = layers({
+        map: [
+            {
+                deny: ['**/adapters/**'],
+                files: ['**/core/**'],
+                message: 'the core is pure',
+                name: 'core',
+            },
+        ],
+    });
+
+    // Then - the layer's whole pattern list sits inside its own override,
+    // Because an oxlint override REPLACES the base entry and never merges it
+    expect(fragment.overrides).toStrictEqual([
+        {
+            files: ['**/core/**'],
+            rules: {
+                'no-restricted-imports': [
+                    'error',
+                    {
+                        patterns: [{ group: ['**/adapters/**'], message: 'the core is pure' }],
+                    },
+                ],
+            },
+        },
+    ]);
+});
+
+/** A map whose two layers claim the same files — the shape `layers()` refuses. */
+function buildOverlappingMap() {
+    return layers({
+        map: [
+            { deny: ['**/a/**'], files: ['**/same/**'], message: 'a', name: 'first' },
+            { deny: ['**/b/**'], files: ['**/same/**'], message: 'b', name: 'second' },
+        ],
+    });
+}
+
+test('refuses a layer map where one glob belongs to two layers', () => {
+    // Given - two layers claiming the same files
+    // Then - the map is refused rather than silently losing one of the two
+    expect(buildOverlappingMap).toThrow(/belongs to both/u);
 });
 
-test('exports the named presets', () => {
-    // Given - the tool-facing entry
-    // Then - every preset is a config object
-    for (const preset of [node, expo, next, hexagonal]) {
-        expect(typeof preset).toBe('object');
-    }
+test('ships the hexagonal map as six complete overrides', () => {
+    // Given - the default map
+    // Then - one override per layer, and the features carve-out is a negated glob
+    expect(hexagonal.overrides).toHaveLength(6);
+    expect(JSON.stringify(hexagonal.overrides)).toContain('!**/presentation/features/common/**');
 });
 
 test("re-exports oxlint's own defineConfig", () => {
     // Given - a config a consumer would write, with oxlint declared nowhere in its project
-    const config = { rules: { curly: 'error' } };
+    const config = { rules: { curly: 'error' } } as const;
 
     // Then - the entry carries the tool's helper, which returns the config unchanged
     expect(defineConfig(config)).toBe(config);

package/presets/oxlint/architectures/hexagonal-rules.js

@@ -1,39 +0,0 @@
-export default [
-    {
-        from: '/domain/',
-        disallow: [
-            '/application/',
-            '/infrastructure/',
-            '/presentation/',
-            '/di/',
-            '/config/',
-            '/generated/',
-        ],
-        message: 'Domain layer must be pure - cannot import from other layers',
-    },
-    {
-        from: '/application/use-cases/',
-        disallow: ['/infrastructure/', '/presentation/', '/di/'],
-        message: 'Use cases can only depend on domain and ports',
-    },
-    {
-        from: '/application/ports/',
-        disallow: ['/infrastructure/', '/presentation/', '/di/'],
-        message: 'Ports are interfaces - cannot depend on implementations',
-    },
-    {
-        from: '/infrastructure/inbound/',
-        disallow: ['/infrastructure/outbound/'],
-        message: 'Inbound adapters should not import outbound adapters - use DI',
-    },
-    {
-        from: '/presentation/ui/(atoms|molecules)/',
-        disallow: ['/navigation/'],
-        message: 'Atoms and molecules must be pure - no navigation imports',
-    },
-    {
-        from: '/presentation/features/',
-        disallow: ['/presentation/features/(?!common)'],
-        message: 'Features should be independent - use shared code in features/common',
-    },
-];

package/presets/oxlint/architectures/hexagonal.js

@@ -1,13 +0,0 @@
-import { resolve } from 'node:path';
-import { defineConfig } from 'oxlint';
-
-import defaultRules from './hexagonal-rules.js';
-
-const pluginPath = resolve(import.meta.dirname, '../plugins/codestyle.js');
-
-export default defineConfig({
-    jsPlugins: [pluginPath],
-    rules: {
-        'codestyle/arch-hexagonal': ['error', { rules: defaultRules }],
-    },
-});

package/presets/oxlint/base.js

@@ -1,145 +0,0 @@
-import { createRequire } from 'node:module';
-import { defineConfig } from 'oxlint';
-
-const require = createRequire(import.meta.url);
-const perfectionistPath = require.resolve('eslint-plugin-perfectionist');
-
-/*
- * Base lint preset — tooling rules only. Wiring is EXPLICIT: this preset never
- * auto-detects other jterrazz packages. A project using @jterrazz/test composes
- * its `testing` fragment itself:
- *
- *     import { testing } from '@jterrazz/test/oxlint';
- *     import { compose, node } from '@jterrazz/typescript/oxlint';
- *
- *     export default compose(node, testing);
- *
- * (The @jterrazz/test plugin is ESM-only: a CommonJS oxlint config silently
- * drops it — `typescript check` still warns loudly about that pitfall.)
- */
-export default defineConfig({
-    plugins: ['typescript', 'import', 'oxc', 'unicorn'],
-    jsPlugins: [perfectionistPath],
-    categories: {
-        correctness: 'error',
-        suspicious: 'error',
-        perf: 'error',
-        pedantic: 'off',
-        style: 'error',
-        nursery: 'off',
-    },
-    rules: {
-        // ============================================
-        // ENABLED RULES
-        // ============================================
-
-        'no-unused-vars': 'error',
-
-        // -- TypeScript --
-        'typescript/consistent-type-imports': [
-            'error',
-            {
-                disallowTypeAnnotations: true,
-                fixStyle: 'inline-type-imports',
-                prefer: 'type-imports',
-            },
-        ],
-        'typescript/no-unused-expressions': [
-            'error',
-            {
-                allowShortCircuit: true,
-                allowTernary: true,
-                allowTaggedTemplates: true,
-            },
-        ],
-
-        // -- Perfectionist (sorting/ordering) --
-        'perfectionist/sort-heritage-clauses': ['error', { type: 'natural' }],
-        'perfectionist/sort-intersection-types': ['error', { type: 'natural' }],
-        'perfectionist/sort-jsx-props': ['error', { type: 'natural' }],
-        'perfectionist/sort-named-exports': ['error', { type: 'natural' }],
-        'perfectionist/sort-named-imports': ['error', { type: 'natural' }],
-        'perfectionist/sort-union-types': ['error', { type: 'natural' }],
-        'perfectionist/sort-imports': [
-            'error',
-            {
-                type: 'alphabetical',
-                order: 'asc',
-                ignoreCase: true,
-                newlinesBetween: 1,
-                groups: [
-                    ['builtin', 'external'],
-                    'internal',
-                    ['parent', 'sibling', 'index'],
-                    'style',
-                    'unknown',
-                ],
-            },
-        ],
-
-        // ============================================
-        // DISABLED - Conflicts with perfectionist
-        // ============================================
-
-        'sort-keys': 'off',
-        'sort-imports': 'off',
-
-        // ============================================
-        // DISABLED - Too strict / opinionated
-        // ============================================
-
-        'func-style': 'off',
-        'no-magic-numbers': 'off',
-        'no-ternary': 'off',
-        'init-declarations': 'off',
-        'id-length': 'off',
-        'max-statements': 'off',
-        'max-params': 'off',
-        'no-continue': 'off',
-        'arrow-body-style': 'off',
-        'prefer-destructuring': 'off',
-        'new-cap': 'off',
-        'no-await-in-loop': 'off',
-        'typescript/consistent-type-definitions': 'off',
-        'typescript/array-type': 'off',
-        'typescript/no-inferrable-types': 'off',
-        'unicorn/no-null': 'off',
-        'unicorn/no-array-sort': 'off',
-        'import/no-unassigned-import': 'off',
-        'import/no-named-default': 'off',
-        'import/no-nodejs-modules': 'off',
-        // Exports-at-end fights how these files actually read everywhere in
-        // The ecosystem — three repos had disabled it locally (jterrazz-web,
-        // Package-test, package-attestation) before it moved here.
-        'import/exports-last': 'off',
-
-        // ============================================
-        // ENABLED - Code style enforcement
-        // ============================================
-
-        'capitalized-comments': 'error',
-        curly: 'error',
-        'no-nested-ternary': 'error',
-        'unicorn/catch-error-name': 'error',
-        'unicorn/numeric-separators-style': 'error',
-
-        // ============================================
-        // DISABLED - Conflicts with other rules
-        // ============================================
-
-        'import/no-named-export': 'off',
-        'import/consistent-type-specifier-style': 'off',
-        'import/prefer-default-export': 'off',
-        'import/no-default-export': 'off',
-        'import/group-exports': 'off',
-        'import/no-anonymous-default-export': 'off',
-
-        // ============================================
-        // ENABLED - Clean imports
-        // ============================================
-
-        'import/first': 'error',
-        'import/no-namespace': 'error',
-    },
-    ignorePatterns: ['dist/**', 'node_modules/**'],
-});

package/presets/oxlint/expo.js

@@ -1,36 +0,0 @@
-import { resolve } from 'node:path';
-import { defineConfig } from 'oxlint';
-
-import base from './base.js';
-
-const pluginPath = resolve(import.meta.dirname, 'plugins/codestyle.js');
-
-export default defineConfig({
-    extends: [base],
-    plugins: ['typescript', 'import', 'react'],
-    jsPlugins: [pluginPath],
-    // `.expo/` is the toolchain cache and `assets/` is scaffolded by Expo
-    // Itself (icons, splash, fonts) — never source.
-    ignorePatterns: ['dist/**', 'node_modules/**', '.expo/**', 'assets/**'],
-    rules: {
-        'typescript/no-require-imports': [
-            'error',
-            {
-                allow: [
-                    String.raw`\.png$`,
-                    String.raw`\.jpg$`,
-                    String.raw`\.jpeg$`,
-                    String.raw`\.gif$`,
-                    String.raw`\.webp$`,
-                ],
-            },
-        ],
-        'codestyle/imports-without-ext': 'error',
-        'react/react-in-jsx-scope': 'off',
-        'react/jsx-props-no-spreading': 'off',
-        'react/jsx-boolean-value': 'off',
-        'react/jsx-handler-names': 'off',
-        'react/jsx-curly-brace-presence': 'off',
-        'unicorn/no-nested-ternary': 'off',
-    },
-});

package/presets/oxlint/next.js

@@ -1,43 +0,0 @@
-import { resolve } from 'node:path';
-import { defineConfig } from 'oxlint';
-
-import base from './base.js';
-
-const pluginPath = resolve(import.meta.dirname, 'plugins/codestyle.js');
-
-export default defineConfig({
-    extends: [base],
-    plugins: ['typescript', 'import', 'react', 'nextjs'],
-    jsPlugins: [pluginPath],
-    // `public/` is Next's static dir and `assets/` is the stack's convention
-    // For content trees (jterrazz-web: signed attestation bytes live there —
-    // A formatter pass would invalidate every proof). Neither is source.
-    ignorePatterns: [
-        'dist/**',
-        'node_modules/**',
-        '.next/**',
-        'next-env.d.ts',
-        'assets/**',
-        'public/**',
-    ],
-    rules: {
-        'codestyle/imports-without-ext': 'error',
-        'react/react-in-jsx-scope': 'off',
-        'react/jsx-props-no-spreading': 'off',
-        'react/jsx-boolean-value': 'off',
-        'react/jsx-handler-names': 'off',
-        'react/jsx-curly-brace-presence': 'off',
-        'react/jsx-max-depth': 'off',
-        'unicorn/no-nested-ternary': 'off',
-        // -- Rules that fight the Next idiom itself, not bad code --
-        // (import/exports-last is off in base: it fights the whole ecosystem.)
-        // Immutable serialization maps (`.map((x) => ({ ...x, url }))`) are
-        // The dominant React idiom; the Object.assign form is strictly worse
-        // For the build-time collection sizes a site actually maps over.
-        'oxc/no-map-spread': 'off',
-        // Client components are browser-only code that means `window`;
-        // Asking them to say `globalThis` trades clarity for portability
-        // They will never need.
-        'unicorn/prefer-global-this': 'off',
-    },
-});

package/presets/oxlint/node.js

@@ -1,14 +0,0 @@
-import { resolve } from 'node:path';
-import { defineConfig } from 'oxlint';
-
-import base from './base.js';
-
-const pluginPath = resolve(import.meta.dirname, 'plugins/codestyle.js');
-
-export default defineConfig({
-    extends: [base],
-    jsPlugins: [pluginPath],
-    rules: {
-        'codestyle/imports-with-ext': 'error',
-    },
-});