@jterrats/smart-deployment 1.0.5 → 1.1.0

package/lib/dependencies/circular-dependency-detector.js

@@ -12,7 +12,8 @@
  * @issue #30
  */
 import { getLogger } from '../utils/logger.js';
-import { DEFAULT_GRAPH_DEPENDENCY_KIND, shouldTraverseDependencyKind } from './dependency-semantics.js';
+import { generateBreakSuggestions } from './cycle-break-suggestions.js';
+import { CycleDiscovery } from './cycle-discovery.js';
 const logger = getLogger('CircularDependencyDetector');
 /**
  * Circular Dependency Detector
@@ -34,6 +35,7 @@ export class CircularDependencyDetector {
     graph;
     options;
     ignoredEdges;
+    discovery;
     constructor(graph, options = {}) {
         this.graph = graph;
         this.options = {
@@ -43,80 +45,12 @@ export class CircularDependencyDetector {
         };
         // Create set of ignored edges for O(1) lookup
         this.ignoredEdges = new Set(this.options.ignoreEdges.map(({ from, to }) => `${from}->${to}`));
+        this.discovery = new CycleDiscovery(this.graph, this.options.maxDepth, this.ignoredEdges);
         logger.debug('Initialized CircularDependencyDetector', {
             nodes: this.graph.size,
             ignoredEdges: this.ignoredEdges.size,
         });
     }
-    // Private static helper methods
-    /**
-     * Calculate priority for breaking an edge
-     * Higher = better candidate to break
-     */
-    static calculateBreakPriority(from, to) {
-        let priority = 50; // Base priority
-        // Test classes are good candidates to break (they can be deployed separately)
-        if (from.includes('Test') || to.includes('Test')) {
-            priority += 30;
-        }
-        // Utility/helper classes are good candidates
-        if (CircularDependencyDetector.isUtilityClass(from) || CircularDependencyDetector.isUtilityClass(to)) {
-            priority += 20;
-        }
-        // Handler -> Service edges are typically safe to break
-        if (from.includes('Handler') && to.includes('Service')) {
-            priority += 15;
-        }
-        // Controller -> Service edges can be broken
-        if (from.includes('Controller') && to.includes('Service')) {
-            priority += 15;
-        }
-        // Trigger -> Handler edges should not be broken (tightly coupled)
-        if (from.includes('Trigger') && to.includes('Handler')) {
-            priority -= 20;
-        }
-        // Core domain classes should not be broken if possible
-        if (CircularDependencyDetector.isCoreDomainClass(from) && CircularDependencyDetector.isCoreDomainClass(to)) {
-            priority -= 15;
-        }
-        return Math.max(0, Math.min(100, priority));
-    }
-    /**
-     * Get human-readable reason for break suggestion
-     */
-    static getBreakReason(from, to, priority) {
-        if (priority >= 80) {
-            return `High priority: ${from} → ${to} is a test or utility dependency`;
-        }
-        else if (priority >= 65) {
-            return `Medium priority: ${from} → ${to} can be broken safely`;
-        }
-        else if (priority >= 50) {
-            return `Low priority: ${from} → ${to} may be tightly coupled`;
-        }
-        else {
-            return `Not recommended: ${from} → ${to} appears to be core business logic`;
-        }
-    }
-    /**
-     * Check if a class is a utility/helper class
-     */
-    static isUtilityClass(nodeId) {
-        const name = nodeId.toLowerCase();
-        return name.includes('util') || name.includes('helper') || name.includes('constant') || name.includes('logger');
-    }
-    /**
-     * Check if a class is core domain logic
-     */
-    static isCoreDomainClass(nodeId) {
-        const name = nodeId.toLowerCase();
-        // Core classes typically don't have suffixes like Test, Handler, etc.
-        return (!name.includes('test') &&
-            !name.includes('handler') &&
-            !name.includes('controller') &&
-            !name.includes('util') &&
-            !name.includes('helper'));
-    }
     /**
      * Generate a unique ID for a cycle (order-independent)
      */
@@ -143,7 +77,7 @@ export class CircularDependencyDetector {
     detectCycles() {
         const startTime = Date.now();
         const visited = new Set();
-        const rawCycles = this.discoverCyclesAcrossGraph(visited);
+        const rawCycles = this.discovery.discoverAcrossGraph(visited);
         const allCycles = this.materializeUniqueCycles(rawCycles);
         const duration = Date.now() - startTime;
         logger.info('Cycle detection completed', {
@@ -157,7 +91,7 @@ export class CircularDependencyDetector {
      * Detect cycles starting from a specific node
      */
     detectCyclesFromNode(startNode) {
-        const rawCycles = this.discoverCyclesFromNode(startNode);
+        const rawCycles = this.discovery.discoverFromNode(startNode);
         return this.materializeUniqueCycles(rawCycles);
     }
     /**
@@ -202,63 +136,10 @@ export class CircularDependencyDetector {
             breakSuggestions: [],
         };
         if (this.options.generateSuggestions) {
-            detected.breakSuggestions = CircularDependencyDetector.generateBreakSuggestions(cycle, closingNode);
+            detected.breakSuggestions = generateBreakSuggestions(cycle, closingNode);
         }
         return detected;
     }
-    discoverCyclesAcrossGraph(visited) {
-        const rawCycles = [];
-        const recursionStack = new Set();
-        const currentPath = [];
-        for (const nodeId of this.graph.keys()) {
-            if (!visited.has(nodeId)) {
-                this.walkForCycles(nodeId, 0, visited, recursionStack, currentPath, rawCycles, true);
-            }
-        }
-        return rawCycles;
-    }
-    discoverCyclesFromNode(startNode) {
-        const rawCycles = [];
-        this.walkForCycles(startNode, 0, undefined, new Set(), [], rawCycles, false);
-        return rawCycles;
-    }
-    walkForCycles(nodeId, depth, visited, recursionStack, currentPath, cycles, warnOnDepthLimit) {
-        if (depth > this.options.maxDepth) {
-            if (warnOnDepthLimit) {
-                logger.warn('Max depth reached during cycle detection', { nodeId, depth });
-            }
-            return;
-        }
-        visited?.add(nodeId);
-        recursionStack.add(nodeId);
-        currentPath.push(nodeId);
-        for (const depId of this.getTraversableDependencies(nodeId)) {
-            if (recursionStack.has(depId)) {
-                const cycleStartIndex = currentPath.indexOf(depId);
-                cycles.push({
-                    cycle: currentPath.slice(cycleStartIndex),
-                    closingNode: depId,
-                });
-                continue;
-            }
-            if (visited?.has(depId)) {
-                continue;
-            }
-            this.walkForCycles(depId, depth + 1, visited, recursionStack, currentPath, cycles, warnOnDepthLimit);
-        }
-        recursionStack.delete(nodeId);
-        currentPath.pop();
-    }
-    getTraversableDependencies(nodeId) {
-        const dependencies = this.graph.get(nodeId) ?? new Set();
-        const traversable = [];
-        for (const depId of dependencies) {
-            if (!this.isEdgeIgnored(nodeId, depId) && shouldTraverseDependencyKind(DEFAULT_GRAPH_DEPENDENCY_KIND)) {
-                traversable.push(depId);
-            }
-        }
-        return traversable;
-    }
     materializeUniqueCycles(rawCycles) {
         const cycles = [];
         for (const rawCycle of rawCycles) {
@@ -268,36 +149,6 @@ export class CircularDependencyDetector {
         }
         return cycles;
     }
-    /**
-     * @ac US-030-AC-4: Suggest where to break cycle
-     *
-     * Generate suggestions for breaking the cycle
-     * Priority based on:
-     * - Test classes (high priority to break)
-     * - Utility classes (medium priority)
-     * - Core business logic (low priority)
-     */
-    static generateBreakSuggestions(cycle, closingNode) {
-        const suggestions = [];
-        // Add closing edge
-        const fullCycle = [...cycle, closingNode];
-        // Analyze each edge in the cycle
-        for (let i = 0; i < fullCycle.length - 1; i++) {
-            const from = fullCycle[i];
-            const to = fullCycle[i + 1];
-            const priority = CircularDependencyDetector.calculateBreakPriority(from, to);
-            const reason = CircularDependencyDetector.getBreakReason(from, to, priority);
-            suggestions.push({
-                from,
-                to,
-                reason,
-                priority,
-            });
-        }
-        // Sort by priority (highest first)
-        suggestions.sort((a, b) => b.priority - a.priority);
-        return suggestions;
-    }
     /**
      * @ac US-030-AC-5: Support user-defined cycle breaks
      *

package/lib/dependencies/circular-dependency-detector.js.map

@@ -1 +1 @@
-{"version":3,"file":"circular-dependency-detector.js","sourceRoot":"","sources":["../../src/dependencies/circular-dependency-detector.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAE/C,OAAO,EAAE,6BAA6B,EAAE,4BAA4B,EAAE,MAAM,2BAA2B,CAAC;AAExG,MAAM,MAAM,GAAG,SAAS,CAAC,4BAA4B,CAAC,CAAC;AAqCvD;;;;;;;;;;;;;;;GAeG;AACH,MAAM,OAAO,0BAA0B;IAC7B,KAAK,CAAkB;IACvB,OAAO,CAAkC;IACzC,YAAY,CAAc;IAElC,YAAmB,KAAsB,EAAE,UAAiC,EAAE;QAC5E,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,OAAO,GAAG;YACb,QAAQ,EAAE,OAAO,CAAC,QAAQ,IAAI,GAAG;YACjC,WAAW,EAAE,OAAO,CAAC,WAAW,IAAI,EAAE;YACtC,mBAAmB,EAAE,OAAO,CAAC,mBAAmB,IAAI,IAAI;SACzD,CAAC;QAEF,8CAA8C;QAC9C,IAAI,CAAC,YAAY,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,EAAE,CAAC,GAAG,IAAI,KAAK,EAAE,EAAE,CAAC,CAAC,CAAC;QAE9F,MAAM,CAAC,KAAK,CAAC,wCAAwC,EAAE;YACrD,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,IAAI;YACtB,YAAY,EAAE,IAAI,CAAC,YAAY,CAAC,IAAI;SACrC,CAAC,CAAC;IACL,CAAC;IAED,gCAAgC;IAChC;;;OAGG;IACK,MAAM,CAAC,sBAAsB,CAAC,IAAY,EAAE,EAAU;QAC5D,IAAI,QAAQ,GAAG,EAAE,CAAC,CAAC,gBAAgB;QAEnC,8EAA8E;QAC9E,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;YACjD,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,6CAA6C;QAC7C,IAAI,0BAA0B,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,0BAA0B,CAAC,cAAc,CAAC,EAAE,CAAC,EAAE,CAAC;YACrG,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,uDAAuD;QACvD,IAAI,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;YACvD,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,4CAA4C;QAC5C,IAAI,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;YAC1D,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,kEAAkE;QAClE,IAAI,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;YACvD,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,uDAAuD;QACvD,IAAI,0BAA0B,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,0BAA0B,CAAC,iBAAiB,CAAC,EAAE,CAAC,EAAE,CAAC;YAC3G,QAAQ,IAAI,EAAE,CAAC;QACjB,CAAC;QAED,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC,CAAC;IAC9C,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,cAAc,CAAC,IAAY,EAAE,EAAU,EAAE,QAAgB;QACtE,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;YACnB,OAAO,kBAAkB,IAAI,MAAM,EAAE,kCAAkC,CAAC;QAC1E,CAAC;aAAM,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;YAC1B,OAAO,oBAAoB,IAAI,MAAM,EAAE,uBAAuB,CAAC;QACjE,CAAC;aAAM,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;YAC1B,OAAO,iBAAiB,IAAI,MAAM,EAAE,yBAAyB,CAAC;QAChE,CAAC;aAAM,CAAC;YACN,OAAO,oBAAoB,IAAI,MAAM,EAAE,oCAAoC,CAAC;QAC9E,CAAC;IACH,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,cAAc,CAAC,MAAc;QAC1C,MAAM,IAAI,GAAG,MAAM,CAAC,WAAW,EAAE,CAAC;QAClC,OAAO,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAClH,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,iBAAiB,CAAC,MAAc;QAC7C,MAAM,IAAI,GAAG,MAAM,CAAC,WAAW,EAAE,CAAC;QAClC,sEAAsE;QACtE,OAAO,CACL,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC;YACtB,CAAC,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC;YACzB,CAAC,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC;YAC5B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC;YACtB,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CACzB,CAAC;IACJ,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,eAAe,CAAC,KAAe;QAC5C,4EAA4E;QAC5E,MAAM,MAAM,GAAG,CAAC,GAAG,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;QACjC,OAAO,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC3B,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,gBAAgB,CAAC,KAAe,EAAE,cAA+B;QAC9E,MAAM,OAAO,GAAG,0BAA0B,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;QAClE,OAAO,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,OAAO,CAAC,CAAC;IACtD,CAAC;IAED,iBAAiB;IACjB;;;;;;OAMG;IACI,YAAY;QACjB,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,MAAM,SAAS,GAAG,IAAI,CAAC,yBAAyB,CAAC,OAAO,CAAC,CAAC;QAC1D,MAAM,SAAS,GAAG,IAAI,CAAC,uBAAuB,CAAC,SAAS,CAAC,CAAC;QAE1D,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QACxC,MAAM,CAAC,IAAI,CAAC,2BAA2B,EAAE;YACvC,WAAW,EAAE,SAAS,CAAC,MAAM;YAC7B,YAAY,EAAE,OAAO,CAAC,IAAI;YAC1B,UAAU,EAAE,QAAQ;SACrB,CAAC,CAAC;QAEH,OAAO,SAAS,CAAC;IACnB,CAAC;IAED;;OAEG;IACI,oBAAoB,CAAC,SAAiB;QAC3C,MAAM,SAAS,GAAG,IAAI,CAAC,sBAAsB,CAAC,SAAS,CAAC,CAAC;QACzD,OAAO,IAAI,CAAC,uBAAuB,CAAC,SAAS,CAAC,CAAC;IACjD,CAAC;IAED;;OAEG;IACI,gBAAgB,CAAC,IAAY,EAAE,EAAU;QAC9C,qDAAqD;QACrD,sDAAsD;QAEtD,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,MAAM,KAAK,GAAa,CAAC,EAAE,CAAC,CAAC;QAE7B,OAAO,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,MAAM,OAAO,GAAG,KAAK,CAAC,KAAK,EAAG,CAAC;YAE/B,IAAI,OAAO,KAAK,IAAI,EAAE,CAAC;gBACrB,OAAO,IAAI,CAAC,CAAC,8BAA8B;YAC7C,CAAC;YAED,IAAI,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzB,SAAS;YACX,CAAC;YAED,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;YAErB,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,IAAI,GAAG,EAAE,CAAC;YAClD,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;gBACvB,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,OAAO,EAAE,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC3D,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;gBAClB,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,KAAK,CAAC;IACf,CAAC;IAED;;;;OAIG;IACK,mBAAmB,CAAC,KAAe,EAAE,WAAmB;QAC9D,MAAM,OAAO,GAAG,0BAA0B,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;QAClE,MAAM,OAAO,GAAG,wBAAwB,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,WAAW,EAAE,CAAC;QAE7E,MAAM,QAAQ,GAAkB;YAC9B,EAAE,EAAE,OAAO;YACX,KAAK,EAAE,CAAC,GAAG,KAAK,CAAC;YACjB,QAAQ,EAAE,KAAK,CAAC,MAAM,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS;YACjD,OAAO;YACP,gBAAgB,EAAE,EAAE;SACrB,CAAC;QAEF,IAAI,IAAI,CAAC,OAAO,CAAC,mBAAmB,EAAE,CAAC;YACrC,QAAQ,CAAC,gBAAgB,GAAG,0BAA0B,CAAC,wBAAwB,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;QACtG,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;IAEO,yBAAyB,CAAC,OAAoB;QACpD,MAAM,SAAS,GAAe,EAAE,CAAC;QACjC,MAAM,cAAc,GAAG,IAAI,GAAG,EAAU,CAAC;QACzC,MAAM,WAAW,GAAa,EAAE,CAAC;QAEjC,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,CAAC;YACvC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;gBACzB,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,SAAS,EAAE,IAAI,CAAC,CAAC;YACvF,CAAC;QACH,CAAC;QAED,OAAO,SAAS,CAAC;IACnB,CAAC;IAEO,sBAAsB,CAAC,SAAiB;QAC9C,MAAM,SAAS,GAAe,EAAE,CAAC;QACjC,IAAI,CAAC,aAAa,CAAC,SAAS,EAAE,CAAC,EAAE,SAAS,EAAE,IAAI,GAAG,EAAU,EAAE,EAAE,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;QACrF,OAAO,SAAS,CAAC;IACnB,CAAC;IAEO,aAAa,CACnB,MAAc,EACd,KAAa,EACb,OAAgC,EAChC,cAA2B,EAC3B,WAAqB,EACrB,MAAkB,EAClB,gBAAyB;QAEzB,IAAI,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,CAAC;YAClC,IAAI,gBAAgB,EAAE,CAAC;gBACrB,MAAM,CAAC,IAAI,CAAC,0CAA0C,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;YAC7E,CAAC;YAED,OAAO;QACT,CAAC;QAED,OAAO,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC;QACrB,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QAC3B,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAEzB,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,0BAA0B,CAAC,MAAM,CAAC,EAAE,CAAC;YAC5D,IAAI,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC9B,MAAM,eAAe,GAAG,WAAW,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;gBACnD,MAAM,CAAC,IAAI,CAAC;oBACV,KAAK,EAAE,WAAW,CAAC,KAAK,CAAC,eAAe,CAAC;oBACzC,WAAW,EAAE,KAAK;iBACnB,CAAC,CAAC;gBACH,SAAS;YACX,CAAC;YAED,IAAI,OAAO,EAAE,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;gBACxB,SAAS;YACX,CAAC;YAED,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,EAAE,gBAAgB,CAAC,CAAC;QACvG,CAAC;QAED,cAAc,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QAC9B,WAAW,CAAC,GAAG,EAAE,CAAC;IACpB,CAAC;IAEO,0BAA0B,CAAC,MAAc;QAC/C,MAAM,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,IAAI,GAAG,EAAE,CAAC;QACzD,MAAM,WAAW,GAAa,EAAE,CAAC;QAEjC,KAAK,MAAM,KAAK,IAAI,YAAY,EAAE,CAAC;YACjC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,4BAA4B,CAAC,6BAA6B,CAAC,EAAE,CAAC;gBACtG,WAAW,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC1B,CAAC;QACH,CAAC;QAED,OAAO,WAAW,CAAC;IACrB,CAAC;IAEO,uBAAuB,CAAC,SAAqB;QACnD,MAAM,MAAM,GAAoB,EAAE,CAAC;QAEnC,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;YACjC,IAAI,CAAC,0BAA0B,CAAC,gBAAgB,CAAC,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC;gBACzE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC,KAAK,EAAE,QAAQ,CAAC,WAAW,CAAC,CAAC,CAAC;YAC9E,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;;;;;;;OAQG;IACK,MAAM,CAAC,wBAAwB,CAAC,KAAe,EAAE,WAAmB;QAC1E,MAAM,WAAW,GAA2B,EAAE,CAAC;QAE/C,mBAAmB;QACnB,MAAM,SAAS,GAAG,CAAC,GAAG,KAAK,EAAE,WAAW,CAAC,CAAC;QAE1C,iCAAiC;QACjC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;YAC9C,MAAM,IAAI,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC;YAC1B,MAAM,EAAE,GAAG,SAAS,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;YAE5B,MAAM,QAAQ,GAAG,0BAA0B,CAAC,sBAAsB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YAC7E,MAAM,MAAM,GAAG,0BAA0B,CAAC,cAAc,CAAC,IAAI,EAAE,EAAE,EAAE,QAAQ,CAAC,CAAC;YAE7E,WAAW,CAAC,IAAI,CAAC;gBACf,IAAI;gBACJ,EAAE;gBACF,MAAM;gBACN,QAAQ;aACT,CAAC,CAAC;QACL,CAAC;QAED,mCAAmC;QACnC,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,QAAQ,CAAC,CAAC;QAEpD,OAAO,WAAW,CAAC;IACrB,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,IAAY,EAAE,EAAU;QAC5C,OAAO,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,GAAG,IAAI,KAAK,EAAE,EAAE,CAAC,CAAC;IACjD,CAAC;IAED;;OAEG;IACI,QAAQ;QAKb,IAAI,UAAU,GAAG,CAAC,CAAC;QACnB,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,EAAE,CAAC;YACvC,UAAU,IAAI,IAAI,CAAC,IAAI,CAAC;QAC1B,CAAC;QAED,OAAO;YACL,UAAU,EAAE,IAAI,CAAC,KAAK,CAAC,IAAI;YAC3B,UAAU;YACV,YAAY,EAAE,IAAI,CAAC,YAAY,CAAC,IAAI;SACrC,CAAC;IACJ,CAAC;CACF"}
+{"version":3,"file":"circular-dependency-detector.js","sourceRoot":"","sources":["../../src/dependencies/circular-dependency-detector.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAE/C,OAAO,EAAE,wBAAwB,EAAE,MAAM,8BAA8B,CAAC;AACxE,OAAO,EAAE,cAAc,EAAiB,MAAM,sBAAsB,CAAC;AAErE,MAAM,MAAM,GAAG,SAAS,CAAC,4BAA4B,CAAC,CAAC;AAgCvD;;;;;;;;;;;;;;;GAeG;AACH,MAAM,OAAO,0BAA0B;IAC7B,KAAK,CAAkB;IACvB,OAAO,CAAkC;IACzC,YAAY,CAAc;IAC1B,SAAS,CAAiB;IAElC,YAAmB,KAAsB,EAAE,UAAiC,EAAE;QAC5E,IAAI,CAAC,KAAK,GAAG,KAAK,CAAC;QACnB,IAAI,CAAC,OAAO,GAAG;YACb,QAAQ,EAAE,OAAO,CAAC,QAAQ,IAAI,GAAG;YACjC,WAAW,EAAE,OAAO,CAAC,WAAW,IAAI,EAAE;YACtC,mBAAmB,EAAE,OAAO,CAAC,mBAAmB,IAAI,IAAI;SACzD,CAAC;QAEF,8CAA8C;QAC9C,IAAI,CAAC,YAAY,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,EAAE,CAAC,GAAG,IAAI,KAAK,EAAE,EAAE,CAAC,CAAC,CAAC;QAC9F,IAAI,CAAC,SAAS,GAAG,IAAI,cAAc,CAAC,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC,OAAO,CAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,CAAC;QAE1F,MAAM,CAAC,KAAK,CAAC,wCAAwC,EAAE;YACrD,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,IAAI;YACtB,YAAY,EAAE,IAAI,CAAC,YAAY,CAAC,IAAI;SACrC,CAAC,CAAC;IACL,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,eAAe,CAAC,KAAe;QAC5C,4EAA4E;QAC5E,MAAM,MAAM,GAAG,CAAC,GAAG,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC;QACjC,OAAO,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC3B,CAAC;IAED;;OAEG;IACK,MAAM,CAAC,gBAAgB,CAAC,KAAe,EAAE,cAA+B;QAC9E,MAAM,OAAO,GAAG,0BAA0B,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;QAClE,OAAO,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,OAAO,CAAC,CAAC;IACtD,CAAC;IAED,iBAAiB;IACjB;;;;;;OAMG;IACI,YAAY;QACjB,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QAC7B,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;QAC9D,MAAM,SAAS,GAAG,IAAI,CAAC,uBAAuB,CAAC,SAAS,CAAC,CAAC;QAE1D,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;QACxC,MAAM,CAAC,IAAI,CAAC,2BAA2B,EAAE;YACvC,WAAW,EAAE,SAAS,CAAC,MAAM;YAC7B,YAAY,EAAE,OAAO,CAAC,IAAI;YAC1B,UAAU,EAAE,QAAQ;SACrB,CAAC,CAAC;QAEH,OAAO,SAAS,CAAC;IACnB,CAAC;IAED;;OAEG;IACI,oBAAoB,CAAC,SAAiB;QAC3C,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,SAAS,CAAC,CAAC;QAC7D,OAAO,IAAI,CAAC,uBAAuB,CAAC,SAAS,CAAC,CAAC;IACjD,CAAC;IAED;;OAEG;IACI,gBAAgB,CAAC,IAAY,EAAE,EAAU;QAC9C,qDAAqD;QACrD,sDAAsD;QAEtD,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,MAAM,KAAK,GAAa,CAAC,EAAE,CAAC,CAAC;QAE7B,OAAO,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,MAAM,OAAO,GAAG,KAAK,CAAC,KAAK,EAAG,CAAC;YAE/B,IAAI,OAAO,KAAK,IAAI,EAAE,CAAC;gBACrB,OAAO,IAAI,CAAC,CAAC,8BAA8B;YAC7C,CAAC;YAED,IAAI,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzB,SAAS;YACX,CAAC;YAED,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;YAErB,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,IAAI,GAAG,EAAE,CAAC;YAClD,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;gBACvB,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,OAAO,EAAE,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC3D,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;gBAClB,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,KAAK,CAAC;IACf,CAAC;IAED;;;;OAIG;IACK,mBAAmB,CAAC,KAAe,EAAE,WAAmB;QAC9D,MAAM,OAAO,GAAG,0BAA0B,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC;QAClE,MAAM,OAAO,GAAG,wBAAwB,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,WAAW,EAAE,CAAC;QAE7E,MAAM,QAAQ,GAAkB;YAC9B,EAAE,EAAE,OAAO;YACX,KAAK,EAAE,CAAC,GAAG,KAAK,CAAC;YACjB,QAAQ,EAAE,KAAK,CAAC,MAAM,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS;YACjD,OAAO;YACP,gBAAgB,EAAE,EAAE;SACrB,CAAC;QAEF,IAAI,IAAI,CAAC,OAAO,CAAC,mBAAmB,EAAE,CAAC;YACrC,QAAQ,CAAC,gBAAgB,GAAG,wBAAwB,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;QAC3E,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;IAEO,uBAAuB,CAAC,SAAqB;QACnD,MAAM,MAAM,GAAoB,EAAE,CAAC;QAEnC,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;YACjC,IAAI,CAAC,0BAA0B,CAAC,gBAAgB,CAAC,QAAQ,CAAC,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC;gBACzE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,QAAQ,CAAC,KAAK,EAAE,QAAQ,CAAC,WAAW,CAAC,CAAC,CAAC;YAC9E,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAC;IAChB,CAAC;IAED;;;;OAIG;IACK,aAAa,CAAC,IAAY,EAAE,EAAU;QAC5C,OAAO,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,GAAG,IAAI,KAAK,EAAE,EAAE,CAAC,CAAC;IACjD,CAAC;IAED;;OAEG;IACI,QAAQ;QAKb,IAAI,UAAU,GAAG,CAAC,CAAC;QACnB,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,EAAE,CAAC;YACvC,UAAU,IAAI,IAAI,CAAC,IAAI,CAAC;QAC1B,CAAC;QAED,OAAO;YACL,UAAU,EAAE,IAAI,CAAC,KAAK,CAAC,IAAI;YAC3B,UAAU;YACV,YAAY,EAAE,IAAI,CAAC,YAAY,CAAC,IAAI;SACrC,CAAC;IACJ,CAAC;CACF"}

package/lib/dependencies/cycle-break-suggestions.d.ts

@@ -0,0 +1,3 @@
+import type { NodeId } from '../types/dependency.js';
+import type { CycleBreakSuggestion } from './circular-dependency-detector.js';
+export declare function generateBreakSuggestions(cycle: NodeId[], closingNode: NodeId): CycleBreakSuggestion[];

package/lib/dependencies/cycle-break-suggestions.js

@@ -0,0 +1,63 @@
+export function generateBreakSuggestions(cycle, closingNode) {
+    const fullCycle = [...cycle, closingNode];
+    const suggestions = [];
+    for (let index = 0; index < fullCycle.length - 1; index++) {
+        const from = fullCycle[index];
+        const to = fullCycle[index + 1];
+        const priority = calculateBreakPriority(from, to);
+        suggestions.push({
+            from,
+            to,
+            reason: getBreakReason(from, to, priority),
+            priority,
+        });
+    }
+    return suggestions.sort((a, b) => b.priority - a.priority);
+}
+function calculateBreakPriority(from, to) {
+    let priority = 50;
+    if (from.includes('Test') || to.includes('Test')) {
+        priority += 30;
+    }
+    if (isUtilityClass(from) || isUtilityClass(to)) {
+        priority += 20;
+    }
+    if (from.includes('Handler') && to.includes('Service')) {
+        priority += 15;
+    }
+    if (from.includes('Controller') && to.includes('Service')) {
+        priority += 15;
+    }
+    if (from.includes('Trigger') && to.includes('Handler')) {
+        priority -= 20;
+    }
+    if (isCoreDomainClass(from) && isCoreDomainClass(to)) {
+        priority -= 15;
+    }
+    return Math.max(0, Math.min(100, priority));
+}
+function getBreakReason(from, to, priority) {
+    if (priority >= 80) {
+        return `High priority: ${from} → ${to} is a test or utility dependency`;
+    }
+    else if (priority >= 65) {
+        return `Medium priority: ${from} → ${to} can be broken safely`;
+    }
+    else if (priority >= 50) {
+        return `Low priority: ${from} → ${to} may be tightly coupled`;
+    }
+    return `Not recommended: ${from} → ${to} appears to be core business logic`;
+}
+function isUtilityClass(nodeId) {
+    const name = nodeId.toLowerCase();
+    return name.includes('util') || name.includes('helper') || name.includes('constant') || name.includes('logger');
+}
+function isCoreDomainClass(nodeId) {
+    const name = nodeId.toLowerCase();
+    return (!name.includes('test') &&
+        !name.includes('handler') &&
+        !name.includes('controller') &&
+        !name.includes('util') &&
+        !name.includes('helper'));
+}
+//# sourceMappingURL=cycle-break-suggestions.js.map

package/lib/dependencies/cycle-break-suggestions.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cycle-break-suggestions.js","sourceRoot":"","sources":["../../src/dependencies/cycle-break-suggestions.ts"],"names":[],"mappings":"AAGA,MAAM,UAAU,wBAAwB,CAAC,KAAe,EAAE,WAAmB;IAC3E,MAAM,SAAS,GAAG,CAAC,GAAG,KAAK,EAAE,WAAW,CAAC,CAAC;IAC1C,MAAM,WAAW,GAA2B,EAAE,CAAC;IAE/C,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,KAAK,GAAG,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,KAAK,EAAE,EAAE,CAAC;QAC1D,MAAM,IAAI,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;QAC9B,MAAM,EAAE,GAAG,SAAS,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC;QAChC,MAAM,QAAQ,GAAG,sBAAsB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QAElD,WAAW,CAAC,IAAI,CAAC;YACf,IAAI;YACJ,EAAE;YACF,MAAM,EAAE,cAAc,CAAC,IAAI,EAAE,EAAE,EAAE,QAAQ,CAAC;YAC1C,QAAQ;SACT,CAAC,CAAC;IACL,CAAC;IAED,OAAO,WAAW,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,QAAQ,CAAC,CAAC;AAC7D,CAAC;AAED,SAAS,sBAAsB,CAAC,IAAY,EAAE,EAAU;IACtD,IAAI,QAAQ,GAAG,EAAE,CAAC;IAElB,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;QACjD,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,IAAI,cAAc,CAAC,IAAI,CAAC,IAAI,cAAc,CAAC,EAAE,CAAC,EAAE,CAAC;QAC/C,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,IAAI,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;QACvD,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,IAAI,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;QAC1D,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,IAAI,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;QACvD,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,IAAI,iBAAiB,CAAC,IAAI,CAAC,IAAI,iBAAiB,CAAC,EAAE,CAAC,EAAE,CAAC;QACrD,QAAQ,IAAI,EAAE,CAAC;IACjB,CAAC;IAED,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,GAAG,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC,CAAC;AAC9C,CAAC;AAED,SAAS,cAAc,CAAC,IAAY,EAAE,EAAU,EAAE,QAAgB;IAChE,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;QACnB,OAAO,kBAAkB,IAAI,MAAM,EAAE,kCAAkC,CAAC;IAC1E,CAAC;SAAM,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;QAC1B,OAAO,oBAAoB,IAAI,MAAM,EAAE,uBAAuB,CAAC;IACjE,CAAC;SAAM,IAAI,QAAQ,IAAI,EAAE,EAAE,CAAC;QAC1B,OAAO,iBAAiB,IAAI,MAAM,EAAE,yBAAyB,CAAC;IAChE,CAAC;IAED,OAAO,oBAAoB,IAAI,MAAM,EAAE,oCAAoC,CAAC;AAC9E,CAAC;AAED,SAAS,cAAc,CAAC,MAAc;IACpC,MAAM,IAAI,GAAG,MAAM,CAAC,WAAW,EAAE,CAAC;IAClC,OAAO,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;AAClH,CAAC;AAED,SAAS,iBAAiB,CAAC,MAAc;IACvC,MAAM,IAAI,GAAG,MAAM,CAAC,WAAW,EAAE,CAAC;IAClC,OAAO,CACL,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC;QACtB,CAAC,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC;QACzB,CAAC,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC;QAC5B,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC;QACtB,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CACzB,CAAC;AACJ,CAAC"}

package/lib/dependencies/cycle-discovery.d.ts

@@ -0,0 +1,16 @@
+import type { DependencyGraph, NodeId } from '../types/dependency.js';
+export type RawCycle = {
+    cycle: NodeId[];
+    closingNode: NodeId;
+};
+export declare class CycleDiscovery {
+    private readonly graph;
+    private readonly maxDepth;
+    private readonly ignoredEdges;
+    constructor(graph: DependencyGraph, maxDepth: number, ignoredEdges: ReadonlySet<string>);
+    discoverAcrossGraph(visited: Set<NodeId>): RawCycle[];
+    discoverFromNode(startNode: NodeId): RawCycle[];
+    private walkForCycles;
+    private getTraversableDependencies;
+    private isEdgeIgnored;
+}

package/lib/dependencies/cycle-discovery.js

@@ -0,0 +1,70 @@
+import { getLogger } from '../utils/logger.js';
+import { DEFAULT_GRAPH_DEPENDENCY_KIND, shouldTraverseDependencyKind } from './dependency-semantics.js';
+const logger = getLogger('CycleDiscovery');
+export class CycleDiscovery {
+    graph;
+    maxDepth;
+    ignoredEdges;
+    constructor(graph, maxDepth, ignoredEdges) {
+        this.graph = graph;
+        this.maxDepth = maxDepth;
+        this.ignoredEdges = ignoredEdges;
+    }
+    discoverAcrossGraph(visited) {
+        const rawCycles = [];
+        const recursionStack = new Set();
+        const currentPath = [];
+        for (const nodeId of this.graph.keys()) {
+            if (!visited.has(nodeId)) {
+                this.walkForCycles(nodeId, 0, visited, recursionStack, currentPath, rawCycles, true);
+            }
+        }
+        return rawCycles;
+    }
+    discoverFromNode(startNode) {
+        const rawCycles = [];
+        this.walkForCycles(startNode, 0, undefined, new Set(), [], rawCycles, false);
+        return rawCycles;
+    }
+    walkForCycles(nodeId, depth, visited, recursionStack, currentPath, cycles, warnOnDepthLimit) {
+        if (depth > this.maxDepth) {
+            if (warnOnDepthLimit) {
+                logger.warn('Max depth reached during cycle detection', { nodeId, depth });
+            }
+            return;
+        }
+        visited?.add(nodeId);
+        recursionStack.add(nodeId);
+        currentPath.push(nodeId);
+        for (const depId of this.getTraversableDependencies(nodeId)) {
+            if (recursionStack.has(depId)) {
+                const cycleStartIndex = currentPath.indexOf(depId);
+                cycles.push({
+                    cycle: currentPath.slice(cycleStartIndex),
+                    closingNode: depId,
+                });
+                continue;
+            }
+            if (visited?.has(depId)) {
+                continue;
+            }
+            this.walkForCycles(depId, depth + 1, visited, recursionStack, currentPath, cycles, warnOnDepthLimit);
+        }
+        recursionStack.delete(nodeId);
+        currentPath.pop();
+    }
+    getTraversableDependencies(nodeId) {
+        const dependencies = this.graph.get(nodeId) ?? new Set();
+        const traversable = [];
+        for (const depId of dependencies) {
+            if (!this.isEdgeIgnored(nodeId, depId) && shouldTraverseDependencyKind(DEFAULT_GRAPH_DEPENDENCY_KIND)) {
+                traversable.push(depId);
+            }
+        }
+        return traversable;
+    }
+    isEdgeIgnored(from, to) {
+        return this.ignoredEdges.has(`${from}->${to}`);
+    }
+}
+//# sourceMappingURL=cycle-discovery.js.map

package/lib/dependencies/cycle-discovery.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cycle-discovery.js","sourceRoot":"","sources":["../../src/dependencies/cycle-discovery.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAE/C,OAAO,EAAE,6BAA6B,EAAE,4BAA4B,EAAE,MAAM,2BAA2B,CAAC;AAExG,MAAM,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAAC;AAO3C,MAAM,OAAO,cAAc;IAEN;IACA;IACA;IAHnB,YACmB,KAAsB,EACtB,QAAgB,EAChB,YAAiC;QAFjC,UAAK,GAAL,KAAK,CAAiB;QACtB,aAAQ,GAAR,QAAQ,CAAQ;QAChB,iBAAY,GAAZ,YAAY,CAAqB;IACjD,CAAC;IAEG,mBAAmB,CAAC,OAAoB;QAC7C,MAAM,SAAS,GAAe,EAAE,CAAC;QACjC,MAAM,cAAc,GAAG,IAAI,GAAG,EAAU,CAAC;QACzC,MAAM,WAAW,GAAa,EAAE,CAAC;QAEjC,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE,EAAE,CAAC;YACvC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;gBACzB,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,SAAS,EAAE,IAAI,CAAC,CAAC;YACvF,CAAC;QACH,CAAC;QAED,OAAO,SAAS,CAAC;IACnB,CAAC;IAEM,gBAAgB,CAAC,SAAiB;QACvC,MAAM,SAAS,GAAe,EAAE,CAAC;QACjC,IAAI,CAAC,aAAa,CAAC,SAAS,EAAE,CAAC,EAAE,SAAS,EAAE,IAAI,GAAG,EAAU,EAAE,EAAE,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;QACrF,OAAO,SAAS,CAAC;IACnB,CAAC;IAEO,aAAa,CACnB,MAAc,EACd,KAAa,EACb,OAAgC,EAChC,cAA2B,EAC3B,WAAqB,EACrB,MAAkB,EAClB,gBAAyB;QAEzB,IAAI,KAAK,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAC;YAC1B,IAAI,gBAAgB,EAAE,CAAC;gBACrB,MAAM,CAAC,IAAI,CAAC,0CAA0C,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;YAC7E,CAAC;YAED,OAAO;QACT,CAAC;QAED,OAAO,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC;QACrB,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;QAC3B,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAEzB,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,0BAA0B,CAAC,MAAM,CAAC,EAAE,CAAC;YAC5D,IAAI,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;gBAC9B,MAAM,eAAe,GAAG,WAAW,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;gBACnD,MAAM,CAAC,IAAI,CAAC;oBACV,KAAK,EAAE,WAAW,CAAC,KAAK,CAAC,eAAe,CAAC;oBACzC,WAAW,EAAE,KAAK;iBACnB,CAAC,CAAC;gBACH,SAAS;YACX,CAAC;YAED,IAAI,OAAO,EAAE,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;gBACxB,SAAS;YACX,CAAC;YAED,IAAI,CAAC,aAAa,CAAC,KAAK,EAAE,KAAK,GAAG,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,EAAE,gBAAgB,CAAC,CAAC;QACvG,CAAC;QAED,cAAc,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QAC9B,WAAW,CAAC,GAAG,EAAE,CAAC;IACpB,CAAC;IAEO,0BAA0B,CAAC,MAAc;QAC/C,MAAM,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,IAAI,GAAG,EAAU,CAAC;QACjE,MAAM,WAAW,GAAa,EAAE,CAAC;QAEjC,KAAK,MAAM,KAAK,IAAI,YAAY,EAAE,CAAC;YACjC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,4BAA4B,CAAC,6BAA6B,CAAC,EAAE,CAAC;gBACtG,WAAW,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC1B,CAAC;QACH,CAAC;QAED,OAAO,WAAW,CAAC;IACrB,CAAC;IAEO,aAAa,CAAC,IAAY,EAAE,EAAU;QAC5C,OAAO,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,GAAG,IAAI,KAAK,EAAE,EAAE,CAAC,CAAC;IACjD,CAAC;CACF"}

package/lib/dependencies/dependency-graph-builder.d.ts

@@ -1,16 +1,3 @@
-/**
- * Dependency Graph Builder
- * Builds a dependency graph from parsed metadata components
- *
- * @ac US-028-AC-1: Add nodes for each component
- * @ac US-028-AC-2: Add edges for each dependency
- * @ac US-028-AC-3: Handle bidirectional dependencies
- * @ac US-028-AC-4: Track dependency types (hard, soft)
- * @ac US-028-AC-5: Support incremental graph building
- * @ac US-028-AC-6: Validate graph structure
- *
- * @issue #28
- */
 import type { MetadataComponent, MetadataDependencyKind } from '../types/metadata.js';
 import type { NodeId, DependencyAnalysisResult } from '../types/dependency.js';
 /**
@@ -28,21 +15,6 @@ export type GraphBuilderOptions = {
     /** Max nodes before warning (performance) */
     maxNodes?: number;
 };
-/**
- * Dependency Graph Builder
- *
- * Performance optimized for 10,000+ nodes:
- * - Uses Map/Set for O(1) lookups
- * - Lazy validation
- * - Incremental building support
- *
- * @example
- * const builder = new DependencyGraphBuilder();
- * builder.addComponent(apexClassComponent);
- * builder.addComponent(triggerComponent);
- * const result = builder.build();
- * console.log(result.stats.totalComponents); // 2
- */
 export declare class DependencyGraphBuilder {
     private components;
     private graph;
@@ -59,10 +31,6 @@ export declare class DependencyGraphBuilder {
      * Check if graph is empty
      */
     get isEmpty(): boolean;
-    /**
-     * Create a node ID from type and name
-     */
-    private static createNodeId;
     /**
      * Add a metadata component to the graph
      *
@@ -130,10 +98,6 @@ export declare class DependencyGraphBuilder {
      * Stage 1a: intake and register the component node.
      */
     private intakeComponentNode;
-    /**
-     * Stage 2: expand legacy dependency sets into typed dependency details.
-     */
-    private expandTypedDependencies;
     /**
      * Stage 3: assemble graph edges from expanded dependency details.
      */
@@ -145,39 +109,10 @@ export declare class DependencyGraphBuilder {
      * @ac US-028-AC-6: Validate graph structure
      */
     private validate;
-    /**
-     * Detect circular dependencies using DFS
-     */
-    private detectCircularDependencies;
-    /**
-     * Find components with no dependencies or dependents
-     */
-    private findIsolatedComponents;
-    /**
-     * Generate graph statistics
-     */
-    private generateStats;
-    private collectGraphMetrics;
-    private collectComponentsByType;
-    /**
-     * Calculate maximum dependency depth (simplified BFS)
-     */
-    private calculateMaxDepth;
-    /**
-     * BFS to calculate depth from a starting node
-     */
-    private bfsDepth;
-    /**
-     * Count total edges in the graph
-     */
-    private countEdges;
     private warnIfGraphIsLarge;
     private initializeNodeEntries;
     private ensureEdgeEndpoints;
     private initializeOutgoingNode;
     private initializeIncomingNode;
     private reportDanglingReferences;
-    private validateGraphStructure;
-    private collectGraphCounts;
-    private findMaxCountEntry;
 }