@jsprismarine/features 0.0.0 → 0.16.0-unstable-20261029134110

package/CHANGELOG.md

@@ -0,0 +1,118 @@
+# @jsprismarine/features
+
+## 0.16.0-unstable-20261029134110
+
+### Minor Changes
+
+- [#2628](https://github.com/JSPrismarine/JSPrismarine/pull/2628) [`2bc83d4`](https://github.com/JSPrismarine/JSPrismarine/commit/2bc83d4e6b2cca1e29a091753300862fa84006ab) Thanks [@filiphsps](https://github.com/filiphsps)! - Give a template a feature placed its block entities, and keep the processors a feature writes
+  inline, so a desert well's suspicious sand holds the loot a brush turns up. Two misses on the
+  same path. `placeJavaTemplate` wrote the template's blocks and never asked for the block entities
+  saved on them, so every compound a feature-placed template carried was dropped. The feature
+  parser kept a `processors` field only when it was a string, so a feature writing its rules where
+  it stands had them thrown away. Java's processor list codec takes an identifier, a bare list or
+  an object holding one, and `TemplateRequest.processors` now carries whichever arrived.
+  
+  The desert well is where both land. In a generated world at seed 1234, its four nearest wells, in
+  chunks -691,-239, -687,-18, -649,-130 and -647,-38, each placed two suspicious sand and no block
+  entity at all. Each now places the same two sand, carrying
+  `loot_tables/archaeology/desert_well.json`.
+  
+  Java 26.3 places a template nine times across its 240 feature documents: two `minecraft:fossil`
+  features that name their processor lists by identifier, and seven `minecraft:template` features
+  nested inside the desert well and the sulfur spring, which is why neither shows up as a feature
+  document of that type. Two of the seven carry processors, both written inline, and both are the
+  desert well's archaeology rule. That rule and the three trail ruins processor lists are the only
+  four `append_loot` in the game data.
+  
+  `append_loot` adds the loot table to the compound it is handed, and the template source keeps
+  each decoded template for the life of the world, so a chain run over a template's own compounds
+  would bake one placement's table into every later placement of it. The placement copies the
+  compounds it hands to the chain, and indexes each copy under the Java block the original sat in,
+  which is where a banner keeps its color.
+  
+  The desert pyramid still leaves its corridor suspicious sand out, for a different reason than the
+  one recorded beside it. The seam carries a brushable block entity and `archaeology/desert_pyramid`
+  is in the loot data. The positions are what is missing: they live in Java's `DesertPyramidPiece`
+  rather than in data, and the pyramid's interior here is a reconstruction.
+
+### Patch Changes
+
+- [#2628](https://github.com/JSPrismarine/JSPrismarine/pull/2628) [`9f5dcbe`](https://github.com/JSPrismarine/JSPrismarine/commit/9f5dcbeff3a03f2061efb3d6179def3ef176c62b) Thanks [@filiphsps](https://github.com/filiphsps)! - Decorate a chunk with the features that belong in it.
+  
+  `DataDrivenGenerator` ran every placed feature of every overworld biome in every chunk and let
+  nothing filter them, which is why trees grew on ice spikes and a single chunk could hold seven
+  species of log. Four fixes, each measured against Java Edition's 26.3 server jar:
+  
+  - The `minecraft:biome` placement modifier now gets the `featureBelongsToBiome` callback it has
+    always asked for, so a position is rejected unless the biome there lists the feature being
+    placed. This is Java's `BiomeFilter`.
+  - A step's candidate features are the union of what the biomes of the surrounding 3 by 3 chunks
+    list, not of every biome in the dimension. Java reads the same nine chunks' biome palettes in
+    `ChunkGenerator.applyBiomeDecoration`.
+  - Feature indices no longer start at the step's structure count. In the jar the structure counter
+    and `globalIndexOfFeature` both restart at zero within a step and are allowed to overlap, so the
+    offset was shifting every feature seed away from vanilla.
+  - `sortFeaturesPerStep`, new in `@jsprismarine/features`, replaces the first-seen feature order
+    with Java's `FeatureSorter`: a depth-first topological sort over every biome's ordering, giving
+    one list per step that every biome agrees with. That index is the other half of the feature seed.
+  
+  Measured over four chunks each deep inside plains, desert, taiga and ice spikes at seed 1234:
+  feature invocations per chunk fell from 171 everywhere to between 48 and 59, and decoration block
+  writes from 8256 to 9610 per chunk down to 3461 to 5120. The ice spikes chunk went from 38 logs
+  and 268 leaves to none, and the desert chunk from 274 logs and 1538 leaves to none. The taiga
+  chunk keeps its spruce.
+
+- [#2628](https://github.com/JSPrismarine/JSPrismarine/pull/2628) [`485ac0b`](https://github.com/JSPrismarine/JSPrismarine/commit/485ac0b0b901a9495c733dc668ff53b4061e03c0) Thanks [@filiphsps](https://github.com/filiphsps)! - Add `@jsprismarine/features`, Java Edition's decoration pass. It implements all 58 feature types
+  Java 26.3 registers, the ten block state providers, the eight int, four float and six height
+  providers, the sixteen block predicates, the ten rule tests, the ten trunk placers, twelve foliage
+  placers, eleven tree decorators, one root placer and two feature sizes, and all eighteen placement
+  modifiers. The placement pipeline reproduces Java's depth-first traversal, which decides the order
+  of the random draws, and `decorateChunk` derives the per-chunk population seed and reseeds before
+  each feature from its index and decoration step, so the same seed and chunk place the same blocks
+  and a feature that draws extra numbers does not move the next one. Features write Java block
+  states through one `FeatureWorld` interface, with a separate `BlockOracle` for the facts that do
+  not depend on position and a `translatingWorld` adapter where a server attaches
+  `@jsprismarine/mapping`; `TestFeatureWorld` is a typed in-memory double with computed heightmaps.
+  The seeding, every provider and the shared biome-info noise are compared exactly against values
+  dumped from the pinned 26.3 server jar, and a gated corpus test reads all 240 configured and 273
+  placed features with zero errors, reporting 47 feature types used at the top level and 15
+  placement modifiers. 26.3 removed `random_patch` in favor of `projected_random_patchy_square` and
+  renamed the dripstone features to `speleothem` and `speleothem_cluster`, so a loader written
+  against 1.21 data does not read this corpus.
+
+- [#2628](https://github.com/JSPrismarine/JSPrismarine/pull/2628) [`e648da4`](https://github.com/JSPrismarine/JSPrismarine/commit/e648da4bbd2bfa55fe80d603e7c8e9f0fea39dfc) Thanks [@filiphsps](https://github.com/filiphsps)! - Carry a structure template's saved block entity into the generated chunk, so the contents
+  translation reaches a world. The translation covers 149 of the 1124 block entities Java 26.3's
+  templates declare and nothing called it: the generation path read the type, the loot table and the
+  spawner's mob off the saved compound and dropped the rest, so a generated decorated pot had no
+  sherds and a generated vault had no key.
+  
+  `BlockEntityRequest` gains `saved` and `javaBlock`. `saved` is typed `unknown` because
+  `@jsprismarine/features` models no NBT and depends on no library that does, and the server narrows
+  it before reading it. `javaBlock` is the Java block the block entity sat in, which is the one thing
+  the saved compound does not carry: Java keeps a banner's color in the block, Bedrock keeps it in
+  the block entity and has a single banner block where Java has sixteen, so the color is
+  unrecoverable once the translation drops the Java palette.
+  
+  The template store indexes the Java block of each saved compound as it reads a template, keyed on
+  the compound itself. That works because the compounds travel by reference: `translateJavaTemplate`,
+  `transformTemplate` and `applyProcessors` each carry `nbt` through untouched, and the one processor
+  that writes to a block entity, a rule's `append_loot` modifier, adds to the compound it was handed
+  rather than replacing it.
+  
+  In a generated world at seed 1234, across the 25 chunks around the trial chamber at chunk 3,-14,
+  all 16 decorated pots carry their four sherds, all 13 vaults carry their reward table and their
+  key, and the one dispenser carries its water bucket. The 13 trial spawners there still carry
+  nothing. That is the listed loss: every trial spawner in the templates writes its configuration as
+  a reference into Java's own registry, and nothing is wired to resolve one.
+  
+  A vault no longer gets a top-level `LootTable`. Reading one level down into `config` for it was how
+  its reward reached a chunk before the contents translation existed. Bedrock's vault reads
+  `config.loot_table`, which the translation now writes, and a vault is not a container, so
+  `fillContainerLoot` never rolled the top-level copy either.
+  
+  One worldgen corpus digest moves, the block entities of `1234/3,-14/full`, which holds the single
+  vault the 22 corpus chunks record. Blocks, biomes, heightmaps, counts, structures and entity spawns
+  are unchanged, and so is the ocean ruin chest in `1234/-12,0/full`, which a data marker places with
+  no saved compound behind it.
+- Updated dependencies [[`b79c330`](https://github.com/JSPrismarine/JSPrismarine/commit/b79c33066896e4639b4c5a06b6739add55a3d361), [`5794f0b`](https://github.com/JSPrismarine/JSPrismarine/commit/5794f0bccdc0cc2123b46b71af342ece984e774a), [`62e14d2`](https://github.com/JSPrismarine/JSPrismarine/commit/62e14d2bf3c19d77897733a422885cdffdf13334), [`86444b4`](https://github.com/JSPrismarine/JSPrismarine/commit/86444b41bb7281acbd0e556ad9421fe913321af0), [`f060520`](https://github.com/JSPrismarine/JSPrismarine/commit/f060520321901b222197f2c65e75d5771c47cdfe), [`0f9d3c1`](https://github.com/JSPrismarine/JSPrismarine/commit/0f9d3c18e72967d0f4d1ba40221a1076bf24ac42), [`258e9d9`](https://github.com/JSPrismarine/JSPrismarine/commit/258e9d915c9d067a86f576ae64f07b992b7c4485), [`4cf5c25`](https://github.com/JSPrismarine/JSPrismarine/commit/4cf5c25c105f4d7dbea3d1d877d67cce48006234), [`7efae53`](https://github.com/JSPrismarine/JSPrismarine/commit/7efae5385415852da187f6b3ec1c010592b00d98), [`bd6780f`](https://github.com/JSPrismarine/JSPrismarine/commit/bd6780f89c73c69635adb9785a997f3103145fb1), [`bd65536`](https://github.com/JSPrismarine/JSPrismarine/commit/bd65536e966bab81bbf9af147a0bf5440890cdae), [`c29803c`](https://github.com/JSPrismarine/JSPrismarine/commit/c29803c5f9f502263fa51fe8c29d41a846048019)]:
+  - @jsprismarine/worldgen@0.16.0-unstable-20261029134110

package/LICENSE

@@ -0,0 +1,373 @@
+Mozilla Public License Version 2.0
+==================================
+
+1. Definitions
+--------------
+
+1.1. "Contributor"
+    means each individual or legal entity that creates, contributes to
+    the creation of, or owns Covered Software.
+
+1.2. "Contributor Version"
+    means the combination of the Contributions of others (if any) used
+    by a Contributor and that particular Contributor's Contribution.
+
+1.3. "Contribution"
+    means Covered Software of a particular Contributor.
+
+1.4. "Covered Software"
+    means Source Code Form to which the initial Contributor has attached
+    the notice in Exhibit A, the Executable Form of such Source Code
+    Form, and Modifications of such Source Code Form, in each case
+    including portions thereof.
+
+1.5. "Incompatible With Secondary Licenses"
+    means
+
+    (a) that the initial Contributor has attached the notice described
+        in Exhibit B to the Covered Software; or
+
+    (b) that the Covered Software was made available under the terms of
+        version 1.1 or earlier of the License, but not also under the
+        terms of a Secondary License.
+
+1.6. "Executable Form"
+    means any form of the work other than Source Code Form.
+
+1.7. "Larger Work"
+    means a work that combines Covered Software with other material, in
+    a separate file or files, that is not Covered Software.
+
+1.8. "License"
+    means this document.
+
+1.9. "Licensable"
+    means having the right to grant, to the maximum extent possible,
+    whether at the time of the initial grant or subsequently, any and
+    all of the rights conveyed by this License.
+
+1.10. "Modifications"
+    means any of the following:
+
+    (a) any file in Source Code Form that results from an addition to,
+        deletion from, or modification of the contents of Covered
+        Software; or
+
+    (b) any new file in Source Code Form that contains any Covered
+        Software.
+
+1.11. "Patent Claims" of a Contributor
+    means any patent claim(s), including without limitation, method,
+    process, and apparatus claims, in any patent Licensable by such
+    Contributor that would be infringed, but for the grant of the
+    License, by the making, using, selling, offering for sale, having
+    made, import, or transfer of either its Contributions or its
+    Contributor Version.
+
+1.12. "Secondary License"
+    means either the GNU General Public License, Version 2.0, the GNU
+    Lesser General Public License, Version 2.1, the GNU Affero General
+    Public License, Version 3.0, or any later versions of those
+    licenses.
+
+1.13. "Source Code Form"
+    means the form of the work preferred for making modifications.
+
+1.14. "You" (or "Your")
+    means an individual or a legal entity exercising rights under this
+    License. For legal entities, "You" includes any entity that
+    controls, is controlled by, or is under common control with You. For
+    purposes of this definition, "control" means (a) the power, direct
+    or indirect, to cause the direction or management of such entity,
+    whether by contract or otherwise, or (b) ownership of more than
+    fifty percent (50%) of the outstanding shares or beneficial
+    ownership of such entity.
+
+2. License Grants and Conditions
+--------------------------------
+
+2.1. Grants
+
+Each Contributor hereby grants You a world-wide, royalty-free,
+non-exclusive license:
+
+(a) under intellectual property rights (other than patent or trademark)
+    Licensable by such Contributor to use, reproduce, make available,
+    modify, display, perform, distribute, and otherwise exploit its
+    Contributions, either on an unmodified basis, with Modifications, or
+    as part of a Larger Work; and
+
+(b) under Patent Claims of such Contributor to make, use, sell, offer
+    for sale, have made, import, and otherwise transfer either its
+    Contributions or its Contributor Version.
+
+2.2. Effective Date
+
+The licenses granted in Section 2.1 with respect to any Contribution
+become effective for each Contribution on the date the Contributor first
+distributes such Contribution.
+
+2.3. Limitations on Grant Scope
+
+The licenses granted in this Section 2 are the only rights granted under
+this License. No additional rights or licenses will be implied from the
+distribution or licensing of Covered Software under this License.
+Notwithstanding Section 2.1(b) above, no patent license is granted by a
+Contributor:
+
+(a) for any code that a Contributor has removed from Covered Software;
+    or
+
+(b) for infringements caused by: (i) Your and any other third party's
+    modifications of Covered Software, or (ii) the combination of its
+    Contributions with other software (except as part of its Contributor
+    Version); or
+
+(c) under Patent Claims infringed by Covered Software in the absence of
+    its Contributions.
+
+This License does not grant any rights in the trademarks, service marks,
+or logos of any Contributor (except as may be necessary to comply with
+the notice requirements in Section 3.4).
+
+2.4. Subsequent Licenses
+
+No Contributor makes additional grants as a result of Your choice to
+distribute the Covered Software under a subsequent version of this
+License (see Section 10.2) or under the terms of a Secondary License (if
+permitted under the terms of Section 3.3).
+
+2.5. Representation
+
+Each Contributor represents that the Contributor believes its
+Contributions are its original creation(s) or it has sufficient rights
+to grant the rights to its Contributions conveyed by this License.
+
+2.6. Fair Use
+
+This License is not intended to limit any rights You have under
+applicable copyright doctrines of fair use, fair dealing, or other
+equivalents.
+
+2.7. Conditions
+
+Sections 3.1, 3.2, 3.3, and 3.4 are conditions of the licenses granted
+in Section 2.1.
+
+3. Responsibilities
+-------------------
+
+3.1. Distribution of Source Form
+
+All distribution of Covered Software in Source Code Form, including any
+Modifications that You create or to which You contribute, must be under
+the terms of this License. You must inform recipients that the Source
+Code Form of the Covered Software is governed by the terms of this
+License, and how they can obtain a copy of this License. You may not
+attempt to alter or restrict the recipients' rights in the Source Code
+Form.
+
+3.2. Distribution of Executable Form
+
+If You distribute Covered Software in Executable Form then:
+
+(a) such Covered Software must also be made available in Source Code
+    Form, as described in Section 3.1, and You must inform recipients of
+    the Executable Form how they can obtain a copy of such Source Code
+    Form by reasonable means in a timely manner, at a charge no more
+    than the cost of distribution to the recipient; and
+
+(b) You may distribute such Executable Form under the terms of this
+    License, or sublicense it under different terms, provided that the
+    license for the Executable Form does not attempt to limit or alter
+    the recipients' rights in the Source Code Form under this License.
+
+3.3. Distribution of a Larger Work
+
+You may create and distribute a Larger Work under terms of Your choice,
+provided that You also comply with the requirements of this License for
+the Covered Software. If the Larger Work is a combination of Covered
+Software with a work governed by one or more Secondary Licenses, and the
+Covered Software is not Incompatible With Secondary Licenses, this
+License permits You to additionally distribute such Covered Software
+under the terms of such Secondary License(s), so that the recipient of
+the Larger Work may, at their option, further distribute the Covered
+Software under the terms of either this License or such Secondary
+License(s).
+
+3.4. Notices
+
+You may not remove or alter the substance of any license notices
+(including copyright notices, patent notices, disclaimers of warranty,
+or limitations of liability) contained within the Source Code Form of
+the Covered Software, except that You may alter any license notices to
+the extent required to remedy known factual inaccuracies.
+
+3.5. Application of Additional Terms
+
+You may choose to offer, and to charge a fee for, warranty, support,
+indemnity or liability obligations to one or more recipients of Covered
+Software. However, You may do so only on Your own behalf, and not on
+behalf of any Contributor. You must make it absolutely clear that any
+such warranty, support, indemnity, or liability obligation is offered by
+You alone, and You hereby agree to indemnify every Contributor for any
+liability incurred by such Contributor as a result of warranty, support,
+indemnity or liability terms You offer. You may include additional
+disclaimers of warranty and limitations of liability specific to any
+jurisdiction.
+
+4. Inability to Comply Due to Statute or Regulation
+---------------------------------------------------
+
+If it is impossible for You to comply with any of the terms of this
+License with respect to some or all of the Covered Software due to
+statute, judicial order, or regulation then You must: (a) comply with
+the terms of this License to the maximum extent possible; and (b)
+describe the limitations and the code they affect. Such description must
+be placed in a text file included with all distributions of the Covered
+Software under this License. Except to the extent prohibited by statute
+or regulation, such description must be sufficiently detailed for a
+recipient of ordinary skill to be able to understand it.
+
+5. Termination
+--------------
+
+5.1. The rights granted under this License will terminate automatically
+if You fail to comply with any of its terms. However, if You become
+compliant, then the rights granted under this License from a particular
+Contributor are reinstated (a) provisionally, unless and until such
+Contributor explicitly and finally terminates Your grants, and (b) on an
+ongoing basis, if such Contributor fails to notify You of the
+non-compliance by some reasonable means prior to 60 days after You have
+come back into compliance. Moreover, Your grants from a particular
+Contributor are reinstated on an ongoing basis if such Contributor
+notifies You of the non-compliance by some reasonable means, this is the
+first time You have received notice of non-compliance with this License
+from such Contributor, and You become compliant prior to 30 days after
+Your receipt of the notice.
+
+5.2. If You initiate litigation against any entity by asserting a patent
+infringement claim (excluding declaratory judgment actions,
+counter-claims, and cross-claims) alleging that a Contributor Version
+directly or indirectly infringes any patent, then the rights granted to
+You by any and all Contributors for the Covered Software under Section
+2.1 of this License shall terminate.
+
+5.3. In the event of termination under Sections 5.1 or 5.2 above, all
+end user license agreements (excluding distributors and resellers) which
+have been validly granted by You or Your distributors under this License
+prior to termination shall survive termination.
+
+************************************************************************
+*                                                                      *
+*  6. Disclaimer of Warranty                                           *
+*  -------------------------                                           *
+*                                                                      *
+*  Covered Software is provided under this License on an "as is"       *
+*  basis, without warranty of any kind, either expressed, implied, or  *
+*  statutory, including, without limitation, warranties that the       *
+*  Covered Software is free of defects, merchantable, fit for a        *
+*  particular purpose or non-infringing. The entire risk as to the     *
+*  quality and performance of the Covered Software is with You.        *
+*  Should any Covered Software prove defective in any respect, You     *
+*  (not any Contributor) assume the cost of any necessary servicing,   *
+*  repair, or correction. This disclaimer of warranty constitutes an   *
+*  essential part of this License. No use of any Covered Software is   *
+*  authorized under this License except under this disclaimer.         *
+*                                                                      *
+************************************************************************
+
+************************************************************************
+*                                                                      *
+*  7. Limitation of Liability                                          *
+*  --------------------------                                          *
+*                                                                      *
+*  Under no circumstances and under no legal theory, whether tort      *
+*  (including negligence), contract, or otherwise, shall any           *
+*  Contributor, or anyone who distributes Covered Software as          *
+*  permitted above, be liable to You for any direct, indirect,         *
+*  special, incidental, or consequential damages of any character      *
+*  including, without limitation, damages for lost profits, loss of    *
+*  goodwill, work stoppage, computer failure or malfunction, or any    *
+*  and all other commercial damages or losses, even if such party      *
+*  shall have been informed of the possibility of such damages. This   *
+*  limitation of liability shall not apply to liability for death or   *
+*  personal injury resulting from such party's negligence to the       *
+*  extent applicable law prohibits such limitation. Some               *
+*  jurisdictions do not allow the exclusion or limitation of           *
+*  incidental or consequential damages, so this exclusion and          *
+*  limitation may not apply to You.                                    *
+*                                                                      *
+************************************************************************
+
+8. Litigation
+-------------
+
+Any litigation relating to this License may be brought only in the
+courts of a jurisdiction where the defendant maintains its principal
+place of business and such litigation shall be governed by laws of that
+jurisdiction, without reference to its conflict-of-law provisions.
+Nothing in this Section shall prevent a party's ability to bring
+cross-claims or counter-claims.
+
+9. Miscellaneous
+----------------
+
+This License represents the complete agreement concerning the subject
+matter hereof. If any provision of this License is held to be
+unenforceable, such provision shall be reformed only to the extent
+necessary to make it enforceable. Any law or regulation which provides
+that the language of a contract shall be construed against the drafter
+shall not be used to construe this License against a Contributor.
+
+10. Versions of the License
+---------------------------
+
+10.1. New Versions
+
+Mozilla Foundation is the license steward. Except as provided in Section
+10.3, no one other than the license steward has the right to modify or
+publish new versions of this License. Each version will be given a
+distinguishing version number.
+
+10.2. Effect of New Versions
+
+You may distribute the Covered Software under the terms of the version
+of the License under which You originally received the Covered Software,
+or under the terms of any subsequent version published by the license
+steward.
+
+10.3. Modified Versions
+
+If you create software not governed by this License, and you want to
+create a new license for such software, you may create and use a
+modified version of this License if you rename the license and remove
+any references to the name of the license steward (except to note that
+such modified license differs from this License).
+
+10.4. Distributing Source Code Form that is Incompatible With Secondary
+Licenses
+
+If You choose to distribute Source Code Form that is Incompatible With
+Secondary Licenses under the terms of this version of the License, the
+notice described in Exhibit B of this License must be attached.
+
+Exhibit A - Source Code Form License Notice
+-------------------------------------------
+
+  This Source Code Form is subject to the terms of the Mozilla Public
+  License, v. 2.0. If a copy of the MPL was not distributed with this
+  file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+If it is not possible or desirable to put the notice in a particular
+file, then You may include the notice in a location (such as a LICENSE
+file in a relevant directory) where a recipient would be likely to look
+for such a notice.
+
+You may add additional accurate notices of copyright ownership.
+
+Exhibit B - "Incompatible With Secondary Licenses" Notice
+---------------------------------------------------------
+
+  This Source Code Form is "Incompatible With Secondary Licenses", as
+  defined by the Mozilla Public License, v. 2.0.