@jspg-ai/coding-bb 0.0.1 → 0.0.2-beta.23

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (145) hide show
  1. package/cbb/bin/cbb.js +6 -0
  2. package/cbb/bin/cbbm.js +6 -0
  3. package/cbb/dev-standards/rules/cbb-ai-behavior.md +103 -103
  4. package/cbb/dev-standards/rules/cbb-priority.md +55 -55
  5. package/cbb/lib/install/claude-code.js +2 -0
  6. package/cbb/lib/install/init.js +496 -290
  7. package/cbb/lib/install/opencode.js +31 -0
  8. package/cbb/lib/install/qoder.js +2 -0
  9. package/cbb/lib/install/workspaces.js +53 -13
  10. package/cbb/lib/openspec/index.js +3 -3
  11. package/cbb/lib/superpowers/index.js +1 -1
  12. package/cbb/lib/utils/check-update.js +16 -14
  13. package/cbb/lib/utils/gitignore.js +2 -1
  14. package/cbb/lib/utils/output.js +92 -4
  15. package/cbb/lib/utils/version.js +2 -31
  16. package/cbb/lib/wiki/cli.js +25 -25
  17. package/cbb/lib/wiki/index.js +16 -16
  18. package/cbb/tools/cbb-design-to-wiki/SKILL.md +14 -14
  19. package/cbb/tools/cbb-wiki-ops/SKILL.md +22 -22
  20. package/cbb/worktrees/_shared/scripts/find-target-worktree.js +2 -2
  21. package/cbb/worktrees/_shared/scripts/find-workspace-root.js +7 -7
  22. package/cbb/worktrees/_shared/scripts/push-core.js +18 -0
  23. package/cbb/worktrees/commands/{close.md → worktree-close.md} +8 -8
  24. package/cbb/worktrees/commands/{init.md → worktree-init.md} +9 -9
  25. package/cbb/worktrees/commands/{push.md → worktree-push.md} +3 -3
  26. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/SKILL.md +20 -20
  27. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/check-env.js +4 -4
  28. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/check-unarchived.js +1 -1
  29. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/delete-branches.js +3 -3
  30. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/discover-apps.js +6 -6
  31. package/cbb/worktrees/skills/{openspec-extend-worktree → cbb-worktree-close}/scripts/find-target-worktree.js +2 -2
  32. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-close}/scripts/find-workspace-root.js +7 -7
  33. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/remove-worktrees.js +4 -4
  34. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/safety-check.js +4 -4
  35. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/SKILL.md +81 -107
  36. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/auto-open.js +1 -1
  37. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/check-env-deep.js +4 -4
  38. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/check-env.js +6 -6
  39. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/check-repos.js +4 -4
  40. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/create-branches.js +4 -4
  41. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/create-worktrees.js +8 -7
  42. package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-init}/scripts/find-workspace-root.js +7 -7
  43. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/install-ai.js +33 -33
  44. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/parse-config.js +7 -7
  45. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/push-branches.js +9 -7
  46. package/cbb/worktrees/skills/{openspec-extend-worktree → cbb-worktree-init}/scripts/push-core.js +18 -0
  47. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/sync-repos.js +10 -12
  48. package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-init}/scripts/update-gitignore.js +19 -6
  49. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-push}/SKILL.md +16 -16
  50. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-push}/scripts/commit-worktrees.js +2 -2
  51. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-push}/scripts/find-target-worktree.js +2 -2
  52. package/cbb/worktrees/skills/{openspec-extend-worktree → cbb-worktree-push}/scripts/find-workspace-root.js +7 -7
  53. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-push}/scripts/push-core.js +18 -0
  54. package/cbb/worktrees/skills/{openspec-push-worktrees → cbb-worktree-push}/scripts/push-worktrees.js +7 -5
  55. package/config/workspace-config.sample.json +18 -0
  56. package/config/workspaces.json +11 -6
  57. package/openspec/.version +6 -6
  58. package/openspec/commands/apply.md +7 -7
  59. package/openspec/commands/archive.md +7 -7
  60. package/openspec/commands/bulk-archive.md +7 -7
  61. package/openspec/commands/continue.md +7 -7
  62. package/openspec/commands/explore.md +7 -7
  63. package/openspec/commands/ff.md +7 -7
  64. package/openspec/commands/new.md +7 -7
  65. package/openspec/commands/onboard.md +7 -7
  66. package/openspec/commands/propose.md +7 -7
  67. package/openspec/commands/sync.md +7 -7
  68. package/openspec/commands/update.md +7 -7
  69. package/openspec/commands/verify.md +7 -7
  70. package/openspec/skills/openspec-apply-change/SKILL.md +187 -187
  71. package/openspec/skills/openspec-archive-change/SKILL.md +181 -181
  72. package/openspec/skills/openspec-bulk-archive-change/SKILL.md +338 -338
  73. package/openspec/skills/openspec-continue-change/SKILL.md +117 -117
  74. package/openspec/skills/openspec-explore/SKILL.md +342 -342
  75. package/openspec/skills/openspec-ff-change/SKILL.md +116 -116
  76. package/openspec/skills/openspec-new-change/SKILL.md +76 -76
  77. package/openspec/skills/openspec-onboard/SKILL.md +560 -560
  78. package/openspec/skills/openspec-propose/SKILL.md +162 -162
  79. package/openspec/skills/openspec-sync-specs/SKILL.md +261 -261
  80. package/openspec/skills/openspec-update-change/SKILL.md +90 -90
  81. package/openspec/skills/openspec-verify-change/SKILL.md +174 -174
  82. package/package.json +4 -3
  83. package/superpowers/.version +6 -6
  84. package/superpowers/skills/brainstorming/SKILL.md +250 -250
  85. package/superpowers/skills/brainstorming/scripts/helper.js +167 -167
  86. package/superpowers/skills/brainstorming/scripts/start-server.sh +209 -209
  87. package/superpowers/skills/brainstorming/scripts/stop-server.sh +120 -120
  88. package/superpowers/skills/brainstorming/spec-document-reviewer-prompt.md +49 -49
  89. package/superpowers/skills/brainstorming/visual-companion.md +299 -299
  90. package/superpowers/skills/dispatching-parallel-agents/SKILL.md +167 -167
  91. package/superpowers/skills/executing-plans/SKILL.md +64 -64
  92. package/superpowers/skills/finishing-a-development-branch/SKILL.md +225 -225
  93. package/superpowers/skills/receiving-code-review/SKILL.md +205 -205
  94. package/superpowers/skills/requesting-code-review/SKILL.md +95 -95
  95. package/superpowers/skills/requesting-code-review/code-reviewer.md +181 -181
  96. package/superpowers/skills/subagent-driven-development/SKILL.md +568 -568
  97. package/superpowers/skills/subagent-driven-development/implementer-prompt.md +154 -154
  98. package/superpowers/skills/subagent-driven-development/re-review-prompt.md +115 -115
  99. package/superpowers/skills/subagent-driven-development/task-reviewer-prompt.md +207 -207
  100. package/superpowers/skills/systematic-debugging/CREATION-LOG.md +119 -119
  101. package/superpowers/skills/systematic-debugging/SKILL.md +283 -283
  102. package/superpowers/skills/systematic-debugging/condition-based-waiting-example.ts +158 -158
  103. package/superpowers/skills/systematic-debugging/condition-based-waiting.md +115 -115
  104. package/superpowers/skills/systematic-debugging/defense-in-depth.md +122 -122
  105. package/superpowers/skills/systematic-debugging/find-polluter.sh +72 -72
  106. package/superpowers/skills/systematic-debugging/root-cause-tracing.md +169 -169
  107. package/superpowers/skills/systematic-debugging/test-academic.md +14 -14
  108. package/superpowers/skills/systematic-debugging/test-pressure-1.md +58 -58
  109. package/superpowers/skills/systematic-debugging/test-pressure-2.md +68 -68
  110. package/superpowers/skills/systematic-debugging/test-pressure-3.md +69 -69
  111. package/superpowers/skills/test-driven-development/SKILL.md +320 -320
  112. package/superpowers/skills/test-driven-development/writing-good-tests.md +198 -198
  113. package/superpowers/skills/using-git-worktrees/SKILL.md +167 -167
  114. package/superpowers/skills/using-superpowers/SKILL.md +63 -63
  115. package/superpowers/skills/using-superpowers/references/antigravity-tools.md +23 -23
  116. package/superpowers/skills/using-superpowers/references/codex-tools.md +108 -108
  117. package/superpowers/skills/using-superpowers/references/gemini-tools.md +63 -63
  118. package/superpowers/skills/using-superpowers/references/hermes-tools.md +56 -56
  119. package/superpowers/skills/using-superpowers/references/pi-tools.md +16 -16
  120. package/superpowers/skills/verification-before-completion/SKILL.md +120 -120
  121. package/superpowers/skills/writing-plans/SKILL.md +171 -171
  122. package/superpowers/skills/writing-plans/plan-document-reviewer-prompt.md +49 -49
  123. package/superpowers/skills/writing-skills/SKILL.md +679 -679
  124. package/superpowers/skills/writing-skills/anthropic-best-practices.md +1150 -1150
  125. package/superpowers/skills/writing-skills/examples/CLAUDE_MD_TESTING.md +189 -189
  126. package/superpowers/skills/writing-skills/persuasion-principles.md +187 -187
  127. package/superpowers/skills/writing-skills/render-graphs.js +169 -169
  128. package/superpowers/skills/writing-skills/testing-skills-with-subagents.md +384 -384
  129. package/cbb/worktrees/commands/extend.md +0 -65
  130. package/cbb/worktrees/skills/openspec-close-worktree/scripts/find-target-worktree.js +0 -96
  131. package/cbb/worktrees/skills/openspec-extend-worktree/SKILL.md +0 -390
  132. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/check-env.js +0 -95
  133. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/check-repos.js +0 -98
  134. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/create-branches-and-worktrees.js +0 -135
  135. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/install-ai.js +0 -150
  136. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/list-available-apps.js +0 -88
  137. package/cbb/worktrees/skills/openspec-extend-worktree/scripts/sync-repos.js +0 -93
  138. package/cbb/worktrees/skills/openspec-init-worktree/scripts/find-workspace-root.js +0 -67
  139. package/cbb/worktrees/skills/openspec-init-worktree/scripts/generate-app-options.js +0 -93
  140. package/cbb/worktrees/skills/openspec-init-worktree/scripts/push-core.js +0 -136
  141. package/cbb/worktrees/skills/openspec-push-worktrees/scripts/silence-popup.js +0 -23
  142. package/config/config.sample.json +0 -16
  143. /package/cbb/worktrees/skills/{openspec-close-worktree → cbb-worktree-close}/scripts/silence-popup.js +0 -0
  144. /package/cbb/worktrees/skills/{openspec-extend-worktree → cbb-worktree-init}/scripts/silence-popup.js +0 -0
  145. /package/cbb/worktrees/skills/{openspec-init-worktree → cbb-worktree-push}/scripts/silence-popup.js +0 -0
@@ -1,207 +1,207 @@
1
- # Task Reviewer Prompt Template
2
-
3
- Use this template when dispatching a task reviewer subagent. The reviewer
4
- reads the task's diff once and returns two verdicts: spec compliance and
5
- code quality.
6
-
7
- **Purpose:** Verify one task's implementation matches its requirements (nothing
8
- more, nothing less) and is well-built (clean, tested, maintainable)
9
-
10
- ```
11
- Subagent (general-purpose):
12
- description: "Review Task N (spec + quality)"
13
- model: [MODEL — REQUIRED: choose per SKILL.md Model Selection; an omitted
14
- model silently inherits the session's most expensive one]
15
- prompt: |
16
- You are reviewing one task's implementation: first whether it matches its
17
- requirements, then whether it is well-built. This is a task-scoped gate,
18
- not a merge review — a broad whole-branch review happens separately after
19
- all tasks are complete.
20
-
21
- ## What Was Requested
22
-
23
- Read the task brief: [BRIEF_FILE]
24
-
25
- Global constraints from the spec/design that bind this task:
26
- [GLOBAL_CONSTRAINTS]
27
-
28
- ## What the Implementer Claims They Built
29
-
30
- Read the implementer's report: [REPORT_FILE]
31
-
32
- ## Diff Under Review
33
-
34
- **Base:** [BASE_SHA]
35
- **Head:** [HEAD_SHA]
36
- **Diff file:** [DIFF_FILE]
37
-
38
- Read the diff file once — it contains the commit list, a stat summary,
39
- and the full diff with surrounding context, and it is your view of the
40
- change. The diff's context lines ARE the changed files: do not Read a
41
- changed file separately unless a hunk you must judge is cut off
42
- mid-function — and say so in your report. Do not re-run git commands.
43
- If the diff file is missing, fetch the diff yourself:
44
- `git diff --stat [BASE_SHA]..[HEAD_SHA]` and `git diff [BASE_SHA]..[HEAD_SHA]`.
45
- Do not crawl the broader codebase. Inspect code outside the diff only
46
- to evaluate a concrete risk you can name — one focused check per named
47
- risk, and name both the risk and what you checked in your report.
48
- Cross-cutting changes are legitimate named risks: if the diff changes
49
- lock ordering, a function or API contract, or shared mutable state,
50
- checking the call sites is the right method.
51
-
52
- Your review is read-only on this checkout. Do not mutate the working
53
- tree, the index, HEAD, or branch state in any way.
54
-
55
- ## You Do Not Dispatch Subagents
56
-
57
- Do all of this review yourself. Never spawn a subagent to review part
58
- of the diff, and never spawn another reviewer for a second opinion.
59
- This process already provides every review seat the work gets; a
60
- reviewer you spawn duplicates one of them at full cost, and its
61
- verdict counts for nothing. If the diff feels too large for one
62
- pass, review it in passes yourself and say so in your report.
63
-
64
- ## Do Not Trust the Report
65
-
66
- Treat the implementer's report as unverified claims about the code. It
67
- may be incomplete, inaccurate, or optimistic. Verify the claims against
68
- the diff. Design rationales in the report are claims too: "left it per
69
- YAGNI," "kept it simple deliberately," or any other justification is the
70
- implementer grading their own work. Judge the code on its merits — a
71
- stated rationale never downgrades a finding's severity.
72
-
73
- ## Tests
74
-
75
- The implementer already ran the tests and reported results with TDD
76
- evidence for exactly this code. Do not re-run the suite to confirm their
77
- report. Run a test only when reading the code raises a specific doubt
78
- that no existing run answers — and then a focused test, never a
79
- package-wide suite, race detector run, or repeated/high-count loop. If
80
- heavy validation seems warranted, recommend it in your report instead of
81
- running it. If you cannot run commands in this environment, name the
82
- test you would run.
83
-
84
- Warnings or other noise in the implementer's reported test output are
85
- findings — test output should be pristine.
86
-
87
- Evidence you cannot see is not evidence that doesn't exist. If the
88
- report or its test evidence looks truncated, or you cannot locate the
89
- results it claims, re-read the file at its stated path — and if it is
90
- genuinely missing or garbled, report that as a gap for the controller.
91
- Re-running the suite to regenerate what you failed to read is not
92
- verification; illegibility of the evidence is not invalidation of it.
93
-
94
- ## Part 1: Spec Compliance
95
-
96
- Compare the diff against What Was Requested:
97
-
98
- - **Missing:** requirements they skipped, missed, or claimed without
99
- implementing
100
- - **Extra:** features that weren't requested, over-engineering, unneeded
101
- "nice to haves"
102
- - **Misunderstood:** right feature built the wrong way, wrong problem
103
- solved
104
-
105
- If the brief lists several files each with its own change (a batched
106
- dispatch), check the diff against that list file by file: every listed
107
- file must have its corresponding hunk. A listed file the diff never
108
- touches is a Missing finding, no matter how clean the rest of the
109
- batch looks.
110
-
111
- If a requirement cannot be verified from this diff alone (it lives in
112
- unchanged code or spans tasks), report it as a ⚠️ item instead of
113
- broadening your search.
114
-
115
- ## Part 2: Code Quality
116
-
117
- **Code quality:**
118
- - Clean separation of concerns?
119
- - Proper error handling?
120
- - DRY without premature abstraction?
121
- - Edge cases handled?
122
-
123
- **Tests:**
124
- - Do the new and changed tests verify real behavior, not mocks?
125
- - Are the task's edge cases covered?
126
-
127
- **Structure:**
128
- - Does each file have one clear responsibility with a well-defined interface?
129
- - Are units decomposed so they can be understood and tested independently?
130
- - Is the implementation following the file structure from the plan?
131
- - Did this change create new files that are already large, or
132
- significantly grow existing files? (Don't flag pre-existing file
133
- sizes — focus on what this change contributed.)
134
-
135
- Your report should point at evidence: file:line references for every
136
- finding and for any check you would otherwise answer with a bare
137
- "yes." A tight report that cites lines gives the controller everything
138
- it needs.
139
-
140
- Your final message is the report itself: begin directly with the
141
- spec-compliance verdict. Every line is a verdict, a finding with
142
- file:line, or a check you ran — no preamble, no process narration,
143
- no closing summary.
144
-
145
- ## Calibration
146
-
147
- Categorize issues by actual severity. Not everything is Critical.
148
- Important means this task cannot be trusted until it is fixed: incorrect
149
- or fragile behavior, a missed requirement, or maintainability damage you
150
- would block a merge over — verbatim duplication of a logic block,
151
- swallowed errors, tests that assert nothing. "Coverage could be broader"
152
- and polish suggestions are Minor.
153
- If the plan or brief explicitly mandates something this rubric calls a
154
- defect (a test that asserts nothing, verbatim duplication of a logic
155
- block), that IS a finding — report it as Important, labeled
156
- plan-mandated. The plan's authorship does not grade its own work; the
157
- human decides.
158
- Acknowledge what was done well before listing issues — accurate praise
159
- helps the implementer trust the rest of the feedback.
160
-
161
- ## Output Format
162
-
163
- ### Spec Compliance
164
-
165
- - ✅ Spec compliant | ❌ Issues found: [what's missing/extra/misunderstood,
166
- with file:line references]
167
- - ⚠️ Cannot verify from diff: [requirements you could not verify from the
168
- diff alone, and what the controller should check — report alongside the
169
- ✅/❌ verdict for everything you could verify]
170
-
171
- ### Strengths
172
- [What's well done? Be specific.]
173
-
174
- ### Issues
175
-
176
- #### Critical (Must Fix)
177
- #### Important (Should Fix)
178
- #### Minor (Nice to Have)
179
-
180
- For each issue: file:line, what's wrong, why it matters, how to fix
181
- (if not obvious).
182
-
183
- ### Assessment
184
-
185
- **Task quality:** [Approved | Needs fixes]
186
-
187
- **Reasoning:** [1-2 sentence technical assessment]
188
- ```
189
-
190
- **Placeholders:**
191
- - `[MODEL]` — REQUIRED: reviewer model per SKILL.md Model Selection
192
- - `[BRIEF_FILE]` — REQUIRED: the task brief file (`scripts/task-brief PLAN N`
193
- prints the path; same file the implementer worked from)
194
- - `[GLOBAL_CONSTRAINTS]` — the binding requirements copied verbatim from
195
- the plan's Global Constraints section or the spec: exact values, formats,
196
- and stated relationships between components (not process rules — those
197
- are already in this template)
198
- - `[REPORT_FILE]` — REQUIRED: the file the implementer wrote its detailed
199
- report to
200
- - `[BASE_SHA]` — commit before this task
201
- - `[HEAD_SHA]` — current commit
202
- - `[DIFF_FILE]` — REQUIRED: the path the controller wrote the review
203
- package to (`scripts/review-package PLAN_FILE BASE HEAD` prints the unique
204
- path it wrote; the package never enters the controller's context)
205
-
206
- **Reviewer returns:** Spec Compliance verdict (✅/❌/⚠️), Strengths, Issues
207
- (Critical/Important/Minor), Task quality verdict
1
+ # Task Reviewer Prompt Template
2
+
3
+ Use this template when dispatching a task reviewer subagent. The reviewer
4
+ reads the task's diff once and returns two verdicts: spec compliance and
5
+ code quality.
6
+
7
+ **Purpose:** Verify one task's implementation matches its requirements (nothing
8
+ more, nothing less) and is well-built (clean, tested, maintainable)
9
+
10
+ ```
11
+ Subagent (general-purpose):
12
+ description: "Review Task N (spec + quality)"
13
+ model: [MODEL — REQUIRED: choose per SKILL.md Model Selection; an omitted
14
+ model silently inherits the session's most expensive one]
15
+ prompt: |
16
+ You are reviewing one task's implementation: first whether it matches its
17
+ requirements, then whether it is well-built. This is a task-scoped gate,
18
+ not a merge review — a broad whole-branch review happens separately after
19
+ all tasks are complete.
20
+
21
+ ## What Was Requested
22
+
23
+ Read the task brief: [BRIEF_FILE]
24
+
25
+ Global constraints from the spec/design that bind this task:
26
+ [GLOBAL_CONSTRAINTS]
27
+
28
+ ## What the Implementer Claims They Built
29
+
30
+ Read the implementer's report: [REPORT_FILE]
31
+
32
+ ## Diff Under Review
33
+
34
+ **Base:** [BASE_SHA]
35
+ **Head:** [HEAD_SHA]
36
+ **Diff file:** [DIFF_FILE]
37
+
38
+ Read the diff file once — it contains the commit list, a stat summary,
39
+ and the full diff with surrounding context, and it is your view of the
40
+ change. The diff's context lines ARE the changed files: do not Read a
41
+ changed file separately unless a hunk you must judge is cut off
42
+ mid-function — and say so in your report. Do not re-run git commands.
43
+ If the diff file is missing, fetch the diff yourself:
44
+ `git diff --stat [BASE_SHA]..[HEAD_SHA]` and `git diff [BASE_SHA]..[HEAD_SHA]`.
45
+ Do not crawl the broader codebase. Inspect code outside the diff only
46
+ to evaluate a concrete risk you can name — one focused check per named
47
+ risk, and name both the risk and what you checked in your report.
48
+ Cross-cutting changes are legitimate named risks: if the diff changes
49
+ lock ordering, a function or API contract, or shared mutable state,
50
+ checking the call sites is the right method.
51
+
52
+ Your review is read-only on this checkout. Do not mutate the working
53
+ tree, the index, HEAD, or branch state in any way.
54
+
55
+ ## You Do Not Dispatch Subagents
56
+
57
+ Do all of this review yourself. Never spawn a subagent to review part
58
+ of the diff, and never spawn another reviewer for a second opinion.
59
+ This process already provides every review seat the work gets; a
60
+ reviewer you spawn duplicates one of them at full cost, and its
61
+ verdict counts for nothing. If the diff feels too large for one
62
+ pass, review it in passes yourself and say so in your report.
63
+
64
+ ## Do Not Trust the Report
65
+
66
+ Treat the implementer's report as unverified claims about the code. It
67
+ may be incomplete, inaccurate, or optimistic. Verify the claims against
68
+ the diff. Design rationales in the report are claims too: "left it per
69
+ YAGNI," "kept it simple deliberately," or any other justification is the
70
+ implementer grading their own work. Judge the code on its merits — a
71
+ stated rationale never downgrades a finding's severity.
72
+
73
+ ## Tests
74
+
75
+ The implementer already ran the tests and reported results with TDD
76
+ evidence for exactly this code. Do not re-run the suite to confirm their
77
+ report. Run a test only when reading the code raises a specific doubt
78
+ that no existing run answers — and then a focused test, never a
79
+ package-wide suite, race detector run, or repeated/high-count loop. If
80
+ heavy validation seems warranted, recommend it in your report instead of
81
+ running it. If you cannot run commands in this environment, name the
82
+ test you would run.
83
+
84
+ Warnings or other noise in the implementer's reported test output are
85
+ findings — test output should be pristine.
86
+
87
+ Evidence you cannot see is not evidence that doesn't exist. If the
88
+ report or its test evidence looks truncated, or you cannot locate the
89
+ results it claims, re-read the file at its stated path — and if it is
90
+ genuinely missing or garbled, report that as a gap for the controller.
91
+ Re-running the suite to regenerate what you failed to read is not
92
+ verification; illegibility of the evidence is not invalidation of it.
93
+
94
+ ## Part 1: Spec Compliance
95
+
96
+ Compare the diff against What Was Requested:
97
+
98
+ - **Missing:** requirements they skipped, missed, or claimed without
99
+ implementing
100
+ - **Extra:** features that weren't requested, over-engineering, unneeded
101
+ "nice to haves"
102
+ - **Misunderstood:** right feature built the wrong way, wrong problem
103
+ solved
104
+
105
+ If the brief lists several files each with its own change (a batched
106
+ dispatch), check the diff against that list file by file: every listed
107
+ file must have its corresponding hunk. A listed file the diff never
108
+ touches is a Missing finding, no matter how clean the rest of the
109
+ batch looks.
110
+
111
+ If a requirement cannot be verified from this diff alone (it lives in
112
+ unchanged code or spans tasks), report it as a ⚠️ item instead of
113
+ broadening your search.
114
+
115
+ ## Part 2: Code Quality
116
+
117
+ **Code quality:**
118
+ - Clean separation of concerns?
119
+ - Proper error handling?
120
+ - DRY without premature abstraction?
121
+ - Edge cases handled?
122
+
123
+ **Tests:**
124
+ - Do the new and changed tests verify real behavior, not mocks?
125
+ - Are the task's edge cases covered?
126
+
127
+ **Structure:**
128
+ - Does each file have one clear responsibility with a well-defined interface?
129
+ - Are units decomposed so they can be understood and tested independently?
130
+ - Is the implementation following the file structure from the plan?
131
+ - Did this change create new files that are already large, or
132
+ significantly grow existing files? (Don't flag pre-existing file
133
+ sizes — focus on what this change contributed.)
134
+
135
+ Your report should point at evidence: file:line references for every
136
+ finding and for any check you would otherwise answer with a bare
137
+ "yes." A tight report that cites lines gives the controller everything
138
+ it needs.
139
+
140
+ Your final message is the report itself: begin directly with the
141
+ spec-compliance verdict. Every line is a verdict, a finding with
142
+ file:line, or a check you ran — no preamble, no process narration,
143
+ no closing summary.
144
+
145
+ ## Calibration
146
+
147
+ Categorize issues by actual severity. Not everything is Critical.
148
+ Important means this task cannot be trusted until it is fixed: incorrect
149
+ or fragile behavior, a missed requirement, or maintainability damage you
150
+ would block a merge over — verbatim duplication of a logic block,
151
+ swallowed errors, tests that assert nothing. "Coverage could be broader"
152
+ and polish suggestions are Minor.
153
+ If the plan or brief explicitly mandates something this rubric calls a
154
+ defect (a test that asserts nothing, verbatim duplication of a logic
155
+ block), that IS a finding — report it as Important, labeled
156
+ plan-mandated. The plan's authorship does not grade its own work; the
157
+ human decides.
158
+ Acknowledge what was done well before listing issues — accurate praise
159
+ helps the implementer trust the rest of the feedback.
160
+
161
+ ## Output Format
162
+
163
+ ### Spec Compliance
164
+
165
+ - ✅ Spec compliant | ❌ Issues found: [what's missing/extra/misunderstood,
166
+ with file:line references]
167
+ - ⚠️ Cannot verify from diff: [requirements you could not verify from the
168
+ diff alone, and what the controller should check — report alongside the
169
+ ✅/❌ verdict for everything you could verify]
170
+
171
+ ### Strengths
172
+ [What's well done? Be specific.]
173
+
174
+ ### Issues
175
+
176
+ #### Critical (Must Fix)
177
+ #### Important (Should Fix)
178
+ #### Minor (Nice to Have)
179
+
180
+ For each issue: file:line, what's wrong, why it matters, how to fix
181
+ (if not obvious).
182
+
183
+ ### Assessment
184
+
185
+ **Task quality:** [Approved | Needs fixes]
186
+
187
+ **Reasoning:** [1-2 sentence technical assessment]
188
+ ```
189
+
190
+ **Placeholders:**
191
+ - `[MODEL]` — REQUIRED: reviewer model per SKILL.md Model Selection
192
+ - `[BRIEF_FILE]` — REQUIRED: the task brief file (`scripts/task-brief PLAN N`
193
+ prints the path; same file the implementer worked from)
194
+ - `[GLOBAL_CONSTRAINTS]` — the binding requirements copied verbatim from
195
+ the plan's Global Constraints section or the spec: exact values, formats,
196
+ and stated relationships between components (not process rules — those
197
+ are already in this template)
198
+ - `[REPORT_FILE]` — REQUIRED: the file the implementer wrote its detailed
199
+ report to
200
+ - `[BASE_SHA]` — commit before this task
201
+ - `[HEAD_SHA]` — current commit
202
+ - `[DIFF_FILE]` — REQUIRED: the path the controller wrote the review
203
+ package to (`scripts/review-package PLAN_FILE BASE HEAD` prints the unique
204
+ path it wrote; the package never enters the controller's context)
205
+
206
+ **Reviewer returns:** Spec Compliance verdict (✅/❌/⚠️), Strengths, Issues
207
+ (Critical/Important/Minor), Task quality verdict
@@ -1,119 +1,119 @@
1
- # Creation Log: Systematic Debugging Skill
2
-
3
- Reference example of extracting, structuring, and bulletproofing a critical skill.
4
-
5
- ## Source Material
6
-
7
- Extracted debugging framework from `~/.claude/CLAUDE.md`:
8
- - 4-phase systematic process (Investigation → Pattern Analysis → Hypothesis → Implementation)
9
- - Core mandate: ALWAYS find root cause, NEVER fix symptoms
10
- - Rules designed to resist time pressure and rationalization
11
-
12
- ## Extraction Decisions
13
-
14
- **What to include:**
15
- - Complete 4-phase framework with all rules
16
- - Anti-shortcuts ("NEVER fix symptom", "STOP and re-analyze")
17
- - Pressure-resistant language ("even if faster", "even if I seem in a hurry")
18
- - Concrete steps for each phase
19
-
20
- **What to leave out:**
21
- - Project-specific context
22
- - Repetitive variations of same rule
23
- - Narrative explanations (condensed to principles)
24
-
25
- ## Structure Following skill-creation/SKILL.md
26
-
27
- 1. **Rich when_to_use** - Included symptoms and anti-patterns
28
- 2. **Type: technique** - Concrete process with steps
29
- 3. **Keywords** - "root cause", "symptom", "workaround", "debugging", "investigation"
30
- 4. **Flowchart** - Decision point for "fix failed" → re-analyze vs add more fixes
31
- 5. **Phase-by-phase breakdown** - Scannable checklist format
32
- 6. **Anti-patterns section** - What NOT to do (critical for this skill)
33
-
34
- ## Bulletproofing Elements
35
-
36
- Framework designed to resist rationalization under pressure:
37
-
38
- ### Language Choices
39
- - "ALWAYS" / "NEVER" (not "should" / "try to")
40
- - "even if faster" / "even if I seem in a hurry"
41
- - "STOP and re-analyze" (explicit pause)
42
- - "Don't skip past" (catches the actual behavior)
43
-
44
- ### Structural Defenses
45
- - **Phase 1 required** - Can't skip to implementation
46
- - **Single hypothesis rule** - Forces thinking, prevents shotgun fixes
47
- - **Explicit failure mode** - "IF your first fix doesn't work" with mandatory action
48
- - **Anti-patterns section** - Shows exactly what shortcuts look like
49
-
50
- ### Redundancy
51
- - Root cause mandate in overview + when_to_use + Phase 1 + implementation rules
52
- - "NEVER fix symptom" appears 4 times in different contexts
53
- - Each phase has explicit "don't skip" guidance
54
-
55
- ## Testing Approach
56
-
57
- Created 4 validation tests following skills/meta/testing-skills-with-subagents:
58
-
59
- ### Test 1: Academic Context (No Pressure)
60
- - Simple bug, no time pressure
61
- - **Result:** Perfect compliance, complete investigation
62
-
63
- ### Test 2: Time Pressure + Obvious Quick Fix
64
- - User "in a hurry", symptom fix looks easy
65
- - **Result:** Resisted shortcut, followed full process, found real root cause
66
-
67
- ### Test 3: Complex System + Uncertainty
68
- - Multi-layer failure, unclear if can find root cause
69
- - **Result:** Systematic investigation, traced through all layers, found source
70
-
71
- ### Test 4: Failed First Fix
72
- - Hypothesis doesn't work, temptation to add more fixes
73
- - **Result:** Stopped, re-analyzed, formed new hypothesis (no shotgun)
74
-
75
- **All tests passed.** No rationalizations found.
76
-
77
- ## Iterations
78
-
79
- ### Initial Version
80
- - Complete 4-phase framework
81
- - Anti-patterns section
82
- - Flowchart for "fix failed" decision
83
-
84
- ### Enhancement 1: TDD Reference
85
- - Added link to skills/testing/test-driven-development
86
- - Note explaining TDD's "simplest code" ≠ debugging's "root cause"
87
- - Prevents confusion between methodologies
88
-
89
- ## Final Outcome
90
-
91
- Bulletproof skill that:
92
- - ✅ Clearly mandates root cause investigation
93
- - ✅ Resists time pressure rationalization
94
- - ✅ Provides concrete steps for each phase
95
- - ✅ Shows anti-patterns explicitly
96
- - ✅ Tested under multiple pressure scenarios
97
- - ✅ Clarifies relationship to TDD
98
- - ✅ Ready for use
99
-
100
- ## Key Insight
101
-
102
- **Most important bulletproofing:** Anti-patterns section showing exact shortcuts that feel justified in the moment. When Claude thinks "I'll just add this one quick fix", seeing that exact pattern listed as wrong creates cognitive friction.
103
-
104
- ## Usage Example
105
-
106
- When encountering a bug:
107
- 1. Load skill: skills/debugging/systematic-debugging
108
- 2. Read overview (10 sec) - reminded of mandate
109
- 3. Follow Phase 1 checklist - forced investigation
110
- 4. If tempted to skip - see anti-pattern, stop
111
- 5. Complete all phases - root cause found
112
-
113
- **Time investment:** 5-10 minutes
114
- **Time saved:** Hours of symptom-whack-a-mole
115
-
116
- ---
117
-
118
- *Created: 2025-10-03*
119
- *Purpose: Reference example for skill extraction and bulletproofing*
1
+ # Creation Log: Systematic Debugging Skill
2
+
3
+ Reference example of extracting, structuring, and bulletproofing a critical skill.
4
+
5
+ ## Source Material
6
+
7
+ Extracted debugging framework from `~/.claude/CLAUDE.md`:
8
+ - 4-phase systematic process (Investigation → Pattern Analysis → Hypothesis → Implementation)
9
+ - Core mandate: ALWAYS find root cause, NEVER fix symptoms
10
+ - Rules designed to resist time pressure and rationalization
11
+
12
+ ## Extraction Decisions
13
+
14
+ **What to include:**
15
+ - Complete 4-phase framework with all rules
16
+ - Anti-shortcuts ("NEVER fix symptom", "STOP and re-analyze")
17
+ - Pressure-resistant language ("even if faster", "even if I seem in a hurry")
18
+ - Concrete steps for each phase
19
+
20
+ **What to leave out:**
21
+ - Project-specific context
22
+ - Repetitive variations of same rule
23
+ - Narrative explanations (condensed to principles)
24
+
25
+ ## Structure Following skill-creation/SKILL.md
26
+
27
+ 1. **Rich when_to_use** - Included symptoms and anti-patterns
28
+ 2. **Type: technique** - Concrete process with steps
29
+ 3. **Keywords** - "root cause", "symptom", "workaround", "debugging", "investigation"
30
+ 4. **Flowchart** - Decision point for "fix failed" → re-analyze vs add more fixes
31
+ 5. **Phase-by-phase breakdown** - Scannable checklist format
32
+ 6. **Anti-patterns section** - What NOT to do (critical for this skill)
33
+
34
+ ## Bulletproofing Elements
35
+
36
+ Framework designed to resist rationalization under pressure:
37
+
38
+ ### Language Choices
39
+ - "ALWAYS" / "NEVER" (not "should" / "try to")
40
+ - "even if faster" / "even if I seem in a hurry"
41
+ - "STOP and re-analyze" (explicit pause)
42
+ - "Don't skip past" (catches the actual behavior)
43
+
44
+ ### Structural Defenses
45
+ - **Phase 1 required** - Can't skip to implementation
46
+ - **Single hypothesis rule** - Forces thinking, prevents shotgun fixes
47
+ - **Explicit failure mode** - "IF your first fix doesn't work" with mandatory action
48
+ - **Anti-patterns section** - Shows exactly what shortcuts look like
49
+
50
+ ### Redundancy
51
+ - Root cause mandate in overview + when_to_use + Phase 1 + implementation rules
52
+ - "NEVER fix symptom" appears 4 times in different contexts
53
+ - Each phase has explicit "don't skip" guidance
54
+
55
+ ## Testing Approach
56
+
57
+ Created 4 validation tests following skills/meta/testing-skills-with-subagents:
58
+
59
+ ### Test 1: Academic Context (No Pressure)
60
+ - Simple bug, no time pressure
61
+ - **Result:** Perfect compliance, complete investigation
62
+
63
+ ### Test 2: Time Pressure + Obvious Quick Fix
64
+ - User "in a hurry", symptom fix looks easy
65
+ - **Result:** Resisted shortcut, followed full process, found real root cause
66
+
67
+ ### Test 3: Complex System + Uncertainty
68
+ - Multi-layer failure, unclear if can find root cause
69
+ - **Result:** Systematic investigation, traced through all layers, found source
70
+
71
+ ### Test 4: Failed First Fix
72
+ - Hypothesis doesn't work, temptation to add more fixes
73
+ - **Result:** Stopped, re-analyzed, formed new hypothesis (no shotgun)
74
+
75
+ **All tests passed.** No rationalizations found.
76
+
77
+ ## Iterations
78
+
79
+ ### Initial Version
80
+ - Complete 4-phase framework
81
+ - Anti-patterns section
82
+ - Flowchart for "fix failed" decision
83
+
84
+ ### Enhancement 1: TDD Reference
85
+ - Added link to skills/testing/test-driven-development
86
+ - Note explaining TDD's "simplest code" ≠ debugging's "root cause"
87
+ - Prevents confusion between methodologies
88
+
89
+ ## Final Outcome
90
+
91
+ Bulletproof skill that:
92
+ - ✅ Clearly mandates root cause investigation
93
+ - ✅ Resists time pressure rationalization
94
+ - ✅ Provides concrete steps for each phase
95
+ - ✅ Shows anti-patterns explicitly
96
+ - ✅ Tested under multiple pressure scenarios
97
+ - ✅ Clarifies relationship to TDD
98
+ - ✅ Ready for use
99
+
100
+ ## Key Insight
101
+
102
+ **Most important bulletproofing:** Anti-patterns section showing exact shortcuts that feel justified in the moment. When Claude thinks "I'll just add this one quick fix", seeing that exact pattern listed as wrong creates cognitive friction.
103
+
104
+ ## Usage Example
105
+
106
+ When encountering a bug:
107
+ 1. Load skill: skills/debugging/systematic-debugging
108
+ 2. Read overview (10 sec) - reminded of mandate
109
+ 3. Follow Phase 1 checklist - forced investigation
110
+ 4. If tempted to skip - see anti-pattern, stop
111
+ 5. Complete all phases - root cause found
112
+
113
+ **Time investment:** 5-10 minutes
114
+ **Time saved:** Hours of symptom-whack-a-mole
115
+
116
+ ---
117
+
118
+ *Created: 2025-10-03*
119
+ *Purpose: Reference example for skill extraction and bulletproofing*