@jslint-org/jslint 2023.10.24 → 2024.6.28

package/CHANGELOG.md

@@ -7,6 +7,21 @@
 - jslint - add new warning requiring paren around plus-separated concatenations.
 - jslint - try to improve parser to be able to parse jquery.js without stopping.
 
+# v2024.6.28
+- coverage - Fix coverage-function v8CoverageReportCreate() throwing error EINVAL in latest nodejs-security-patch, when running win32-coverage with npm.cmd.
+- jslint - Remove unnecessary shell-function shCurlExe().
+
+# v2024.3.26
+- ci - Add shell-functions shGitPullrequestCleanup(), shGitPullrequest() to automatically cleanup or create-and-push github-pull-commit to origin/alpha.
+- jslint - Allow destructuring-assignment after function-definition.
+- ci - Replace npm-package used to auto-build vscode-plugin, vsce to @vscode/vsce.
+- test - Update test-function jstestDescribe() to wait awhile for imports to initialize before running tests.
+- ci - Fix tmpdir in shell-function shBrowserScreenshot().
+- vim - Allow installing vim-plugin to any directory, instead of hardcoded to ~/.vim/.
+- ci - Update github-ci for actions/cache, actions/setup-python from nodejs v16 to nodejs v20.
+- ci - Update shell-function shRollupFetch() to fix blank date-committed.
+- ci - bugfix - Fix google-chrome unable to create screenshot because user-data-dir is /dev/null.
+
 # v2023.10.24
 - jslint - bugfix - Update file jslint_wrapper_vim.vim to fix broken vim-link when linting shell-files.
 - ci - add custom-shell-ci hooks to script jslint_ci.sh:

package/README.md

@@ -3,7 +3,7 @@ Douglas Crockford <douglas@crockford.com>
 
 
 # Status
-| Branch | [master<br>(v2023.10.24)](https://github.com/jslint-org/jslint/tree/master) | [beta<br>(Web Demo)](https://github.com/jslint-org/jslint/tree/beta) | [alpha<br>(Development)](https://github.com/jslint-org/jslint/tree/alpha) |
+| Branch | [master<br>(v2024.6.28)](https://github.com/jslint-org/jslint/tree/master) | [beta<br>(Web Demo)](https://github.com/jslint-org/jslint/tree/beta) | [alpha<br>(Development)](https://github.com/jslint-org/jslint/tree/alpha) |
 |--:|:--:|:--:|:--:|
 | CI | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/jslint-org/jslint/actions?query=branch%3Amaster) | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=beta)](https://github.com/jslint-org/jslint/actions?query=branch%3Abeta) | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=alpha)](https://github.com/jslint-org/jslint/actions?query=branch%3Aalpha) |
 | Coverage | [![coverage](https://jslint-org.github.io/jslint/branch-master/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-master/.artifact/coverage/index.html) | [![coverage](https://jslint-org.github.io/jslint/branch-beta/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-beta/.artifact/coverage/index.html) | [![coverage](https://jslint-org.github.io/jslint/branch-alpha/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-alpha/.artifact/coverage/index.html) |
@@ -74,9 +74,9 @@ Douglas Crockford <douglas@crockford.com>
 12. [License](#license)
 
 13. [Devops Instruction](#devops-instruction)
+    - [pull-request merge](#pull-request-merge)
     - [branch-master commit](#branch-master-commit)
     - [branch-master publish](#branch-master-publish)
-    - [pull-request merge](#pull-request-merge)
     - [vscode-jslint publish](#vscode-jslint-publish)
 
 
@@ -506,6 +506,9 @@ window.addEventListener("load", function () {
 # Quickstart JSLint in Vim
 1. Download and save [`jslint.mjs`](https://www.jslint.com/jslint.mjs), [`jslint_wrapper_vim.vim`](https://www.jslint.com/jslint_wrapper_vim.vim) to directory `~/.vim/`
 2. Add vim-command `:source ~/.vim/jslint_wrapper_vim.vim` to file `~/.vimrc`
+    - If above files were saved to custom-directory, then use that directory instead, e.g.:
+        - save [`jslint.mjs`](https://www.jslint.com/jslint.mjs), [`jslint_wrapper_vim.vim`](https://www.jslint.com/jslint_wrapper_vim.vim) to directory `~/vimfiles/`
+        - vim-command `:source ~/vimfiles/jslint_wrapper_vim.vim`
 3. Vim can now jslint files (via nodejs):
     - with vim-command `:SaveAndJslint`
     - with vim-key-combo `<Ctrl-S> <Ctrl-J>`
@@ -912,105 +915,119 @@ eval("1"); //jslint-ignore-line
 
 
 <br><br>
-### branch-master commit
-- $ `shGitSquashPop <commit-beta> '# v20yy.mm.dd\n<release notes from CHANGELOG.md>'`
-    - verify correct-year `20yy`
-- $ `git push origin alpha:branch-v20yy.mm.dd`
-- $ `git push upstream alpha -f`
-- verify ci-success for upstream-branch-alpha
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
-- goto https://github.com/kaizhu256/jslint/pulls
-- click `New pull request`
-- click `base repository: jslint-org/jslint base:beta`
-- click `head repository: kaizhu256/jslint compare:branch-v20yy.mm.dd`
+### pull-request merge
+- find highest issue-number at https://github.com/jslint-org/jslint/issues/, https://github.com/jslint-org/jslint/pulls/, and add +1 to it for PR-xxx
+- `shGitPullrequest beta beta`
+    - verify ci-success for origin-branch-alpha
+    - https://github.com/kaizhu256/jslint/actions
+- `git push upstream alpha -f`
+    - verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions
+- goto https://github.com/jslint-org/jslint/compare/beta...kaizhu256:jslint:branch-p2024.6.23
+- click `Create pull request`
+- input `Add your description here...` with:
+```
+Fixes #xxx.
+- <primary-commit-message>
+
+This PR will ...
+
+this PR will additionally:
+- <secondary-commit-message>
+...
+
+<screenshot>
+```
 - verify `commit into jslint-org:beta`
 - click `Create pull request`
-- verify ci-success for pull-request
+    - verify ci-success for pull-request
     - https://github.com/jslint-org/jslint/actions/workflows/on_pull_request.yml
+- wait awhile before continuing ...
 - click `Rebase and merge`
-- verify ci-success for upstream-branch-beta
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
-```shell
-git fetch upstream beta
-git diff alpha..upstream/beta
-# verify no diff between alpha..upstream/beta
-git reset upstream/beta
-git push origin alpha -f
-git push origin alpha:beta
-shMyciUpdate
-git push upstream alpha -f
-```
-- verify ci-success for origin-branch-alpha
-    - https://github.com/kaizhu256/jslint/actions/workflows/ci.yml
-- verify ci-success for upstream-branch-alpha
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+    - verify ci-success for upstream-branch-beta
+    - https://github.com/jslint-org/jslint/actions
+- `shGitPullrequestCleanup`
+    - verify ci-success for origin-branch-alpha
+    - https://github.com/kaizhu256/jslint/actions
+- `git push upstream alpha -f`
+    - verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions
 - click `Delete branch`
-```shell
-git push origin beta:master
-git push upstream beta:master
+
+
+<br><br>
+### branch-master commit
+- `shGitPullrequest master beta`
+    - verify ci-success for origin-branch-alpha
+    - https://github.com/kaizhu256/jslint/actions
+- `git push upstream alpha -f`
+    - verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions
+- goto https://github.com/jslint-org/jslint/compare/beta...kaizhu256:jslint:branch-v2024.6.28
+- click `Create pull request`
+- input `Add a title` with: `# v20yy.mm.dd`
+- input `Add a description` with:
+```
+- <primary-commit-message>
+- <secondary-commit-message>
 ```
-- verify ci-success for origin-branch-master
-    - https://github.com/kaizhu256/jslint/actions/workflows/ci.yml
-- verify ci-success for upstream-branch-master
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+- verify `commit into jslint-org:beta`
+- click `Create pull request`
+    - verify ci-success for pull-request
+    - https://github.com/jslint-org/jslint/actions/workflows/on_pull_request.yml
+- wait awhile before continuing ...
+- click `Rebase and merge`
+    - verify ci-success for upstream-branch-beta
+    - https://github.com/jslint-org/jslint/actions
+- `shGitPullrequestCleanup`
+    - verify ci-success for origin-branch-alpha
+    - https://github.com/kaizhu256/jslint/actions
+- `git push upstream alpha -f`
+    - verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions
+- click `Delete branch`
+- `git push origin beta:master`
+    - verify ci-success for origin-branch-master
+    - https://github.com/kaizhu256/jslint/actions
+- `git push upstream beta:master`
+    - verify ci-success for upstream-branch-master
+    - https://github.com/jslint-org/jslint/actions
 
 
 <br><br>
 ### branch-master publish
-- $ `git push upstream beta:master`
-- verify ci-success for upstream-branch-master
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+- `git push upstream beta:master`
+    - verify ci-success for upstream-branch-master
+    - https://github.com/jslint-org/jslint/actions
 - goto https://github.com/jslint-org/jslint/releases/new
-- input tag `v20yy.mm.dd`
+- input `Choose a tag` with: `v20yy.mm.dd`
 - click `Create new tag: v20yy.mm.dd on publish`
     - verify correct-year `20yy`
-- click `Target: master`
-- input `Release title: v20yy.mm.dd - <description>`
-- copy-paste release notes from CHANGELOG.md
+- select `Target: master`
+- select `Previous tag:auto`
+- input `Release title` with: `v20yy.mm.dd - <primary-commit-message>`
+- input `Describe this release` with:
+```
+- <primary-commit-message>
+- <secondary-commit-message>
+```
 - click `Generate release notes`
 - click `Set as the latest release`
 - click `Preview` and review
 - click `Publish release`
-- verify ci-success for upstream-branch-publish
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
-- verify email-notification `Successfully published @jslint-org/jslint@20yy.mm.dd`
-
-
-<br><br>
-### pull-request merge
-- find highest issue-number at https://github.com/jslint-org/jslint/issues/, and add +1 to it for PR-xxx
-- verify `commit into jslint-org:beta`
-- click `Create pull request`
-- verify ci-success for pull-request
-    - https://github.com/jslint-org/jslint/actions/workflows/on_pull_request.yml
-- click `Rebase and merge`
-- verify ci-success for upstream-branch-beta
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
-```shell
-git fetch upstream beta
-git diff alpha..upstream/beta
-# verify no diff between alpha..upstream/beta
-git reset upstream/beta
-git push origin alpha -f
-git push origin alpha:beta
-shMyciUpdate
-git push upstream alpha -f
-```
-- verify ci-success for origin-branch-alpha
-    - https://github.com/kaizhu256/jslint/actions/workflows/ci.yml
-- verify ci-success for upstream-branch-alpha
-    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
-- click `Delete branch`
+    - verify ci-success for upstream-branch-publish
+    - https://github.com/jslint-org/jslint/actions
+    - verify email-notification `Successfully published @jslint-org/jslint@20yy.mm.dd`
 
 
 <br><br>
 ### vscode-jslint publish
 - goto https://github.com/jslint-org/jslint/tree/gh-pages/branch-beta/.artifact/jslint_wrapper_vscode
 - click `vscode-jslint-20yy.mm.dd.vsix`
-- click `Download`
+- click `Raw` to download
 - goto https://marketplace.visualstudio.com/manage/publishers/jslint
 - right-click `Update`
-- drag-and-drop downloaded `vscode-jslint-20yy.mm.dd.vsix`
+- upload downloaded file `vscode-jslint-20yy.mm.dd.vsix`
 - click 'Upload'
 - verify email-notification `[Succeeded] Extension publish on Visual Studio Marketplace - vscode-jslint`
 

package/jslint.mjs

@@ -125,8 +125,8 @@
     process_env, process_exit, promises, property, property_dict, push, quote,
     ranges, readFile, readdir, readonly, recursive, reduce, repeat, replace,
     resolve, result, reverse, role, round, scriptId, search, set, shebang,
-    shift, signature, single, slice, some, sort, source, spawn, splice, split,
-    stack, stack_trace, start, startOffset, startsWith, statement,
+    shell, shift, signature, single, slice, some, sort, source, spawn, splice,
+    split, stack, stack_trace, start, startOffset, startsWith, statement,
     statement_prv, stdio, stop, stop_at, stringify, subscript, switch,
     syntax_dict, tenure, test, test_cause, test_internal_error, this, thru,
     toLocaleString, toString, token, token_global, token_list, token_nxt,
@@ -163,7 +163,7 @@ let jslint_charset_ascii = (
     + "@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_"
     + "`abcdefghijklmnopqrstuvwxyz{|}~\u007f"
 );
-let jslint_edition = "v2023.10.24";
+let jslint_edition = "v2024.6.28";
 let jslint_export;                      // The jslint object to be exported.
 let jslint_fudge = 1;                   // Fudge starting line and starting
                                         // ... column to 1.
@@ -5487,13 +5487,15 @@ function jslint_phase3_parse(state) {
         if (
             token_nxt.id === "."
             || token_nxt.id === "?."
-            || token_nxt.id === "["
+
+// PR-459 - Allow destructuring-assignment after function-definition.
+
+            // || token_nxt.id === "["
         ) {
 
 // test_cause:
 // ["function aa(){}\n.aa", "prefix_function", "unexpected_a", ".", 1]
 // ["function aa(){}\n?.aa", "prefix_function", "unexpected_a", "?.", 1]
-// ["function aa(){}\n[]", "prefix_function", "unexpected_a", "[", 1]
 
             warn("unexpected_a");
         }
@@ -9952,6 +9954,12 @@ async function jstestDescribe(description, testFunction) {
         process.on("exit", jstestOnExit);
     }
 
+// PR-457 - Wait awhile for imports to initialize.
+
+    await new Promise(function (resolve) {
+        setTimeout(resolve);
+    });
+
 // Init jstestItList.
 
     jstestItList = [];
@@ -10005,9 +10013,7 @@ function jstestIt(description, testFunction, mode) {
         } catch (errCaught) {
             err = errCaught;
         }
-        resolve([
-            err, description, mode
-        ]);
+        resolve([err, description, mode]);
     }));
 }
 
@@ -11279,24 +11285,37 @@ function sentinel() {}
             }
         }));
         exitCode = await new Promise(function (resolve) {
-            moduleChildProcess.spawn(
-                (
-                    processArgv[0] === "npm"
+            let processArgv0 = processArgv[0];
 
 // If win32 environment, then replace program npm with npm.cmd.
 // Coverage-hack - Ugly-hack to get test-coverage under both win32 and linux.
 
-                    ? process.platform.replace("win32", "npm.cmd").replace(
-                        process.platform,
-                        "npm"
-                    )
-                    : processArgv[0]
-                ),
+            if (processArgv0 === "npm") {
+                processArgv0 = process.platform.replace(
+                    "win32",
+                    "npm.cmd"
+                ).replace(
+                    process.platform,
+                    "npm"
+                );
+            }
+            moduleChildProcess.spawn(
+                processArgv0,
                 processArgv.slice(1),
                 {
                     env: Object.assign({}, process.env, {
                         NODE_V8_COVERAGE: coverageDir
                     }),
+
+// PR-465
+// https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
+// Node.js will now error with EINVAL if a .bat or .cmd file is passed to
+// child_process.spawn and child_process.spawnSync without the shell option set.
+
+                    shell: (
+                        processArgv0.endsWith(".bat")
+                        || processArgv0.endsWith(".cmd")
+                    ),
                     stdio: ["ignore", 1, 2]
                 }
             ).on("exit", resolve);

package/package.json

@@ -1,6 +1,6 @@
 {
     "bin": {
-        "jslint": "./jslint.mjs"
+        "jslint": "jslint.mjs"
     },
     "bugs": {
         "url": "https://github.com/jslint-org/jslint/issues"
@@ -26,7 +26,7 @@
     "name": "@jslint-org/jslint",
     "repository": {
         "type": "git",
-        "url": "https://github.com/jslint-org/jslint.git"
+        "url": "git+https://github.com/jslint-org/jslint.git"
     },
     "scripts": {
         "test": "node jslint.mjs v8_coverage_report=.artifact/coverage node test.mjs",
@@ -35,5 +35,5 @@
     "shCiArtifactUpload": 1,
     "shCiPublishNpm": 1,
     "type": "module",
-    "version": "2023.10.24"
+    "version": "2024.6.28"
 }