@jslint-org/jslint 2023.1.29 → 2023.5.23

package/CHANGELOG.md

@@ -5,9 +5,31 @@
 - coverage - add macros `/*coverage-disable*/` and `/*coverage-enable*/`.
 - jslint - add html and css linting back into jslint.
 - jslint - add new warning requiring paren around plus-separated concatenations.
-- jslint - require regexp to use open-form.
 - jslint - try to improve parser to be able to parse jquery.js without stopping.
-- jslint - unify analysis of variable-assignment/function-parameters into one function
+
+# v2023.5.23
+- jslint - Check exported properties are ordered.
+- jslint - Add grammar for "export async function ...".
+- python - Add shell-function shLintPython().
+- jslint - Add grammar for regexp-named-capture-group and regexp-named-backreference.
+- jslint - Add grammar for side-effect import-statement.
+- ci - Rename shell-function shRawLibFetch() to shRollupFetch().
+- doc - document devop procedures to maintain jslint-repo
+
+# v2023.4.29
+- vscode - Add manual lint-on-save command to vscode-jslint extension.
+- ci - add custom-shell-ci hooks to script jslint_ci.sh:
+    shCiArtifactUploadCustom()
+    shCiBaseCustom()
+    shCiBaseCustom2()
+    shCiLintCustom()
+    shCiLintCustom2()
+    shCiNpmPublishCustom()
+    shCiPreCustom()
+    shCiPreCustom2()
+- ci - housekeeping of ci-file jslint_ci.sh
+- ci - update shell-function shGitCommitPushOrSquash() to be able to save to specified filename
+- ci - remove little-used shell-function shCiBranchPromote()
 
 # v2023.1.29
 - ci - in windows-ci-env, alias node=node.exe instead of using winpty for pipes

package/README.md

@@ -3,7 +3,7 @@ Douglas Crockford <douglas@crockford.com>
 
 
 # Status
-| Branch | [master<br>(v2023.1.29)](https://github.com/jslint-org/jslint/tree/master) | [beta<br>(Web Demo)](https://github.com/jslint-org/jslint/tree/beta) | [alpha<br>(Development)](https://github.com/jslint-org/jslint/tree/alpha) |
+| Branch | [master<br>(v2023.5.23)](https://github.com/jslint-org/jslint/tree/master) | [beta<br>(Web Demo)](https://github.com/jslint-org/jslint/tree/beta) | [alpha<br>(Development)](https://github.com/jslint-org/jslint/tree/alpha) |
 |--:|:--:|:--:|:--:|
 | CI | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/jslint-org/jslint/actions?query=branch%3Amaster) | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=beta)](https://github.com/jslint-org/jslint/actions?query=branch%3Abeta) | [![ci](https://github.com/jslint-org/jslint/actions/workflows/ci.yml/badge.svg?branch=alpha)](https://github.com/jslint-org/jslint/actions?query=branch%3Aalpha) |
 | Coverage | [![coverage](https://jslint-org.github.io/jslint/branch-master/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-master/.artifact/coverage/index.html) | [![coverage](https://jslint-org.github.io/jslint/branch-beta/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-beta/.artifact/coverage/index.html) | [![coverage](https://jslint-org.github.io/jslint/branch-alpha/.artifact/coverage/coverage_badge.svg)](https://jslint-org.github.io/jslint/branch-alpha/.artifact/coverage/index.html) |
@@ -73,6 +73,12 @@ Douglas Crockford <douglas@crockford.com>
 
 12. [License](#license)
 
+13. [Devops Instruction](#devops-instruction)
+    - [branch-master commit](#branch-master-commit)
+    - [branch-master publish](#branch-master-publish)
+    - [pull-request merge](#pull-request-merge)
+    - [vscode-jslint publish](#vscode-jslint-publish)
+
 
 <br><br>
 # Web Demo
@@ -895,6 +901,96 @@ eval("1"); //jslint-ignore-line
 - CodeMirror editor is under [MIT License](https://github.com/codemirror/codemirror5/blob/d0e3b2e727c41aa4fd89fbad0adfb3815339174c/LICENSE).
 - Function `v8CoverageListMerge` is derived from [MIT Licensed v8-coverage](https://github.com/demurgos/v8-coverage/blob/73446087dc38f61b09832c9867122a23f8577099/ts/LICENSE.md).
 
+
+<br><br>
+# Devops Instruction
+
+
+<br><br>
+### branch-master commit
+- $ `shGitSquashPop <commit-beta> '# v20yy.mm.dd\n<release notes from CHANGELOG.md>'`
+    - verify correct-year `20yy`
+- $ `git push origin alpha:branch-v20yy.mm.dd`
+- $ `git push upstream alpha -f`
+- verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+- goto https://github.com/kaizhu256/jslint/pulls
+- click `New pull request`
+- click `base repository: jslint-org/jslint base:beta`
+- click `head repository: kaizhu256/jslint compare:branch-v20yy.mm.dd`
+- click `Create pull request`
+- verify ci-success for pull-request
+    - https://github.com/jslint-org/jslint/actions/workflows/on_pull_request.yml
+- click `Rebase and merge`
+- verify ci-success for upstream-branch-beta
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+```shell
+git fetch upstream beta
+git diff alpha..upstream/beta
+# verify no diff between alpha..upstream/beta
+git reset upstream/beta
+git push origin alpha -f
+git push origin alpha:beta
+git push upstream alpha -f
+git push origin :branch-v20yy.mm.dd -f
+```
+- verify ci-success for origin-branch-alpha
+    - https://github.com/kaizhu256/jslint/actions/workflows/ci.yml
+- verify ci-success for upstream-branch-alpha
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+
+
+<br><br>
+### branch-master publish
+- $ `git push upstream beta:master`
+- verify ci-success for upstream-branch-master
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+- goto https://github.com/jslint-org/jslint/releases/new
+- input tag `v20yy.mm.dd`
+- click `Create new tag: v20yy.mm.dd on publish`
+    - verify correct-year `20yy`
+- click `Target: master`
+- input `Release title: v20yy.mm.dd - <description>`
+- copy-paste release notes from CHANGELOG.md
+- click `Generate release notes`
+- click `Set as the latest release`
+- click `Publish release`
+- verify ci-success for upstream-branch-publish
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+- verify email-notification `Successfully published @jslint-org/jslint@20yy.mm.dd`
+
+
+<br><br>
+### pull-request merge
+- find highest issue-number at https://github.com/jslint-org/jslint/issues/, and add +1 to it for PR-xxx
+- verify `commit into jslint-org:beta`
+- verify ci-success for pull-request
+    - https://github.com/jslint-org/jslint/actions/workflows/on_pull_request.yml
+- click `Rebase and merge`
+- verify ci-success for upstream-branch-beta
+    - https://github.com/jslint-org/jslint/actions/workflows/ci.yml
+```shell
+git fetch upstream beta
+git diff upstream/beta
+git reset upstream/beta
+git push -f origin alpha alpha:beta
+shMyciUpdate
+git push -f upstream alpha
+```
+
+
+<br><br>
+### vscode-jslint publish
+- goto https://github.com/jslint-org/jslint/tree/gh-pages/branch-beta/.artifact/jslint_wrapper_vscode
+- click `vscode-jslint-20yy.mm.dd.vsix`
+- click `Download`
+- goto https://marketplace.visualstudio.com/manage/publishers/jslint
+- right-click `Update`
+- drag-and-drop downloaded `vscode-jslint-20yy.mm.dd.vsix`
+- click 'Upload'
+- verify email-notification `[Succeeded] Extension publish on Visual Studio Marketplace - vscode-jslint`
+
+
 <!--
 Coverage-hack
 node --eval '

package/asset_codemirror_rollup.js

@@ -1,6 +1,6 @@
 /*jslint-disable*/
 /*
-shRawLibFetch
+shRollupFetch
 {
     "fetchList": [
         {

package/jslint.mjs

@@ -165,7 +165,7 @@ let jslint_charset_ascii = (
     + "@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_"
     + "`abcdefghijklmnopqrstuvwxyz{|}~\u007f"
 );
-let jslint_edition = "v2023.1.29";
+let jslint_edition = "v2023.5.23";
 let jslint_export;                      // The jslint object to be exported.
 let jslint_fudge = 1;                   // Fudge starting line and starting
                                         // ... column to 1.
@@ -1584,7 +1584,9 @@ ${name}<span class="apidocSignatureSpan">${signature}</span>
         ), "\n");
         return result;
     }));
-    // init module_list
+
+// Init module_list.
+
     module_list = await Promise.all(module_list.map(async function ({
         pathname
     }) {
@@ -1990,8 +1992,11 @@ async function jslint_cli({
                 ).test(process_argv[1])
                 || mode_cli
             )
-            && moduleUrl.fileURLToPath(import_meta_url)
-            === modulePath.resolve(process_argv[1])
+            && (
+                moduleUrl.fileURLToPath(import_meta_url)
+                ===
+                modulePath.resolve(process_argv[1])
+            )
         )
         && !mode_cli
     ) {
@@ -2810,20 +2815,30 @@ function jslint_phase2_lex(state) {
 // Match a group that starts with left paren.
 
                     char_after("(");
-                    if (char === "?") {
-                        char_after("?");
-                        if (char === "=" || char === "!") {
-                            char_after();
-                        } else {
-                            char_after(":");
-                        }
-                    } else if (char === ":") {
+                    switch (char) {
+                    case ":":
 
 // test_cause:
 // ["aa=/(:)/", "lex_regexp_group", "expected_a_before_b", ":", 6]
 // ["aa=/?/", "lex_regexp_group", "expected_a_before_b", "?", 5]
 
                         warn_at("expected_a_before_b", line, column, "?", ":");
+                        break;
+                    case "?":
+                        char_after("?");
+                        switch (char) {
+                        case "!":
+
+// PR-437 - Add grammar for regexp-named-capture-group.
+
+                        case "<":
+                        case "=":
+                            char_after();
+                            break;
+                        default:
+                            char_after(":");
+                        }
+                        break;
                     }
 
 // RegExp
@@ -2857,7 +2872,10 @@ function jslint_phase2_lex(state) {
 // ["aa=/\\/", "lex_regexp_group", "escape", "", 0]
 
                     test_cause("escape");
-                    char_after_escape("BbDdSsWw^${}[]():=!.|*+?");
+
+// PR-437 - Add grammar for regexp-named-backreference.
+
+                    char_after_escape("BbDdSsWw^${}[]():=!.|*+?k");
                     break;
                 case "^":
                     if (snippet !== "^") {
@@ -6170,7 +6188,8 @@ function jslint_phase3_parse(state) {
     }
 
     function stmt_export() {
-        const the_export = token_now;
+        let export_list = [];
+        let the_export = token_now;
         let the_id;
         let the_name;
         let the_thing;
@@ -6214,9 +6233,13 @@ function jslint_phase3_parse(state) {
             export_dict.default = the_thing;
             the_export.expression.push(the_thing);
         } else {
-            if (token_nxt.id === "function") {
+
+// PR-439 - Add grammar for "export async function ...".
+
+            if (token_nxt.id === "function" || token_nxt.id === "async") {
 
 // test_cause:
+// ["export async function aa(){}", "stmt_export", "freeze_exports", "async", 8]
 // ["export function aa(){}", "stmt_export", "freeze_exports", "function", 8]
 
                 warn("freeze_exports");
@@ -6266,6 +6289,7 @@ function jslint_phase3_parse(state) {
                         stop("expected_identifier_a");
                     }
                     the_id = token_nxt.id;
+                    export_list.push(token_nxt);
                     the_name = token_global.context[the_id];
                     if (the_name === undefined) {
 
@@ -6292,6 +6316,13 @@ function jslint_phase3_parse(state) {
                         break;
                     }
                 }
+
+// PR-439 - Check exported properties are ordered.
+
+// test_cause:
+// ["export {bb, aa}", "check_ordered", "expected_a_b_before_c_d", "aa", 13]
+
+                check_ordered("export", export_list);
                 advance("}");
                 semicolon();
             } else {
@@ -6441,6 +6472,20 @@ function jslint_phase3_parse(state) {
 //         }
 
         state.mode_module = true;
+
+// PR-436 - Add grammar for side-effect import-statement.
+
+        if (token_nxt.id === "(string)") {
+
+// test_cause:
+// ["import \"./aa.mjs\";", "stmt_import", "import_side_effect", "", 0]
+
+            test_cause("import_side_effect");
+            warn("expected_a_b", token_nxt, "{", artifact());
+            advance();
+            semicolon();
+            return the_import;
+        }
         if (token_nxt.identifier) {
             name = token_nxt;
             advance();
@@ -11231,35 +11276,41 @@ function sentinel() {}
             if ((
                 /^coverage-\d+?-\d+?-\d+?\.json$/
             ).test(file)) {
-                console.error("rm file " + coverageDir + file);
+                consoleError("rm file " + coverageDir + file);
                 await moduleFs.promises.unlink(coverageDir + file);
             }
         }));
         exitCode = await new Promise(function (resolve) {
-            moduleChildProcess.spawn((
-                processArgv[0] === "npm"
+            moduleChildProcess.spawn(
+                (
+                    processArgv[0] === "npm"
 
 // If win32 environment, then replace program npm with npm.cmd.
 // Coverage-hack - Ugly-hack to get test-coverage under both win32 and linux.
 
-                ? process.platform.replace("win32", "npm.cmd").replace(
-                    process.platform,
-                    "npm"
-                )
-                : processArgv[0]
-            ), processArgv.slice(1), {
-                env: Object.assign({}, process.env, {
-                    NODE_V8_COVERAGE: coverageDir
-                }),
-                stdio: [
-                    "ignore", 1, 2
-                ]
-            }).on("exit", resolve);
+                    ? process.platform.replace("win32", "npm.cmd").replace(
+                        process.platform,
+                        "npm"
+                    )
+                    : processArgv[0]
+                ),
+                processArgv.slice(1),
+                {
+                    env: Object.assign({}, process.env, {
+                        NODE_V8_COVERAGE: coverageDir
+                    }),
+                    stdio: ["ignore", 1, 2]
+                }
+            ).on("exit", resolve);
         });
+        consoleError(
+            `v8CoverageReportCreate - program exited with exitCode=${exitCode}`
+        );
     }
 
 // 2. Merge JSON v8-coverage-files in <coverageDir>.
 
+    consoleError("v8CoverageReportCreate - merging coverage files...");
     v8CoverageObj = await moduleFs.promises.readdir(coverageDir);
     v8CoverageObj = v8CoverageObj.filter(function (file) {
         return (
@@ -11331,6 +11382,7 @@ function sentinel() {}
 
 // 3. Create html-coverage-reports in <coverageDir>.
 
+    consoleError("v8CoverageReportCreate - creating html-coverage-report...");
     fileDict = Object.create(null);
     await Promise.all(v8CoverageObj.result.map(async function ({
         functions,

package/jslint_wrapper_vscode.js

@@ -30,11 +30,12 @@
 /*property
     Diagnostic, DiagnosticSeverity, ProgressLocation, Warning, Window, activate,
     cancellable, character, clear, column, commands, createDiagnosticCollection,
-    document, end, endsWith, exports, getText, increment, insert, isEmpty,
-    jslint, languages, line, lineAt, location, map, message, module, push,
-    range, rangeIncludingLineBreak, readFileSync, registerTextEditorCommand,
-    replace, report, runInNewContext, selection, set, slice, start,
-    subscriptions, title, uri, warnings, window, withProgress
+    document, end, endsWith, exports, fsPath, getText, increment, insert,
+    isEmpty, jslint, languages, line, lineAt, location, map, message, module,
+    promises, push, range, rangeIncludingLineBreak, readFileSync,
+    registerTextEditorCommand, replace, report, runInNewContext, selection, set,
+    slice, start, subscriptions, title, uri, warnings, window, withProgress,
+    writeFile
 */
 
 "use strict";
@@ -182,6 +183,20 @@ function activate({
         });
     }
 
+// PR-429 - Add manual lint-on-save command.
+
+    async function jslintLintAndSave({
+        document
+    }) {
+        jslintLint({
+            document
+        });
+        await require("fs").promises.writeFile(
+            document.uri.fsPath,
+            document.getText()
+        );
+    }
+
 // Initialize vscode and jslint.
 
     vscode = require("vscode");
@@ -222,6 +237,9 @@ function activate({
     subscriptions.push(vscode.commands.registerTextEditorCommand((
         "jslint.lint"
     ), jslintLint));
+    subscriptions.push(vscode.commands.registerTextEditorCommand((
+        "jslint.lintAndSave"
+    ), jslintLintAndSave));
 }
 
 exports.activate = activate;

package/package.json

@@ -35,5 +35,5 @@
     "shCiArtifactUpload": 1,
     "shCiNpmPublish": 1,
     "type": "module",
-    "version": "2023.1.29"
+    "version": "2023.5.23"
 }