@jskit-ai/users-core 0.1.42 → 0.1.44

package/test/workspaceService.test.js

@@ -28,10 +28,10 @@ function createWorkspaceServiceFixture({
   userWorkspaceRows = null,
   membershipResolver = null,
   personalWorkspace = {
-    id: 1,
+    id: "1",
     slug: "tonymobily3",
     name: "TonyMobily3",
-    ownerUserId: 7,
+    ownerUserId: "7",
     isPersonal: true,
     avatarUrl: ""
   }
@@ -93,7 +93,7 @@ function createWorkspaceServiceFixture({
         }
         return [
           {
-            id: 1,
+            id: "1",
             slug: "tonymobily3",
             name: "TonyMobily3",
             avatarUrl: "",
@@ -101,7 +101,7 @@ function createWorkspaceServiceFixture({
             membershipStatus: "active"
           },
           {
-            id: 2,
+            id: "2",
             slug: "pending-workspace",
             name: "Pending Workspace",
             avatarUrl: "",
@@ -113,12 +113,12 @@ function createWorkspaceServiceFixture({
       async insert(payload) {
         calls.insert += 1;
         insertedPayloads.push(payload);
-        const workspaceId = nextWorkspaceId++;
+        const workspaceId = String(nextWorkspaceId++);
         const inserted = {
           id: workspaceId,
           slug: String(payload.slug || ""),
           name: String(payload.name || ""),
-          ownerUserId: Number(payload.ownerUserId),
+          ownerUserId: String(payload.ownerUserId || ""),
           isPersonal: payload.isPersonal === true,
           avatarUrl: String(payload.avatarUrl || "")
         };
@@ -127,9 +127,9 @@ function createWorkspaceServiceFixture({
       },
       async updateById(workspaceId, patch) {
         calls.updateById += 1;
-        const targetId = Number(workspaceId);
+        const targetId = String(workspaceId || "").trim();
         for (const [slug, workspace] of workspaceBySlug.entries()) {
-          if (Number(workspace.id) !== targetId) {
+          if (String(workspace.id || "").trim() !== targetId) {
             continue;
           }
           const updated = {
@@ -185,7 +185,7 @@ test("workspaceService no longer exposes bootstrap payload assembly", () => {
 test("workspaceService.listWorkspacesForUser returns only accessible workspaces", async () => {
   const { service, calls } = createWorkspaceServiceFixture();
   const workspaces = await service.listWorkspacesForUser({
-    id: 7,
+    id: "7",
     email: "chiaramobily@gmail.com",
     displayName: "Chiara"
   });
@@ -204,7 +204,7 @@ test("workspaceService.listWorkspacesForUser no longer provisions personal works
   });
 
   await service.listWorkspacesForUser({
-    id: 7,
+    id: "7",
     email: "chiaramobily@gmail.com",
     displayName: "Chiara"
   });
@@ -218,7 +218,7 @@ test("workspaceService.listWorkspacesForUser returns all active memberships in p
     tenancyMode: "personal",
     userWorkspaceRows: [
       {
-        id: 1,
+        id: "1",
         slug: "chiaramobily",
         name: "Chiara Personal",
         avatarUrl: "",
@@ -226,7 +226,7 @@ test("workspaceService.listWorkspacesForUser returns all active memberships in p
         membershipStatus: "active"
       },
       {
-        id: 2,
+        id: "2",
         slug: "tonymobily",
         name: "Tony Workspace",
         avatarUrl: "",
@@ -234,7 +234,7 @@ test("workspaceService.listWorkspacesForUser returns all active memberships in p
         membershipStatus: "active"
       },
       {
-        id: 3,
+        id: "3",
         slug: "pending-workspace",
         name: "Pending Workspace",
         avatarUrl: "",
@@ -245,7 +245,7 @@ test("workspaceService.listWorkspacesForUser returns all active memberships in p
   });
 
   const workspaces = await service.listWorkspacesForUser({
-    id: 7,
+    id: "7",
     email: "chiaramobily@gmail.com",
     displayName: "Chiara"
   });
@@ -265,7 +265,7 @@ test("workspaceService.provisionWorkspaceForNewUser provisions personal workspac
   });
 
   const workspace = await service.provisionWorkspaceForNewUser({
-    id: 7,
+    id: "7",
     email: "chiaramobily@gmail.com",
     displayName: "Chiara"
   });
@@ -283,7 +283,7 @@ test("workspaceService.provisionWorkspaceForNewUser is a no-op outside personal
   });
 
   const result = await service.provisionWorkspaceForNewUser({
-    id: 7,
+    id: "7",
     email: "chiaramobily@gmail.com",
     displayName: "Chiara"
   });
@@ -304,7 +304,7 @@ test("workspaceService.createWorkspaceForAuthenticatedUser creates non-personal
 
   const workspace = await service.createWorkspaceForAuthenticatedUser(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },
@@ -318,7 +318,7 @@ test("workspaceService.createWorkspaceForAuthenticatedUser creates non-personal
   assert.equal(calls.insert, 1);
   assert.equal(calls.ensureOwnerMembership, 1);
   assert.equal(insertedPayloads[0].isPersonal, false);
-  assert.equal(insertedPayloads[0].ownerUserId, 7);
+  assert.equal(insertedPayloads[0].ownerUserId, "7");
 });
 
 test("workspaceService.createWorkspaceForAuthenticatedUser rejects creation when self-create policy is disabled", async () => {
@@ -330,7 +330,7 @@ test("workspaceService.createWorkspaceForAuthenticatedUser rejects creation when
     () =>
       service.createWorkspaceForAuthenticatedUser(
         {
-          id: 7,
+          id: "7",
           email: "chiaramobily@gmail.com",
           displayName: "Chiara"
         },
@@ -352,7 +352,7 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug returns workspace-no
     () =>
       service.resolveWorkspaceContextForUserBySlug(
         {
-          id: 7,
+          id: "7",
           email: "chiaramobily@gmail.com",
           displayName: "Chiara"
         },
@@ -366,19 +366,19 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug allows personal tena
   const { service } = createWorkspaceServiceFixture({
     tenancyMode: "personal",
     personalWorkspace: {
-      id: 1,
+      id: "1",
       slug: "my-personal",
       name: "My Personal",
-      ownerUserId: 7,
+      ownerUserId: "7",
       isPersonal: true,
       avatarUrl: ""
     },
     additionalWorkspaces: [
       {
-        id: 42,
+        id: "42",
         slug: "team-alpha",
         name: "Team Alpha",
-        ownerUserId: 99,
+        ownerUserId: "99",
         isPersonal: false,
         avatarUrl: ""
       }
@@ -387,7 +387,7 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug allows personal tena
 
   const context = await service.resolveWorkspaceContextForUserBySlug(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },
@@ -414,10 +414,10 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug grants owner access
           return null;
         }
         return {
-          id: 1,
+          id: "1",
           slug: "tonymobily",
           name: "TonyMobily",
-          ownerUserId: 7,
+          ownerUserId: "7",
           isPersonal: true,
           avatarUrl: ""
         };
@@ -458,7 +458,7 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug grants owner access
 
   const context = await service.resolveWorkspaceContextForUserBySlug(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },
@@ -487,7 +487,7 @@ test("workspaceService.resolveWorkspaceContextForUserBySlug resolves permissions
 
   const context = await service.resolveWorkspaceContextForUserBySlug(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },
@@ -501,10 +501,10 @@ test("workspaceService.getWorkspaceForAuthenticatedUser resolves workspace from
   const { service } = createWorkspaceServiceFixture({
     additionalWorkspaces: [
       {
-        id: 42,
+        id: "42",
         slug: "team-alpha",
         name: "Team Alpha",
-        ownerUserId: 99,
+        ownerUserId: "99",
         isPersonal: false,
         avatarUrl: ""
       }
@@ -513,7 +513,7 @@ test("workspaceService.getWorkspaceForAuthenticatedUser resolves workspace from
 
   const workspace = await service.getWorkspaceForAuthenticatedUser(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },
@@ -529,7 +529,7 @@ test("workspaceService.updateWorkspaceForAuthenticatedUser updates workspace pro
 
   const workspace = await service.updateWorkspaceForAuthenticatedUser(
     {
-      id: 7,
+      id: "7",
       email: "chiaramobily@gmail.com",
       displayName: "Chiara"
     },

package/test/workspaceSettingsRepository.test.js

@@ -110,10 +110,10 @@ test("workspaceSettingsRepository.findByWorkspaceId maps the stored row", async
     defaultInvitesEnabled: createDefaultWorkspaceSettings()
   });
 
-  const record = await repository.findByWorkspaceId(1);
+  const record = await repository.findByWorkspaceId("1");
 
   assert.deepEqual(record, {
-    workspaceId: 1,
+    workspaceId: "1",
     lightPrimaryColor: DEFAULT_WORKSPACE_THEME.light.color,
     lightSecondaryColor: DEFAULT_WORKSPACE_THEME.light.secondaryColor,
     lightSurfaceColor: DEFAULT_WORKSPACE_THEME.light.surfaceColor,
@@ -134,7 +134,7 @@ test("workspaceSettingsRepository.updateSettingsByWorkspaceId updates invitesEna
     defaultInvitesEnabled: createDefaultWorkspaceSettings()
   });
 
-  const updated = await repository.updateSettingsByWorkspaceId(1, {
+  const updated = await repository.updateSettingsByWorkspaceId("1", {
     invitesEnabled: false
   });
 
@@ -149,9 +149,9 @@ test("workspaceSettingsRepository.ensureForWorkspaceId inserts the injected defa
     defaultInvitesEnabled: false
   });
 
-  const record = await repository.ensureForWorkspaceId(5);
+  const record = await repository.ensureForWorkspaceId("5");
 
-  assert.equal(state.insertedRow.workspace_id, 5);
+  assert.equal(state.insertedRow.workspace_id, "5");
   assert.equal(state.insertedRow.light_primary_color, DEFAULT_WORKSPACE_THEME.light.color);
   assert.equal(state.insertedRow.light_secondary_color, DEFAULT_WORKSPACE_THEME.light.secondaryColor);
   assert.equal(state.insertedRow.light_surface_color, DEFAULT_WORKSPACE_THEME.light.surfaceColor);
@@ -176,6 +176,7 @@ test("workspaceSettingsRepository.ensureForWorkspaceId inserts the injected defa
   assert.equal(record.darkSurfaceColor, DEFAULT_WORKSPACE_THEME.dark.surfaceColor);
   assert.equal(record.darkSurfaceVariantColor, DEFAULT_WORKSPACE_THEME.dark.surfaceVariantColor);
   assert.equal(record.invitesEnabled, false);
+  assert.equal(record.workspaceId, "5");
 });
 
 test("workspaceSettingsRepository.updateSettingsByWorkspaceId updates workspace settings columns", async () => {
@@ -184,7 +185,7 @@ test("workspaceSettingsRepository.updateSettingsByWorkspaceId updates workspace
     defaultInvitesEnabled: true
   });
 
-  const updated = await repository.updateSettingsByWorkspaceId(1, {
+  const updated = await repository.updateSettingsByWorkspaceId("1", {
     lightPrimaryColor: "#123abc"
   });
 

package/test/workspaceSettingsResource.test.js

@@ -118,9 +118,9 @@ test("workspace settings output normalizes raw service payloads", () => {
 
   assert.deepEqual(normalized, {
     workspace: {
-      id: 7,
+      id: "7",
       slug: "mercury",
-      ownerUserId: 9
+      ownerUserId: "9"
     },
     settings: {
       lightPrimaryColor: "#0F6B54",

package/src/server/common/README.md

@@ -1,20 +0,0 @@
-# Server Common
-
-This directory contains server-only runtime pieces reused by multiple slices in `users-core`.
-
-Use these folders:
-- `repositories/`: shared repositories and repository-only helpers.
-- `services/`: shared domain services consumed by multiple slices.
-- `contributors/`: shared action-context/bootstrap contributors.
-- `validators/`: shared request/response validators used by multiple adapters.
-- `formatters/`: shared payload formatters/projections for transport output.
-- `routes/`: shared route schema maps used by more than one route adapter.
-
-Keep these files here:
-- `registerCommonRepositories.js`: shared repository bindings.
-- `registerSharedApi.js`: shared API metadata registration.
-
-Do not put these in `common/`:
-- feature-only actions/services/repositories/controllers
-- one-off route payload shapes used by a single feature
-- UI/client code

package/src/server/common/contributors/README.md

@@ -1,11 +0,0 @@
-# `contributors/`
-
-Put shared runtime contributors here (for action context or bootstrap payload composition).
-
-Allowed:
-- contributors reused by multiple slices/actions
-- contributor logic that delegates domain work to services
-
-Not allowed:
-- feature-specific contributors used by one slice only
-- direct repository access when a service already owns that domain

package/src/server/common/formatters/README.md

@@ -1,11 +0,0 @@
-# `formatters/`
-
-Put shared transport/output projection logic here.
-
-Allowed:
-- shaping domain records into API payloads used in multiple slices
-
-Not allowed:
-- business rules
-- repository reads/writes
-- HTTP adapter/controller code

package/src/server/common/repositories/README.md

@@ -1,24 +0,0 @@
-# `repositories/`
-
-Use this directory for persistence code shared by more than one server slice.
-
-What belongs here:
-- repository helpers that are part of persistence logic
-- shared repositories used by multiple features/slices
-
-Examples:
-- SQL/date/JSON helper functions reused by several repositories
-- `workspaceMembershipsRepository`
-- `workspaceInvitesRepository`
-
-Do not put these here:
-- repositories used by only one feature
-- business logic
-- action definitions
-- transport validation
-- feature-specific response mapping
-
-Rule:
-- if a helper is reused by multiple repository files, it can live here
-- if a repository is reused by multiple slices, keep it here
-- if a repository is owned by one slice only, keep it in that slice folder

package/src/server/common/routes/README.md

@@ -1,11 +0,0 @@
-# `routes/`
-
-Put shared route schema maps here when multiple route adapters consume them.
-
-Allowed:
-- shared route request/response schema groupings
-- references to shared resources/commands
-
-Not allowed:
-- route registration/handlers
-- business logic

package/src/server/common/services/README.md

@@ -1,12 +0,0 @@
-# `services/`
-
-Put shared server services here when they are used by more than one slice.
-
-Allowed:
-- cross-slice service logic with clear inputs/outputs
-- no HTTP route validator handling
-
-Not allowed:
-- feature-only services
-- route adapters/controllers
-- response schema declarations

package/src/server/common/validators/README.md

@@ -1,11 +0,0 @@
-# `validators/`
-
-Put shared validators here when they are reused by multiple server slices/adapters.
-
-Allowed:
-- validator objects (`schema` + `normalize`)
-- transport-level reusable validators
-
-Not allowed:
-- feature-only validators used by one slice
-- business/domain decision logic