@jskit-ai/users-core 0.1.146 → 0.1.147

package/package.descriptor.mjs

@@ -1,7 +1,7 @@
 export default Object.freeze({
   packageVersion: 1,
   packageId: "@jskit-ai/users-core",
-  version: "0.1.146",
+  version: "0.1.147",
   kind: "runtime",
   description: "Users/account runtime plus HTTP routes for account features.",
   dependsOn: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jskit-ai/users-core",
-  "version": "0.1.146",
+  "version": "0.1.147",
   "type": "module",
   "scripts": {
     "test": "node --test"

package/src/server/accountProfile/bootAccountProfileRoutes.js

@@ -135,7 +135,7 @@ function bootAccountProfileRoutes(app) {
           stream: filePart.stream,
           mimeType: filePart.mimeType,
           fileName: filePart.fileName,
-          uploadDimension
+          ...(uploadDimension !== undefined ? { uploadDimension } : {})
         }
       });
 

package/src/server/accountSecurity/bootAccountSecurityRoutes.js

@@ -116,11 +116,12 @@ function bootAccountSecurityRoutes(app) {
       }
     },
     async function (request, reply) {
+      const query = request.input.query || {};
       const result = await request.executeAction({
         actionId: "settings.security.oauth.link.start",
         input: {
           provider: request.input.params.provider,
-          returnTo: request.input.query.returnTo
+          ...(Object.hasOwn(query, "returnTo") ? { returnTo: query.returnTo } : {})
         }
       });
 

package/test/usersRouteRequestInputValidator.test.js

@@ -228,6 +228,54 @@ test("account route handlers build action input from request.input", async () =>
   assert.equal(calls[7].actionId, "settings.security.sessions.logout_others");
 });
 
+test("account route handlers preserve omitted optional action fields", async () => {
+  const routes = await registerRoutes();
+  const calls = [];
+  const executeAction = async (payload) => {
+    calls.push(payload);
+    if (payload.actionId === "settings.security.oauth.link.start") {
+      return { url: "/oauth/link" };
+    }
+    return {};
+  };
+
+  await findRoute(routes, { method: "GET", path: "/api/settings/security/oauth/:provider/start" }).handler(
+    createActionRequest({
+      input: {
+        params: { provider: "github" },
+        query: {}
+      },
+      executeAction
+    }),
+    createReplyDouble()
+  );
+
+  const avatarStream = {};
+  await findRoute(routes, { method: "POST", path: "/api/settings/profile/avatar" }).handler(
+    createActionRequest({
+      file: async () => ({
+        fieldname: "avatar",
+        filename: "avatar.png",
+        mimetype: "image/png",
+        encoding: "7bit",
+        file: avatarStream,
+        fields: {}
+      }),
+      executeAction
+    }),
+    createReplyDouble()
+  );
+
+  assert.deepEqual(calls[0].input, { provider: "github" });
+  assert.equal(Object.hasOwn(calls[0].input, "returnTo"), false);
+  assert.deepEqual(calls[1].input, {
+    stream: avatarStream,
+    mimeType: "image/png",
+    fileName: "avatar.png"
+  });
+  assert.equal(Object.hasOwn(calls[1].input, "uploadDimension"), false);
+});
+
 test("account settings jsonapi transport resolves response resource id from request user", async () => {
   const routes = await registerRoutes();
   const settingsRoute = findRoute(routes, { method: "GET", path: "/api/settings" });