@jskit-ai/ui-generator 0.1.15 → 0.1.16

package/package.descriptor.mjs

@@ -1,7 +1,7 @@
 export default Object.freeze({
   packageVersion: 1,
   packageId: "@jskit-ai/ui-generator",
-  version: "0.1.15",
+  version: "0.1.16",
   kind: "generator",
   description: "Create non-CRUD pages, reusable UI elements, and subpage hosts.",
   options: {
@@ -274,7 +274,7 @@ export default Object.freeze({
   mutations: {
     dependencies: {
       runtime: {
-        "@jskit-ai/users-web": "0.1.47"
+        "@jskit-ai/users-web": "0.1.48"
       },
       dev: {}
     },

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@jskit-ai/ui-generator",
-  "version": "0.1.15",
+  "version": "0.1.16",
   "type": "module",
   "scripts": {
     "test": "node --test"
   },
   "dependencies": {
-    "@jskit-ai/kernel": "0.1.32"
+    "@jskit-ai/kernel": "0.1.33"
   },
   "exports": {
     "./server/buildTemplateContext": "./src/server/buildTemplateContext.js"

package/src/server/subcommands/outlet.js

@@ -141,6 +141,11 @@ async function runGeneratorSubcommand({
   const targetFilePath = resolvePathWithinApp(appRoot, targetFile, {
     context: "ui-generator outlet"
   });
+  if (!targetFilePath.relativePath.toLowerCase().endsWith(".vue")) {
+    throw new Error(
+      `ui-generator outlet target file must be an existing Vue SFC (.vue): ${targetFilePath.relativePath}.`
+    );
+  }
 
   let source = "";
   try {

package/src/server/subcommands/page.js

@@ -11,7 +11,7 @@ import {
 } from "./support.js";
 import {
   resolvePageTargetDetails,
-  renderPlainPageSource,
+  renderPlainPageSource
 } from "./pageSupport.js";
 
 function renderPageLinkPlacementBlock({
@@ -86,14 +86,6 @@ async function runGeneratorSubcommand({
     );
   }
 
-  if (!pageAlreadyExisted || forceOverwrite) {
-    if (dryRun !== true) {
-      await mkdir(path.dirname(pageFilePath), { recursive: true });
-      await writeFile(pageFilePath, renderPlainPageSource(pageLabel), "utf8");
-    }
-    touchedFiles.add(pageRelativePath);
-  }
-
   const placementContext = await buildUiPageTemplateContext({
     appRoot: pageTarget.appRoot,
     targetFile,
@@ -114,6 +106,15 @@ async function runGeneratorSubcommand({
       surface: pageTarget.surfaceId
     })
   );
+
+  if (!pageAlreadyExisted || forceOverwrite) {
+    if (dryRun !== true) {
+      await mkdir(path.dirname(pageFilePath), { recursive: true });
+      await writeFile(pageFilePath, renderPlainPageSource(pageLabel), "utf8");
+    }
+    touchedFiles.add(pageRelativePath);
+  }
+
   if (placementApplied.changed) {
     if (dryRun !== true) {
       await writeFile(placementPath.absolutePath, placementApplied.content, "utf8");
@@ -122,20 +123,11 @@ async function runGeneratorSubcommand({
   }
 
   const touchedFileList = [...touchedFiles].sort((left, right) => left.localeCompare(right));
-  const summaryParts = [];
-  if (!pageAlreadyExisted) {
-    summaryParts.push(`Generated UI page "${pageTarget.routeUrlSuffix}" at ${pageRelativePath}.`);
-  } else if (forceOverwrite) {
-    summaryParts.push(`Regenerated UI page "${pageTarget.routeUrlSuffix}" at ${pageRelativePath}.`);
-  } else if (placementApplied.changed) {
-    summaryParts.push(`Updated page link placement for existing UI page "${pageTarget.routeUrlSuffix}".`);
-  } else {
-    summaryParts.push(`UI page "${pageTarget.routeUrlSuffix}" is already up to date.`);
-  }
-
   return {
     touchedFiles: touchedFileList,
-    summary: summaryParts.join(" ")
+    summary: !pageAlreadyExisted
+      ? `Generated UI page "${pageTarget.routeUrlSuffix}" at ${pageRelativePath}.`
+      : `Regenerated UI page "${pageTarget.routeUrlSuffix}" at ${pageRelativePath}.`
   };
 }
 

package/test/outletSubcommand.test.js

@@ -259,6 +259,32 @@ test("ui-generator outlet supports explicit target host:position", async () => {
   });
 });
 
+test("ui-generator outlet rejects non-vue target files without changing them", async () => {
+  await withTempApp(async (appRoot) => {
+    const targetFile = "src/pages/w/[workspaceSlug]/admin/practice/vets/_components/VetAddEditFormFields.js";
+    const targetPath = path.join(appRoot, targetFile);
+    const originalSource = "export const fields = [];\n";
+
+    await mkdir(path.dirname(targetPath), { recursive: true });
+    await writeFile(targetPath, originalSource, "utf8");
+
+    await assert.rejects(
+      runGeneratorSubcommand({
+        appRoot,
+        subcommand: "outlet",
+        args: [targetFile],
+        options: {
+          target: "vet-view"
+        }
+      }),
+      /ui-generator outlet target file must be an existing Vue SFC \(\.vue\): src\/pages\/w\/\[workspaceSlug\]\/admin\/practice\/vets\/_components\/VetAddEditFormFields\.js\./
+    );
+
+    const output = await readFile(targetPath, "utf8");
+    assert.equal(output, originalSource);
+  });
+});
+
 test("ui-generator outlet validates target format", async () => {
   await withTempApp(async (appRoot) => {
     const targetFile = "src/components/ContactDetailsPanel.vue";

package/test/pageSubcommand.test.js

@@ -73,6 +73,7 @@ test("ui-generator page subcommand creates an index page from an explicit target
     });
 
     assert.deepEqual(result.touchedFiles, [toPagePath(targetFile), "src/placement.js"]);
+    assert.equal(result.summary, 'Generated UI page "/practice" at src/pages/w/[workspaceSlug]/admin/practice/index.vue.');
 
     const pageSource = await readFile(path.join(appRoot, toPagePath(targetFile)), "utf8");
     assert.match(pageSource, /<h1 class="text-h5 mb-2">Practice<\/h1>/);
@@ -350,3 +351,65 @@ test("ui-generator page subcommand overwrites an existing page when --force is p
     assert.doesNotMatch(pageSource, /custom practice page/);
   });
 });
+
+test("ui-generator page subcommand rejects invalid link placement before creating a new page", async () => {
+  await withTempApp(async (appRoot) => {
+    await writeAppFixture(appRoot);
+
+    const targetFile = "w/[workspaceSlug]/admin/practice/index.vue";
+    const placementPath = path.join(appRoot, "src", "placement.js");
+    const originalPlacementSource = await readFile(placementPath, "utf8");
+
+    await assert.rejects(
+      runGeneratorSubcommand({
+        appRoot,
+        subcommand: "page",
+        args: [targetFile],
+        options: {
+          "link-placement": "missing:target"
+        }
+      }),
+      /ui-generator page option "placement" target "missing:target" is not declared/
+    );
+
+    await assert.rejects(readFile(path.join(appRoot, toPagePath(targetFile)), "utf8"), /ENOENT/);
+    const placementSource = await readFile(placementPath, "utf8");
+    assert.equal(placementSource, originalPlacementSource);
+  });
+});
+
+test("ui-generator page subcommand rejects invalid link placement before overwriting an existing page", async () => {
+  await withTempApp(async (appRoot) => {
+    await writeAppFixture(appRoot);
+
+    const targetFile = "w/[workspaceSlug]/admin/practice/index.vue";
+    const targetPath = path.join(appRoot, toPagePath(targetFile));
+    const originalPageSource = `<template>
+  <div>custom practice page</div>
+</template>
+`;
+    const placementPath = path.join(appRoot, "src", "placement.js");
+    const originalPlacementSource = await readFile(placementPath, "utf8");
+
+    await mkdir(path.dirname(targetPath), { recursive: true });
+    await writeFile(targetPath, originalPageSource, "utf8");
+
+    await assert.rejects(
+      runGeneratorSubcommand({
+        appRoot,
+        subcommand: "page",
+        args: [targetFile],
+        options: {
+          force: "true",
+          "link-placement": "missing:target"
+        }
+      }),
+      /ui-generator page option "placement" target "missing:target" is not declared/
+    );
+
+    const pageSource = await readFile(targetPath, "utf8");
+    assert.equal(pageSource, originalPageSource);
+    const placementSource = await readFile(placementPath, "utf8");
+    assert.equal(placementSource, originalPlacementSource);
+  });
+});